dgoldman created this revision. dgoldman added reviewers: sammccall, yvvan. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. dgoldman updated this revision to Diff 268803. dgoldman added a comment.
- Fix test run line Exempt ObjC from arrow/dot fixits since this has limited value for Objective-C, where properties (referenced by dot syntax) are normally backed by ivars (referenced by arrow syntax). In addition, the current implementation doesn't properly mark the fix it condition for Objective-C. This was initially added in https://reviews.llvm.org/D41537 for C++ and then later C, don't believe the Objective-C changes were intentional. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81263 Files: clang/test/CodeCompletion/objc-member-access.m Index: clang/test/CodeCompletion/objc-member-access.m =================================================================== --- clang/test/CodeCompletion/objc-member-access.m +++ clang/test/CodeCompletion/objc-member-access.m @@ -15,7 +15,7 @@ return foo; } -// RUN: %clang_cc1 -fsyntax-only -code-completion-with-fixits -code-completion-at=%s:16:19 %s -o - | FileCheck -check-prefix=CHECK-CC1 %s +// RUN: %clang_cc1 -fsyntax-only -code-completion-with-fixits -code-completion-at=%s:14:19 %s -o - | FileCheck -check-prefix=CHECK-CC1 %s // CHECK-CC1-NOT: [#int#]_bar // CHECK-CC1-NOT: [#int#]_foo // CHECK-CC1: [#int#]bar
Index: clang/test/CodeCompletion/objc-member-access.m =================================================================== --- clang/test/CodeCompletion/objc-member-access.m +++ clang/test/CodeCompletion/objc-member-access.m @@ -15,7 +15,7 @@ return foo; } -// RUN: %clang_cc1 -fsyntax-only -code-completion-with-fixits -code-completion-at=%s:16:19 %s -o - | FileCheck -check-prefix=CHECK-CC1 %s +// RUN: %clang_cc1 -fsyntax-only -code-completion-with-fixits -code-completion-at=%s:14:19 %s -o - | FileCheck -check-prefix=CHECK-CC1 %s // CHECK-CC1-NOT: [#int#]_bar // CHECK-CC1-NOT: [#int#]_foo // CHECK-CC1: [#int#]bar
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
