[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv created this revision. ilinpv added reviewers: samparker, dmgreen, SjoerdMeijer. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. FMLA/FMLS 8H duplane indexed patterns added. Fixes https://bugs.llvm.org/show_bug.cgi?id=45467 Repos

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

NoQ added a comment. In D77809#1984689 , @efriedma wrote: > > Where is the size expression actually evaluated? Is it evaluated at the > > point of the typedef or at the point of the variable definition? > > At the point of the typedef. Whoa, indeed. Nic

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

stephan.dollberg added a comment. Thanks, can you merge it? Don't have access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77420/new/ https://reviews.llvm.org/D77420 ___ cfe-commits mailing list cfe-

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257893. kbobyrev marked 18 inline comments as done. kbobyrev added a comment. Address a bunch of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Files: cla

[PATCH] D77880: get scan-view executable from environment

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thank you! While it probably will never matter in practice because `scan-view` is barely ever updated, wouldn't it be a bit safer from revision lock perspective to keep looking for `scan-view` rela

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 7 inline comments as done. gamesh411 added inline comments. Comment at: clang/test/Analysis/ctu-on-demand-parsing.c:5 +// RUN: cp "%S/Inputs/ctu-other.c" "%t/ctu-other.c" +// RUN: echo '[{"directory":"%t","command":"gcc -c -std=c89 -Wno-visibility ctu-other.c","

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 257896. gamesh411 marked an inline comment as done. gamesh411 added a comment. Implement review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: c

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 5 inline comments as done. gamesh411 added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:457 +return llvm::make_error( +index_error_code::ambiguous_compile_commands_database); + martong wrote: > Could we have

[clang] 2ba12ff - Revert "Attempt to fix build with MSVC."

Author: Richard Smith Date: 2020-04-15T17:40:00-07:00 New Revision: 2ba12ff1e51aee7d33233f95734937d44c4a1282 URL: https://github.com/llvm/llvm-project/commit/2ba12ff1e51aee7d33233f95734937d44c4a1282 DIFF: https://github.com/llvm/llvm-project/commit/2ba12ff1e51aee7d33233f95734937d44c4a1282.diff

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

ahatanak added a comment. In D78134#1982291 , @rsmith wrote: > In D78134#1981866 , @rsmith wrote: > > > I'm going to take this to CWG. > > > So far, the direction the wind is blowing is that attempting to perform an

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

rsmith added a comment. In D78134#1985467 , @ahatanak wrote: > In D78134#1982291 , @rsmith wrote: > > > So far, the direction the wind is blowing is that attempting to perform an > > lvalue-to-rvalue conversion on

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert added a comment. The problem I want to address is with code owners. TBH, I would like our overall description of that role to be (more) like @hfinkel described it. In case there is no controversy, that is not really different from @dblaikie vision (I think). If there is controversy, a

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

efriedma added a comment. If you can `assert(ParentCGF.LocalDeclMap.size() == 2);`, I guess the current code is good enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https://reviews.llvm.org/D77982 __

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert added a comment. I tested a bit more and there is a problem: some errors now appear twice, and I think they shouldn't. template void f(int x = [](T x = nullptr) -> int { return x; }()); void g() { f(); } The error is expected, but it should only appear once: :2:23: err

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert updated this revision to Diff 257938. aaronpuchert added a comment. Add test case, loosely based on that in the bug report. By choosing a conversion that should error out we can detect the issue in a pure frontend test. However, we would expect the error only once. Further investig

[clang] 1765edb - Fix memory leak introduced by llvmorg-11-init-11960-gbab6df86aef.

Author: Richard Smith Date: 2020-04-15T19:39:39-07:00 New Revision: 1765edbb5660b028cee56f40e9a1988791762fd5 URL: https://github.com/llvm/llvm-project/commit/1765edbb5660b028cee56f40e9a1988791762fd5 DIFF: https://github.com/llvm/llvm-project/commit/1765edbb5660b028cee56f40e9a1988791762fd5.diff

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

rjmccall added a comment. I'm not sure if the AST-level v-table layout abstraction really cares about these differences. I don't think it vends byte offsets into the v-table, just slot indices (i.e. word offsets). Comment at: clang/include/clang/AST/VTableBuilder.h:380 +

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added inline comments. Comment at: clang/docs/MatrixTypes.rst:29 +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types or an implementation-defined half-precision floating point +type, otherwise the program is ill-formed.

[PATCH] D78273: [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

lattner created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay added inline comments. Comment at: clang-tools-extra/modularize/PreprocessorTracker.cpp:912 // Lookup/add string. - StringHandle addString(llvm::StringRef Str) { retu

[PATCH] D78273: [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

MaskRay added inline comments. Comment at: clang-tools-extra/modularize/PreprocessorTracker.cpp:912 // Lookup/add string. - StringHandle addString(llvm::StringRef Str) { return Strings.intern(Str); } + StringHandle addString(llvm::StringRef Str) { +return Strings.insert(

[PATCH] D78273: [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

lattner added a comment. Hey @maskray, yes StringSet/StringMap's entries are separately allocated and the iterators/pointers are stable. The strings are held in each entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78273/new/ https://reviews.

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a comment. It can be greater than 2 because this Map includes Decls of User locals from parent. see CodeGenFunction::EmitCapturedLocals() (the same place of this fix). .. auto I = ParentCGF.LocalDeclMap.find(VD); if (I == ParentCGF.LocalDeclMap.end()) continue; Add

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8055 multiclass SIMDFPIndexedTiedPatterns { + let Predicates = [HasNEON, HasFullFP16] in { + // 1 variant for the .8h version: DUPLANE from 128-bit Should we have equal p

<    1   2   3