[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

2020-04-14 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:607 + FeatureSVE + ]>; + Not sure how accurate the link you referenced is, but it doesn't mention SVE or Crypto ex

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

2020-04-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:211 NonConflicting.push_back(TokRef.front()); + else if (auto Resolved = resolveConflict

[PATCH] D74813: [RFC] Add hash of block contents to function block names

2020-04-14 Thread Alex Borcan via Phabricator via cfe-commits
alexbdv added a comment. @erik.pilkington / @vsk / @dexonsmith - how block name = hash(parent_function_name + block_type) ? So any blocks that are inside the same parent function + have the same type will get an incremental number to de-duplicate names. CHANGES SINCE LAST ACTION https://rev

[clang] fe06e23 - [AVR] Define __ELF__

2020-04-14 Thread Ayke van Laethem via cfe-commits
Author: Ayke van Laethem Date: 2020-04-15T00:22:53+02:00 New Revision: fe06e231ff1536e7d0a99551590f6de5a38ce23a URL: https://github.com/llvm/llvm-project/commit/fe06e231ff1536e7d0a99551590f6de5a38ce23a DIFF: https://github.com/llvm/llvm-project/commit/fe06e231ff1536e7d0a99551590f6de5a38ce23a.di

[clang] 021a333 - [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

2020-04-14 Thread Hubert Tong via cfe-commits
Author: Hubert Tong Date: 2020-04-14T18:38:35-04:00 New Revision: 021a333bfca363ecb672d22dcff6295d4ecee3b7 URL: https://github.com/llvm/llvm-project/commit/021a333bfca363ecb672d22dcff6295d4ecee3b7 DIFF: https://github.com/llvm/llvm-project/commit/021a333bfca363ecb672d22dcff6295d4ecee3b7.diff L

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

2020-04-14 Thread George Burgess IV via Phabricator via cfe-commits
george.burgess.iv created this revision. george.burgess.iv added reviewers: efriedma, serge-sans-paille. george.burgess.iv added a project: clang. Herald added a subscriber: cfe-commits. This suboptimality was encountered in Linux (see some discussion on D71082 ,

[PATCH] D78117: [AVR] Define __ELF__

2020-04-14 Thread Ayke via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfe06e231ff15: [AVR] Define __ELF__ (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78117/new/ https://reviews.llvm.org/D78117 Files: c

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

2020-04-14 Thread Hubert Tong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG021a333bfca3: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D78117: [AVR] Define __ELF__

2020-04-14 Thread Ayke via Phabricator via cfe-commits
aykevl added a comment. Okay, I have committed this patch and created a new patch to move the files: https://reviews.llvm.org/D78163 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78117/new/ https://reviews.llvm.org/D78117 __

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

2020-04-14 Thread Ayke via Phabricator via cfe-commits
aykevl created this revision. aykevl added reviewers: dylanmckay, rjmccall, MaskRay. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. MaskRay added a comment. Not sure we need `target-cpu-defines/` You can add a `lit.local.cfg` to avoid `REQUIRES: avr-registered-target`

[PATCH] D77431: [X86] Add tests to clang Driver to ensure that SLH/Retpoline features are not enabled with LVI-hardening

2020-04-14 Thread Craig Topper via Phabricator via cfe-commits
craig.topper commandeered this revision. craig.topper edited reviewers, added: sconstab; removed: craig.topper. craig.topper added a comment. Merged into D75936 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77431/new/ https://reviews.llvm.org/D77431

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

2020-04-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:749-750 +/// The set of the included headers' UID for the submodule. +std::set IncludedFiles; + A `std::set` is a very heavy object to be copying each time a module is ente

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

2020-04-14 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 257549. craig.topper added a comment. Merge in test case from D77431 since it logically belongs with these changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Fil

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

2020-04-14 Thread Ayke via Phabricator via cfe-commits
aykevl updated this revision to Diff 257548. aykevl added a comment. Update to use the function pointer address space from the function declaration. (This is slightly different from what @rjmccall suggested but I think this is more readable). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

2020-04-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", + BeginningOfTimeUs.time_since_epoch().count()); broadwayl

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

2020-04-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D78134#1981866 , @rsmith wrote: > I'm going to take this to CWG. So far, the direction the wind is blowing is that attempting to perform an lvalue-to-rvalue conversion on an array should be a no-op. (That's weirdly different

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

2020-04-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Not sure we need `target-cpu-defines/` You can add a `lit.local.cfg` to avoid `REQUIRES: avr-registered-target` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ https://reviews.llvm.org/D78163 __

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

2020-04-14 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi updated this revision to Diff 257550. plotfi added a comment. Adding a kind_ prefix to avoid any keywords being used in the ObjCPropertyAttribute enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

2020-04-14 Thread Ten Tzen via Phabricator via cfe-commits
tentzen added a comment. In D77982#1981505 , @efriedma wrote: > Searching LocalDeclMap is less problematic, I guess... but still, it should > be possible to something more straightforward. Maybe make > startOutlinedSEHHelper store the actual ImplicitPar

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

2020-04-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd";> Please heed this comment, and check in a matching change to `make_cxx_dr_status` =) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

2020-04-14 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik updated this revision to Diff 257552. shafik marked 4 inline comments as done. shafik added a comment. Addressing comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78000/new/ https://reviews.llvm.org/D78000 Files: clang/lib/AST/ASTImporter.cpp lldb/test/API/commands/ex

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

2020-04-14 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. WFM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78125/new/ https://reviews.llvm.org/D78125 ___

[PATCH] D77989: Allow disabling of vectorization using internal options

2020-04-14 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7618-7621 +: InterleaveOnlyWhenForced(Opts.InterleaveOnlyWhenForced | + !EnableLoopInterleaving), + Vect

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

2020-04-14 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D78134#1982291 , @rsmith wrote: > In D78134#1981866 , @rsmith wrote: > > > I'm going to take this to CWG. > > > So far, the direction the wind is blowing is that attempting to perform an

[PATCH] D77989: Allow disabling of vectorization using internal options

2020-04-14 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson updated this revision to Diff 257562. tejohnson added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77989/new/ https://reviews.llvm.org/D77989 Files: clang/test/CodeGen/thinlto-loop-vectorize-pm.c clang/tes

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

2020-04-14 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd";> rsmith wrote: > Please heed this comment, and check in a matching change to > `make_cxx_dr_status` =) Thanks for poi

[PATCH] D78171: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

2020-04-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. There are a few cleanups I made along the way here that I'll be factoring out and committing separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78171/new/ https://reviews.llvm.org/D78171 __

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

2020-04-14 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, +

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

2020-04-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. > This fix is necessary to let Clang compile compiler-rt for AVR. This suggests that some compiler-rt declarations do not follow the best practice... What are they? Comment at: clang/test/CodeGen/address-space-avr.c:3 + +// CHECK: define void @bar() a

[PATCH] D78171: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

2020-04-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added a reviewer: rnk. rsmith added a project: clang. Herald added a subscriber: arphaman. Herald added a reviewer: jdoerfert. rsmith added a comment. There are a few cleanups I made along the way here that I'll be factoring out and committing separately. Pr

[PATCH] D78172: [www] Update make_cxx_dr_status for v10; regenerate cxx_dr_status.html

2020-04-14 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast created this revision. hubert.reinterpretcast added a reviewer: rsmith. Herald added a project: clang. hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/www/cxx_dr_status.html:14486 +

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

2020-04-14 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd";> hubert.reinterpretcast wrote: > rsmith wrote: > > Please hee

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

2020-04-14 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78162/new/ https://reviews.llvm.org/D78162 ___

[PATCH] D78172: [www] Update make_cxx_dr_status for v10; regenerate cxx_dr_status.html

2020-04-14 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/www/cxx_dr_status.html:14486 +https://wg21.link/cwg2445";>2445 + +Partial ordering with rewritten candidates The status is blank o

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

2020-04-14 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi updated this revision to Diff 257577. plotfi added a comment. Update for clang-format changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files: clang/include/clang/AST/DeclObjC.h clang/incl

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

2020-04-14 Thread Ayke via Phabricator via cfe-commits
aykevl added a comment. In D78125#1982471 , @MaskRay wrote: > > This fix is necessary to let Clang compile compiler-rt for AVR. > > This suggests that some compiler-rt declarations do not follow the best > practice... What are they? The calls come from

[PATCH] D78171: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

2020-04-14 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm There's a lot of stuff going on here, and I didn't review that deeply. Let me know if you want a closer reading of the code. Comment at: clang/include/clang/AST/TemplateBase

[clang] 33ffb62 - Allow disabling of vectorization using internal options

2020-04-14 Thread Teresa Johnson via cfe-commits
Author: Teresa Johnson Date: 2020-04-14T18:09:10-07:00 New Revision: 33ffb62e23e7a7bece5618d5a7b54bdb401d0bcf URL: https://github.com/llvm/llvm-project/commit/33ffb62e23e7a7bece5618d5a7b54bdb401d0bcf DIFF: https://github.com/llvm/llvm-project/commit/33ffb62e23e7a7bece5618d5a7b54bdb401d0bcf.diff

[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

2020-04-14 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76646/new/ https://reviews.llvm.org/D76646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D77989: Allow disabling of vectorization using internal options

2020-04-14 Thread Teresa Johnson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG33ffb62e23e7: Allow disabling of vectorization using internal options (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77989/new/ http

[clang] 8da5b90 - [MS] Fix packed struct layout for arrays of aligned non-record types

2020-04-14 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-04-14T18:34:52-07:00 New Revision: 8da5b9083691b557f50f72ab099598bb291aec5f URL: https://github.com/llvm/llvm-project/commit/8da5b9083691b557f50f72ab099598bb291aec5f DIFF: https://github.com/llvm/llvm-project/commit/8da5b9083691b557f50f72ab099598bb291aec5f.diff

[PATCH] D77923: OpenCL: Fix some missing predefined macros

2020-04-14 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D77923#1981698 , @jvesely wrote: > does passing `-U__OPENCL_VERSION__ -D __OPENCL_VERSION__=x.y` on the > commadline work as well? the header trick was my fallback path. Yes the command line option -U or -D override predefined

[PATCH] D77754: [MS] Fix packed struct layout for arrays of aligned non-record types

2020-04-14 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8da5b9083691: [MS] Fix packed struct layout for arrays of aligned non-record types (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77754/new

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

2020-04-14 Thread Ehud Katz via Phabricator via cfe-commits
ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } rjmccall wrote: > ekatz wrote: > > rjmccall wrote: > > > I liked the structure of the old code better, in case we want to

[PATCH] D74813: [RFC] Add hash of block contents to function block names

2020-04-14 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D74813#1982089 , @alexbdv wrote: > @erik.pilkington / @vsk / @dexonsmith - how block name = > hash(parent_function_name + block_type) ? > So any blocks that are inside the same parent function + have the same type > will

[PATCH] D78172: [www] Update make_cxx_dr_status for v10; regenerate cxx_dr_status.html

2020-04-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/www/cxx_dr_status.html:11246 https://wg21.link/cwg1905";>1905 -MAD Dependent types and injected-class-names Haha :)

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-04-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. This revision is now accepted and ready to land. Thanks! I'm happy for you to go ahead landing patches that implement the direction documented here. (Let me know if you want me to review them anyway,

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

2020-04-14 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/test/CodeGen/address-space-avr.c:3 + +// CHECK: define void @bar() addrspace(1) +// CHECK: call addrspace(1) void bitcast (void (...) addrspace(1)* @foo to void (i16) addrspace(1)*)(i16 3) MaskRay wrote: > Add a

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

2020-04-14 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } ekatz wrote: > rjmccall wrote: > > ekatz wrote: > > > rjmccall wrote: > > > > I liked the structure of the old code better, in case we want to look > > > > th

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

2020-04-14 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Looks like the established convention would be to just put these tests in `test/Preprocessor` with an `avr-` prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ https://reviews.llvm.org/D78163

Buildbot numbers for the week of 03/22/2020 - 03/28/2020

2020-04-14 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 03/22/2020 - 03/28/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 03/29/2020 - 04/4/2020

2020-04-14 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 03/29/2020 - 04/4/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 04/05/2020 - 04/11/2020

2020-04-14 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 04/05/2020 - 04/11/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[clang-tools-extra] d83541d - [clangd] Color dependent names based on their heuristic target if they have one

2020-04-14 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-04-15T00:57:08-04:00 New Revision: d83541d1b8f75ff44083c8ba1dba1ca7bac330cf URL: https://github.com/llvm/llvm-project/commit/d83541d1b8f75ff44083c8ba1dba1ca7bac330cf DIFF: https://github.com/llvm/llvm-project/commit/d83541d1b8f75ff44083c8ba1dba1ca7bac330cf.diff

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

2020-04-14 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd83541d1b8f7: [clangd] Color dependent names based on their heuristic target if they have one (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D76896?vs=257596&id=257597#toc Repo

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

2020-04-14 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 257596. nridge added a comment. Address final review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76896/new/ https://reviews.llvm.org/D76896 Files: clang-tools-extra/clangd/FindTarget.cpp clang-too

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

2020-04-14 Thread Matthew Riley via Phabricator via cfe-commits
mattdr marked an inline comment as done. mattdr added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:366 +std::vector TrimmedNodes(TrimNodes.size()); +for (size_type I = 0; I < TrimNodes.size(); ++I) { + TrimmedNodes[I] = TrimmedNodesSoFar; ---

[clang] 5d3f717 - Remove setters from CXXTypeidExpr and CXXUuidofExpr.

2020-04-14 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-04-14T23:15:27-07:00 New Revision: 5d3f7176c1b299d456cec7da4923be5f39e61228 URL: https://github.com/llvm/llvm-project/commit/5d3f7176c1b299d456cec7da4923be5f39e61228 DIFF: https://github.com/llvm/llvm-project/commit/5d3f7176c1b299d456cec7da4923be5f39e61228.diff

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

2020-04-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 257607. kadircet added a comment. - Add tests for sharding logic and preamble overwrite Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77732/new/ https://reviews.llvm.org/D77732 Files: clang-tools-extra/clan

<    1   2   3