aykevl added a comment.

In D78125#1982471 <https://reviews.llvm.org/D78125#1982471>, @MaskRay wrote:

> > This fix is necessary to let Clang compile compiler-rt for AVR.
>
> This suggests that some compiler-rt declarations do not follow the best 
> practice... What are they?


The calls come from `__addXf3__` (in fp_add_impl.inc). This is what I get when 
I dump the bitcast:

  i16 () addrspace(1)* bitcast (i16 (...) addrspace(1)* @__fe_getround to i16 
() addrspace(1)*)
  i16 () addrspace(1)* bitcast (i16 (...) addrspace(1)* @__fe_raise_inexact to 
i16 () addrspace(1)*)
  i16 () addrspace(1)* bitcast (i16 (...) addrspace(1)* @__fe_getround to i16 
() addrspace(1)*)
  i16 () addrspace(1)* bitcast (i16 (...) addrspace(1)* @__fe_raise_inexact to 
i16 () addrspace(1)*)

So they must have been introduced with D57143 <https://reviews.llvm.org/D57143>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78125/new/

https://reviews.llvm.org/D78125



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to