[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen marked 4 inline comments as done. tentzen added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:1798 + +// if the parent is a _finally, need to retrive Establisher's FP, +// 2nd paramenter, saved & named frame_pointer in parent's frame

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

lebedev.ri added a comment. Thanks, this is indeed much better and the direction again in-line with what i've raised in some attributor patch. LG to me in general, but please wait for someone else to take a look, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert updated this revision to Diff 256938. fickert added a comment. rebased, fixed two unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75034/new/ https://reviews.llvm.org/D75034 Files: clang/docs/ClangFormatStyleOptions.rst clang/i

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru updated this revision to Diff 256943. sylvestre.ledru added a comment. 2 spaces instead of 4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://reviews.llvm.org/D77983 Files: clang-tools-extra/docs/clang-tidy/checks

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen updated this revision to Diff 256942. tentzen added a comment. Remove hard-code name "frame-pointer". get the name from 2nd Arg of the _finally(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https://reviews.llvm.org/D77982 Fi

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal added a comment. In D77461#1963166 , @lebedev.ri wrote: > https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Ri-global > is in "Interfaces" section, it only covers inter-procedural stuff. > Diagnosing function-local st

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

nikic added a comment. I gave D77952 a try (on top of this one), but didn't see a significant improvement from that change. Looking at the callgrind output for compilation of a **small** file, I see 52M total instructions, 4 calls to TLII initialization, where

[clang-tools-extra] 48d851a - [clangd] Update TUStatus test to handle async PreambleThread

Author: Kadir Cetinkaya Date: 2020-04-13T12:27:50+02:00 New Revision: 48d851a92e98ca9c425d4d9bc43def3693895498 URL: https://github.com/llvm/llvm-project/commit/48d851a92e98ca9c425d4d9bc43def3693895498 DIFF: https://github.com/llvm/llvm-project/commit/48d851a92e98ca9c425d4d9bc43def3693895498.dif

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh friend ping, please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 ___ cfe-commits mailing list cfe-commit

[PATCH] D77669: [clangd] Update TUStatus test to handle async PreambleThread

This revision was automatically updated to reflect the committed changes. Closed by commit rG48d851a92e98: [clangd] Update TUStatus test to handle async PreambleThread (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77669/new/

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

ASDenysPetrov added a comment. @Szelethus, @NoQ I've investigated graph.dot of the sample. F11723129: t37503.dot Here is a simplification: 1. SA thinks that `ptr` is a pointer with a structure `MemRegion->MemRegion->MemRegion->Element` 2. Then `*(unsigned ch

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. From what I understand the whole idea here is to just ask the external AST source to complete the record before we import them? If yes, then this seems like the right idea to m

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

aaron.ballman added a comment. In D77461#1977503 , @vingeldal wrote: > In D77461#1963166 , @lebedev.ri > wrote: > > > https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Ri-global > > is i

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Apologies for the delay! It's sort of a crazy time now =\ The code looks mostly good now modulo a few comments inline. Comment at: clang-tools-extra/clang-tidy/ClangTidyChec

[clang] ebd5290 - Address sphinx warnings

Author: Benjamin Kramer Date: 2020-04-13T14:41:55+02:00 New Revision: ebd5290ff2b34c6863ee50cd2bcadff19d260812 URL: https://github.com/llvm/llvm-project/commit/ebd5290ff2b34c6863ee50cd2bcadff19d260812 DIFF: https://github.com/llvm/llvm-project/commit/ebd5290ff2b34c6863ee50cd2bcadff19d260812.dif

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

alexfh added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/abseil-duration-conversion-cast.rst:29-35 Note: In the second example, the suggested fix could yield a different result, as the conversion to integer could truncate. In practice, this is very r

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

lebedev.ri added a comment. FWIW i've posted https://github.com/isocpp/CppCoreGuidelines/issues/1599 asking for clarification, but no replies so far.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77461/new/ https://reviews.llvm.org/D77461

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM (after fixing those tests). Thanks for cleaning this up! Comment at: clang/tools/c-index-test/c-index-test.c:1107 PRINT_PROP_ATTR(unsafe_unret

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal added a comment. In D77461#1977639 , @aaron.ballman wrote: > In D77461#1977503 , @vingeldal wrote: > > > In D77461#1963166 , @lebedev.ri > > wrote: > > > > > http

[PATCH] D77545: Represent FP options in AST by special Expression node

sepavloff added a comment. In D77545#1974509 , @rjmccall wrote: > For example, in this code: > > const float global = 2.22 + 3.33; > > #pragma STDV FENV_ROUND > float getGlobal() { return global; } > > > The code-generation of `getGlobal` will att

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal added a comment. I'm also adding to this discussion the exception-part of the rule: "A global object is often better than a singleton." I would argue that the example given above, while not strictly follwong the definition of a singleton, is behaviorally consistent with a singleton.

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:98 + "::access;" + "::bind;" + "::connect;" aar

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal added a comment. In D77461#1977703 , @aaron.ballman wrote: > In D77461#1977687 , @vingeldal wrote: > > > In D77461#1977639 , @aaron.ballman > > wrote: > > > > > I

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

aaron.ballman added a comment. In D77461#1977687 , @vingeldal wrote: > In D77461#1977639 , @aaron.ballman > wrote: > > > In D77461#1977503 , @vingeldal > > wrote: > > > > >

[clang] 072ae7c - [clang-format] Always break line after enum opening brace

Author: mydeveloperday Date: 2020-04-13T15:03:36+01:00 New Revision: 072ae7c1e64f8dd1b5e9db17838c93b150f8b487 URL: https://github.com/llvm/llvm-project/commit/072ae7c1e64f8dd1b5e9db17838c93b150f8b487 DIFF: https://github.com/llvm/llvm-project/commit/072ae7c1e64f8dd1b5e9db17838c93b150f8b487.diff

[clang] 3b37924 - [clang-format] A Minor change to clang-format-diff.py

Author: mydeveloperday Date: 2020-04-13T15:08:07+01:00 New Revision: 3b379246c365721425d7e29772c08d8373b4a606 URL: https://github.com/llvm/llvm-project/commit/3b379246c365721425d7e29772c08d8373b4a606 DIFF: https://github.com/llvm/llvm-project/commit/3b379246c365721425d7e29772c08d8373b4a606.diff

[clang] e811150 - [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

Author: mydeveloperday Date: 2020-04-13T15:14:26+01:00 New Revision: e8111502d8696896241132865c7a44c6f84f93c1 URL: https://github.com/llvm/llvm-project/commit/e8111502d8696896241132865c7a44c6f84f93c1 DIFF: https://github.com/llvm/llvm-project/commit/e8111502d8696896241132865c7a44c6f84f93c1.diff

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9481 + // emitted, Cand1 is not better than Cand2. This rule should have precedence + // over other rules. + // rjmccall wrote: > Please add `[CU

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 __

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru added a comment. Makes sense. I will give it a try :) thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://reviews.llvm.org/D77983 ___ cfe-commits mailing list cfe-co

[PATCH] D77974: A Minor change to clang-format-diff.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b379246c365: [clang-format] A Minor change to clang-format-diff.py (authored by MyDeveloperDay, committed by paulhoad ). Herald added a project: clang. Herald added a subscriber: cfe

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8111502d869: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D77682: [clang-format] Always break line after enum opening brace

This revision was automatically updated to reflect the committed changes. Closed by commit rG072ae7c1e64f: [clang-format] Always break line after enum opening brace (authored by MyDeveloperDay, committed by paulhoad ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm created this revision. arsenm added reviewers: yaxunl, tra. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. arsenm added a child revision: D78020: clang/AMDGPU: Assume denormals are enabled for the default target.. I didn't realize HIP was a distinct offloading kind, so the sub

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

sammccall added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:98 + "::access;" + "::bind;" + "::connect;" aaron.b

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl updated this revision to Diff 256973. yaxunl marked 3 inline comments as done. yaxunl added a comment. fix preference for multiversion. add comments. add more tests for wrong-sided function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added inline comments. Comment at: clang/include/clang-c/Index.h:4503 CXObjCPropertyAttr_unsafe_unretained = 0x800, - CXObjCPropertyAttr_class = 0x1000 + CXObjCPropertyAttr_classattr = 0x1000 } CXObjCPropertyAttrKind; @erik.pilkington Do you think w

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec, b-sumner, msearles. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. arsenm added a parent revision: D78019: HIP: Fix handling of denormal mode. Since the default logic was based on

[PATCH] D76182: [AVR] Support aliases in non-zero address space

aykevl updated this revision to Diff 256977. aykevl added a comment. - added test - using `getPointerAddressSpace` instead of a cast This is now ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76182/new/ https://reviews.llvm.org/D7

[PATCH] D77923: OpenCL: Fix some missing predefined macros

arsenm added a comment. In D77923#1976497 , @jvesely wrote: > OPENCL_VERSION is something that should be really set by the opencl driver > rather than the compiler. > coarse-grained SVM can be done without FEATURE_FLAT_ADDRESS_SPACE, so those > gpus can

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

erik.pilkington requested changes to this revision. erik.pilkington added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang-c/Index.h:4503 CXObjCPropertyAttr_unsafe_unretained = 0x800, - CXObjCPropertyAttr_class = 0x1000 + CXObjC

[PATCH] D78019: HIP: Fix handling of denormal mode

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:286 + +// FIXME: Should this use the default mode based on the target? How do we +// deal with multiple --cuda-gpu-arch? If there are multiple --cuda-gpu-arch, driver will cr

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/test/CodeGen/ppc32-struct-return.c:53 + +// AIX-SVR4: fatal error: error in backend: -msvr4-struct-return not supported on AIX + If certain front end option is not supported on certain target, I think it makes

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/ClangObjectiveCFuzzer.cpp:19 -extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) { return 0; } - RKSimon wrote: > @dgoldman @morehouse Removing this has been causing link failures e

[clang] a59ba33 - Fix an indent.

Author: Nico Weber Date: 2020-04-13T11:54:00-04:00 New Revision: a59ba3384e9d5e1cf89ddae1d14601a613b8d7b7 URL: https://github.com/llvm/llvm-project/commit/a59ba3384e9d5e1cf89ddae1d14601a613b8d7b7 DIFF: https://github.com/llvm/llvm-project/commit/a59ba3384e9d5e1cf89ddae1d14601a613b8d7b7.diff LO

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

jdoerfert added a comment. I think this is fine. Two comments to consider below. Comment at: llvm/include/llvm/IR/IRBuilder.h:1600 +return CreateAlignedLoad(Ty, Ptr, DL.getABITypeAlign(Ty), isVolatile, Name); } Can't we just pawn of the alignment stuf

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

tejohnson added a comment. In D77632#1976308 , @mehdi_amini wrote: > In D77632#1976231 , @wenlei wrote: > > > And agree with @tejohnson, if the openness is a feature, it should be > > covered in tests, otherwise it

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

broadwaylamb created this revision. broadwaylamb added reviewers: anton-afanasyev, russell.gallop. Herald added subscribers: cfe-commits, MaskRay, hiraditya, emaste. Herald added a reviewer: espindola. Herald added a project: clang. broadwaylamb added a parent revision: D78022: Introduce llvm::sys

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

broadwaylamb updated this revision to Diff 256993. broadwaylamb added a comment. Remove unrelated changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78027/new/ https://reviews.llvm.org/D78027 Files: clang/test/Driver/check-time-trace.cpp lld/test/ELF/time-trace.s llvm/lib/Supp

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 256998. mibintc added a comment. I made the changes requested by @rjmccall ; I also used clang-format on the tip. check-clang is passing. Look OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ http

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang-c/Index.h:4503 CXObjCPropertyAttr_unsafe_unretained = 0x800, - CXObjCPropertyAttr_class = 0x1000 + CXObjCPropertyAttr_classattr = 0x1000 } CXObjCPropertyAttrKind;

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

kadircet updated this revision to Diff 257003. kadircet marked 4 inline comments as done. kadircet added a comment. - Unify sharding logic in BackgroundIndex and FileIndex. - Make sure relations have valid subjects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb created this revision. broadwaylamb added reviewers: anton-afanasyev, russell.gallop, espindola. Herald added subscribers: cfe-commits, MaskRay, hiraditya, emaste. Herald added a project: clang. broadwaylamb added a parent revision: D78027: [TimeProfiler] Emit real process ID and thre

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

yaxunl added a comment. I think https://reviews.llvm.org/D78019 should fix the issue about HIP not using correct default denormal value if no arch is specified. In that case, driver actually sets offloading arch to gfx803 and clang should be able to see it in JobAction. CHANGES SINCE LAST ACT

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:97 +/// paths used by \p FileSyms. +void shardSlabToFiles(const SymbolSlab &Syms, const RelationSlab &Rels, + FileSymbols &FileSyms, llvm::StringRef HintPath) { -

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/test/Driver/cuda-flush-denormals-to-zero.cu:27 +// Test multiple offload archs with different defaults. +// RUN: %clang -x hip -no-canonical-prefixes -### -target x86_64-linux-gnu -c -march=

[PATCH] D78033: [cmake] Restrict symbols exported from libclang-cpp

pirama created this revision. pirama added reviewers: beanz, mgorny. Herald added a project: clang. Herald added a subscriber: cfe-commits. In libclang-cpp, export only symbols from the clang namespace or clang_* (functions for the C interface). This fixes the use case where a tool depends on bot

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm added a comment. In D78020#1978034 , @yaxunl wrote: > I think https://reviews.llvm.org/D78019 should fix the issue about HIP not > using correct default denormal value if no arch is specified. > > In that case, driver actually sets offloading arch

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm updated this revision to Diff 257011. arsenm added a comment. Remove leftover comment from before I used JobAction CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChai

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

hfinkel added a comment. In D77683#1973762 , @dblaikie wrote: > In D77683#1973757 , @jdoerfert wrote: > > > In D77683#1970826 , @mehdi_amini > > wrote: > > > > > I am still

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:286 + // ND is the canonical (i.e. first) declaration. If it's in the main file + // (which is not a header), then no public declaration w

[PATCH] D77908: [WebAssembly] Enable nontrapping-fptoint for `default` cpu

kripken added a comment. In D77908#1977039 , @sbc100 wrote: > As a less controversial version of this change I could instead create a new > CPU called `current` and leave `generic` as is (basically leave it at mvp) > until we can agree that a features is

[PATCH] D77859: Revert "[DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff."

mehdi_amini added a comment. Was reverted, can we drop this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77859/new/ https://reviews.llvm.org/D77859 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

efriedma added a comment. Again, using the name isn't reliable. Among other things, in release builds, IR values don't have names at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https://reviews.llvm.org/D77982

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

broadwaylamb updated this revision to Diff 257015. broadwaylamb added a comment. Explicitly specify argument types in `writeMetadataEvent` lambda. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78027/new/ https://reviews.llvm.org/D78027 Files: clang/test/Driver/check-time-trace.cpp

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram marked 2 inline comments as done. tmsriram added a comment. In D73307#1972388 , @rnk wrote: > Regarding the alias attribute, it occurs to me that reimplementing this as an > early LLVM pass would not have that problem. Do you think that would be

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

efriedma marked an inline comment as done. efriedma added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:1600 +return CreateAlignedLoad(Ty, Ptr, DL.getABITypeAlign(Ty), isVolatile, Name); } jdoerfert wrote: > Can't we just pawn of the ali

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

khchen added a comment. Herald added a reviewer: herhut. Herald added subscribers: frgossen, grosul1, Joonsoo. Hi @lenary, I added a PoC patch D78035 to complete ThinLTO based on this patch. There is also a missed hook in `ParallelCG.cpp` @@ -28,6 +28,7 @@ st

[clang-tools-extra] 31db1e0 - [clangd] Send the correct error code when cancelling requests.

Author: Sam McCall Date: 2020-04-13T19:42:38+02:00 New Revision: 31db1e0bd1ea020046eb7ac2359ced8c7239de1e URL: https://github.com/llvm/llvm-project/commit/31db1e0bd1ea020046eb7ac2359ced8c7239de1e DIFF: https://github.com/llvm/llvm-project/commit/31db1e0bd1ea020046eb7ac2359ced8c7239de1e.diff LO

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

rjmccall added a reviewer: echristo. rjmccall added a subscriber: echristo. rjmccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9481 + // emitted, Cand1 is not better than Cand2. This rule should have precedence + // over other rules. + // -

[PATCH] D76182: [AVR] Support aliases in non-zero address space

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76182/new/ https://reviews.llvm.org/D76182

[PATCH] D77962: PR38490: Support reading values out of __uuidof(X) expressions during constant evaluation.

aeubanks added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3949 + // Special-case reading from __uuidof expressions so we don't have to + // construct an APValue for the whole uuid. + if (LVal.Designator.isOnePastTheEnd()) { For my

[PATCH] D77923: OpenCL: Fix some missing predefined macros

scott.linder added a comment. https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/preprocessorDirectives.html describes `__OPENCL_VERSION__` as "an integer reflecting the version number of the OpenCL supported by the OpenCL device." as contrasted with `__OPENCL_C_VERSION__` which is

[PATCH] D77859: Revert "[DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff."

bondhugula abandoned this revision. bondhugula added a comment. Another revision performed this revert. Dropping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77859/new/ https://reviews.llvm.org/D77859 __

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This should probably be untangled into 3 separate patches, but looking for feedback first on whether we want to do this at all. a) store in

[PATCH] D77936: [Windows SEH] Fix abnormal-exits in _try

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77936/new/ https://reviews.llvm.org/D77936 ___

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. Thanks. Just a bunch of fairly minor requests now. Comment at: clang/include/clang/AST/Expr.h:3474 + size_t offsetOfTrailingStorage() const; + size_t offsetOfTrailingStorage(); + You don't need the non-const overload.

[PATCH] D78019: HIP: Fix handling of denormal mode

tra added a comment. LGTM. The patch appears to be an NFC one for CUDA. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D77947: [clangd] Send the correct error code when cancelling requests.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/JSONTransport.cpp:28 + [&](const CancelledError &C) -> llvm::Error { +switch (C.Reason) { + case static_cast(ErrorCode::ContentModif

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added inline comments. Comment at: clang/docs/MatrixSupport.rst:3 +Matrix Support +== + rjmccall wrote: > This extension should be called something like "Matrices" or "Matrix Types". > The "X Support" name makes it sound like it's a suppor

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257025. fhahn marked 15 inline comments as done. fhahn added a comment. Address @rjmccall comments. In D76612#1975719 , @rjmccall wrote: > Scanned through the first bit. Thanks a lot! I hope I managed to address the c

[PATCH] D77923: OpenCL: Fix some missing predefined macros

arsenm added a comment. In D77923#1978172 , @scott.linder wrote: > https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/preprocessorDirectives.html > describes `__OPENCL_VERSION__` as "an integer reflecting the version number > of the OpenCL s

[PATCH] D77947: [clangd] Send the correct error code when cancelling requests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG31db1e0bd1ea: [clangd] Send the correct error code when cancelling requests. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77947?vs=256777&id=257031#toc Repository: rG L

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. In D74387#1974981 , @jdoerfert wrote: > As I mentioned before. As long as the type is not "used" you can treat it as > a sequence of bytes just as well. So we can lower `__float128` to `char [16]` > with the right alignment. SP

[PATCH] D78019: HIP: Fix handling of denormal mode

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019 ___ cfe-commits mailing list cfe-

[PATCH] D77923: OpenCL: Fix some missing predefined macros

scott.linder added a comment. In D77923#1978261 , @arsenm wrote: > In D77923#1978172 , @scott.linder > wrote: > > > https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/preprocessorDirectives.html > > de

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

dblaikie added a comment. In D77683#1978070 , @hfinkel wrote: > In D77683#1973762 , @dblaikie wrote: > > > In D77683#1973757 , @jdoerfert > > wrote: > > > > > In D77683#1970

Re: [clang] 246398e - [clang][Parse] properly parse asm-qualifiers, asm inline

On Sun, Apr 12, 2020 at 3:45 PM Joerg Sonnenberger wrote: > > On Thu, Mar 12, 2020 at 03:25:49PM -0700, Nick Desaulniers via cfe-commits > wrote: > > > > Author: Nick Desaulniers > > Date: 2020-03-12T15:13:59-07:00 > > New Revision: 246398ece7115b57a02dbe7876d86ae8e72406ef > > > > URL: > > https

[clang] dc89a3e - HIP: Fix handling of denormal mode

Author: Matt Arsenault Date: 2020-04-13T11:48:45-07:00 New Revision: dc89a3efb43feedec04facfa2206de011d2606e7 URL: https://github.com/llvm/llvm-project/commit/dc89a3efb43feedec04facfa2206de011d2606e7 DIFF: https://github.com/llvm/llvm-project/commit/dc89a3efb43feedec04facfa2206de011d2606e7.diff

[PATCH] D77918: [OpenMP] Avoid crash in preparation for diagnose of unsupported type

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77918/new/ https://reviews.llvm.org/D77918 __

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm added a comment. In D78019#1978216 , @tra wrote: > LGTM. The patch appears to be an NFC one for CUDA. CUDA currently isn't changing the default FTZ mode based on the subtarget, which differs from nvcc according to the documentation CHANGES SINC

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

tra added a comment. LGTM in principle. That said, my gut feeling is that this patch has a good chance of breaking something in sufficiently convoluted CUDA code like Eigen. When you land this patch, I'd appreciate if you could do it on a workday morning (Pacific time) so I'm around to test it

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee updated this revision to Diff 257044. browneee added a comment. Changed SizeMax to static constexpr function. Changed static asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 Files: llvm/i

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm closed this revision. arsenm added a comment. dc89a3efb43feedec04facfa2206de011d2606e7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019 __

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257055. mibintc added a comment. Responded to @rjmccall 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 Files: clang/include/clang/AST/Expr.h clang/includ

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked 3 inline comments as done. mibintc added a comment. Adding an inline reply for John. rebased the patch, also re-applied clang-format. What do you think? Comment at: clang/lib/Analysis/BodyFarm.cpp:120 +VK_RValue, OK_Ordinary, Sou

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

dblaikie added a comment. Looks good to me at this point (I have some vague quandries about whether the report_fatal_error stuff could be improved/made more clear, but couldn't come up with an actionable suggestion so far) - @dexonsmith could you check this over and offer final approval? Repo

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

efriedma updated this revision to Diff 257059. efriedma added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77984/new/ https://reviews.llvm.org/D77984 Files: clang/test/CodeGen/arm_neon_intrinsics.c llvm/incl

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal updated this revision to Diff 257058. vingeldal added a comment. Modified the check to not report static variables in function scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77461/new/ https://reviews.llvm.org/D77461 Files: clan

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal updated this revision to Diff 257060. vingeldal added a comment. Ran automatic formatting on the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77461/new/ https://reviews.llvm.org/D77461 Files: clang-tools-extra/clang-tidy/cppcor

  1   2   >