erik.pilkington requested changes to this revision. erik.pilkington added inline comments. This revision now requires changes to proceed.
================ Comment at: clang/include/clang-c/Index.h:4503 CXObjCPropertyAttr_unsafe_unretained = 0x800, - CXObjCPropertyAttr_class = 0x1000 + CXObjCPropertyAttr_classattr = 0x1000 } CXObjCPropertyAttrKind; ---------------- plotfi wrote: > @erik.pilkington Do you think we should be adding the C-API analogs of > nullability / null_resettable (and direct) to clang/include/clang-c/Index.h? > > I noticed those are missing. > > Oh, sorry, I missed this. The C API is supposed to be stable, so I don't think we should change the name of this enumerator (@arphaman can you confirm?). Adding the missing attributes seem fine though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
