[PATCH] D77776: [Driver] Drop support for FreeBSD < 10

jbeich updated this revision to Diff 256202. jbeich added a comment. - Attempt to unbreak tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Driver/T

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7ff5b38f27f: [FPEnv] Use single enum to represent rounding mode (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D77379?vs=255949&id=256203#toc Repository: rG LLVM Github M

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added a comment. In D68049#1970825 , @tmsriram wrote: > Ping. @rsmith ^^^ More specific question, do you think `clang/test/CodeGen/basicblock-sections.c` should be converted to a `-S -emit-llvm` test? CHANGES SINCE LAST ACTION https://revie

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

MaskRay added a comment. Moving functions from Linux.cpp to Gnu.cpp is definitely appropriate. Have you made any adjustment? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing l

[PATCH] D77766: [clangd] Set up machinery for gtests of ClangdLSPServer.

kadircet added a comment. LGTM, mostly nits. Unfortunately I don't see any way to make it simpler :/ Comment at: clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp:104 + +MATCHER_P(DiagMessage, M, "") { + if (const auto *O = arg.getAsObject()) { nit:

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2694 + +void Generic_GCC::AddGCCMultilibPaths(const Driver &D, + const std::string &SysRoot, The class already has `GCC` in the name, so there's no

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

balazske added inline comments. Comment at: clang/include/clang/AST/Expr.h:1494 SourceLocation l, unsigned Scale); - // Store the int as is without any bit shifting. This line removal is not needed and can cause disturbances, it is better

[PATCH] D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag

pratyai updated this revision to Diff 256206. pratyai marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77637/new/ https://reviews.llvm.org/D77637 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Basic/Co

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

mwyman updated this revision to Diff 256210. mwyman added a comment. Add matching MemberRefExpr case, not just the non-matching case there was before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77571/new/ https://reviews.llvm.org/D77571 Files:

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

ASDenysPetrov added a comment. @thakis > 'perl' is not recognized as an internal or external command, I think you got another problem, that Perl isn't just presented in your PATH. It is not the case for buildbot logs. > perl wasn't required to run tests on Win for a long time. If we do want to

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 256212. gamesh411 added a comment. Herald added a subscriber: ASDenysPetrov. Refactored the test Copying the compile_commands.json in case of test for C files results in the extdef mapping tool finding the correct compiler flags for the C to be imported. R

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

mwyman updated this revision to Diff 256209. mwyman marked an inline comment as done. mwyman added a comment. Updating per Stephane's comments. To deal with struct fields needed to match MemberRefExprs. However, in doing so I discovered that the match conditions I thought were catching ObjcIvar

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

mwyman marked 4 inline comments as done. mwyman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/NSInvocationArgumentLifetimeCheck.cpp:49 + QT->getScalarTypeKind() == Type::STK_BlockPointer) && + QT.getQualifiers().getObjCLifetime() > Qualifi

[PATCH] D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag

pratyai updated this revision to Diff 256211. pratyai added a comment. Was unintentionally enabling the bool-flag coverage in SanitizerArgs.cpp before (line#383, `if (Add & SanitizerKind::FuzzerNoLink) { CoverageFeatures |= ... }` Couldn't catch it before because `cmake -G Ninja ../llvm` didn't

[clang-tools-extra] 340d111 - [clang-tidy] [doc] Fix hicpp-noexcept-move alias links.

Author: Marek Kurdej Date: 2020-04-09T10:48:08+02:00 New Revision: 340d1119eddaa30446853832c3ad1e95c6ff96dc URL: https://github.com/llvm/llvm-project/commit/340d1119eddaa30446853832c3ad1e95c6ff96dc DIFF: https://github.com/llvm/llvm-project/commit/340d1119eddaa30446853832c3ad1e95c6ff96dc.diff

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre added a comment. rsmith: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag

vitalybuka added a comment. In D77637#1971417 , @pratyai wrote: > Was unintentionally enabling the bool-flag coverage in SanitizerArgs.cpp > before (line#383, `if (Add & SanitizerKind::FuzzerNoLink) { CoverageFeatures > |= ... }` > > Couldn't catch it be

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 added a comment. In D75665#1907938 , @martong wrote: > > As the CTUDir string prefix is only needed in case of the old approach, I > > have refactored the external definition mapping storage to NOT include that. > > Both `ctu-main.c` and `ctu-on

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 added a comment. In D75665#1907914 , @martong wrote: > The warning below suggests that we parse the ctu-other.c file (and presumably > every file) as a C++ file, even if it should be parsed as a C file. Perhaps > the invocation of the parser

[PATCH] D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGced398fdc813: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag (authored by pratyai, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] ced398f - [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag

Author: Pratyai Mazumder Date: 2020-04-09T02:40:55-07:00 New Revision: ced398fdc813930bfe88df5252c0f5405af541fc URL: https://github.com/llvm/llvm-project/commit/ced398fdc813930bfe88df5252c0f5405af541fc DIFF: https://github.com/llvm/llvm-project/commit/ced398fdc813930bfe88df5252c0f5405af541fc.di

[PATCH] D77776: [Driver] Drop support for FreeBSD < 10

arichardson added a comment. Alternatively, the checks could be changed to also handle OSMajorVersion == 0 and translate that to 10. This seems to be what NetBSD.cpp does. Darwin.cpp also infers the version from the host when running on macos. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://reviews.llvm.org/D76291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

SjoerdMeijer added inline comments. Comment at: clang/docs/MatrixSupport.rst:254 + +Example +=== Hi Florian, just reading this for the first time, this is cool stuff, and just a drive-by comment: this section, Example, looks like a good candidate to be move

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

fhahn added a comment. In D77540#1970034 , @LukeGeeson wrote: > In D77540#1969873 , @fhahn wrote: > > > This patch is quite big and I think it would be easier to review if it > > would be split up into distinct cla

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers updated this revision to Diff 256234. vabridgers added a comment. Address comment from @balazske Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 Files: clang/include/clang/ASTMatchers/ASTMatche

[PATCH] D77503: [ASTMatchers] Fixed CastKind being parsed incorrectly for dynamic matchers

njames93 updated this revision to Diff 256237. njames93 added a comment. Fixed up documentation for CastKind matcher. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77503/new/ https://reviews.llvm.org/D77503 Files: clang/docs/LibASTMatchersRefere

[PATCH] D61716: [libclang] Expose AtomicType

JornVernee added a comment. Would like to try to draw attention to this patch again, since it seems to have gone under the radar. Can someone review this/help get it integrated? We are still having to work around _Atomic types because we can't get to the underlying value type. Thanks Reposito

[clang] 792b109 - [Driver][X86] Add -mpad-max-prefix-size

Author: Shengchen Kan Date: 2020-04-09T19:34:12+08:00 New Revision: 792b10978dfdd424721fbf0ffd99c35d628f2321 URL: https://github.com/llvm/llvm-project/commit/792b10978dfdd424721fbf0ffd99c35d628f2321 DIFF: https://github.com/llvm/llvm-project/commit/792b10978dfdd424721fbf0ffd99c35d628f2321.diff

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

rnk added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t && \ leonardchan wrote: > nemanja

[PATCH] D61716: [libclang] Expose AtomicType

aaron.ballman added a comment. I'm sorry about the delay in review, this did fall off my radar. Thank you for bringing it to my attention! Looks mostly good to me, just a few small nits. Comment at: clang/include/clang-c/Index.h:3953 +/** + * Gets the type contained by this a

[PATCH] D77503: [ASTMatchers] Fixed CastKind being parsed incorrectly for dynamic matchers

aaron.ballman added a comment. Can you also add some unit tests to the dynamic matcher tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77503/new/ https://reviews.llvm.org/D77503 ___ cfe-commits ma

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added inline comments. Comment at: llvm/lib/Target/ARM/ARMTargetMachine.cpp:553 addPass(createARMConstantIslandPass()); - addPass(createARMLowOverheadLoopsPass()); + if (!MachineOutlinerEnabled) +addPass(createARMLowOverheadLoopsPass()); samparker

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

This revision was automatically updated to reflect the committed changes. Closed by commit rG792b10978dfd: [Driver][X86] Add -mpad-max-prefix-size (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/

[PATCH] D77791: [ASTMatchers] Add support for dynamic matching of ofKind narrowing matcher

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for using the ofKind in clang-query and other dynamic matcher use cases Repository: rG LLVM

[PATCH] D77728: [Driver][X86] Add an alias for -mpad-max-prefix-size

skan updated this revision to Diff 256250. skan added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77728/new/ https://reviews.llvm.org/D77728 Files: clang/include/clang/Driver/Options.td clang/test/Driver/x86-malign-branch.c

[PATCH] D77791: [ASTMatchers] Add support for dynamic matching of ofKind narrowing matcher

aaron.ballman added a comment. Thank you for this! It basically LG, but can you also add a dynamic matcher unit test for this functionality? Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:102-106 + static constexpr llvm::StringRef Allowed[] = { + "UETT_SizeOf"

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

steakhal created this revision. steakhal added reviewers: NoQ, baloghadamsoftware, Charusso, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: clang. This patch

[PATCH] D77477: tsan: don't instrument __attribute__((naked)) functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e1ccec8d529: tsan: don't instrument __attribute__((naked)) functions (authored by AntonBikineev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77477/new/

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1125 +DVar.CKind = OMPC_firstprivate; +DVar.PrivateCopy = nullptr; +return DVar; Need to add `DVar.ImplicitDSALoc = Iter->DefaultAttrLoc;` Comment at: clang/l

[PATCH] D77477: tsan: don't instrument __attribute__((naked)) functions

AntonBikineev added a comment. Thanks for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77477/new/ https://reviews.llvm.org/D77477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77791: [ASTMatchers] Add support for dynamic matching of ofKind narrowing matcher

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:102-106 + static constexpr llvm::StringRef Allowed[] = { + "UETT_SizeOf", "UETT_AlignOf", + "UETT_VecStep", "UETT_OpenMPRequiredSimdAlign", + "UETT_Preferr

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. kbobyrev updated this revision to Diff 256263. kbobyrev added a comment. Rebase on to

[PATCH] D77791: [ASTMatchers] Add support for dynamic matching of ofKind narrowing matcher

njames93 updated this revision to Diff 256262. njames93 marked 4 inline comments as done. njames93 added a comment. Added test cases and address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77791/new/ https://reviews.llvm.org/D77791 Files:

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev updated this revision to Diff 256263. kbobyrev added a comment. Rebase on top of the correct revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Files: clang-tools-extra/clangd/CMakeLists.tx

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev updated this revision to Diff 256265. kbobyrev added a comment. Discard Dexp.cpp formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Files: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. In D74387#1970374 , @jdoerfert wrote: > In D74387#1969891 , @Fznamznon wrote: > > > In D74387#1967386 , @jdoerfert > > wrote: > > > > > In D74387#

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev updated this revision to Diff 256267. kbobyrev added a comment. Rebase on top of the correct revision again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Files: clang-tools-extra/clangd/CMakeLi

[PATCH] D77791: [ASTMatchers] Add support for dynamic matching of ofKind narrowing matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:102-106 + static constexpr llvm::StringRef Allowed[] = { + "UETT_SizeOf",

[PATCH] D77728: [Driver][X86] Add an alias for -mpad-max-prefix-size

skan updated this revision to Diff 256268. skan edited the summary of this revision. skan added a comment. Rebase(didn't rebase correctly last time) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77728/new/ https://reviews.llvm.org/D77728 Files:

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! You seem to have a firm grasp on where you want this checker to go, and I like everything about it. The code needs seme `clang-format` treatment, and another eye might not hurt, b

[clang] bf968e2 - [ASTMatchers] Add support for dynamic matching of ofKind narrowing matcher

Author: Nathan James Date: 2020-04-09T14:33:04+01:00 New Revision: bf968e28ee82efce6a34a4dffd904c3c5df4eae4 URL: https://github.com/llvm/llvm-project/commit/bf968e28ee82efce6a34a4dffd904c3c5df4eae4 DIFF: https://github.com/llvm/llvm-project/commit/bf968e28ee82efce6a34a4dffd904c3c5df4eae4.diff

[clang] 9bda29a - [Hexagon] Default linker tests can fail if CLANG_DEFAULT_LINKER is used.

Author: Sid Manning Date: 2020-04-09T08:36:50-05:00 New Revision: 9bda29ab0fdfee4e4b5cbe17f87a16f673e91e1f URL: https://github.com/llvm/llvm-project/commit/9bda29ab0fdfee4e4b5cbe17f87a16f673e91e1f DIFF: https://github.com/llvm/llvm-project/commit/9bda29ab0fdfee4e4b5cbe17f87a16f673e91e1f.diff L

[PATCH] D77503: [ASTMatchers] Fixed CastKind being parsed incorrectly for dynamic matchers

njames93 updated this revision to Diff 256275. njames93 added a comment. Added unit test for matcher Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77503/new/ https://reviews.llvm.org/D77503 Files: clang/docs/LibASTMatchersReference.html clang/

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin marked 2 inline comments as done. DiggerLin added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1500 + if (cast(Name)->hasContainingCsect()) +emitLinkage(&F, Name); + jasonliu wrote: > DiggerLin wrote: > > jasonliu

[PATCH] D77791: [ASTMatchers] Add support for dynamic matching of ofKind narrowing matcher

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:102-106 + static constexpr llvm::StringRef Allowed[] = { + "UETT_SizeOf", "UETT_AlignOf", + "UETT_VecStep", "UETT_Ope

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

Szelethus added a comment. You seem to have forgotten `-U` :^) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77792/new/ https://reviews.llvm.org/D77792 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D77684: [Hexagon] Remove testcases that check for default linker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bda29ab0fdf: [Hexagon] Default linker tests can fail if CLANG_DEFAULT_LINKER is used. (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D77791: [ASTMatchers] Add support for dynamic matching of ofKind narrowing matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf968e28ee82: [ASTMatchers] Add support for dynamic matching of ofKind narrowing matcher (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

sfertile added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 + +class PPCAIX32TargetCodeGenInfo : public TargetCodeGenInfo { +public: Xiangling_L wrote: > I have a question here. AIX32 falls into PPC32 target, so why we don't > inherit from

[clang] 30e5c7e - [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API

Author: Balazs Benics Date: 2020-04-09T16:06:32+02:00 New Revision: 30e5c7e82fa1c5318540feb83d54757c632e2599 URL: https://github.com/llvm/llvm-project/commit/30e5c7e82fa1c5318540feb83d54757c632e2599 DIFF: https://github.com/llvm/llvm-project/commit/30e5c7e82fa1c5318540feb83d54757c632e2599.diff

[clang] db71354 - [ASTMatchers] Fixed CastKind being parsed incorrectly for dynamic matchers

Author: Nathan James Date: 2020-04-09T15:09:45+01:00 New Revision: db71354e4ff13e8f5c6ab38da6339c7583209be0 URL: https://github.com/llvm/llvm-project/commit/db71354e4ff13e8f5c6ab38da6339c7583209be0 DIFF: https://github.com/llvm/llvm-project/commit/db71354e4ff13e8f5c6ab38da6339c7583209be0.diff

[clang] a2b6ece - [analyzer] Display the checker name in the text output

Author: Kirstóf Umann Date: 2020-04-09T16:21:45+02:00 New Revision: a2b6ece1fd4e13f2f463c5075eb0e513af47e656 URL: https://github.com/llvm/llvm-project/commit/a2b6ece1fd4e13f2f463c5075eb0e513af47e656 DIFF: https://github.com/llvm/llvm-project/commit/a2b6ece1fd4e13f2f463c5075eb0e513af47e656.diff

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, baloghadamsoftware. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. This fixes https://b

[PATCH] D77503: [ASTMatchers] Fixed CastKind being parsed incorrectly for dynamic matchers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77503/new/ https://reviews.llvm.org/D77503

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 + +class PPCAIX32TargetCodeGenInfo : public TargetCodeGenInfo { +public: sfertile wrote: > Xiangling_L wrote: > > I have a question here. AIX32 falls into PPC32 target, so why we

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, JDevlieghere, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. We

[PATCH] D77391: [analyzer][AnalysisOrder] Display the CallEvent type for preCall/postCall

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:971-972 #else -void* operator new(std::size_t, const std::nothrow_t&) throw(); -void* operator new[](std::size_t, const std::nothrow_

[PATCH] D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API

This revision was automatically updated to reflect the committed changes. Closed by commit rG30e5c7e82fa1: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API (authored by steakhal). Herald added a subscriber: ASDenysPetrov. Changed prior to commit: https://reviews.llvm.or

[PATCH] D77503: [ASTMatchers] Fixed CastKind being parsed incorrectly for dynamic matchers

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb71354e4ff1: [ASTMatchers] Fixed CastKind being parsed incorrectly for dynamic matchers (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D76605: [analyzer] Display the checker name in the text output

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2b6ece1fd4e: [analyzer] Display the checker name in the text output (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76605/new/ https

[PATCH] D77391: [analyzer][AnalysisOrder] Display the CallEvent type for preCall/postCall

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:202 virtual Kind getKind() const = 0; + virtual StringRef getKindAsString() const = 0; NoQ wrote: > M

[clang] 56c3b2b - [OPENMP]Fix capturing of global variables in OpenMP regions.

Author: Alexey Bataev Date: 2020-04-09T10:36:09-04:00 New Revision: 56c3b2b091bf94ed5c3d614f3d10e8e973a72d17 URL: https://github.com/llvm/llvm-project/commit/56c3b2b091bf94ed5c3d614f3d10e8e973a72d17 DIFF: https://github.com/llvm/llvm-project/commit/56c3b2b091bf94ed5c3d614f3d10e8e973a72d17.diff

[clang] 023c4d4 - [analyzer][AnalysisOrderChecker] Display the CallEvent type in preCall/postCall

Author: Kirstóf Umann Date: 2020-04-09T16:41:07+02:00 New Revision: 023c4d400ef5acf3a7339dc8452ce552b15a9ae4 URL: https://github.com/llvm/llvm-project/commit/023c4d400ef5acf3a7339dc8452ce552b15a9ae4 DIFF: https://github.com/llvm/llvm-project/commit/023c4d400ef5acf3a7339dc8452ce552b15a9ae4.diff

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1500 + if (cast(Name)->hasContainingCsect()) +emitLinkage(&F, Name); + DiggerLin wrote: > jasonliu wrote: > > DiggerLin wrote: > > > jasonliu wrote: > > > > 1. We

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

asb added a comment. I've approved D65649 now, so I think this one can land as soon as that one does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891 ___

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko updated this revision to Diff 256306. vsavchenko added a comment. Add one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker.

[PATCH] D77728: [Driver][X86] Add an alias for -mpad-max-prefix-size

skan updated this revision to Diff 256308. skan added a comment. Fix the tests after rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77728/new/ https://reviews.llvm.org/D77728 Files: clang/include/clang/Driver/Options.td clang/test/Driver

[PATCH] D77305: [Analyzer][VLASize] Support multi-dimensional arrays.

balazske updated this revision to Diff 256307. balazske marked 3 inline comments as done. balazske added a comment. Small renamings and reformatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77305/new/ https://reviews.llvm.org/D77305 Files:

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Hi Vince, this looks good to me! On the other hand I was pondering on @balazske's comment, this one: > Or use the new flag added to every item in DefaultTestValuesForRunOptions, > specially

[PATCH] D77391: [analyzer][AnalysisOrder] Display the CallEvent type for preCall/postCall

This revision was automatically updated to reflect the committed changes. Szelethus marked an inline comment as done. Closed by commit rG023c4d400ef5: [analyzer][AnalysisOrderChecker] Display the CallEvent type in preCall/postCall (authored by Szelethus). Changed prior to commit: https://review

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 256310. baloghadamsoftware added a comment. OK. I solved almost every problem except that `checkDeadSymbols()` removes the iterator position keyed by the temporary region representing the argument from the map before it is needed. Either I must so

[PATCH] D77731: [OPENMP]Fix capturing of global variables in OpenMP regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG56c3b2b091bf: [OPENMP]Fix capturing of global variables in OpenMP regions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77731/new/ h

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1497 + OutContext.getOrCreateSymbol("." + Name->getName()); + assert(FnEntryPointSym->getName().equals( + cast(FnEntryPointSym)->getUnqualifiedName()) && -

[clang] 2b8c1ac - [OPENMP]Fix the test to pacify buildbots, NFC.

Author: Alexey Bataev Date: 2020-04-09T11:28:50-04:00 New Revision: 2b8c1ac9cad6c4465e1ff79a67ab68b8e83a49d3 URL: https://github.com/llvm/llvm-project/commit/2b8c1ac9cad6c4465e1ff79a67ab68b8e83a49d3 DIFF: https://github.com/llvm/llvm-project/commit/2b8c1ac9cad6c4465e1ff79a67ab68b8e83a49d3.diff

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-extern.ll:14 + +; Function Attrs: noinline nounwind optnone +define void @foo() #0 { nit: Function Attrs and `#0` could be removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

kmclaughlin added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76078/new/ https://reviews.llvm.org/D76078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

balazske updated this revision to Diff 256317. balazske added a comment. Addressed review comments (reformat and rename). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75851/new/ https://reviews.llvm.org/D75851 Files: clang/lib/StaticAnalyzer/Ch

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko updated this revision to Diff 256318. vsavchenko added a comment. Add forgotten hunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:253 + + // FIXME Implement a generic negate for all BO values. + assert(Tmp.Op == BO_LE && "Op should be <="); -

Build czar switchover

Hi Volodymyr and Azhar, Here is the current status of the bots: 1. Automerger Automerger has almost caught up. [apple/master -> internal/master] has just 13 unmerged commits and no conflicts. 2. BlueDragon There are a few clang-1200 bots that are failing. - The following bot is failing because

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

martong added a comment. I like it, nice work! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:774 +Optional RangeConstraintManager::tryAssumeSymSymOp( +ProgramStateRef State, BinaryOperator::Opcode Op, SymbolRef LHSSym, Is it possibl

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

hliao updated this revision to Diff 256321. hliao added a comment. Rebase to trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org/D7 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenCUDA/surface

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Array size expr

Re: changes to matrix size check

+ Volodymyr, Azhar > On Apr 8, 2020, at 6:28 AM, Florian Hahn wrote: > > Hi Akira, > >> On Apr 7, 2020, at 21:12, Akira Hatanaka > > wrote: >> >> Hi Adam and Florian, >> >> Just to give you a heads up, I’ve made changes to the code that checks >> matrix size and t

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

martong added a comment. In D75665#1971440 , @gamesh411 wrote: > In D75665#1907914 , @martong wrote: > > > The warning below suggests that we parse the ctu-other.c file (and > > presumably every file) as a C++ file

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

martong added a comment. There must be a way to dump the CFG. Perhaps you could add a test that dumps the CFG of a given source and then by using `FileCheck` we could see the exact feature that is missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton accepted this revision. s.egerton added a comment. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 ___ cfe-commits mailing list cfe-c

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

hliao requested changes to this revision. hliao added a comment. This revision now requires changes to proceed. In D77743#1970304 , @tra wrote: > In D77743#1970163 , @yaxunl wrote: > > > The kernel handle is a varia

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

Szelethus added a comment. In D77809#1972232 , @martong wrote: > There must be a way to dump the CFG. Perhaps you could add a test that dumps > the CFG of a given source and then by using `FileCheck` we could see the > exact feature that is missing. `d

  1   2   3   >