+ Volodymyr, Azhar > On Apr 8, 2020, at 6:28 AM, Florian Hahn <florian_h...@apple.com> wrote: > > Hi Akira, > >> On Apr 7, 2020, at 21:12, Akira Hatanaka <ahatan...@apple.com >> <mailto:ahatan...@apple.com>> wrote: >> >> Hi Adam and Florian, >> >> Just to give you a heads up, I’ve made changes to the code that checks >> matrix size and the corresponding test case following Sam McCall’s open >> source patch >> (https://github.com/llvm/llvm-project/commit/88fbadd0f5d50ea1d310fb63da6da15b82a9be05 >> >> <https://github.com/llvm/llvm-project/commit/88fbadd0f5d50ea1d310fb63da6da15b82a9be05>). >> If it’s not correct or if you think there are better ways to do the check, >> feel free to rewrite the code I committed. >> >> https://stashweb.sd.apple.com/projects/DEVTOOLS/repos/llvm-project/pull-requests/1408/overview >> >> <https://stashweb.sd.apple.com/projects/DEVTOOLS/repos/llvm-project/pull-requests/1408/overview> > Thanks for the heads-up. I will take a look. I just noticed that > internal/master started crashing for matrix code. Might be related. >
I’m seeing aarch64-matrix-amx-versioning.cpp assert when I run the tests on my desktop machine. Is that the test you saw that was crashing? I haven’t seen this failure in any of our internal bots though, probably because the test is guarded by ‘REQUIRES: matrix-test’. Also, there was a commit by Eli Friedman which removed SequentialType from the type hierarchy. I just did the minimum to resolve the merge conflict, but it looks like there are several places that need to be fixed to handle MatrixType. Could you take a look at them too? Also, there are three failing opt pipeline tests: https://smooshbase.apple.com/ci/view/BuildCzar/job/apple-clang-xcode-stage1-RA/job/internal%252Fclang%252F1200/238/ Should we cherry pick the following commit to clang 1200 or should we just fix the check strings in the tests? Author: Florian Hahn <florian_h...@apple.com <mailto:florian_h...@apple.com>> Date: Tue Apr 7 14:44:19 2020 +0100 [Matrix] Preserve LI in TileBuilder. > Cheers, > Florian >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
