[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

2020-03-20 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Actually this may not need a reproducer since the error seems straightforward with just calling a builtin function. The main issue is that before this patch, something like #include float64x2_t func(int8x8_t x) { return __builtin_neon_splatq_lane_v(x, 1, 10

[PATCH] D76452: Use LLD by default for Android.

2020-03-20 Thread Dan Albert via Phabricator via cfe-commits
danalbert abandoned this revision. danalbert added a comment. Looks like we don't actually need this. Can achieve the same effect by installing `ld.lld` to the same directory as Clang as `ld` and it'll be preferred over the other locations. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D76393: Allow remapping the sysroot with -fdebug-prefix-map.

2020-03-20 Thread Adrian Prantl via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6725c4836a5b: Allow remapping the sysroot with -fdebug-prefix-map. (authored by aprantl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D76393?vs=251412&id=251798#toc

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

2020-03-20 Thread Paula Toth via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG556b917fffcf: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers… (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] ceae471 - Allow remapping the sysroot with -fdebug-prefix-map.

2020-03-20 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2020-03-20T16:27:50-07:00 New Revision: ceae47143b1d2c5622e0318255e6663264d61299 URL: https://github.com/llvm/llvm-project/commit/ceae47143b1d2c5622e0318255e6663264d61299 DIFF: https://github.com/llvm/llvm-project/commit/ceae47143b1d2c5622e0318255e6663264d61299.diff

[clang] bde15de - Revert "Allow remapping the sysroot with -fdebug-prefix-map."

2020-03-20 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2020-03-20T16:27:23-07:00 New Revision: bde15de3cabff6363008e67a999e6e4559743867 URL: https://github.com/llvm/llvm-project/commit/bde15de3cabff6363008e67a999e6e4559743867 DIFF: https://github.com/llvm/llvm-project/commit/bde15de3cabff6363008e67a999e6e4559743867.diff

[clang] 0e916bf - Driver: Improve performance of getSDKName()

2020-03-20 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2020-03-20T16:41:59-07:00 New Revision: 0e916bf9f5e4a51af621fd72ccf4b00b7e6f86fa URL: https://github.com/llvm/llvm-project/commit/0e916bf9f5e4a51af621fd72ccf4b00b7e6f86fa DIFF: https://github.com/llvm/llvm-project/commit/0e916bf9f5e4a51af621fd72ccf4b00b7e6f86fa.diff

[PATCH] D76097: improve performance of getSDKName()

2020-03-20 Thread Adrian Prantl via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e916bf9f5e4: Driver: Improve performance of getSDKName() (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D76393: Allow remapping the sysroot with -fdebug-prefix-map.

2020-03-20 Thread Paula Toth via Phabricator via cfe-commits
PaulkaToast added a comment. This seems to be causing a failure in our buildbot , mind taking a look? (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76393/new/ https://reviews.llvm.org/D76393

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

2020-03-20 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Let's make this patch be purely a representation change. I wouldn't expect *any* test changes from that; if there are, we should understand why. You can then add the stuff about tracking whether there's a pragma in a separate patch. Comment at: cla

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

2020-03-20 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 251801. oontvoo marked an inline comment as done. oontvoo added a comment. Additional change: Also keep "Importers" and de/serialise these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://revie

[PATCH] D76452: Use LLD by default for Android.

2020-03-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Thanks for abandoning this patch. I am glad Android does not need customization on top of the generic Linux behavior. (This makes clangDriver clean.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/ https://reviews

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

2020-03-20 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. Oh good catch. Were there no vector tests which tripped this? Vectors can hold scalar types with padding (i.e. `long double`)? Tail padding in vectors do seem important to initialize as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D76393: Allow remapping the sysroot with -fdebug-prefix-map.

2020-03-20 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. Yeah, screwed up during rebasing and accidentally committed an extra file from a different review I reverted and relanded the patch now and the bots are running again. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

2020-03-20 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 251804. oontvoo added a comment. Removed accidentally committed file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

2020-03-20 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:701-713 + if (getLangOpts().CUDAIsDevice) { +// As CUDA builtin surface/texture types are replaced, skip generating TBAA +// access info. +if (AccessType->isCUDADeviceBuiltinSurfaceType()) { +

[clang] be10b7e - Use values cached in ConstantExprs for expression evaluation where

2020-03-20 Thread Richard Smith via cfe-commits
Author: Wyatt Childers Date: 2020-03-20T18:14:58-07:00 New Revision: be10b7e43a3a10fbd3244f826591f3f65c0b7e21 URL: https://github.com/llvm/llvm-project/commit/be10b7e43a3a10fbd3244f826591f3f65c0b7e21 DIFF: https://github.com/llvm/llvm-project/commit/be10b7e43a3a10fbd3244f826591f3f65c0b7e21.diff

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

2020-03-20 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbe10b7e43a3a: Use values cached in ConstantExprs for expression evaluation where present. (authored by wchilders, committed by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d35a454 - [CodeGen] Emit destructor calls to destruct non-trivial C struct objects

2020-03-20 Thread via cfe-commits
Author: Akira Hatanaka Date: 2020-03-20T18:34:22-07:00 New Revision: d35a454170da3da9c9bb0b5627f5796113195283 URL: https://github.com/llvm/llvm-project/commit/d35a454170da3da9c9bb0b5627f5796113195283 DIFF: https://github.com/llvm/llvm-project/commit/d35a454170da3da9c9bb0b5627f5796113195283.diff

[clang] ced7617 - PR45267: Don't reject pure-specifiers with escaped newlines in their '0' token.

2020-03-20 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-03-20T18:44:55-07:00 New Revision: ced7617c3853d19ffa00a578e92ffd7c54b6c2fb URL: https://github.com/llvm/llvm-project/commit/ced7617c3853d19ffa00a578e92ffd7c54b6c2fb DIFF: https://github.com/llvm/llvm-project/commit/ced7617c3853d19ffa00a578e92ffd7c54b6c2fb.diff

[clang] a299178 - [cmake] Fix -stripped for umbrella library install targets

2020-03-20 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2020-03-20T18:46:48-07:00 New Revision: a299178ae77a9d0c7d66f50d17483b7d18898ef0 URL: https://github.com/llvm/llvm-project/commit/a299178ae77a9d0c7d66f50d17483b7d18898ef0 DIFF: https://github.com/llvm/llvm-project/commit/a299178ae77a9d0c7d66f50d17483b7d18898ef0.diff

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

2020-03-20 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd35a454170da: [CodeGen] Emit destructor calls to destruct non-trivial C struct objects… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D76538: [WebAssembly] Add SIMD integer abs builtins

2020-03-20 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Since the conditional operator cannot be used with vector conditions in C, we need a builtin to be able to express th

[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

2020-03-20 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Is the option issue causing the documentation to be wrong in any way, or does it just produce a warning? If the latter, we could raise this issue with them. Repository: rG LLVM Github

[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

2020-03-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. What should the behavior of the builtin be if the calling function has its own target cpu like __attribute__((target("arch=sandybridge"))) and that CPU has a different size than the CPU that was passed on the command line? Comment at: clang/inclu

[PATCH] D76424: [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC

2020-03-20 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang/lib/AST/Type.cpp:3036 -if (epi.ExceptionSpec.NoexceptExpr->isValueDependent() || -epi.ExceptionSpec.NoexceptExpr->isInstantiationDepen

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

2020-03-20 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 251567. baloghadamsoftware added a comment. Updated according to the comments and automatic formatting suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76361/new/ https://reviews.llvm.org/D76361 Files: clang/lib/StaticAnalyze

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

2020-03-20 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D75184#1932764 , @alexfh wrote: > There's one more thing to consider: just by looking at the name of a local > option we don't know whether it will be read using `get()` or > `getLocalOrGlobal()`. By removing local options we

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

2020-03-20 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware marked 9 inline comments as done. baloghadamsoftware added a comment. In D76361#1929483 , @martong wrote: > I suppose we could get this strange behavior with `std::distance` too? Would > it be worth to handle that as well here? Modeli

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

2020-03-20 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun updated this revision to Diff 251569. xazax.hun marked an inline comment as done. xazax.hun added a comment. - Rebase. - Address some review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72810/new/ https://reviews.llvm.org/D72810 Files: clang/include/clang/AST/Att

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

2020-03-20 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun marked 14 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:163 +// Maps each annotated entity to a lifetime set. +using LifetimeContracts = std::map; + aaron.ballman wrote: > xazax.hun wrote: >

[clang] e963063 - [Syntax] Split syntax tests

2020-03-20 Thread Dmitri Gribenko via cfe-commits
Author: Marcel Hlopko Date: 2020-03-20T09:53:43+01:00 New Revision: e9630630ffa2a69bf3eabe154a3846deab694fa0 URL: https://github.com/llvm/llvm-project/commit/e9630630ffa2a69bf3eabe154a3846deab694fa0 DIFF: https://github.com/llvm/llvm-project/commit/e9630630ffa2a69bf3eabe154a3846deab694fa0.diff

[PATCH] D76366: [Syntax] Split syntax tests

2020-03-20 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251571. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76366/new/ https://reviews.llvm.org/D76366 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unittests/Tooli

[PATCH] D76366: [Syntax] Split syntax tests

2020-03-20 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe9630630ffa2: [Syntax] Split syntax tests (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76366/new/ https://rev

[PATCH] D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc

2020-03-20 Thread LiuChen via Phabricator via cfe-commits
LiuChen3 marked 3 inline comments as done. LiuChen3 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1559 + if (const auto *AT = QT->getAsArrayTypeUnsafe()) +TempAlignment = getContext().getTypeAlign(AT->getElementType()) / 8; + e

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

2020-03-20 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llvm.org/D75360 ___ cfe-commits m

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251576. hlopko added a comment. Refactored to run tests on both default and windows platforms. Opting out Templates test for now since it doesn't work with -fdelayed-template-parsing yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:102 +std::vector Args = {"-target", Target.data(), + "-fsyn

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251585. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76433/new/ https://reviews.llvm.org/D76433 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unittests/Tool

[PATCH] D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS

2020-03-20 Thread Lucas Prates via Phabricator via cfe-commits
pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75903/new/ https://reviews.llvm.org/D75903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251582. hlopko marked 3 inline comments as done. hlopko added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76433/new/ https://reviews.llvm.org/D76433 Files: clang/unittests/Tooli

[PATCH] D75904: [ARM][CodeGen] Fixing stack alignment of HFA arguments on AArch32 PCS

2020-03-20 Thread Lucas Prates via Phabricator via cfe-commits
pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75904/new/ https://reviews.llvm.org/D75904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] 180581c - [clang] Add support for consteval constructors

2020-03-20 Thread via cfe-commits
Author: Tyker Date: 2020-03-20T11:33:54+01:00 New Revision: 180581cfcf5115388caa3b8ee20eac1fd35f2d11 URL: https://github.com/llvm/llvm-project/commit/180581cfcf5115388caa3b8ee20eac1fd35f2d11 DIFF: https://github.com/llvm/llvm-project/commit/180581cfcf5115388caa3b8ee20eac1fd35f2d11.diff LOG: [c

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

2020-03-20 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. In D75184#1932764 , @alexfh wrote: > There's one more thing to consider: just by looking at the name of a local > option we don't know whether it will be read using `get()` or > `getLocalOrGlobal()`. By removing local opti

[PATCH] D76444: Use FinishThunk to finish musttail thunks

2020-03-20 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76444/new/ https://reviews.llvm.org/D76444 ___ cfe

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfd7300f717c1: [Syntax] Test both the default and windows target platforms in unittests (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] fd7300f - [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Dmitri Gribenko via cfe-commits
Author: Marcel Hlopko Date: 2020-03-20T11:42:18+01:00 New Revision: fd7300f717c18c861e77685efe6f16f12fb63ae7 URL: https://github.com/llvm/llvm-project/commit/fd7300f717c18c861e77685efe6f16f12fb63ae7 DIFF: https://github.com/llvm/llvm-project/commit/fd7300f717c18c861e77685efe6f16f12fb63ae7.diff

[PATCH] D74007: [clang] Add support for consteval constructors

2020-03-20 Thread Tyker via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG180581cfcf51: [clang] Add support for consteval constructors (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org

[clang] 9967352 - Revert "[Syntax] Test both the default and windows target platforms in unittests"

2020-03-20 Thread Dmitri Gribenko via cfe-commits
Author: Dmitri Gribenko Date: 2020-03-20T12:13:49+01:00 New Revision: 9967352a0346021d389afb6e3283d0c58911a560 URL: https://github.com/llvm/llvm-project/commit/9967352a0346021d389afb6e3283d0c58911a560 DIFF: https://github.com/llvm/llvm-project/commit/9967352a0346021d389afb6e3283d0c58911a560.dif

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Breaks tests on Windows: http://45.33.8.238/win/10881/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76433/new/ https://reviews.llvm.org/D76433 ___ cfe-commits mailing

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-20 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko added a comment. Taking over the patch in https://reviews.llvm.org/D76355. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:147 + void add(ASTPtr From, syntax::Tree *To) { +assert(To != nullptr); + gribozavr2 wrote: > Also assert that From is not

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-20 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251603. hlopko added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooli

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

2020-03-20 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. In D75591#1904969 , @lebedev.ri wrote: > IIUC `default(firstprivate)` is being added in openmp-5.1, > it is not in openmp-4.5, so it

[PATCH] D76140: [InlineFunction] update attributes during inlining

2020-03-20 Thread Anna Thomas via Phabricator via cfe-commits
anna marked an inline comment as done. anna added inline comments. Herald added a reviewer: aartbik. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1172 +return true; +return false; + }; jdoerfert wrote: > `mayThrow` is not sufficient. As w

[PATCH] D76140: [InlineFunction] update attributes during inlining

2020-03-20 Thread Anna Thomas via Phabricator via cfe-commits
anna updated this revision to Diff 251615. anna added a comment. use isGuaranteedToTransferExecutionToSuccessor instead of `MayThrow` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76140/new/ https://reviews.llvm.org/D76140 Files: clang/test/Code

[PATCH] D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family.

2020-03-20 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. I've implemented them as target-specific IR intrinsics rather than using `@llvm.e

[PATCH] D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.

2020-03-20 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: cfe-commits, hiraditya, kristof.beyls. Herald added a project: clang. I've implemented these as target-specific IR intrinsics, because they're not //quite// enough

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

2020-03-20 Thread Andrzej Warzynski via Phabricator via cfe-commits
andwar added a comment. > Have you considered adding an interface for the new PM? Please ignore that comment ^^^. I incorrectly assumed that the backend has also been ported to the new PM, but that's not the case. In particular, `llc` will only use the legacy PM anyway: https://github.com/llvm

[clang] fcba7c3 - [OPENMP50]Initial support for scan directive.

2020-03-20 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-03-20T07:58:15-04:00 New Revision: fcba7c3534f98851531095f8457eb3142e237f0b URL: https://github.com/llvm/llvm-project/commit/fcba7c3534f98851531095f8457eb3142e237f0b DIFF: https://github.com/llvm/llvm-project/commit/fcba7c3534f98851531095f8457eb3142e237f0b.diff

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

2020-03-20 Thread Mark Murray via Phabricator via cfe-commits
MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76296/new/ https://reviews.llvm.org/D76296 ___ cfe-commits mailing list

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

2020-03-20 Thread Mark Murray via Phabricator via cfe-commits
MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. I like to use of the macros instead of a huge cross-product of types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76299/new/ https://reviews.llvm.org/D76299 ___

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

2020-03-20 Thread Mark Murray via Phabricator via cfe-commits
MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76298/new/ https://reviews.llvm.org/D76298 ___ cfe-commits mailing list

[PATCH] D76300: [ARM,CDE] Implement CDE vreinterpret intrinsics

2020-03-20 Thread Mark Murray via Phabricator via cfe-commits
MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76300/new/ https://reviews.llvm.org/D76300 _

[clang] a4edea2 - Fix `-Wunused-variable` warning. NFC.

2020-03-20 Thread Michael Liao via cfe-commits
Author: Michael Liao Date: 2020-03-20T09:31:58-04:00 New Revision: a4edea29be2a77a8c8c237d75563a09a61791442 URL: https://github.com/llvm/llvm-project/commit/a4edea29be2a77a8c8c237d75563a09a61791442 DIFF: https://github.com/llvm/llvm-project/commit/a4edea29be2a77a8c8c237d75563a09a61791442.diff

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

2020-03-20 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen marked 4 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:128 def SVLD1 : MInst<"svld1[_{2}]", "dPc", "csilUcUsUiUlhfd", [IsLoad]>; +def SVLD1SB : MInst<"svld1sb_{d}", "dPS", "silUsUiUl", [IsLoad],

[PATCH] D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.

2020-03-20 Thread Mark Murray via Phabricator via cfe-commits
MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76490/new/ https://reviews.llvm.org/D76490 _

[clang] d22e661 - [ARM, CDE] Implement CDE S and D-register intrinsics

2020-03-20 Thread Mikhail Maltsev via cfe-commits
Author: Mikhail Maltsev Date: 2020-03-20T14:01:53Z New Revision: d22e66171251cd3dd07507912189aa814a419678 URL: https://github.com/llvm/llvm-project/commit/d22e66171251cd3dd07507912189aa814a419678 DIFF: https://github.com/llvm/llvm-project/commit/d22e66171251cd3dd07507912189aa814a419678.diff LO

[clang] 7a85e35 - [ARM,CDE] Implement GPR CDE intrinsics

2020-03-20 Thread Mikhail Maltsev via cfe-commits
Author: Mikhail Maltsev Date: 2020-03-20T14:01:51Z New Revision: 7a85e3585ec59b1bfe3b08072ff042af80d07f22 URL: https://github.com/llvm/llvm-project/commit/7a85e3585ec59b1bfe3b08072ff042af80d07f22 DIFF: https://github.com/llvm/llvm-project/commit/7a85e3585ec59b1bfe3b08072ff042af80d07f22.diff LO

[clang] 969034b - [ARM, CDE] Implement CDE unpredicated Q-register intrinsics

2020-03-20 Thread Mikhail Maltsev via cfe-commits
Author: Mikhail Maltsev Date: 2020-03-20T14:01:56Z New Revision: 969034b86037d3c1daf725aef13ba16424f92fe1 URL: https://github.com/llvm/llvm-project/commit/969034b86037d3c1daf725aef13ba16424f92fe1 DIFF: https://github.com/llvm/llvm-project/commit/969034b86037d3c1daf725aef13ba16424f92fe1.diff LO

[clang] 6ae3eff - [ARM,CDE] Implement CDE vreinterpret intrinsics

2020-03-20 Thread Mikhail Maltsev via cfe-commits
Author: Mikhail Maltsev Date: 2020-03-20T14:01:57Z New Revision: 6ae3eff8baaca95752b1ec9732c605b3d4e8d630 URL: https://github.com/llvm/llvm-project/commit/6ae3eff8baaca95752b1ec9732c605b3d4e8d630 DIFF: https://github.com/llvm/llvm-project/commit/6ae3eff8baaca95752b1ec9732c605b3d4e8d630.diff LO

[PATCH] D76496: [clang-tidy] StringFindStartswith should ignore 3-arg find()

2020-03-20 Thread Niko Weh via Phabricator via cfe-commits
niko created this revision. niko added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. string::find() has a 3-argument version, with the third argument specifying the 'length of sequence of characters to match' (for a const char* 1st argument, t

[PATCH] D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.

2020-03-20 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham updated this revision to Diff 251626. simon_tatham added a comment. Update tests to fix CI failure (oops). Also added `opt -sroa` to make the incidental half/float argument marshalling a bit less verbose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

2020-03-20 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D76365#1932517 , @tra wrote: > In D76365#1932439 , @hliao wrote: > > > > > > > > > That's a magic. I could not figure out how it works. From its use, e.g. > > `tex2D` on `texture`, > > >

[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This increases the coverage for things that differ between Linux and Windows, such as -fdelayed-template-parsing. This would have prevented the rollback of https://reviews.llvm.org/D76346. While

[PATCH] D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout

2020-03-20 Thread Vishal Chebrolu via Phabricator via cfe-commits
vish99 updated this revision to Diff 251630. vish99 added a comment. Reverting back to diff 222348, the previous diff was against a wrong branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52898/new/ https://reviews.llvm.org/D52898 Files: llvm

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

2020-03-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG969034b86037: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D76299?vs=251039&id=251635#toc Repository: rG LLVM Git

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

2020-03-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd22e66171251: [ARM,CDE] Implement CDE S and D-register intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76298/new/ https://rev

[PATCH] D76300: [ARM,CDE] Implement CDE vreinterpret intrinsics

2020-03-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6ae3eff8baac: [ARM,CDE] Implement CDE vreinterpret intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76300/new/ https://reviews

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

2020-03-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7a85e3585ec5: [ARM,CDE] Implement GPR CDE intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76296/new/ https://reviews.llvm.org

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

2020-03-20 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks good to me. Please wait a day in case Eli has more comments. Comment at: clang/include/clang/Basic/arm_sve.td:128 def SVLD1 : MInst<"svld1[_{2}]", "dPc",

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

2020-03-20 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 251640. balazske added a comment. Simplified code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75851/new/ https://reviews.llvm.org/D75851 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp clang

[clang] 94061df - [analyzer] StdLibraryFunctionsChecker: Add argument constraints

2020-03-20 Thread Gabor Marton via cfe-commits
Author: Gabor Marton Date: 2020-03-20T16:33:14+01:00 New Revision: 94061df6e5f24c2f25ad7c55af13dd175856 URL: https://github.com/llvm/llvm-project/commit/94061df6e5f24c2f25ad7c55af13dd175856 DIFF: https://github.com/llvm/llvm-project/commit/94061df6e5f24c2f25ad7c55af13dd175856.diff

[clang] eddede9 - [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Dmitri Gribenko via cfe-commits
Author: Marcel Hlopko Date: 2020-03-20T16:33:58+01:00 New Revision: eddede9d5184a431c7f859ef1869f1a4de8d08d4 URL: https://github.com/llvm/llvm-project/commit/eddede9d5184a431c7f859ef1869f1a4de8d08d4 DIFF: https://github.com/llvm/llvm-project/commit/eddede9d5184a431c7f859ef1869f1a4de8d08d4.diff

<    1   2