rjmccall added a comment.
Let's make this patch be purely a representation change. I wouldn't expect
*any* test changes from that; if there are, we should understand why. You can
then add the stuff about tracking whether there's a pragma in a separate patch.
================
Comment at: clang/include/clang/AST/StmtVisitor.h:92
+ case BO_XorAssign:
+ DISPATCH(BinXorAssign, BinaryOperator);
case BO_Comma: DISPATCH(BinComma, BinaryOperator);
----------------
Let's stick with the existing formatting for consistency. It's just vertically
aligning the DISPATCH and class-name tokens to emphasize the common pattern.
================
Comment at: clang/include/clang/Serialization/ASTBitCodes.h:1560
- /// A CompoundAssignOperator record.
- EXPR_COMPOUND_ASSIGN_OPERATOR,
-
----------------
I think the intent is that we don't change constant values in this file. You
can leave this in place with a comment saying it's defunct, though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76384/new/
https://reviews.llvm.org/D76384
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
