[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 added a comment. Just giving this a friendly ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72282/new/ https://reviews.llvm.org/D72282 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added a comment. In D75917#1916972 , @sameerds wrote: > Well, there is a problem: The LangRef says that scopes are target-defined. > This change says that scopes are defined by the high-level language and > further assumes that OpenCL sco

[PATCH] D74615: [Analyzer] Add visitor to track iterator invalidation

Szelethus added a comment. You may have explained it in the summary, and I didn't get it, but why isn't putting a `NoteTag` in `invalidateAllIteratorPositions` sufficient? We could state something like `All iterators associated with 'V' are invalidated`. I'm not against a visitor, just playing

[libunwind] 8ffdabd - Lazily save initialState of registers during unwind.

Author: Sterling Augustine Date: 2020-03-11T10:13:33-07:00 New Revision: 8ffdabdb61e1e2251b07ee93a4806cde1890f47d URL: https://github.com/llvm/llvm-project/commit/8ffdabdb61e1e2251b07ee93a4806cde1890f47d DIFF: https://github.com/llvm/llvm-project/commit/8ffdabdb61e1e2251b07ee93a4806cde1890f47d.

[clang] 0d7c8c0 - [OPENMP][DOCS]Mark depobj as implemented, NFC.

Author: Alexey Bataev Date: 2020-03-11T13:26:01-04:00 New Revision: 0d7c8c07d2a532d62487e646b1d6dec1542111f6 URL: https://github.com/llvm/llvm-project/commit/0d7c8c07d2a532d62487e646b1d6dec1542111f6 DIFF: https://github.com/llvm/llvm-project/commit/0d7c8c07d2a532d62487e646b1d6dec1542111f6.diff

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

jdoerfert added a subscriber: fghanim. jdoerfert added a comment. In D75591#1916433 , @atmnpatel wrote: > Modified the unit test for CodeGen of default(firstprivate) to more > accurately reflect the IR. > > From the perspective of the AST, the variables t

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. @rjmccall Since CompoundAssignmentOperator derives from BinaryOperator, it's not simple to add Trailing storage here. I think I will have to fold CompoundAssignmentOperator into BinaryOperator and then add the 2 extra fields needed by CompoundAssignmentOperator into Tr

[PATCH] D74541: [Analyzer] Use note tags to track iterator increments and decrements

Szelethus added a comment. A few nits, otherwise the patch is great! Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:519-520 +const NoteTag *IteratorModeling::getChangeTag(CheckerContext &C, StringRef Text, + cons

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

mibintc added a comment. I ran into an obstacle trying to add Trailing storage onto binary operator. it will probably take me longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75443/new/ https://reviews.llvm.org/D75443 _

[PATCH] D75560: Make Decl:: setOwningModuleID() public. (NFC)

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75560/new/ https://reviews.llvm.org/D75560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

tra marked an inline comment as done. tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:51 + // the latest version we support. + D.Diag(diag::warn_drv_unknown_cuda_version) + << MajorMinor << CudaVersionToString(CudaVersion::LATEST); -

[PATCH] D74541: [Analyzer] Use note tags to track iterator increments and decrements

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:519-520 +const NoteTag *IteratorModeling::getChangeTag(CheckerContext &C, StringRef Text, + const Expr *ItE, SVal It1, +

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

Szelethus added a comment. Its very interesting to see how the idea of interestingness propagation through `NoteTag`s works in practice -- I feel like many other checkers will need to adopt something like this, and its great that we have the first use case presented here. The patch from afar lo

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers updated this revision to Diff 249680. vabridgers added a comment. Address Artem's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFu

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille added a comment. @MaskRay are you ok with that version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___ cfe-commits mailing list cfe-commi

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

Szelethus added inline comments. Comment at: clang/test/Analysis/iterator-modelling.cpp:169 clang_analyzer_eval(clang_analyzer_iterator_container(i2) == &v); // expected-warning{{TRUE}} // expected-note@-

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

Szelethus added a comment. The code from in `ExprInspectionChecker.cpp` is duplicated from D75677 , isn't it? Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:55 - ExplodedNode *reportBug(llvm::StringRef Msg, CheckerCo

[PATCH] D75985: clangd doc: Show a test case for clangd with some commands

sammccall added a comment. Thanks for the context! In D75985#1917163 , @sylvestre.ledru wrote: > With my Debian/Ubuntu hat, i have been interested to write some dumb > integration tests to be sure that clangd, as a package, works as expected. > I just

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added a comment. In D72841#1917340 , @mibintc wrote: > @rjmccall Since CompoundAssignmentOperator derives from BinaryOperator, it's > not simple to add Trailing storage here. I think I will have to fold > CompoundAssignmentOperator into BinaryO

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249690. oontvoo retitled this revision from "draft " to "draft". oontvoo added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include

[PATCH] D62738: [HIP] Support attribute hip_pinned_shadow

yaxunl added a comment. @tra Originally we introduced the `__hip_pinned_shadow__` attribute to support texture type. It ended up as a variable attribute for more generic usage. However we got usability issue since users have to add this attribute whenever they use texture type. I would like to

[PATCH] D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.

sstefan1 updated this revision to Diff 249695. sstefan1 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75010/new/ https://reviews.llvm.org/D75010

[PATCH] D76015: [clang-tidy] Mock system headers for portability-restrict-system-includes tests.

PaulkaToast created this revision. PaulkaToast added reviewers: RKSimon, aaron.ballman. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Didn't realize that headers such as stddef.h may not exist on all systems. This

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

bcain added a comment. @kparzysz do you have any thoughts about those review comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75638/new/ https://reviews.llvm.org/D75638 ___ cfe-commits mailing l

[PATCH] D76015: [clang-tidy] Mock system headers for portability-restrict-system-includes tests.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76015/new/ https://reviews.llvm.org/D76015

RE: [PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

Sorry I don't understand. I have to add "final" onto BinaryOperator in order to use Trailing storage. But when I do that I can't derive CompoundAssignmentOperator from BinaryOperator. So I think I must fold these 2 classes together. Is there another way? > -Original Message- > From: Jo

[clang] 0197eac - Temporarily re-apply https://reviews.llvm.org/D74347

Author: Sergej Jaskiewicz Date: 2020-03-11T21:35:14+03:00 New Revision: 0197eac3330c04a49519f3e4dac38c4de605c654 URL: https://github.com/llvm/llvm-project/commit/0197eac3330c04a49519f3e4dac38c4de605c654 DIFF: https://github.com/llvm/llvm-project/commit/0197eac3330c04a49519f3e4dac38c4de605c654.d

[PATCH] D74813: [RFC] Add hash of block contents to function block names

manmanren added a comment. There are a few concerns about the approach: 1> Compile time: dumping AST as string then hashing the string. Alex measured it on a synthetic benchmark, it shows insignificant impact. 2> Stability: from my understanding, the main goal of this patch is to increase stabil

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:66-67 +const SourceManager &SM, Preprocessor *PP, Preprocessor *

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249708. oontvoo added a comment. Updated typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/HeaderSear

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

mwyman updated this revision to Diff 249709. mwyman marked 5 inline comments as done. mwyman added a comment. After some discussion, have decided to remove the fix-it entirely and update the diagnostic message; removing the method altogether may not be the correct behavior, as previously depreca

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249711. oontvoo added a comment. More typo correction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/He

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

mwyman marked 3 inline comments as done. mwyman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MethodUnavailableNotOverrideCheck.cpp:34 +// Matches Objective-C methods that are not overriding a superclass method. +AST_MATCHER(ObjCMethodDecl, isNotOverriding

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249712. oontvoo added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/HeaderSearch.cpp

[clang-tools-extra] f1736f7 - [clang-tidy] Mock system headers for portability-restrict-system-includes tests.

Author: Paula Toth Date: 2020-03-11T12:13:27-07:00 New Revision: f1736f7a2a660944c24aac45e24cdf1ea6c6effa URL: https://github.com/llvm/llvm-project/commit/f1736f7a2a660944c24aac45e24cdf1ea6c6effa DIFF: https://github.com/llvm/llvm-project/commit/f1736f7a2a660944c24aac45e24cdf1ea6c6effa.diff LO

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249717. oontvoo added a comment. Wrong name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/HeaderSearch

[PATCH] D76015: [clang-tidy] Mock system headers for portability-restrict-system-includes tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1736f7a2a66: [clang-tidy] Mock system headers for portability-restrict-system-includes tests. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 10b1a87 - [clang-format] Add option to specify explicit config file

Author: Mitchell Balan Date: 2020-03-11T15:56:44-04:00 New Revision: 10b1a87ba35d386b718f0e83c1d750631705b220 URL: https://github.com/llvm/llvm-project/commit/10b1a87ba35d386b718f0e83c1d750631705b220 DIFF: https://github.com/llvm/llvm-project/commit/10b1a87ba35d386b718f0e83c1d750631705b220.diff

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. Shiva, I see a warning always being printed: '+small-data-limit=' is not a recognized feature for this target (ignoring feature) This is because it is being passed down as a target feature. Might be good to add a test case to make sure the SmallDataLimit module flag is

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. your patch seems to be missing the other files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow added a comment. Revisiting this patch. I think that before fixing the `-ffp-contract=off` problem I originally raised here, there are two questions that have come up in this discussion that we should first resolve. Specifically: (1) Do we want to enable FMA transformations by defaul

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

This revision was automatically updated to reflect the committed changes. Closed by commit rG10b1a87ba35d: [clang-format] Add option to specify explicit config file Summary: This diff… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] c5c487f - Revert "[clang-format] Add option to specify explicit config file"

Author: Mitchell Balan Date: 2020-03-11T16:14:42-04:00 New Revision: c5c487f0d4c6720f4384f670490086e723f5fe32 URL: https://github.com/llvm/llvm-project/commit/c5c487f0d4c6720f4384f670490086e723f5fe32 DIFF: https://github.com/llvm/llvm-project/commit/c5c487f0d4c6720f4384f670490086e723f5fe32.diff

[clang] a0cacb6 - Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode

Author: Jin Lin Date: 2020-03-11T13:26:06-07:00 New Revision: a0cacb60549f2346f7addf9205cd32720afc8fb4 URL: https://github.com/llvm/llvm-project/commit/a0cacb60549f2346f7addf9205cd32720afc8fb4 DIFF: https://github.com/llvm/llvm-project/commit/a0cacb60549f2346f7addf9205cd32720afc8fb4.diff LOG:

[PATCH] D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4497 Value *CodeGenFunction::EmitNeonSplat(Value *V, Constant *C) { - unsigned nElts = V->getType()->getVectorNumElements(); - Value* SV = llvm::ConstantVector::getSplat(nElts, C); + auto EC = V->getT

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. In D75791#1917837 , @MyDeveloperDay wrote: > your patch seems to be missing the other files Which other files? I made a new commit and did the full context diff, now sure why it's only showing the documentation update.

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

mitchell-stellar reopened this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Reverted this commit due to an unexpected test failure: TEST 'Clang :: Format/dump-config-objc.h' FAILED Script: -- : 'RUN

[PATCH] D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0cacb60549f: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of… (authored by jinlin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] c915cb9 - Avoid including Module.h from ExternalASTSource.h

Author: Reid Kleckner Date: 2020-03-11T13:37:41-07:00 New Revision: c915cb957dc37275ce1ca1a0b993239c82f12692 URL: https://github.com/llvm/llvm-project/commit/c915cb957dc37275ce1ca1a0b993239c82f12692 DIFF: https://github.com/llvm/llvm-project/commit/c915cb957dc37275ce1ca1a0b993239c82f12692.diff

[clang] 0c06a38 - [CUDA,clang-cl] Filter out unsupported arguments for device-side compilation.

Author: Artem Belevich Date: 2020-03-11T13:42:16-07:00 New Revision: 0c06a389e5937895579effd5e608c79bc6332e53 URL: https://github.com/llvm/llvm-project/commit/0c06a389e5937895579effd5e608c79bc6332e53 DIFF: https://github.com/llvm/llvm-project/commit/0c06a389e5937895579effd5e608c79bc6332e53.diff

[clang] 526a4f2 - Fix formatting after Module.h include adjustment, NFC

Author: Reid Kleckner Date: 2020-03-11T13:52:47-07:00 New Revision: 526a4f2ac365a5babbc80e0f7c17be310728a538 URL: https://github.com/llvm/llvm-project/commit/526a4f2ac365a5babbc80e0f7c17be310728a538 DIFF: https://github.com/llvm/llvm-project/commit/526a4f2ac365a5babbc80e0f7c17be310728a538.diff

[clang] e08464f - Avoid including FileManager.h from SourceManager.h

Author: Reid Kleckner Date: 2020-03-11T13:53:12-07:00 New Revision: e08464fb450456881733c885267b32dc7339cf11 URL: https://github.com/llvm/llvm-project/commit/e08464fb450456881733c885267b32dc7339cf11 DIFF: https://github.com/llvm/llvm-project/commit/e08464fb450456881733c885267b32dc7339cf11.diff

[PATCH] D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75998/new/ https://reviews.llvm.org/D75998 _

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk added a comment. Thanks! In D75784#1917181 , @aprantl wrote: > To avoid bot breakage, I would recommend testing -DLLVM_ENABLE_MODULES=1 > stage2 build works before landing this, as it is notoriously sensitive to > header reshuffling. Good idea, I

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

This revision was automatically updated to reflect the committed changes. rnk marked an inline comment as done. Closed by commit rGc915cb957dc3: Avoid including Module.h from ExternalASTSource.h (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D75310: [CUDA, clang-cl] Filter out unsupported arguments for device-side compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c06a389e593: [CUDA,clang-cl] Filter out unsupported arguments for device-side compilation. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGe08464fb4504: Avoid including FileManager.h from SourceManager.h (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D75406?vs=247479&id=249752#toc Repository: rG LLVM Github Monorep

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:937 +case AQ_goto: return "goto"; +case AQ_unspecified:; + } aaron.ballman wrote: > This looks wrong to me -- it flows through to an unreachable despite being > reachabl

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 249757. nickdesaulniers added a comment. - remove isUnspecified(), was partially committed from refactoring I changed my mind on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 249754. nickdesaulniers marked 8 inline comments as done. nickdesaulniers added a comment. - address latest review comments, more refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ htt

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 249760. nickdesaulniers added a comment. - drop `auto` as type is no longer implicit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 Files: clang/docs/Release

[clang] 828fe79 - Revert "Temporarily re-apply https://reviews.llvm.org/D74347"

Author: Vladimir Vereschaka Date: 2020-03-11T15:00:56-07:00 New Revision: 828fe7916f91fb7aed5e711bfeb1a30ad197a2c3 URL: https://github.com/llvm/llvm-project/commit/828fe7916f91fb7aed5e711bfeb1a30ad197a2c3 DIFF: https://github.com/llvm/llvm-project/commit/828fe7916f91fb7aed5e711bfeb1a30ad197a2c3

[PATCH] D76029: Summary: Fix DanglingHandleCheck to match conversion operator whose return type is a type alias, e.g. `std::string`'s conversion operator to `std::string_view`.

zhangxy988 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zhangxy988 added a reviewer: alexfh. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76029 Files: clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.cpp clang-tools

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/5]

sconstab updated this revision to Diff 249763. sconstab added a comment. Added help text for driver CLI options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75934/new/ https://reviews.llvm.org/D75934 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Arch/X8

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/5]

sconstab updated this revision to Diff 249765. sconstab added a comment. Added help text for the CLI options CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Arch/X86.cp

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

tra added a comment. This patch should fix it: https://reviews.llvm.org/D76030 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73231/new/ https://reviews.llvm.org/D73231 ___ cfe-commits mailing list cfe-

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

tra created this revision. tra added a reviewer: yaxunl. Herald added subscribers: sanjoy.google, bixia. Herald added a project: clang. tra updated this revision to Diff 249773. tra retitled this revision from "[CUDA] Warn about unsupported CUDA SDK version only if it's used. " to "[CUDA] Warn

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

tra updated this revision to Diff 249773. tra retitled this revision from "[CUDA] Warn about unsupported CUDA SDK version only if it's used. " to "[CUDA] Warn about unsupported CUDA SDK version only if it's used.". tra added a comment. Added a test. Repository: rG LLVM Github Monorepo C

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I've already stated my disapproval of this patch. Libc++ has never and will never provide nor value C++03 conformance. Moving backwards to C++03 is inconsistent with the libraries gen

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

EricWF added a comment. I'll be picking this up seriously this week. I'm currently getting an internal version of this clang-tidy reviewed, and my plan was to submit it upstream after because I didn't see this patch until now (bad email filters). I think we can unify the two checks, Thanks for w

[PATCH] D76032: [HIP] Fix duplicate clang -cc1 options on MSVC toolchain

yaxunl created this revision. yaxunl added a reviewer: tra. HIPToolChain::TranslateArgs call TranslateArgs of host toolchain with the input args to get a list of derived args called DAL, then go through the input args by itself and append them to DAL. This assumes that the host toolchain should

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb updated this revision to Diff 249779. broadwaylamb added a comment. Add one more libc++abi header search path when building libc++ @vvereschaka this is supposed to fix the buildbot failure. It's more of a sweep under the rug type of fix. The real problem is that the value of the `C

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76030/new/ https://reviews.llvm.org/D76030 __

[clang] 213aea4 - Remove unused Endian.h includes, NFC

Author: Reid Kleckner Date: 2020-03-11T15:45:34-07:00 New Revision: 213aea4c5836934771eb97eb97e4c964053a8596 URL: https://github.com/llvm/llvm-project/commit/213aea4c5836934771eb97eb97e4c964053a8596 DIFF: https://github.com/llvm/llvm-project/commit/213aea4c5836934771eb97eb97e4c964053a8596.diff

[clang] 2b366e7 - Make Decl::setOwningModuleID() public. (NFC)

Author: Adrian Prantl Date: 2020-03-11T15:50:03-07:00 New Revision: 2b366e75d41341e7cb2e763b20c4fc8fd3bd4b3c URL: https://github.com/llvm/llvm-project/commit/2b366e75d41341e7cb2e763b20c4fc8fd3bd4b3c DIFF: https://github.com/llvm/llvm-project/commit/2b366e75d41341e7cb2e763b20c4fc8fd3bd4b3c.diff

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. - This check should suggest fixes. It knows what function is actually being resolved, and it has enough information to create a minimally qualified name that resolves it. - This ch

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added a comment. In D73245#1918148 , @EricWF wrote: > I've already stated my disapproval of this patch. Libc++ has never and will > never provide nor value C++03 conformance. > Moving backwards to C++03 is inconsistent with the libraries general

[PATCH] D75560: Make Decl:: setOwningModuleID() public. (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b366e75d413: Make Decl::setOwningModuleID() public. (NFC) (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a comment. Can we change the element type of the vector to `_Float16`? `typedef __attribute__((neon_vector_type(4))) _Float16 float16x4_t;` It seems that the original plan discussed on llvm-dev (http://lists.llvm.org/pipermail/cfe-dev/2017-May/053768.html) was to introduce `_Flo

[clang] 8527c1e - Added constraints on cl-options.cu test

Author: Artem Belevich Date: 2020-03-11T16:06:09-07:00 New Revision: 8527c1ed66c63db0590cd69320ba0bf8fad59b87 URL: https://github.com/llvm/llvm-project/commit/8527c1ed66c63db0590cd69320ba0bf8fad59b87 DIFF: https://github.com/llvm/llvm-project/commit/8527c1ed66c63db0590cd69320ba0bf8fad59b87.diff

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

tra updated this revision to Diff 249792. tra added a comment. clang-formatted the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76030/new/ https://reviews.llvm.org/D76030 Files: clang/lib/Driver/ToolChains/Cuda.cpp clang/lib/Driver/T

[PATCH] D76032: [HIP] Fix duplicate clang -cc1 options on MSVC toolchain

tra added a reviewer: rnk. tra added a comment. LGTM, but I'm not familiar with the details of clang-cl. I've added Reid who'd have a better idea. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76032/new/ https://reviews.llvm.org/D76032 ___

[clang-tools-extra] d6497a5 - Add missing StringMap.h inclusion, apparently clangd is not covered by check-clang-tools zzz

Author: Reid Kleckner Date: 2020-03-11T16:47:49-07:00 New Revision: d6497a521bbd4024ed39a384b44af5f4f4a81e05 URL: https://github.com/llvm/llvm-project/commit/d6497a521bbd4024ed39a384b44af5f4f4a81e05 DIFF: https://github.com/llvm/llvm-project/commit/d6497a521bbd4024ed39a384b44af5f4f4a81e05.diff

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 249802. PaulkaToast added a comment. Mocked the header files so that we don't experience failures due to differences in systems. Mind taking a quick look @aaron.ballman? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Quuxplusone added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.h:27 +class UnintendedADLCheck : public ClangTidyCheck { + const bool IgnoreOverloadedOperators; + const std::vector AllowedIdentifiers; EricWF wrote: > I th

[PATCH] D75570: [AST][SVE] Add new Type queries for sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75570/new/ https://reviews.llvm.org/D75570 ___

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. Shiva, I am not sure how the SDataLimit is being honored in LTO mode. Where does getModuleMetadata get called? If the SelectSectionForGlobal api is called without getModuleMetadata being called first, it will use the default 8 instead of honoring the SDataLimit. Reposit

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

efriedma added a comment. Changing the way we expose the builtins isn't going to affect most of the code related to the SVE intrinsics. I'm fine sticking with a known working approach, and trying to address that issue later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75298/new/ ht

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, AlexanderLanin. Herald added a project: clang. Herald added a subscriber: cfe-commits. Escapes replacement text when exporting to yaml and unescapes when importing from yaml. Repository: rG LLVM Github Monore

[clang] 560aa53 - [X86] Support intrinsics _bextr2*

Author: Shengchen Kan Date: 2020-03-12T09:26:51+08:00 New Revision: 560aa53f8fe58abcbc4bb441b631e8a401ee78fe URL: https://github.com/llvm/llvm-project/commit/560aa53f8fe58abcbc4bb441b631e8a401ee78fe DIFF: https://github.com/llvm/llvm-project/commit/560aa53f8fe58abcbc4bb441b631e8a401ee78fe.diff

[PATCH] D75690: [SVE][Inline-Asm] Add constraints for SVE ACLE types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75690/new/ https://reviews.llvm.org/D75690 ___ cfe-commits mailing list cfe-commi

[PATCH] D75894: [X86] Support intrinsics _bextr2*

This revision was automatically updated to reflect the committed changes. Closed by commit rG560aa53f8fe5: [X86] Support intrinsics _bextr2* (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75894/new/ https://reviews.llvm.org/D75894

[PATCH] D75896: [X86] Support intrinsic _mm_cldemote

This revision was automatically updated to reflect the committed changes. Closed by commit rGab69cd0779c5: [X86] Support intrinsic _mm_cldemote (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75896/new/ https://reviews.llvm.org/D75

[clang] ab69cd0 - [X86] Support intrinsic _mm_cldemote

Author: Shengchen Kan Date: 2020-03-12T10:03:41+08:00 New Revision: ab69cd0779c529519eb7d26e0fa1b8dfb505f838 URL: https://github.com/llvm/llvm-project/commit/ab69cd0779c529519eb7d26e0fa1b8dfb505f838 DIFF: https://github.com/llvm/llvm-project/commit/ab69cd0779c529519eb7d26e0fa1b8dfb505f838.diff

[PATCH] D75571: [Sema][SVE] Add tests for valid and invalid type usage

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75571/new/ https://reviews.llvm.org/D75571 ___

[PATCH] D75738: [Sema][SVE] Reject by-copy capture of sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75738/new/ https://reviews.llvm.org/D75738 ___

[PATCH] D75734: [Sema][SVE] Reject atomic sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75734/new/ https://reviews.llvm.org/D75734 ___

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 marked 2 inline comments as done. logan-5 added a comment. Thanks for the feedback. In D72282#1918253 , @EricWF wrote: > - This check should suggest fixes. It knows what function is actually being > resolved, and it has enough information to crea

<    1   2   3   >