EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed.
I've already stated my disapproval of this patch. Libc++ has never and will never provide nor value C++03 conformance. Moving backwards to C++03 is inconsistent with the libraries general direction. This patch disables tests, which could hide bugs, including serious ABI differences between dialects. I would like to unbreak compilation on NetBSD. But all that's needed there is to provide our own correct declaration of max_align_t. I don't see why C++03 conformance is a necessary condition. If you would still like to proceed in this direction. Please remove me as a reviewer. ================ Comment at: libcxx/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp:156 +#if TEST_STD_VER >= 11 #if defined(NO_SIZE) && defined(NO_ALIGN) ---------------- It's important these tests continue to pass in C++03. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
