[PATCH] D75723: [X86] Enable intrinsics _BitScan*

craig.topper added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:421 +if (__c != 0) { \ + *(a) = (unsigned)__bsfd(__c); \ + __d = 1;

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis added a comment. I'm done, Aaron, Quuxplusone, do you have any comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

Re: [clang-tools-extra] 54928ba - [clang-tidy] Use more widely available headers for protability-restrict-system-includes-check's test

On Wed, Mar 11, 2020 at 2:54 AM Paula Toth via cfe-commits wrote: > > > Author: Paula Toth > Date: 2020-03-10T16:54:11-07:00 > New Revision: 54928ba0ec8355edbbdb31c7b01bb45eb2d384b6 > > URL: > https://github.com/llvm/llvm-project/commit/54928ba0ec8355edbbdb31c7b01bb45eb2d384b6 > DIFF: > https://

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan marked an inline comment as done. skan added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:421 +if (__c != 0) { \ + *(a) = (unsigned)__bsfd(__c); \

[PATCH] D75922: [ASTImporter] Compare the DC of the underlying type of a FriendDecl

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3679 +if (FromFriendDC) { // The underlying friend type is not dependent. + ExpectedDecl FriendDCDeclOrErr = import(cast(*FromFriendDC)); + if (!FriendDCDeclOrErr) Computing `

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM For the record `check-clang-tools` is sufficient for testing all clang tidy checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75901/new/ https://reviews.llvm.org/D75901

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske marked 2 inline comments as done. balazske added a comment. I do not understand totally this remove-of-AnyError thing. If handling the `AnyError` will be removed the code remains still not testable. Because none of the possible failing file operations are modeled in this revision. A tes

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 249570. atmnpatel added a comment. Modified the unit test for CodeGen of default(firstprivate) to more accurately reflect the IR. >From the perspective of the AST, the variables that are firstprivate from a >default clause are managed in a way that is sim

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ cfe

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 249574. tbaeder added a comment. Updated according to Aaron's comments. I'm not sure about changing the `DeclSpec` member and moving `ParsedAttributesWithRange` to ParsedAttr.h. Tests included. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/ne

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1916291 , @djtodoro wrote: > In D73534#1915048 , @mstorsjo wrote: > > > This broke compiling for mingw, repro.c: > > > > a(short); > > b() { a(1); } > > > > > > `clang -target

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1915048 , @mstorsjo wrote: > This broke compiling for mingw, repro.c: > > a(short); > b() { a(1); } > > > `clang -target x86_64-w64-mingw32 -c repro.c -g -O2`, which gives `Assertion > '!MI.isMoveImmediate() && "Une

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:33-45 + enum KindTy { +Opened, /// Stream is opened. +Closed, /// Closed stream (an invalid stream pointer after it was closed). +OpenFailed /// The last open operation h

[PATCH] D65994: Extended FPOptions with new attributes

sammccall added a comment. This patch increased the used size of BinaryOperator by 5 bits. Those bits were all padding, but now BinaryOperatorBitfields is completely full at 32 bits and we can't add any new bits to Stmt without increasing BinaryOperator by 8 bytes. (See D75443

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. With the nit addressed, this LGTM Comment at: clang/utils/TableGen/SveEmitter.cpp:634 " *\n" " * Permission is hereby granted, free of charge, t

[PATCH] D75922: [ASTImporter] Compare the DC of the underlying type of a FriendDecl

martong added a comment. In D75922#1915918 , @shafik wrote: > I believe that your main example violates basic.scope.class p2 > : > > > A name N used in a class S shall refer to the same declaration in its > > c

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

balazske added a comment. Probably we need to clarify when to make warnings. Originally I do not wanted a warning after for example failed read, because it is possible to retry the operation. But the standard says that after failed fread the file position is indeterminate, so a new read may get

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ cfe-commits mailing list cfe-commi

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

sammccall added a comment. Herald added a reviewer: jdoerfert. So if I understand the history here: - the `IsOMPStructuredBlock` bit on `Stmt` was added to implement `getStructuredBlock()` - after review, `getStructuredBlock()` doesn't use the bit - the bit is used in the textual AST dump, and a

Re: [PATCH] D65994: Extended FPOptions with new attributes

It is a matter of taste, but for me it looks strange to develop complex and error-prone system to save 7 bits at expense of readability and maintainability. My observations show that clang AST consumes much less memory than llvm objects. FPOption could be shared between user using something like s

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

RKSimon added a comment. @PaulkaToast This patch appears to have caused a buildbot issue, please can you investigate/revert: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/63869 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from minor nits, this seems reasonable to me, LG! Comment at: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:16 #include "llvm/ADT/StringR

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:33-45 + enum KindTy { +Opened, /// Stream is opened. +Closed, /// Closed stream (an invalid stream pointer after it was closed). +OpenFailed /// The last open op

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added a comment. In D75917#1916160 , @sameerds wrote: > how this builtin fits in with the overall scheme of language-specific and > target-specific details of an atomic operation. For example, is this meant > only for OpenCL? Does it work

[PATCH] D75983: [clang-format] Improved identification of C# nullables

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow '?' inside C# generics. Do not mistake casts like (Type?) as conditional operators. Repository: rG LLVM Gith

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:382-384 + C.addTransition(StateNotFailed); + C.addTransition(StateFailedWithFError); + C.addTransition(StateFailedWithoutFError); Szelethus wrote: > balaz

[PATCH] D75985: clangd doc: Show a test case for clangd with some commands

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sylvestre.ledru updated this revision to Diff 249595. sylvestre.ledru added a co

[PATCH] D75983: [clang-format] Improved identification of C# nullables

krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1016 if (Style.isCSharp()) { -// `Type? name;` and `Type? name =` can only be nullable types. +// `Type?)`, `Type?>`, `Type? name;`and `Type? name =` can only be +// nul

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:33-45 + enum KindTy { +Opened, /// Stream is opened. +Closed, /// Closed stream (an invalid stream pointer after it was closed). +OpenFailed /// The last open operation h

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:394 +StreamSym, StreamState::getOpenedWithOtherError()); +C.addTransition(StateEof); +C.addTransition(StateOther); --

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

aaron.ballman added a comment. In D75786#1916637 , @RKSimon wrote: > @PaulkaToast This patch appears to have caused a buildbot issue, please can > you investigate/revert: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/buil

[PATCH] D75985: clangd doc: Show a test case for clangd with some commands

sylvestre.ledru updated this revision to Diff 249595. sylvestre.ledru added a comment. Add a link to the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75985/new/ https://reviews.llvm.org/D75985 Files: clang-tools-extra/docs/clangd/SimpleExam

[PATCH] D75984: [clang-format] No space in 'new()' and 'this[Type x]' in C#

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75984 Files: clang/lib/Format/TokenAnnotator.cpp clang/un

[clang] 5c917bd - [clang-format] No space in `new()` and `this[Type x]` in C#

Author: Jonathan Coe Date: 2020-03-11T12:53:53Z New Revision: 5c917bd9a7de8fc45401da00cd27661b429887e9 URL: https://github.com/llvm/llvm-project/commit/5c917bd9a7de8fc45401da00cd27661b429887e9 DIFF: https://github.com/llvm/llvm-project/commit/5c917bd9a7de8fc45401da00cd27661b429887e9.diff LOG:

Re: [PATCH] D65994: Extended FPOptions with new attributes

On Wed, Mar 11, 2020 at 12:42 PM Serge Pavlov wrote: > It is a matter of taste, but for me it looks strange to develop complex > and error-prone system to save 7 bits at expense of readability and > maintainability. My observations show that clang AST consumes much less > memory than llvm objects

[clang] 1fb9c29 - [clang-format] Improved identification of C# nullables

Author: Jonathan Coe Date: 2020-03-11T12:58:52Z New Revision: 1fb9c29833ab88c4a3d6fda997839754d998 URL: https://github.com/llvm/llvm-project/commit/1fb9c29833ab88c4a3d6fda997839754d998 DIFF: https://github.com/llvm/llvm-project/commit/1fb9c29833ab88c4a3d6fda997839754d998.diff LOG:

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:43 +EofError, /// EOF condition (`feof` is true). +OtherError, /// Other (non-EOF) error (`ferror` is true). +AnyError/// EofError or OtherError, used if ex

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

baloghadamsoftware added inline comments. Comment at: clang/test/Analysis/stream.c:188 +C = fgetc(fp); +fread(0, 0, 0, fp); // expected-warning {{Should call}} +fread(0, 0, 0, fp); Szelethus wrote: > balazske wrote: > > Szelethus wrote: > > > Are we s

[PATCH] D75984: [clang-format] No space in `new()` and `this[Type x]` in C#

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75984/new/ https://reviews.llvm.org/D75984 _

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

mibintc added a comment. I'm working on a patch that will move FPOptions to Trailing storage, part of https://reviews.llvm.org/D72841 ; hope to have another revision uploaded today or tomorrow. I got feedback that moving the field to BinaryOperator isn't adequate. Repository: rG LLVM Githu

[PATCH] D75983: [clang-format] Improved identification of C# nullables

jbcoe updated this revision to Diff 249596. jbcoe added a comment. Fix nits from review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75983/new/ https://reviews.llvm.org/D75983 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTestCSharp.cpp Index: clang/un

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

sammccall added a comment. As discussed offline... this undoes a desirable optimization from D54526 . A couple of possible ways to avoid this: - FPOptions integer encoding can fit into 7 bits: combine integer behavior + exception behavior into 3 x 5 = 15 states

[PATCH] D75983: [clang-format] Improved identification of C# nullables

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75983/new/ https://reviews.llvm.org/D75983 ___ cfe-commits mailing list cfe

[PATCH] D75983: [clang-format] Improved identification of C# nullables

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fb9c29833ab: [clang-format] Improved identification of C# nullables (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D75984: [clang-format] No space in `new()` and `this[Type x]` in C#

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c917bd9a7de: [clang-format] No space in `new()` and `this[Type x]` in C# (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

hokein updated this revision to Diff 249606. hokein added a comment. reduce FPOption from 8 bits to 7 bits, based on the offline discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75443/new/ https://reviews.llvm.org/D75443 Files: clang/in

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

hokein updated this revision to Diff 249607. hokein added a comment. update a missing CXXOperatorCallExprBitfields, and fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75443/new/ https://reviews.llvm.org/D75443 Files: clang/include/clan

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske added a comment. What is better? Have this (or similar) change that adds a feature that is used in a later change and is only testable in that later change, or have a bigger change that contains real use of the added features? (This means: Add `fseek` to this change or not.) The error

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

sammccall added a comment. In D75443#1916761 , @mibintc wrote: > I'm working on a patch that will move FPOptions to Trailing storage, part of > https://reviews.llvm.org/D72841 ; hope to have another revision uploaded > today or tomorrow. I got feedback

[clang] edbf2fd - [analyzer] Fix a strange compile error on a certain Clang-7.0.0

Author: Artem Dergachev Date: 2020-03-11T16:54:34+03:00 New Revision: edbf2fde14a2b50e64ea20a011b2a3242c75b4d9 URL: https://github.com/llvm/llvm-project/commit/edbf2fde14a2b50e64ea20a011b2a3242c75b4d9 DIFF: https://github.com/llvm/llvm-project/commit/edbf2fde14a2b50e64ea20a011b2a3242c75b4d9.dif

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske marked 4 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:33-45 + enum KindTy { +Opened, /// Stream is opened. +Closed, /// Closed stream (an invalid stream pointer after it was closed). +

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

hokein updated this revision to Diff 249613. hokein marked 4 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75443/new/ https://reviews.llvm.org/D75443 Files: clang/include/clang/A

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

hokein added a comment. In D75443#1916829 , @sammccall wrote: > In D75443#1916761 , @mibintc wrote: > > > I'm working on a patch that will move FPOptions to Trailing storage, part > > of https://reviews.llvm.org/D7

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

baloghadamsoftware added a comment. In D75682#1916809 , @balazske wrote: > What is better? Have this (or similar) change that adds a feature that is > used in a later change and is only testable in that later change, or have a > bigger change that contai

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

daltenty added a comment. On AIX and PPC LE Linux after this change we are seeing invalid accesses when the backend asserts/fatal_errors. Looks like the driver and CC1 now share some global TimerGroup state that points to Timers which got created by CC1 but didn't get cleanup after the assert.

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 249616. tnorth added a comment. Rebased on master (6d5603e2 ). Some refactoring was indeed needed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

mibintc added a comment. well, it would probably be quickest to separate the trailing storage into a separate patch. i'll try to get that submitted today. shall i submit that as a phabricator review or is there a different, preferred way to do that? Repository: rG LLVM Github Monorepo CHA

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

sammccall added a comment. In D75443#1916909 , @mibintc wrote: > well, it would probably be quickest to separate the trailing storage into a > separate patch. i'll try to get that submitted today. shall i submit that > as a phabricator review or is the

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

sammccall added a subscriber: sepavloff. sammccall added a comment. this looks reasonable to me, would like to give @mibintc and also @sepavloff a chance to chime in. Comment at: clang/include/clang/Basic/LangOptions.h:437 + LangOptions::FPExc

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

hokein added a comment. In D75443#1916909 , @mibintc wrote: > well, it would probably be quickest to separate the trailing storage into a > separate patch. i'll try to get that submitted today. shall i submit that > as a phabricator review or is there

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske added a comment. And why not add first the "unknown error" state and later the feof and ferror error states? Or add every error state but not the `feof` and `ferror` functions? Every way results in an intermediate state of the checker. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hubert.reinterpretcast added a comment. In D69825#1916865 , @daltenty wrote: > On AIX and PPC LE Linux after this change we are seeing invalid accesses when > the backend asserts/fatal_errors. Looks like the driver and CC1 now share > some global TimerGr

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added a comment. Also, thank you guys for chipping in! Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:394 +StreamSym, StreamState::getOpenedWithOtherError()); +C.addTransition(StateEof); +C.addTransition(StateOther); b

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added a comment. I see that we're a bit stuck on naming, and that is largely my fault. Apologies, let us focus on high level stuff for a bit. In D75682#1916435 , @balazske wrote: > I do not understand totally this remove-of-AnyError thing. If h

Re: [PATCH] D65994: Extended FPOptions with new attributes

> >In this environment, 5 bits are quite a lot for FP flexibility, and I > think the complexity of reducing this is small and isolated (rounding + > exceptions together fit in 4 bits) Rounding (5 standard variants) and exception (3 variants) already do not fit 4 bits. And there is also precis

[clang-tools-extra] d83ade4 - [clangd] Improve the "max limit" error message in rename, NFC.

Author: Haojian Wu Date: 2020-03-11T16:13:46+01:00 New Revision: d83ade4506089329217918439042b68093e8d6e4 URL: https://github.com/llvm/llvm-project/commit/d83ade4506089329217918439042b68093e8d6e4 DIFF: https://github.com/llvm/llvm-project/commit/d83ade4506089329217918439042b68093e8d6e4.diff LO

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds added a comment. In D75917#1916664 , @JonChesterfield wrote: > In D75917#1916160 , @sameerds wrote: > > > how this builtin fits in with the overall scheme of language-specific and > > target-specific deta

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:33-45 + enum KindTy { +Opened, /// Stream is opened. +Closed, /// Closed stream (an invalid stream pointer after it was closed). +OpenFailed /// The last open op

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:151 + + using ValueConstraintPtr = std::shared_ptr; + /// The complete list of constraints that defines a single branch. martong wrote: > Szelethus wro

[PATCH] D75995: [clangd] Decouple preamble and mainfile builds, NFCI

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. First step to enable deferred preamble builds. Not intending to land it alone, will h

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:382-384 + C.addTransition(StateNotFailed); + C.addTransition(StateFailedWithFError); + C.addTransition(StateFailedWithoutFError);

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:461 + constexpr static unsigned MaxExceptionValue = 3; + unsigned rounding_and_exceptions: 4; }; There are 5 rounding directions defined by IEEE-754, which we should eventuall

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

Szelethus added a comment. Just littering some more inlines, don't mind me :) Lets still wait on the dependency patch before updating. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:296 +def StdCLibraryFunctionArgsChecker : Checker<"StdCLibraryFunctionArgs

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:175 +using ValueConstraint::ValueConstraint; +bool CannotBeNull = true; + What does this do? Is it ever used in the patch? Repository: rG LLV

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

baloghadamsoftware added a comment. I do not say I fully grab every single character, but basically it looks good to me. @NoQ, please take a look on this, you are more competent in finding issues with it. This patch is needed to my patch preventing registration of checkers that depend on an ana

Re: [PATCH] D65994: Extended FPOptions with new attributes

On Wed, Mar 11, 2020 at 4:09 PM Serge Pavlov wrote: >In this environment, 5 bits are quite a lot for FP flexibility, and I >> think the complexity of reducing this is small and isolated (rounding + >> exceptions together fit in 4 bits) > > > Rounding (5 standard variants) and exception (3 var

[PATCH] D75996: [clangd] Populate PreambleData::CompileCommand and make use of it inside buildPreamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75995: [clangd] Decouple preamble and mainfile builds,

[PATCH] D75997: [ARM,MVE] Fix user-namespace violation in arm_mve.h.

simon_tatham created this revision. simon_tatham added reviewers: miyuki, MarkMurrayARM, ostannard. Herald added subscribers: cfe-commits, danielkiss, dmgreen, kristof.beyls. Herald added a project: clang. We were generating the declarations of polymorphic intrinsics using `__attribute__((overload

[PATCH] D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. simon_tatham updated this revision to Diff 249641. simon_tatha

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske updated this revision to Diff 249642. balazske added a comment. - Removed AnyError. - Using common code for `evalFeof` and ferror. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 Files: clang/lib

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D72874#1915840 , @nridge wrote: > I've started to update the patch to be in line with the direction discussed > in the issue. > > @sammccall,

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske updated this revision to Diff 249643. balazske added a comment. Adding correct diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp c

[PATCH] D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add.

simon_tatham updated this revision to Diff 249641. simon_tatham added a comment. Update test results following a last-minute correctness fix. (I updated one of the two test files but not the other.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D759

[PATCH] D75985: clangd doc: Show a test case for clangd with some commands

sammccall added a comment. Thanks Sylvestre! We're actually in the process of moving docs to a new site (preview: https://clangd.github.io - once set up it will be at clangd.llvm.org). Who do you think is the audience/purpose for this doc? End-users don't need to understand this to use clangd

[PATCH] D76001: [AST] Respect shouldTraversePostOrder when traversing type locs

hlopko created this revision. hlopko added a reviewer: gribozavr2. hlopko added a project: clang. Herald added a subscriber: cfe-commits. Copy of https://reviews.llvm.org/D72072, submitting with ilya-biryukov's permission. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76001

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

rjmccall added a comment. If the bit is unused except for propagation, please remove it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59214/new/ https://reviews.llvm.org/D59214 ___ cfe-commits mailing list cfe-commit

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added a comment. In D59214#1916596 , @sammccall wrote: > So if I understand the history here: > > - the `IsOMPStructuredBlock` bit on `Stmt` was added to implement > `getStructuredBlock()` > - after review, `getStructuredBlock()` doesn't use th

[PATCH] D75985: clangd doc: Show a test case for clangd with some commands

sylvestre.ledru updated this revision to Diff 249653. sylvestre.ledru added a comment. fix some typo + desc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75985/new/ https://reviews.llvm.org/D75985 Files: clang-tools-extra/docs/clangd/SimpleExamp

[PATCH] D75985: clangd doc: Show a test case for clangd with some commands

sylvestre.ledru added a comment. Good question :) I have been wearing two hats here. With my Debian/Ubuntu hat, i have been interested to write some dumb integration tests to be sure that clangd, as a package, works as expected. I just need to make sure that the binary starts, that I can send s

[PATCH] D75997: [ARM,MVE] Fix user-namespace violation in arm_mve.h.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75997/new/ https://reviews.llvm.org/D75997 ___

[PATCH] D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS

pratlucas added a comment. I believe rule B.2 from the AAPCS64 should take precedence over rule B.5 for HFA arguments: B.2 If the argument type is an HFA or an HVA, then the argument is used unmodified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

aprantl added a comment. To avoid bot breakage, I would recommend testing -DLLVM_ENABLE_MODULES=1 stage2 build works before landing this, as it is notoriously sensitive to header reshuffling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75784/new

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added a comment. Could you please add the warning we discussed? That would be a great demonstration of this patch's capabilities, and wouldn't deserve its own patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://review

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:217 +mgr.template registerChecker(); } baloghadamsoftware wrote: > Why do we need `MGR` here as templat

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

Szelethus added a comment. So, as far as I understand, your thinking here is that `CXXOperatorCallExpr`s (which are global, non-member operators) when they are `>>`, they will propagate taintedness from the 0th argument to the 1st and the return value, correct? So, if I do this: struct Panda

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

rjmccall added a comment. In D59214#1917149 , @lebedev.ri wrote: > In D59214#1916596 , @sammccall wrote: > > > So if I understand the history here: > > > > - the `IsOMPStructuredBlock` bit on `Stmt` was added to imp

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast added a comment. In D75786#1916714 , @aaron.ballman wrote: > In D75786#1916637 , @RKSimon wrote: > > > @PaulkaToast This patch appears to have caused a buildbot issue, please can > > you investigate/re

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:51 + // the latest version we support. + D.Diag(diag::warn_drv_unknown_cuda_version) + << MajorMinor << CudaVersionToString(CudaVersion::LATEST); We got some issue with this war

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:102 + /// Given a range, should the argument stay inside or outside this range? + enum RangeKind { OutOfRange, WithinRange }; I would move t

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added a comment. Looking at the issue now, it should be a straightforward fix. Will send a patch ASAP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 _

  1   2   3   >