[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

simon_tatham added a subscriber: sdesmalen. simon_tatham added a comment. > Renames the 'clang_arm_mve_alias' attribute into 'clang_arm_builtin_alias' > (it will be used with CDE intrinsics as well as MVE intrinsics) You might talk to @sdesmalen, who mentioned introducing an `arm_sve_alias` att

[PATCH] D75856: [clang-format] cleanup from D75517

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix typo in comment. Add closing brace to test text. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75856

[PATCH] D75858: [AArch64][SVE] Add SVE intrinsics for address calculations

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, andwar, efriedma, dancgr, cameron.mcinally. Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the @llvm.aarch6

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tra added a comment. I'm not sure that's the problem worth solving. Magically changing compiler target based on something external to compiler is a bad idea IMO. I would expect a compilation with exactly the same compiler options to do exactly the same thing. If we magically change default targ

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdeeb548bbeb: [ARM,CDE] Implement CDE feature test macros (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75843/new/ https://reviews.llv

[PATCH] D75523: [www] cxx_status: Update title to mention C++20

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75523/new/ https://reviews.llvm.org/D75523

[PATCH] D75524: [www] cxx_status: Update Reflection TS to Cologne draft

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75524/new/ https://reviews.llvm.org/D75524

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki updated this revision to Diff 249140. miyuki added a comment. Fix linter and formatter warnings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new/ https://reviews.llvm.org/D75850 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/inc

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

jstenglein added a comment. In D75768#1912519 , @erichkeane wrote: > I did a bit of research and I don't think i know of anything better than > 'most' here, and noone else had an opinion at the end of last week so I'll > take that silence as consent. Ap

[PATCH] D75806: [CUDA] Add CUDA 10.2 detection

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. This looks like an elaborate way to achieve the effect of `-Wno-unknown_cuda_version`. :-) Similar change has been discussed recently. See https://reviews.llvm.org/D74571#1875340 which de

[PATCH] D75731: [clang-format] C# does not indent braced initializers as continuations

krasimir requested changes to this revision. krasimir added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:544 Shape[] shapes = new[] { new Circle { Radius = 2.7281, Colour = Colours.Red }, -

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, miyuki, efriedma, simon_tatham. Herald added subscribers: cfe-commits, danielkiss, dmgreen, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. The SVE ACLE allows usi

[PATCH] D75731: [clang-format] C# does not indent braced initializers as continuations

krasimir added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:544 Shape[] shapes = new[] { new Circle { Radius = 2.7281, Colour = Colours.Red }, - new Square { - Side = 101.1, -

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. Looks good! I'll stamp this after https://reviews.llvm.org/D75731 gets merged and this rebased on top of it. Comment at: clang/lib/Format/ContinuationIndenter.

[PATCH] D75856: [clang-format] cleanup from D75517

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75856/new/ https://reviews.llvm.org/D75856 ___ cfe-commits mailing list cfe

[PATCH] D75856: [clang-format] cleanup from D75517

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. The new pre-merge checks are cool! Please clang-format the updated lines accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75856/new/ https://reviews.llvm.org/

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

miyuki added a comment. In D75470#1910071 , @sdesmalen wrote: > The SVE implementation now does more or less the same thing the MVE > implementation; `arm_sve.h` also uses `__attribute__((overloadable))` and > `__attribute__((arm_sve_alias("__builtin_...

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

sdesmalen added a comment. In D75850#1912685 , @simon_tatham wrote: > > Renames the 'clang_arm_mve_alias' attribute into 'clang_arm_builtin_alias' > > (it will be used with CDE intrinsics as well as MVE intrinsics) > > You might talk to @sdesmalen, who m

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers added a comment. Herald added a subscriber: danielkiss. @Charusso, I cannot find a way to create a test for this change, since this was found using an architecture that supports 16-bit chars. I understand the need to create test cases for changes. In this case, I believe a rationale f

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki added a comment. In D75850#1912810 , @sdesmalen wrote: > but am happy to update my patch to reuse the generic > `__clang_arm_builtin_alias`! Please do. It would be nicer to have a single attribute than 2 or 3 distinct ones which serve essentia

[PATCH] D75856: [clang-format] cleanup from D75517

jbcoe updated this revision to Diff 249148. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75856/new/ https://reviews.llvm.org/D75856 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTestCSharp.cpp Index: clang/unittests/Format/FormatTestCSharp.cpp ===

[PATCH] D75858: [AArch64][SVE] Add SVE intrinsics for address calculations

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75858/new/ https://reviews.llvm.org/D75858

[PATCH] D75731: [clang-format] C# does not indent braced initializers as continuations

jbcoe marked 2 inline comments as done. jbcoe added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:544 Shape[] shapes = new[] { new Circle { Radius = 2.7281, Colour = Colours.Red }, - new Square { - Si

[clang] b28ed9c - [clang-format] cleanup from D75517

Author: Jonathan Coe Date: 2020-03-09T17:31:36Z New Revision: b28ed9cec8dd7225164eb8c0884aa463654ef3fc URL: https://github.com/llvm/llvm-project/commit/b28ed9cec8dd7225164eb8c0884aa463654ef3fc DIFF: https://github.com/llvm/llvm-project/commit/b28ed9cec8dd7225164eb8c0884aa463654ef3fc.diff LOG:

[clang-tools-extra] 3486cc0 - [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC

Author: Jonathan Roelofs Date: 2020-03-09T11:32:44-06:00 New Revision: 3486cc014b208df3897cf5656db0d0fdeae26d6b URL: https://github.com/llvm/llvm-project/commit/3486cc014b208df3897cf5656db0d0fdeae26d6b DIFF: https://github.com/llvm/llvm-project/commit/3486cc014b208df3897cf5656db0d0fdeae26d6b.di

[clang-tools-extra] 47caa69 - [clang-tidy] Use ; as separator for HeaderFileExtensions

Author: Jonathan Roelofs Date: 2020-03-09T11:32:44-06:00 New Revision: 47caa69120e582bf1b795ec646f069c83b0e9456 URL: https://github.com/llvm/llvm-project/commit/47caa69120e582bf1b795ec646f069c83b0e9456 DIFF: https://github.com/llvm/llvm-project/commit/47caa69120e582bf1b795ec646f069c83b0e9456.di

[clang] eb682b8 - [clang-format] C# does not indent braced initializers as continuations

Author: Jonathan Coe Date: 2020-03-09T17:36:21Z New Revision: eb682b80274d5486d062e3f53040969f592277e4 URL: https://github.com/llvm/llvm-project/commit/eb682b80274d5486d062e3f53040969f592277e4 DIFF: https://github.com/llvm/llvm-project/commit/eb682b80274d5486d062e3f53040969f592277e4.diff LOG:

[clang] 843a977 - Add a warning for builtin_return_address/frame_address with > 0 argument

Author: Jeremy Stenglein Date: 2020-03-09T10:43:09-07:00 New Revision: 843a9778fcd5ef93804fc22de04af9ab8c8b20a9 URL: https://github.com/llvm/llvm-project/commit/843a9778fcd5ef93804fc22de04af9ab8c8b20a9 DIFF: https://github.com/llvm/llvm-project/commit/843a9778fcd5ef93804fc22de04af9ab8c8b20a9.di

[PATCH] D75760: [clang-format] Do not indent C# array initialisers as continuations

krasimir requested changes to this revision. krasimir added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1443 +if (Style.isCSharp()) + FormatTok->BlockKind = BK_BracedInit; nextToken

[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

rnk added a comment. I think I patched this in, ran tests, but didn't push. Feel free to push if you get the chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75643/new/ https://reviews.llvm.org/D75643 __

[PATCH] D75731: [clang-format] C# does not indent braced initializers as continuations

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75731/new/ https://reviews.llvm.org/D75731 ___ cfe-commits mailing list cfe-

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

Charusso accepted this revision. Charusso added a comment. In D75529#1912849 , @vabridgers wrote: > @Charusso, I cannot find a way to create a test for this change, since this > was found using an architecture that supports 16-bit chars. I really felt t

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs closed this revision. jroelofs added a comment. https://github.com/llvm/llvm-project/commit/47caa69120e582bf1b795ec646f069c83b0e9456 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.org/D75621 __

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

jbcoe updated this revision to Diff 249155. jbcoe added a comment. Format code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75747/new/ https://reviews.llvm.org/D75747 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unittests/Format/FormatTestCSharp.cpp Index: clang/unitt

[PATCH] D51762: First part of the calendar stuff

ldionne closed this revision. ldionne added a comment. Like I said, this was committed in 5b08c1742a536f54bd5e270b00ff851cbc7314ef CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51762/new/ https://reviews.llvm.org/D51762 ___ cfe-commits mail

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71018/new/ https://reviews.llvm.org/D71018 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D75489: [clang-tidy] Generalize HeaderFileExtensions.{h, cpp}. NFC

jroelofs closed this revision. jroelofs added a comment. https://github.com/llvm/llvm-project/commit/3486cc014b208df3897cf5656db0d0fdeae26d6b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75489/new/ https://reviews.llvm.org/D75489 __

[PATCH] D75856: [clang-format] cleanup from D75517

This revision was automatically updated to reflect the committed changes. Closed by commit rGb28ed9cec8dd: [clang-format] cleanup from D75517 (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75856/new/ htt

[PATCH] D14411: Use __attribute__((internal_linkage)) when available.

ldionne added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. I think this should be closed since the work we did on `internal_linkage` in 2018. @eugenis Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14411/new/ https://reviews.ll

[PATCH] D75731: [clang-format] C# does not indent braced initializers as continuations

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb682b80274d: [clang-format] C# does not indent braced initializers as continuations (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG843a9778fcd5: Add a warning for builtin_return_address/frame_address with > 0 argument (authored by jstenglein, committed by erichkeane). Changed prior to commit: https://reviews.llvm.org/D75768?vs=248

[clang] 90e791d - Add test missed in r843a9778fcd5

Author: Jeremy Stenglein Date: 2020-03-09T10:54:56-07:00 New Revision: 90e791d732dfb0e0ab8af13e49aa5f92aa4f349d URL: https://github.com/llvm/llvm-project/commit/90e791d732dfb0e0ab8af13e49aa5f92aa4f349d DIFF: https://github.com/llvm/llvm-project/commit/90e791d732dfb0e0ab8af13e49aa5f92aa4f349d.di

[clang] cb3f20d - [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

Author: Jonathan Coe Date: 2020-03-09T18:04:34Z New Revision: cb3f20d27c9e91cb9f997f0401f388e62c4ba993 URL: https://github.com/llvm/llvm-project/commit/cb3f20d27c9e91cb9f997f0401f388e62c4ba993 DIFF: https://github.com/llvm/llvm-project/commit/cb3f20d27c9e91cb9f997f0401f388e62c4ba993.diff LOG:

[clang-tools-extra] c71ef7a - Drop HEADER_ per review feedback on D74669

Author: Jonathan Roelofs Date: 2020-03-09T12:14:22-06:00 New Revision: c71ef7a85d2447903ff9240aff649a57d70b050d URL: https://github.com/llvm/llvm-project/commit/c71ef7a85d2447903ff9240aff649a57d70b050d DIFF: https://github.com/llvm/llvm-project/commit/c71ef7a85d2447903ff9240aff649a57d70b050d.di

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75747/new/ https://reviews.llvm.org/D75747 ___ cfe-commits mailing list cfe

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249164. jroelofs added a comment. Fix comment, add docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyMod

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs marked 3 inline comments as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:9 + +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_UTILS_HEADER_FILE_EXTENSIONS_UTILS_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_UTILS_HEA

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb3f20d27c9e: [clang-format] Correct indentation for `[key] = value,` entries in C++ object… (authored by Jonathan Coe ). Changed prior to commit: https://reviews.llvm.org/D75747?vs=2

[clang] f4076ad - [www] cxx_status: Update title to mention C++20

Author: Hubert Tong Date: 2020-03-09T14:51:11-04:00 New Revision: f4076ad6407594c0abedb4ff61f73abecce394f7 URL: https://github.com/llvm/llvm-project/commit/f4076ad6407594c0abedb4ff61f73abecce394f7 DIFF: https://github.com/llvm/llvm-project/commit/f4076ad6407594c0abedb4ff61f73abecce394f7.diff L

[clang] dfaafba - [www] cxx_status: Update Reflection TS to Cologne draft

Author: Hubert Tong Date: 2020-03-09T14:51:11-04:00 New Revision: dfaafbab4687676f8ad616a79d3d924267831cbd URL: https://github.com/llvm/llvm-project/commit/dfaafbab4687676f8ad616a79d3d924267831cbd DIFF: https://github.com/llvm/llvm-project/commit/dfaafbab4687676f8ad616a79d3d924267831cbd.diff L

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak updated this revision to Diff 249173. ahatanak marked 4 inline comments as done. ahatanak added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64464/new/ https://reviews.llvm.org/D64464 Files: clang/inc

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:869 + if (auto *BD = C.dyn_cast()) +enterBlockScope(*this, BD); } rjmccall wrote: > I wonder if we could just switch blocks to th

[PATCH] D73513: [memtag] Plug in stack safety analysis.

eugenis updated this revision to Diff 249175. eugenis added a comment. Herald added a subscriber: danielkiss. + a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73513/new/ https://reviews.llvm.org/D73513 Files: clang/lib/CodeGen/BackendUtil.

[PATCH] D75524: [www] cxx_status: Update Reflection TS to Cologne draft

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfaafbab4687: [www] cxx_status: Update Reflection TS to Cologne draft (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D755

[PATCH] D75523: [www] cxx_status: Update title to mention C++20

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4076ad64075: [www] cxx_status: Update title to mention C++20 (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75523/new/

[PATCH] D74104: Remove test dependency on the presence of an assembler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Interesting, indeed, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74104/new/ https://reviews.llvm.org/D74104 _

[PATCH] D75806: [CUDA] Add CUDA 10.2 detection

tambre added a comment. Thanks for the context! To avoid other people stepping into this trap, maybe it'd make sense to reword this warning to say "unsupported" instead of "unknown"? Or maybe add detection for newer versions, but introduce a separate warning for unsupported versions? Reposito

[clang] e4dfc9f - Fix the type of the capture passed to LambdaIntroducer::addCapture in

Author: Akira Hatanaka Date: 2020-03-09T12:25:28-07:00 New Revision: e4dfc9f5bda3171e159f2ff62390c8795d9497e7 URL: https://github.com/llvm/llvm-project/commit/e4dfc9f5bda3171e159f2ff62390c8795d9497e7 DIFF: https://github.com/llvm/llvm-project/commit/e4dfc9f5bda3171e159f2ff62390c8795d9497e7.diff

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

shafik added a comment. LGTM WDYT @teemperor Comment at: clang/lib/AST/ASTImporter.cpp:3638 + /// Number of similar looking friends. + unsigned int TotalCount; + /// Index of the specific FriendDecl. `uint32_t` Is there a reason to not prefer fixed width in

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

baloghadamsoftware updated this revision to Diff 249187. baloghadamsoftware added a comment. Test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75842/new/ https://reviews.llvm.org/D75842 Files: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h clang/unittests/Sta

[PATCH] D58164: Block+lambda: allow reference capture

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4dfc9f5bda3: Fix the type of the capture passed to LambdaIntroducer::addCapture in… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58

[clang] cc8390b - Permit attribute 'used' with 'target' multiversioning.

Author: Erich Keane Date: 2020-03-09T12:38:03-07:00 New Revision: cc8390bfe30d08633d62a1b53e6669e386c95600 URL: https://github.com/llvm/llvm-project/commit/cc8390bfe30d08633d62a1b53e6669e386c95600 DIFF: https://github.com/llvm/llvm-project/commit/cc8390bfe30d08633d62a1b53e6669e386c95600.diff L

[clang] d0ca104 - [Hexagon] Refactor handling of circular load/store builtins, NFC

Author: Krzysztof Parzyszek Date: 2020-03-09T14:40:08-05:00 New Revision: d0ca1041ba0d2d6b8adc7f04d017502e44a118e3 URL: https://github.com/llvm/llvm-project/commit/d0ca1041ba0d2d6b8adc7f04d017502e44a118e3 DIFF: https://github.com/llvm/llvm-project/commit/d0ca1041ba0d2d6b8adc7f04d017502e44a118e3

[clang] 3d9a044 - Recommit #2 "[Driver] Default to -fno-common for all targets"

Author: Sjoerd Meijer Date: 2020-03-09T19:57:03Z New Revision: 3d9a0445cce368b55dc3a573bc91fe902bbb977f URL: https://github.com/llvm/llvm-project/commit/3d9a0445cce368b55dc3a573bc91fe902bbb977f DIFF: https://github.com/llvm/llvm-project/commit/3d9a0445cce368b55dc3a573bc91fe902bbb977f.diff LOG:

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak updated this revision to Diff 249190. ahatanak marked an inline comment as done. ahatanak added a comment. Fix the way `IsExternallyDestructed` is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66094/new/ https://reviews.llvm.org/D660

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre added a comment. > Magically changing compiler target based on something external to compiler is > a bad idea IMO. I would expect a compilation with exactly the same compiler > options to do exactly the same thing. If we magically change default target, > that will not be the case. It'd

[PATCH] D75068: libclang: Add static build support for Windows

mstorsjo added a comment. @thakis? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Minor comments; otherwise LGTM. Comment at: clang/lib/Sema/SemaExpr.cpp:6256 +// Compound literals that have automatic storage duration are destroyed at +// the e

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

bcain added a comment. In general, I recommend qualifying metric and threshold values with their associated units: bits, bytes, pages, etc. That way it's easy to see where the unit conversions are happening and easy to see whether the logic is correct without reasoning about how the value chan

[PATCH] D73521: [analyzer][WIP] add-new-checker.py: Introduction

NoQ added a comment. Herald added subscribers: martong, steakhal. I didn't use it yet but i like it. The code is easy to understand, so i'll be happy to maintain it as it lands. The example checker is nice and i like how you made sure it demonstrates modern API usage. I'm a bit worried that it

[clang] 51d7f64 - Don't emit pointer to int cast warnings under -Wmicrosoft-cast

Author: Arthur Eubanks Date: 2020-03-09T13:27:46-07:00 New Revision: 51d7f645448b49c7d3b029a60532bac019da1348 URL: https://github.com/llvm/llvm-project/commit/51d7f645448b49c7d3b029a60532bac019da1348 DIFF: https://github.com/llvm/llvm-project/commit/51d7f645448b49c7d3b029a60532bac019da1348.diff

[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

This revision was automatically updated to reflect the committed changes. Closed by commit rG51d7f645448b: Don't emit pointer to int cast warnings under -Wmicrosoft-cast (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D75643?vs=248306&id=249203#toc Repository: rG LL

[clang] 22c457a - [HIP] Fix device stub name

Author: Yaxun (Sam) Liu Date: 2020-03-09T16:40:05-04:00 New Revision: 22c457a869d5dd9d7e6ca0f97e2a8408bf7326f2 URL: https://github.com/llvm/llvm-project/commit/22c457a869d5dd9d7e6ca0f97e2a8408bf7326f2 DIFF: https://github.com/llvm/llvm-project/commit/22c457a869d5dd9d7e6ca0f97e2a8408bf7326f2.dif

[clang] e32f8ef - Follow up of 3d9a0445cce3, clang driver defaulting to -fno-common

Author: Sjoerd Meijer Date: 2020-03-09T20:43:05Z New Revision: e32f8ef9277dbaaeef1fbabe9505683ff5e35edf URL: https://github.com/llvm/llvm-project/commit/e32f8ef9277dbaaeef1fbabe9505683ff5e35edf DIFF: https://github.com/llvm/llvm-project/commit/e32f8ef9277dbaaeef1fbabe9505683ff5e35edf.diff LOG:

Re: [PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

From the peanut gallery: Perhaps something like --cuda_arch=min_supported would solve your problem while still meeting tra's request not to change behavior of the compiler based on something external. On Mon, Mar 9, 2020 at 12:58 PM Raul Tambre via Phabricator wrote: > > tambre added a comment. >

[PATCH] D68578: [HIP] Fix device stub name

yaxunl marked 9 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/AST/GlobalDecl.h:61 assert(!isa(D) && "Use other ctor with dtor decls!"); +assert(!D->hasAttr() && "Use other ctor with HIP kernels!"); tra wrote: >

[PATCH] D75841: [ASTMatchers] Add hasAnyOverloadedOperatorName matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75841/new/ https://reviews.llvm.org/D75841

[PATCH] D75714: Add Optional overload to DiagnosticBuilder operator <

aaron.ballman added a comment. Is there any code we can cleanup as a result of adding these overloads? I would have expected to see some code changes justifying each additional overload, which would also give us test coverage for the changes. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D68578: [HIP] Fix device stub name

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rG22c457a869d5: [HIP] Fix device stub name (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D68578?vs=248927&

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tra added a comment. In D75811#1913148 , @tambre wrote: > > Magically changing compiler target based on something external to compiler > > is a bad idea IMO. I would expect a compilation with exactly the same > > compiler options to do exactly the same t

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

SjoerdMeijer added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5292 + { #NameBase, SVE::BI__builtin_sve_##NameBase, 0, 0, TypeModifier } +static const NeonIntrinsicInfo AArch64SVEIntrinsicMap[] = { +#define GET_SVE_LLVM_INTRINSIC_MAP I am wonder

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added a comment. Thank you for the patch! It should also have some test cases associated with it. I'd recommend adding a test to the `AST` directory that do AST dumps where you test the line and column information directly. Comment at: clang/lib/Parse/ParseStmt.

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some documentation and testing nits. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-suspicious-include.rst:15-17 + #include "Ve

[clang] 6309334 - [OPENMP50]Codegen for depobj dependency kind.

Author: Alexey Bataev Date: 2020-03-09T17:46:06-04:00 New Revision: 6309334b9574017523f73648da879fa5e6ef017a URL: https://github.com/llvm/llvm-project/commit/6309334b9574017523f73648da879fa5e6ef017a DIFF: https://github.com/llvm/llvm-project/commit/6309334b9574017523f73648da879fa5e6ef017a.diff

[clang-tools-extra] 1e0669b - [clang-tidy] New check: bugprone-suspicious-include

Author: Jonathan Roelofs Date: 2020-03-09T15:54:32-06:00 New Revision: 1e0669bfe05f0f48ee88152c4a1d581f484f8d67 URL: https://github.com/llvm/llvm-project/commit/1e0669bfe05f0f48ee88152c4a1d581f484f8d67 DIFF: https://github.com/llvm/llvm-project/commit/1e0669bfe05f0f48ee88152c4a1d581f484f8d67.di

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs closed this revision. jroelofs marked 7 inline comments as done. jroelofs added a comment. Thanks for the review! https://github.com/llvm/llvm-project/commit/1e0669bfe05f0f48ee88152c4a1d581f484f8d67 Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-susp

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249223. jroelofs added a comment. Implement review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTid

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249224. jroelofs added a comment. Add missing release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTid

[clang-tools-extra] 698a127 - release notes: fix new check name

Author: Jonathan Roelofs Date: 2020-03-09T16:11:35-06:00 New Revision: 698a12712920c214e39bb215fe26fad2e099425b URL: https://github.com/llvm/llvm-project/commit/698a12712920c214e39bb215fe26fad2e099425b DIFF: https://github.com/llvm/llvm-project/commit/698a12712920c214e39bb215fe26fad2e099425b.di

[clang-tools-extra] 2e9d33b - Add missing list.rst entry

Author: Jonathan Roelofs Date: 2020-03-09T16:27:35-06:00 New Revision: 2e9d33bccd587763fc284098b5cc60cfb9c25251 URL: https://github.com/llvm/llvm-project/commit/2e9d33bccd587763fc284098b5cc60cfb9c25251 DIFF: https://github.com/llvm/llvm-project/commit/2e9d33bccd587763fc284098b5cc60cfb9c25251.di

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:101 +- New :doc:`bugprone-suspicious-includei + ` check. Please keep alphabetical order. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:104 + + F

[clang] 7fbf15a - [CodeGenObjC] Privatize some ObjC metadata symbols

Author: Erik Pilkington Date: 2020-03-09T15:40:24-07:00 New Revision: 7fbf15a8f2df039cd47de7f2e98c4cd655d82e41 URL: https://github.com/llvm/llvm-project/commit/7fbf15a8f2df039cd47de7f2e98c4cd655d82e41 DIFF: https://github.com/llvm/llvm-project/commit/7fbf15a8f2df039cd47de7f2e98c4cd655d82e41.dif

[clang] 54d8225 - Change tests to use -S instead of -c to work when an external assembler is used that is not present. NFCI.

Author: Douglas Yung Date: 2020-03-09T15:45:00-07:00 New Revision: 54d82255fd270e87de5147e6b771b63d48552e71 URL: https://github.com/llvm/llvm-project/commit/54d82255fd270e87de5147e6b771b63d48552e71 DIFF: https://github.com/llvm/llvm-project/commit/54d82255fd270e87de5147e6b771b63d48552e71.diff

[clang-tools-extra] 52bbdad - [clang-tidy][docs] Post-commit feedback on D74669

Author: Jonathan Roelofs Date: 2020-03-09T16:51:41-06:00 New Revision: 52bbdad7d63fd060d102b3591b433d116a982255 URL: https://github.com/llvm/llvm-project/commit/52bbdad7d63fd060d102b3591b433d116a982255 DIFF: https://github.com/llvm/llvm-project/commit/52bbdad7d63fd060d102b3591b433d116a982255.di

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. Herald added subscribers: evandro, luismarques, sameer.abuasal, pzheng, s.egerton, lenary. Shiva, we forgot about this patch. Can you rebase it so we move on with merging. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://r

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs marked 6 inline comments as done. jroelofs added a comment. https://github.com/llvm/llvm-project/commit/52bbdad7d63fd060d102b3591b433d116a982255 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 __

[PATCH] D75491: [CodeGenObjC] Privatize some ObjC metadata symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fbf15a8f2df: [CodeGenObjC] Privatize some ObjC metadata symbols (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D74104: Remove test dependency on the presence of an assembler

This revision was automatically updated to reflect the committed changes. Closed by commit rG54d82255fd27: Change tests to use -S instead of -c to work when an external assembler is used… (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D75714: Add Optional overload to DiagnosticBuilder operator <

njames93 added a comment. In D75714#1913230 , @aaron.ballman wrote: > Is there any code we can cleanup as a result of adding these overloads? I > would have expected to see some code changes justifying each additional > overload, which would also give u

<    1   2   3   >