Eugene.Zelenko added inline comments.
================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:101 +- New :doc:`bugprone-suspicious-includei + <clang-tidy/checks/bugprone-suspicious-include>` check. ---------------- Please keep alphabetical order. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:104 + + Finds includes that appear to be referring to implementation files (which + tends to cause ODR violations), and diagnoses them. ---------------- Please synchronize with first statement in documentation. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-suspicious-include.rst:6 + +The checker detects various cases when an include refers to what appears to be +an implementation file, which often leads to hard-to-track-down ODR violations. ---------------- Please omit //The checker//. Clang-tidy uses //check// in its terminology. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-suspicious-include.rst:23 + + Default value: ";h;hh;hpp;hxx" + A semicolon-separated list of filename extensions of header files (the ---------------- Please use single back-ticks for option values. Same above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
