[PATCH] D74907: libclang: Make shared object symbol exporting by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a7c753b0cca: libclang: Make shared object symbol exporting by default (authored by cristian.adam, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 6d34a87 - [cxx_status] Update -std= instructions for C++20.

Author: Richard Smith Date: 2020-02-20T11:40:09-08:00 New Revision: 6d34a87bae6ea211076c25faef7da5d29cb8e46d URL: https://github.com/llvm/llvm-project/commit/6d34a87bae6ea211076c25faef7da5d29cb8e46d DIFF: https://github.com/llvm/llvm-project/commit/6d34a87bae6ea211076c25faef7da5d29cb8e46d.diff

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. Thank you! A build with `-DLIBCLANG_BUILD_STATIC=ON` and `-DLLVM_ENABLE_PIC=OFF` is green at: https://github.com/cristianadam/llvm-project/actions/runs/42545217 The default build with `-DLIBCLANG_BUILD_STATIC=OFF` and `-DLLVM_ENABLE_PIC=ON` is green at: https:/

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

lebedev.ri added a comment. No proofs, but for completeness, some amd numbers Comment at: clang/lib/Basic/Targets/X86.cpp:1811-1814 +// K6 +case CK_K6: +case CK_K6_2: +case CK_K6_3: K6 should have 32B cache line size Comment a

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

mehdi_amini added a comment. > It seems to me that we are not dropping the flag of -fdiscard-value-names. I also reads this as overriding a cc1 flag / ignoring the flag, I don't know if we consistently warn in such cases though. Overall LGTM for the fix, pending resolution for the warning, than

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver added a comment. @lebedev.ri thanks! I'll add those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver updated this revision to Diff 245708. zoecarver added a comment. - Add AMD cache line sizes based on @lebedev.ri's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 Files: clang/include/c

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 added a comment. Running this over llvm with only clang and clang-tools-extra enabled this was the output. ninja check-all ran successfully with no errors. Didn't try transform `TransformCxxOpCalls` or `TransformDepend

[clang] e844447 - Revert "libclang: Add static build support for Windows" and

Author: Nico Weber Date: 2020-02-20T15:17:51-05:00 New Revision: e8781aad23ed66d46d23637df4768677e76e URL: https://github.com/llvm/llvm-project/commit/e8781aad23ed66d46d23637df4768677e76e DIFF: https://github.com/llvm/llvm-project/commit/e8781aad23ed66d46d23637df4768677e76e.diff LO

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis added a comment. Looks like things are still broken in several ways even with this in: [2600/2950] Linking CXX executable bin\c-index-test.exe FAILED: bin/c-index-test.exe cmd.exe /C "cd . && C:\b\s\w\ir\cache\builder\src\third_party\llvm-build-tools\cmake-3.12.1-win32-x86\bin\cm

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes updated this revision to Diff 245717. compositeprimes marked an inline comment as done. compositeprimes added a comment. Added tests for Yaml serialization CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews.llvm.org/D69782 Files: include/clang/To

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes added inline comments. Comment at: include/clang/Tooling/Core/Diagnostic.h:51 +/// Represents a single source ranges to be associated with a diagnostic. +struct DiagnosticAssociatedRange { + DiagnosticAssociatedRange() = default; alexfh wrote: >

[clang] bf3f427 - [ASTImporter] Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage

Author: shafik Date: 2020-02-20T12:49:14-08:00 New Revision: bf3f427ba239bd2942bfaa350d06ed072935f048 URL: https://github.com/llvm/llvm-project/commit/bf3f427ba239bd2942bfaa350d06ed072935f048 DIFF: https://github.com/llvm/llvm-project/commit/bf3f427ba239bd2942bfaa350d06ed072935f048.diff LOG: [

[PATCH] D74639: Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf3f427ba239: [ASTImporter] Add linkage check to ASTNodeImporter::hasSameVisibilityContext… (authored by shafik). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D74639?

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

efriedma added a comment. Where are you planning to use this? Comment at: clang/lib/Sema/SemaStmt.cpp:2817 + + unsigned targetCacheLineSize = Ctx.getTargetInfo().getCPUCacheLineSize(); + if (!targetCacheLineSize) "64" here is arbitrary; it's not actually supp

[clang] 6123074 - [Driver] Escape the program path for -frecord-command-line

Author: Scott Linder Date: 2020-02-20T16:31:17-05:00 New Revision: 6123074d0c0de3614f1552f2f2d6b9db7b32cebe URL: https://github.com/llvm/llvm-project/commit/6123074d0c0de3614f1552f2f2d6b9db7b32cebe DIFF: https://github.com/llvm/llvm-project/commit/6123074d0c0de3614f1552f2f2d6b9db7b32cebe.diff

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

This revision was automatically updated to reflect the committed changes. Closed by commit rG6123074d0c0d: [Driver] Escape the program path for -frecord-command-line (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

jyknight added a comment. As I've mentioned before, depending on what this will be used for, "64" is not a _useful_ answer if you want to know how your memory accesses will behave on modern intel x86 CPUs, despite being the "correct" answer for cache-line size. But, modern intel CPUs fetch alig

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

rjmccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11444 + return nullptr; +const Decl *ContextDecl = dyn_cast(CurContext); +if (!ContextDecl) You really want this to match whenever we're in a local context, right? How abou

[PATCH] D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs

jkorous added a comment. @vsapsai Sorry! I read your comment only after landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74746/new/ https://reviews.llvm.org/D74746 ___ cfe-commits mailing li

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 245735. hliao marked an inline comment as done. hliao added a comment. Rebase the code to the latest trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

jfb added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1193 + // the given cpu and returns `0` if the CPU is not found. + virtual unsigned getCPUCacheLineSize() const { return 0; } + Return an optional instead of using zero to mean "unkno

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

NoQ added a comment. Herald added subscribers: martong, steakhal. Hmm, has this patch not landed yet? I was so excited to finally have https://bugs.llvm.org/show_bug.cgi?id=28450 fixed :) Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:767 + DefinedOrUnknownSV

Re: [PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

I'm currently traveling but will take a look tomorrow. If necessary go ahead and revert, I will not be able to do so myself until tomorrow. Teresa On Tue, Feb 18, 2020, 8:48 PM Alexandre Ganea via Phabricator < revi...@reviews.llvm.org> wrote: > aganea added a comment. > > There seems to be still

RE: [PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

No need to revert, I can wait. Thanks! De : Teresa Johnson Envoyé : February 20, 2020 5:07 PM À : reviews+d73242+public+5822844df8563...@reviews.llvm.org Cc : Peter Collingbourne ; Evgeny Leviant ; Alexandre Ganea ; joker@gmail.com; piotr.padlew...@gmail.com; hiradi...@msn.com; steve...@ap

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. In D69471#1884043 , @dexonsmith wrote: > In D69471#1883912 , @rnk wrote: > > > Everything is off-by-one because the empty bases are not zero sized. The > > MSVC record layout algorithm is just

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 245747. hliao added a comment. Revise following reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/lib/Pa

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk planned changes to this revision. vsk added a comment. @rnk Thanks for chasing this down. I'll update the function record structs to use free functions instead of multiple inheritance. I don't plan on getting rid of the awkward method calls at this point. The coverage reader is still templa

[clang] 577d9ce - Revert "[Driver] Escape the program path for -frecord-command-line"

Author: Scott Linder Date: 2020-02-20T17:36:56-05:00 New Revision: 577d9ce35532439203411c999deefc9c80e04c69 URL: https://github.com/llvm/llvm-project/commit/577d9ce35532439203411c999deefc9c80e04c69 DIFF: https://github.com/llvm/llvm-project/commit/577d9ce35532439203411c999deefc9c80e04c69.diff

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

scott.linder added a comment. Multiple build bots were failing with the patch applied, see e.g. http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4890/steps/test-check-clang/logs/FAIL%3A%20Clang%3A%3Aclang_f_opts.c Seems like on platforms with a backslash for a directory separato

[PATCH] D74934: [Clang interpreter] Rename Block.{h,cpp} to AllocatedBlock.{h,cpp}

MaskRay created this revision. MaskRay added reviewers: jfb, gribozavr, nand, RKSimon. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, mgorny. Herald added projects: clang, LLVM. The Blocks runtime provide a header named Block.h. It is generally preferable to avoid name collision

[PATCH] D74934: [Clang interpreter] Rename Block.{h,cpp} to AllocatedBlock.{h,cpp}

MaskRay updated this revision to Diff 245755. MaskRay added a comment. Fix a file header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74934/new/ https://reviews.llvm.org/D74934 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Allocate

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk updated this revision to Diff 245756. vsk added a comment. This revision is now accepted and ready to land. Get rid of multiple inheritance in the coverage::accessors namespace. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471 Files: clang/

[libunwind] d4ded05 - [libunwind][CMake] Treat S files as C to work around CMake bug.

Author: Michael Spencer Date: 2020-02-20T15:26:09-08:00 New Revision: d4ded05ba851304b26a437896bc3962ef56f62cb URL: https://github.com/llvm/llvm-project/commit/d4ded05ba851304b26a437896bc3962ef56f62cb DIFF: https://github.com/llvm/llvm-project/commit/d4ded05ba851304b26a437896bc3962ef56f62cb.dif

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert created this revision. jdoerfert added reviewers: hfinkel, nlopes, regehr, efriedma. Herald added a subscriber: bollu. Herald added a reviewer: sstefan1. Herald added a reviewer: uenoku. Herald added a project: LLVM. We already mention that `noalias` is modeled after the C99 `restrict` q

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk accepted this revision. rnk added a comment. Sounds like a plan, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1738 +// ++-+--

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1834 +case CK_Tigerlake: +case CK_Lakemont: + I think Lakemont is 16 bytes. Assuming I'm interpretting the CLFLUSH line size from this CPUID dump correctly https://github.co

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

efriedma added a comment. I'm not sure I like the wording; it's a complicated sentence to understand. Can we make it sort of list-like? "for each memory location accessed through a noalias pointer, either: 1. the location is not modified during the execution of the function. 2. all accesses t

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan added a comment. In D74811#1885514 , @scott.linder wrote: > Multiple build bots were failing with the patch applied, see e.g. > http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4890/steps/test-check-clang/logs/FAIL%3A%20C

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

aqjune added a comment. Hi, The term 'object' seems ambiguous to me. For example, void f(i32* noalias x, i32* noalias y) { *x = 1; *y = 2; } int x[2]; f(&x[0], &x[1]); If object means an allocation, this should be UB, because x and y are pointing to the same object. Memory lo

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert updated this revision to Diff 245774. jdoerfert added a comment. Tried to simplify the wording by making it two sentences. @efriedma's wording is another option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74935/new/ https://reviews.ll

[PATCH] D74939: clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC.

vsapsai created this revision. vsapsai added reviewers: dexonsmith, bruno, Bigcheese. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. Follow-up to 20d51b2f14ac4488f684f8fc57cb0ba718a6b91d , rename th

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added subscribers: llvm-commits, guansong, bollu, jholewinski. Herald added projects: clang, LLVM. This is the first pa

[PATCH] D74939: clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Don't know how I missed that API... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74939/new/ https://reviews.llvm.org/D7

[clang] 4b540fa - [OpenMP][NFC] Remove leftover debug messages

Author: Johannes Doerfert Date: 2020-02-20T20:28:42-06:00 New Revision: 4b540fa8a1c1077468cf8eb7c32fd2481cdbc520 URL: https://github.com/llvm/llvm-project/commit/4b540fa8a1c1077468cf8eb7c32fd2481cdbc520 DIFF: https://github.com/llvm/llvm-project/commit/4b540fa8a1c1077468cf8eb7c32fd2481cdbc520.d

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

aqjune added a comment. Never mind, I see that the keyword object comes from the alias analysis document. The alias analysis document is using the term object consistently. I was confused because the term is used at llvm.objectsize intrinsic's LangRef documentation, which seems to refer an alloc

[libclc] efeafa1 - libclc: Use acos implementation from amd_builtins

Author: Jan Vesely Date: 2020-02-20T23:36:14-05:00 New Revision: efeafa1bdaa715733fc100bcd9d21f93c7272368 URL: https://github.com/llvm/llvm-project/commit/efeafa1bdaa715733fc100bcd9d21f93c7272368 DIFF: https://github.com/llvm/llvm-project/commit/efeafa1bdaa715733fc100bcd9d21f93c7272368.diff LO

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver marked 7 inline comments as done. zoecarver added a comment. To address the question, what will this be used for: this could be used for several things in the library and compiler, but the primary use will be to create a builtin that can be used to implement P0154

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1738 +// ++-+--

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert updated this revision to Diff 245795. jdoerfert added a comment. Remove leftover word Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74935/new/ https://reviews.llvm.org/D74935 Files: llvm/docs/LangRef.rst Index: llvm/docs/LangRef.rst

<    1   2