mehdi_amini added a comment.

> It seems to me that we are not dropping the flag of -fdiscard-value-names.

I also reads this as overriding a cc1 flag / ignoring the flag, I don't know if 
we consistently warn in such cases though.

Overall LGTM for the fix, pending resolution for the warning, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74878/new/

https://reviews.llvm.org/D74878



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to