[clang] 62c221b - [Concepts] Profile TypeConstraints in ProfileTemplateParameterList

Author: Saar Raz Date: 2020-01-23T09:59:51+02:00 New Revision: 62c221b5090c2e1d3ca408bcab6f69c4d9e175b7 URL: https://github.com/llvm/llvm-project/commit/62c221b5090c2e1d3ca408bcab6f69c4d9e175b7 DIFF: https://github.com/llvm/llvm-project/commit/62c221b5090c2e1d3ca408bcab6f69c4d9e175b7.diff LOG:

[PATCH] D73199: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup! Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:84 + if (llvm::none_of(Files, [](const auto &KV) { +return llvm::StringRe

[PATCH] D73185: [AST] Add fixed-point subtraction constant evaluation.

ebevhan marked an inline comment as done. ebevhan added inline comments. Comment at: clang/include/clang/Basic/FixedPoint.h:82 + unsigned IsSaturated: 1; + unsigned HasUnsignedPadding : 1; }; rjmccall wrote: > These changes should probably be done in a sep

[PATCH] D73185: [AST] Add fixed-point subtraction constant evaluation.

ebevhan updated this revision to Diff 239791. ebevhan added a comment. Move packing of FixedPointSemantics to a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73185/new/ https://reviews.llvm.org/D73185 Files: clang/include/clang/B

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62133 tests passed, 0 failed and 808 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73257: [AST] Compress the FixedPointSemantics type better.

ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan, bjope. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73257 Files: clang/include/clang/Basic/FixedPoint.h Index: clang/includ

[PATCH] D73257: [AST] Compress the FixedPointSemantics type better.

ebevhan updated this revision to Diff 239796. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73257/new/ https://reviews.llvm.org/D73257 Files: clang/include/clang/Basic/FixedPoint.h Index: clang/include/clang/B

[PATCH] D73182: [CodeGen] Emit IR for fixed-point multiplication and division.

ebevhan updated this revision to Diff 239793. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73182/new/ https://reviews.llvm.org/D73182 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_point_

[PATCH] D73184: [CodeGen] Emit IR for compound assignment with fixed-point operands.

ebevhan updated this revision to Diff 239795. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73184/new/ https://reviews.llvm.org/D73184 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/SemaExpr.cpp cl

[PATCH] D73187: [AST] Add fixed-point division constant evaluation.

ebevhan updated this revision to Diff 239798. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73187/new/ https://reviews.llvm.org/D73187 Files: clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ExprConstant.c

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

RKSimon added a comment. Add to isNegatibleForFree/getNegatedExpression as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___ cfe-commits mailing list cf

[PATCH] D73183: [CodeGen] Emit IR for fixed-point unary operators.

ebevhan updated this revision to Diff 239794. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73183/new/ https://reviews.llvm.org/D73183 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_point_

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan updated this revision to Diff 239797. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73186/new/ https://reviews.llvm.org/D73186 Files: clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ExprConstant.c

[PATCH] D73188: [AST] Improve overflow diagnostics for fixed-point constant evaluation.

ebevhan updated this revision to Diff 239799. ebevhan added a comment. Added tests for saturating types. Changed the warning group name for consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73188/new/ https://reviews.llvm.org/D73188 File

[PATCH] D73189: [AST] Fix certain consteval assignment and comma operator issues with fixed-point types.

ebevhan updated this revision to Diff 239800. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73189/new/ https://reviews.llvm.org/D73189 Files: clang/lib/AST/ExprConstant.cpp clang/test/Frontend/fixed_point_cras

[PATCH] D73099: [Alignment][NFC] Deprecate Align::None()

gchatelet updated this revision to Diff 239801. gchatelet added a comment. - Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73099/new/ https://reviews.llvm.org/D73099 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGObjCMac.c

[PATCH] D72829: Implement -fsemantic-interposition

grimar added inline comments. Comment at: llvm/lib/IR/Module.cpp:558 +bool Module::getSemanticInterposition() const { + auto *Val = + cast_or_null(getModuleFlag("SemanticInterposition")); A minor nit about style: This probably would be nicer as ``` if (a

[PATCH] D72934: [ARM,MVE] Support immediate vbicq,vorrq,vmvnq intrinsics.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Looks good, from what I can tell. I especially like the selects. We know that we have to do more work there, but adding this for more instructions would go a long way towards creating more

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

pengfei added a comment. In D72824#1835568 , @RKSimon wrote: > Add to isNegatibleForFree/getNegatedExpression as well? We don't need to add them to isNegatibleForFree/getNegatedExpression. We won't negate any FMA results by negative FMA instructions und

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239809. serge-sans-paille added a comment. Take review into account Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/include/clang/Basic/LangOpt

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:223 +// We've requested the client to create a progress bar. +// Meanwhile, the state is buffered in PendingBackgraundIndexProgress. +Creating, s/PendingBackgraundI

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

russell.gallop updated this revision to Diff 239808. russell.gallop added a comment. Update to check for start of metadata. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73162/new/ https://reviews.llvm.org/D73162 Files: clang/test/CodeGen/loop-unroll.c Index: clang/test/CodeGen/loo

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

russell.gallop added a comment. In D73162#1834379 , @asbirlea wrote: > Oh, wow! Might I ask you add the same for fmul? We may get a revision like > that next time :). > Thank you! fmul shouldn't have the same problem as git hashes are only hex characte

[clang] 4662f6e - [test] Avoid loop-unroll.c test getting confused by fadd in git revision

Author: Russell Gallop Date: 2020-01-23T09:27:16Z New Revision: 4662f6e1c7781bea5cc836948b1aa67f58b8b98d URL: https://github.com/llvm/llvm-project/commit/4662f6e1c7781bea5cc836948b1aa67f58b8b98d DIFF: https://github.com/llvm/llvm-project/commit/4662f6e1c7781bea5cc836948b1aa67f58b8b98d.diff LOG

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

This revision was automatically updated to reflect the committed changes. Closed by commit rG4662f6e1c778: [test] Avoid loop-unroll.c test getting confused by fadd in git revision (authored by russell.gallop). Changed prior to commit: https://reviews.llvm.org/D73162?vs=239808&id=239812#toc Rep

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

evgeny777 added inline comments. Comment at: llvm/lib/Transforms/IPO/GlobalSplit.cpp:116 +if (GV.hasMetadata(LLVMContext::MD_vcall_visibility)) + SplitGV->setVCallVisibilityMetadata(GV.getVCallVisibility()); } I think this needs a test. Removal of thi

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62134 tests passed, 0 failed and 808 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + rjmccall wrote: > If the maximum expressible value is *k*, and the fully-precise multiplication > yields *k+e* for some epsi

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added a comment. Looks good so far. See remaining comment in D71907 Comment at: clang/lib/CodeGen/CGVTables.cpp:1050 - if (getCodeGenOpts().LTOVisibilityPublicStd) { -const DeclContext *DC = RD; -while (1) { - auto *D

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

RKSimon added a comment. In D72824#1835633 , @pengfei wrote: > In D72824#1835568 , @RKSimon wrote: > > > Add to isNegatibleForFree/getNegatedExpression as well? > > > We don't need to add them to isNegatibleForFree/

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 updated this revision to Diff 239825. njames93 added a comment. - use regex for func name matching Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/ https://reviews.llvm.org/D73098 Files: clang-tools-extra/clang-tidy/readability/

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 updated this revision to Diff 239830. njames93 added a comment. - Dont trim func name before regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/ https://reviews.llvm.org/D73098 Files: clang-tools-extra/clang-tidy/readability/

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

awpandey created this revision. awpandey added reviewers: dblaikie, aprantl, probinson, jini.susan.george. awpandey added projects: debug-info, LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. This patch adds //dw_at_const_expr// flag for the constant variable or funct

[PATCH] D72144: Treat C# `using` as a control statement

jbcoe updated this revision to Diff 239836. jbcoe added a comment. Extended tests and added some comments explaining why seeming duplicated tests are useful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 Files: clang/lib/Format/TokenAnnotat

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239837. serge-sans-paille added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/include/clang/Basic/LangOptions.def cl

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62131 tests passed, 0 failed and 808 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62131 tests passed, 0 failed and 808 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:383 + } else { +static llvm::Regex Matcher("(^((W[Mm])|(wm))ain([_A-Z]|$))|([a-z0-9_]W[Mm]" + "ain([_A-Z]|$))|(_wmain(_|$))", ---

[PATCH] D72144: Treat C# `using` as a control statement

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. I looked up the C# reference and all the examples are top-level, so having top-level

[PATCH] D72144: Treat C# `using` as a control statement

krasimir accepted this revision. krasimir added a comment. I'll submit this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D72959: Relative VTables ABI on Fuchsia

peter.smith added a comment. In D72959#1835368 , @rjmccall wrote: > There's two independently-useful things here for the relocation, right? > First, it's useful to be able to express a relocation to a symbol that has > the semantics of a particular func

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62132 tests passed, 0 failed and 808 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. In D69868#1832725 , @MaskRay wrote: > In D69868#1832559 , @void wrote: > > > @jyknight Do you think you'll have time to review this patch this week? I'd > > like to get it into the 10.0 releas

[PATCH] D72934: [ARM,MVE] Support immediate vbicq,vorrq,vmvnq intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4321c6af28e9: [ARM,MVE] Support immediate vbicq,vorrq,vmvnq intrinsics. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72934/new/

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava updated this revision to Diff 239847. adalava added a comment. Updated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71600/new/ https://reviews.llvm.org/D71600 Files: clang/lib/AST/ExprConstant.cpp compiler-rt/lib/builtins/atom

[PATCH] D73025: [AArch64][SVE] Add first-faulting load intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa0f37e14a87: [AArch64][SVE] Add first-faulting load intrinsic (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D73025?vs=239303&id=239849#toc Repository: rG LLVM Github M

[clang] 1e0174a - Treat C# `using` as a control statement

Author: Krasimir Georgiev Date: 2020-01-23T13:19:55+01:00 New Revision: 1e0174a93cfd364bffd12abc8f0148509d0d0f75 URL: https://github.com/llvm/llvm-project/commit/1e0174a93cfd364bffd12abc8f0148509d0d0f75 DIFF: https://github.com/llvm/llvm-project/commit/1e0174a93cfd364bffd12abc8f0148509d0d0f75.d

[PATCH] D72144: Treat C# `using` as a control statement

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG1e0174a93cfd: Treat C# `using` as a control statement (authored by krasimir). Repository: rG LLVM Github Monorepo CH

[PATCH] D73265: header file warning

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. goncharov removed subscribers: jkorous, arphaman, kadircet, usaxena95, cfe-commits. warning in a header Repository: rG LLVM Github Monorepo https://r

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239857. serge-sans-paille added a comment. Add Release note and doc. @MaskRay can you confirm current state is ok? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72

[PATCH] D73268: [ARM,MVE] Make the MVE intrinsics work in C++!

simon_tatham created this revision. simon_tatham added reviewers: LukeGeeson, MarkMurrayARM, miyuki, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Apparently nobody has tried this in months of development. It turns out that `FunctionDecl::getBuiltinI

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62135 tests passed, 0 failed and 808 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:383 + } else { +static llvm::Regex Matcher("(^((W[Mm])|(wm))ain([_A-Z]|$))|([a-z0-9_]W[Mm]" + "ain([_A-Z]|$))|(_wmain(_|$))", --

[PATCH] D71566: New checks for fortified sprintf

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D71566#1834472 , @serge-sans-paille wrote: > In D71566#1832394 , @aaron.ballman > wrote: > >

[PATCH] D73268: [ARM,MVE] Make the MVE intrinsics work in C++!

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73268/new/ https://reviews.llvm.org/D73268 _

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 239874. balazske added a comment. Small bugfixes, added some tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 Files: clang/include/clang/StaticAnalyzer/Checker

[clang] 98ea4b3 - [ARM,MVE] Make the MVE intrinsics work in C++!

Author: Simon Tatham Date: 2020-01-23T14:10:27Z New Revision: 98ea4b30c2c4e122defce039e29f7023aa2663e7 URL: https://github.com/llvm/llvm-project/commit/98ea4b30c2c4e122defce039e29f7023aa2663e7 DIFF: https://github.com/llvm/llvm-project/commit/98ea4b30c2c4e122defce039e29f7023aa2663e7.diff LOG:

[PATCH] D73270: [clan-tidy] Fix false positive in bugprone-infinite-loop

baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: gribozavr2. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: mgehre, gamesh411, Szelethus, rnkovacs, whisperity. Herald added a project: clang. The checker `bugprone-infinite-loop` does n

[PATCH] D73268: [ARM,MVE] Make the MVE intrinsics work in C++!

This revision was automatically updated to reflect the committed changes. Closed by commit rG98ea4b30c2c4: [ARM,MVE] Make the MVE intrinsics work in C++! (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73268/new/ https://re

[clang] 24364cd - [clang][CodeComplete] Make completion work after initializer lists

Author: Kadir Cetinkaya Date: 2020-01-23T15:32:46+01:00 New Revision: 24364cd12bbfa2e58fa74bfb49d4ea85c64c0951 URL: https://github.com/llvm/llvm-project/commit/24364cd12bbfa2e58fa74bfb49d4ea85c64c0951 DIFF: https://github.com/llvm/llvm-project/commit/24364cd12bbfa2e58fa74bfb49d4ea85c64c0951.dif

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73271 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/Sema.h clang

[PATCH] D73177: [clang][CodeComplete] Make completion work after initializer lists

This revision was automatically updated to reflect the committed changes. Closed by commit rG24364cd12bbf: [clang][CodeComplete] Make completion work after initializer lists (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73177/

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:179 + if (const auto *While = dyn_cast(LoopStmt)) { +if (const auto *LoopVarDecl = While->getConditionVariable()) { + if (const Expr *Init = LoopVarDecl->getIni

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 updated this revision to Diff 239884. njames93 added a comment. - Small refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72448/new/ https://reviews.llvm.org/D72448 Files: clang-tools-extra/clang-tidy/readability/RedundantStringIni

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:383 + } else { +static llvm::Regex Matcher("(^((W[Mm])|(wm))ain([_A-Z]|$))|([a-z0-9_]W[Mm]" +

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62138 tests passed, 0 failed and 808 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

tejohnson marked 2 inline comments as done. tejohnson added inline comments. Comment at: llvm/lib/Transforms/IPO/GlobalSplit.cpp:116 +if (GV.hasMetadata(LLVMContext::MD_vcall_visibility)) + SplitGV->setVCallVisibilityMetadata(GV.getVCallVisibility()); } --

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

tejohnson updated this revision to Diff 239888. tejohnson marked an inline comment as done. tejohnson added a comment. Test GlobalSplit handling of vcall_visibility metadata Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71907/new/ https://reviews.l

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62130 tests passed, 0 failed and 808 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 2 warnings

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nit: maybe mention "top-level" in the patch? Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4731 +static RecordDecl *getAsRecordDecl(const QualType BaseType) { + i

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 239890. tejohnson added a comment. Implement suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen

[PATCH] D65994: Extended FPOptions with new attributes

sepavloff updated this revision to Diff 239893. sepavloff added a comment. Rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65994/new/ https://reviews.llvm.org/D65994 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Bas

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 239891. balazske added a comment. Added garbage collection and better problem detection. Without preventing garbage collection it is not possible to improve the checker (in this way). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D72467: Remove "mask" operand from shufflevector.

spatel added inline comments. Comment at: llvm/include/llvm/IR/Constants.h:1220 + /// Assert that this is an shufflevector and return the mask. See class + /// ShuffleVectorInst for a description of the mask representation. an shufflevector -> a shufflevector

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 _

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71907/new/ https://reviews.llvm.org/D71907 _

[PATCH] D73274: [Alignment][NFC] Use Align with CreateAlignedStore

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, hiraditya, nhaehnle, jvesely, arsenm. Herald added a reviewer: bollu. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 updated this revision to Diff 239902. njames93 added a comment. - Added checks for access specifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/ https://reviews.llvm.org/D73098 Files: clang-tools-extra/clang-tidy/readabilit

[PATCH] D73274: [Alignment][NFC] Use Align with CreateAlignedStore

gchatelet updated this revision to Diff 239903. gchatelet added a comment. - Improving DataLayout Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73274/new/ https://reviews.llvm.org/D73274 Files: clang/lib/CodeGen/CGBlocks.cpp clang/lib/CodeGen/

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62135 tests passed, 0 failed and 812 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73274: [Alignment][NFC] Use Align with CreateAlignedStore

courbet accepted this revision. courbet added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/DataLayout.h:504 /// Returns the minimum ABI-required alignment for the specified type. + /// TODO: Deprecate this function once mi

[PATCH] D73274: [Alignment][NFC] Use Align with CreateAlignedStore

gchatelet updated this revision to Diff 239906. gchatelet marked 5 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73274/new/ https://reviews.llvm.org/D73274 Files: clang/lib/C

[clang] 49f7bc9 - [hip] Remove `-Werror=format-nonliteral`

Author: Michael Liao Date: 2020-01-23T11:02:11-05:00 New Revision: 49f7bc9e1e50eb8f6e065f97585b3bf0bcc23d5c URL: https://github.com/llvm/llvm-project/commit/49f7bc9e1e50eb8f6e065f97585b3bf0bcc23d5c DIFF: https://github.com/llvm/llvm-project/commit/49f7bc9e1e50eb8f6e065f97585b3bf0bcc23d5c.diff

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman added a comment. In D72647#1833203 , @sammccall wrote: > Let's make the minimal change here and land this. Done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/ https://reviews.llvm.org/D

[PATCH] D73224: [hip] Remove `-Werror=format-nonliteral`

This revision was automatically updated to reflect the committed changes. Closed by commit rG49f7bc9e1e50: [hip] Remove `-Werror=format-nonliteral` (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D73224?vs=239683&id=239910#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman updated this revision to Diff 239907. dgoldman added a comment. - Swap to stringset and simpler way of tracking modified files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/ https://reviews.llvm.org/D72647 Files: clang-tools-e

[clang] f3c508f - [OPENMP]Fix use of local allocators in allocate clauses.

Author: Alexey Bataev Date: 2020-01-23T11:04:14-05:00 New Revision: f3c508fe91606c7383c812838b07ed5433a00dcf URL: https://github.com/llvm/llvm-project/commit/f3c508fe91606c7383c812838b07ed5433a00dcf DIFF: https://github.com/llvm/llvm-project/commit/f3c508fe91606c7383c812838b07ed5433a00dcf.diff

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:132 } + return false; Don't change formatting of code this patch doesn't need to touch Comment at: clang-tools-extra/clang-tidy/bugpro

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + ebevhan wrote: > rjmccall wrote: > > If the maximum expressible value is *k*, and the fully-precise > > multiplication yield

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 239913. serge-sans-paille added a comment. Remove extra new lines. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 Files: clang/include

[clang] 59f9522 - [Alignment][NFC] Use Align with CreateAlignedStore

Author: Guillaume Chatelet Date: 2020-01-23T17:34:32+01:00 New Revision: 59f95222d4c5e997342b0514984823a99a16d44b URL: https://github.com/llvm/llvm-project/commit/59f95222d4c5e997342b0514984823a99a16d44b DIFF: https://github.com/llvm/llvm-project/commit/59f95222d4c5e997342b0514984823a99a16d44b.

[PATCH] D73229: [analyzer] Improve FuchsiaHandleChecker's diagnostic messages

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Nice! These are indeed useful when multiple things can happen. You may also consider adding stack hints a-la `MallocChecker` (i.e., "Returning; handle was closed"). Comment at: c

[PATCH] D73274: [Alignment][NFC] Use Align with CreateAlignedStore

This revision was automatically updated to reflect the committed changes. Closed by commit rG59f95222d4c5: [Alignment][NFC] Use Align with CreateAlignedStore (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73274/new/ https://r

[PATCH] D72467: Remove "mask" operand from shufflevector.

ctetreau added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:2544 +SmallVector IntMask; +ShuffleVectorInst::getShuffleMask(cast(Mask), IntMask); +return CreateShuffleVector(V1, V2, IntMask, Name); spatel wrote: > Add an assert that Mas

[PATCH] D71566: New checks for fortified sprintf

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62135 tests passed, 0 failed and 812 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D73229: [analyzer] Improve FuchsiaHandleChecker's diagnostic messages

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:363 } else -return ""; +return std::string{}; }); NoQ wrote: > What was

[PATCH] D73229: [analyzer] Improve FuchsiaHandleChecker's diagnostic messages

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:363 } else -return ""; +return std::string{}; }); xazax.hun wrote: > NoQ wrote: > > What was wrong with good old `""`? >

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

peter.smith added a comment. Although this particular commit will not be at fault, it is the option that enables the feature which is the earliest I can bisect the fault to. There are 3 files in linux that assert fail on the Implement the 'patchable-function attribute'. The files in question ar

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

NoQ added a comment. Thank you everybody for unbreaking us! 🙏 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72982/new/ https://reviews.llvm.org/D72982 ___ cfe-commits mailing list cfe-commits@lists.llv

  1   2   3   >