tejohnson marked 2 inline comments as done. tejohnson added inline comments.
================ Comment at: llvm/lib/Transforms/IPO/GlobalSplit.cpp:116 + if (GV.hasMetadata(LLVMContext::MD_vcall_visibility)) + SplitGV->setVCallVisibilityMetadata(GV.getVCallVisibility()); } ---------------- evgeny777 wrote: > I think this needs a test. Removal of this code doesn't break anything Adding some checking in a GlobalSplit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71907/new/ https://reviews.llvm.org/D71907 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
