[PATCH] D69585: PerformPendingInstatiations() already in the PCH

ABataev added a comment. I don't see any crashes in OpenMP tests, other tests just must be updated by the author, if this patch will ever going to be landed. I don't think it is a good idea to have a not fully functional implementation, even guarded by the option. CHANGES SINCE LAST ACTION

[clang] 60d3947 - [remark][diagnostics] Using clang diagnostic handler for IR input files

Author: Rong Xu Date: 2020-01-14T15:44:57-08:00 New Revision: 60d39479221d6bc09060f7816bcd7c54eb286603 URL: https://github.com/llvm/llvm-project/commit/60d39479221d6bc09060f7816bcd7c54eb286603 DIFF: https://github.com/llvm/llvm-project/commit/60d39479221d6bc09060f7816bcd7c54eb286603.diff LOG:

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

This revision was automatically updated to reflect the committed changes. Closed by commit rG60d39479221d: [remark][diagnostics] Using clang diagnostic handler for IR input files (authored by xur). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D72523?vs=237810

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

emilio created this revision. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Sign-extension is not guaranteed by the ABI, and thus the callee cannot assume it. This fixes PR44228 and PR12207. With these changes, there

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

rnk added a comment. I think I liked the first version of this patch better. I would say, if the AST after instantiation remains the same as it was before D69950 , then the first one seems like the right fix. The pattern AST will just be missing a node to repres

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

hubert.reinterpretcast added inline comments. Comment at: llvm/include/llvm/Support/FileUtilities.h:38 +#if defined(_AIX) + SmallString<128> getLoadModuleFilenameForFunctionAIX(void (*Func)(void)); +#endif This should be an internal function in the `.cpp` file i

[clang] c9ee5e9 - Fix windows bot failures in c410adb092c9cb51ddb0b55862b70f2aa8c5b16f

Author: Rong Xu Date: 2020-01-14T16:32:17-08:00 New Revision: c9ee5e996e3c89a751a35e8b771870e0ec24f3c0 URL: https://github.com/llvm/llvm-project/commit/c9ee5e996e3c89a751a35e8b771870e0ec24f3c0 DIFF: https://github.com/llvm/llvm-project/commit/c9ee5e996e3c89a751a35e8b771870e0ec24f3c0.diff LOG:

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

wristow updated this revision to Diff 238143. wristow retitled this revision from "ix -ffast-math/-ffp-contract interaction" to "Fix -ffast-math/-ffp-contract interaction". wristow added a comment. Addressed comments from @hfinkel . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72675/ne

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

ychen updated this revision to Diff 238142. ychen edited the summary of this revision. ychen added a comment. - fix test when clang is the host compiler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

tejohnson added a comment. Overall I like this approach. Comment at: llvm/lib/Passes/PassBuilder.cpp:246 -static bool isOptimizingForSize(PassBuilder::OptimizationLevel Level) { - switch (Level) { - case PassBuilder::O0: - case PassBuilder::O1: - case PassBuilder::O2: -

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

efriedma added a comment. Okay. Please let me know if you want me to review anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71387/new/ https://reviews.llvm.org/D71387 ___ cfe-commits mailing l

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

rnk updated this revision to Diff 238147. rnk added a comment. - use %clang_cc1 as possible in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72405/new/ https://reviews.llvm.org/D72405 Files: clang/lib/Lex/PPDirectives.cpp clang/test/PCH/

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 ___

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D72405#1818237 , @zahen wrote: > I had no luck converting the CHECK-FOO & CHECK-NOFOO tests to use `-verify` > because the errors were reported against "(

[clang] 0f9cf42 - Allow /D flags absent during PCH creation under msvc-compat

Author: Zachary Henkel Date: 2020-01-14T17:26:01-08:00 New Revision: 0f9cf42facaf9eff47dc0b9eb7e6ed8803d3bc3b URL: https://github.com/llvm/llvm-project/commit/0f9cf42facaf9eff47dc0b9eb7e6ed8803d3bc3b DIFF: https://github.com/llvm/llvm-project/commit/0f9cf42facaf9eff47dc0b9eb7e6ed8803d3bc3b.diff

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9cf42facaf: Allow /D flags absent during PCH creation under msvc-compat (authored by zahen, committed by rnk). Changed prior to commit: https://reviews.llvm.org/D72405?vs=238147&id=238149#toc Reposit

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61859 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[clang] 8e78025 - [X86] ABI compat bugfix for MSVC vectorcall

Author: Reid Kleckner Date: 2020-01-14T17:49:13-08:00 New Revision: 8e780252a7284be45cf1ba224cabd884847e8e92 URL: https://github.com/llvm/llvm-project/commit/8e780252a7284be45cf1ba224cabd884847e8e92 DIFF: https://github.com/llvm/llvm-project/commit/8e780252a7284be45cf1ba224cabd884847e8e92.diff

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rjmccall wrote: > rnk wrote: > > rnk wrot

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 marked 3 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:6 + + Flags use of the `C` standard library functions 'memset', 'memcpy' and + 'memcmp' and similar derivatives on non-trivial type

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 238153. njames93 marked an inline comment as done. njames93 added a comment. - double ticks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files: clang-tools-extra/

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk updated this revision to Diff 238152. rnk marked 2 inline comments as done. rnk added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72114/new/ https://reviews.llvm.org/D72114 Files: clang/include/clang/CodeGen/CGFunctionI

[PATCH] D72110: [X86] ABI compat bugfix for MSVC vectorcall

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e780252a728: [X86] ABI compat bugfix for MSVC vectorcall (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72110/new/ https://reviews.llvm.o

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61850 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61871 tests passed, 1 failed and 781 were skipped. failed: Clang.PCH/ms-pch-macro.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your ch

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

ormris added a comment. Hi Zach, The tests in this patch are failing on this PS4 windows bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/30273/steps/test-check-all/logs/stdio Thanks! Repository: rG LLVM Github Monorepo

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kbobyrev added a subscriber: hokein. This patch allows the index does to provide a way to distinguish implicit referen

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev added a comment. Changed reviewer to @kadircet because Sam would be out until the end of the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72638/new/ https://reviews.llvm.org/D72638 ___

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

tejohnson added a comment. From an LTO perspective, this seems fine for the reasons we discussed here. I looked through the patch and have a few comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:818 + if (TM) { +TM->initializeOptionsWithModuleMetadata(*TheModule);

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev added a comment. The patch could be shorter and slightly less confusing if I preserved 1:1 `RefKind::Implicit` <-> `index::SymbolKind::Implicit` relation, but I thought we might want to keep `RefKind` being 1 byte so that we don't waste unnecessary memory. Also, since we might want to

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61855 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] c6e6988 - Modify test to use -S instead of -c so that it works when an external assembler is used that is not present.

Author: Douglas Yung Date: 2020-01-14T18:58:18-08:00 New Revision: c6e69880ae4d9ce4d27bf046292a0a20c3ab3540 URL: https://github.com/llvm/llvm-project/commit/c6e69880ae4d9ce4d27bf046292a0a20c3ab3540 DIFF: https://github.com/llvm/llvm-project/commit/c6e69880ae4d9ce4d27bf046292a0a20c3ab3540.diff

[clang] 1b5404a - PR44540: Prefer an inherited default constructor over an initializer

Author: Richard Smith Date: 2020-01-14T19:29:50-08:00 New Revision: 1b5404aff37953ce4c10191d04872ed7c2dc6548 URL: https://github.com/llvm/llvm-project/commit/1b5404aff37953ce4c10191d04872ed7c2dc6548 DIFF: https://github.com/llvm/llvm-project/commit/1b5404aff37953ce4c10191d04872ed7c2dc6548.diff

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

zahen added a comment. Wild guess is that `2> %t.err` should be removed from the `-verify` lines? That change passes in the single env I have access to. @rnk any idea what might be going on? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72405/new

[clang] d18fbfc - Relax the rules around objc_alloc and objc_alloc_init optimizations.

Author: Pierre Habouzit Date: 2020-01-14T19:48:33-08:00 New Revision: d18fbfc09720009c0dc6a1ddf315402ee0a7751d URL: https://github.com/llvm/llvm-project/commit/d18fbfc09720009c0dc6a1ddf315402ee0a7751d DIFF: https://github.com/llvm/llvm-project/commit/d18fbfc09720009c0dc6a1ddf315402ee0a7751d.dif

[PATCH] D71682: Relax the rules around objc_alloc and objc_alloc_init optimizations.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd18fbfc09720: Relax the rules around objc_alloc and objc_alloc_init optimizations. (authored by MadCoder). Changed prior to commit: https://reviews.llvm.org/D71682?vs=234644&id=238161#toc Repository:

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

MadCoder created this revision. MadCoder added reviewers: ahatanak, arphaman, dexonsmith, erik.pilkington. MadCoder added a project: clang. Herald added a subscriber: cfe-commits. Sending a message to `self` when it is const and within a class method is safe because we know that `self` is the Cla

[clang] a60e892 - [ODRHash] Fix wrong error message with bitfields and mutable.

Author: Weverything Date: 2020-01-14T21:12:15-08:00 New Revision: a60e8927297005898b10a46300d929ba5cf7833c URL: https://github.com/llvm/llvm-project/commit/a60e8927297005898b10a46300d929ba5cf7833c DIFF: https://github.com/llvm/llvm-project/commit/a60e8927297005898b10a46300d929ba5cf7833c.diff L

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM The principle of override here is consistent with MC (D72738 ). So I think this patch is better than D72227 . Repository:

[PATCH] D72227: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

skan abandoned this revision. skan added a comment. The override principle of driver should keep same with MC (D72738 ). D72463 is better, so I prefer to abandon this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 5ca24d0 - [Driver][X86] Add -malign-branch* and -mbranches-within-32B-boundaries

Author: Fangrui Song Date: 2020-01-14T21:57:06-08:00 New Revision: 5ca24d09aefaedf8e4148c7fce4b4ab0c4ecc72a URL: https://github.com/llvm/llvm-project/commit/5ca24d09aefaedf8e4148c7fce4b4ab0c4ecc72a DIFF: https://github.com/llvm/llvm-project/commit/5ca24d09aefaedf8e4148c7fce4b4ab0c4ecc72a.diff

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ca24d09aefa: [Driver][X86] Add -malign-branch* and -mbranches-within-32B-boundaries (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D72463?vs=238120&id=238167#toc Repository:

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

rtrieu added a comment. Heads up in case it affects you refactoring work: While looking through this code, I found a bug I previously made. I fixed it with a small change, but that lies in the middle of your refactoring during FieldDecl handling. The change is here: https://reviews.llvm.org/r

[clang] c42116c - Fix up ms-pch-macro.c test to pass on non-Windows

Author: Reid Kleckner Date: 2020-01-14T22:19:30-08:00 New Revision: c42116cc653ae1618cc49dab367d9f6addd8cfd9 URL: https://github.com/llvm/llvm-project/commit/c42116cc653ae1618cc49dab367d9f6addd8cfd9 DIFF: https://github.com/llvm/llvm-project/commit/c42116cc653ae1618cc49dab367d9f6addd8cfd9.diff

<    1   2   3