hubert.reinterpretcast added inline comments.
================
Comment at: llvm/include/llvm/Support/FileUtilities.h:38
+#if defined(_AIX)
+ SmallString<128> getLoadModuleFilenameForFunctionAIX(void (*Func)(void));
+#endif
----------------
This should be an internal function in the `.cpp` file implementing the
following function. It should not be declared in an interface `.h` file.
================
Comment at: llvm/include/llvm/Support/FileUtilities.h:42
+ template <typename FuncAddrType>
+ SmallString<128> getLoadModuleFilenameForFunction(FuncAddrType FuncAddr) {
+ if (!FuncAddr) {
----------------
The description of `FileUtilities.h` does not seem to encompass what this
function does. Perhaps `SystemUtils.h` works better? fyi, when posting patches
to Phabricator, the "full context" (using `diff -U <large number>`) should be
provided.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72736/new/
https://reviews.llvm.org/D72736
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
