[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

kpn created this revision. kpn added a reviewer: uweigand. Herald added a project: clang. Herald added a subscriber: cfe-commits. When constrained floating point is enabled the SystemZ-specific builtins don't use constrained intrinsics in some cases. Fix that. Repository: rG LLVM Github Monor

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov created this revision. kpyzhov added a reviewer: yaxunl. kpyzhov added a project: AMDGPU. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl, arsenm. Herald added projects: clang, LLVM. Added declarations of MFMA built-

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 238036. njames93 added a comment. - Rebase from trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp c

[PATCH] D72089: [Syntax] Build declarator nodes

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61848 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

MaskRay added a comment. In D65616#1819581 , @serge-sans-paille wrote: > (back on that one) The default in clang is implicitly > `-fno-semantic-interposition`. I think we can safely support it, and either > warn or error on `-fsemantic-interposition`.

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:29 +public: + RenamerClangTidyCheck(StringRef CheckName, ClangTidyContext *Context); + ~RenamerClangTidyCheck(); Should this be protected as this class should

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

MaskRay created this revision. MaskRay added reviewers: hfinkel, tstellar, Romain-Geissler-1A, serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fedora wants to build projects with -fno-semantic-interposition (e.g. https://fedoraproject.org/wiki/Changes/Pyt

[PATCH] D72334: [Syntax] Build nodes for template declarations.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61849 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

ychen updated this revision to Diff 238042. ychen added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-debug-pm.c

[clang-tools-extra] 36fcbb8 - Added readability-qualified-auto check

Author: Nathan James Date: 2020-01-14T14:06:46-05:00 New Revision: 36fcbb838c8f293f46bfed78c6ed8c177f1e3485 URL: https://github.com/llvm/llvm-project/commit/36fcbb838c8f293f46bfed78c6ed8c177f1e3485 DIFF: https://github.com/llvm/llvm-project/commit/36fcbb838c8f293f46bfed78c6ed8c177f1e3485.diff

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked 9 inline comments as done. tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:559 + if (!CodeGenOpts.ThinLTOIndexFile.empty()) +MPM.add(createLowerTypeTestsPass(/*ExportSummary=*/nullptr, + /*Im

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 238048. tejohnson marked 2 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913 Files: clang/lib/Cod

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the new check, I've commit on your behalf in 36fcbb838c8f293f46bfed78c6ed8c177f1e3485 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

logan-5 marked an inline comment as done. logan-5 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:29 +public: + RenamerClangTidyCheck(StringRef CheckName, ClangTidyContext *Context); + ~RenamerClangTidyCheck(); njam

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60543 tests passed, 1 failed and 726 were skipped. failed: Clang.CodeGen/thinlto-debug-pm.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format

[clang] 88b8cb7 - Fix NetBSD bot after b4a99a061f517e60985667e39519f60186cbb469 ([Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation)

Author: Alexandre Ganea Date: 2020-01-14T14:26:50-05:00 New Revision: 88b8cb7215d4333ab990c99f21c7f92262ef02ef URL: https://github.com/llvm/llvm-project/commit/88b8cb7215d4333ab990c99f21c7f92262ef02ef DIFF: https://github.com/llvm/llvm-project/commit/88b8cb7215d4333ab990c99f21c7f92262ef02ef.dif

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61851 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added a comment. Fixed NetBSD as suggested in rG88b8cb7215d4333ab990c99f21c7f92262ef02ef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60543 tests passed, 1 failed and 726 were skipped. failed: Clang.CodeGen/thinlto-debug-pm.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

lenary marked 2 inline comments as done. lenary added a comment. In D72624#1817464 , @tejohnson wrote: > Thank you for your feedback! It has been very helpful. > I'm not sure if ThinLTOCodeGenerator.cpp and LTOBackend.cpp were > intentionally left out

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/NotTrivialTypesLibcMemoryCallsCheck.cpp:33-44 +static const char BuiltinMemSet[] = "::std::memset;" +"::memset;"; +static const char BuiltinMemCpy[] = "::std::memcpy

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 238052. njames93 marked 13 inline comments as done. njames93 added a comment. - Fix a few nits, extra names will follow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

lenary updated this revision to Diff 238053. lenary added a comment. Herald added subscribers: mgorny, MatzeB. Address some review feedback. This patch remains incomplete with regards to module flags and ThinLTO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61849 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61849 tests passed, 1 failed and 781 were skipped. failed: Clang.CodeGen/thinlto-debug-pm.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format

[clang] 48bad08 - [OPENMP]Improve handling of possibly incorrectly mapped types.

Author: Alexey Bataev Date: 2020-01-14T14:47:34-05:00 New Revision: 48bad08aa3b3bf6ad5dabe858fa655a623757395 URL: https://github.com/llvm/llvm-project/commit/48bad08aa3b3bf6ad5dabe858fa655a623757395 DIFF: https://github.com/llvm/llvm-project/commit/48bad08aa3b3bf6ad5dabe858fa655a623757395.diff

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61850 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72724/new/ https://reviews.llvm.org/D72724 _

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

MaskRay updated this revision to Diff 238065. MaskRay added a comment. Use Flag<> instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72724/new/ https://reviews.llvm.org/D72724 Files: clang/include/clang/Driver/Options.td clang/test/Driver/c

[clang] 5d1b3ba - [Driver] Ignore -fno-semantic-interposition

Author: Fangrui Song Date: 2020-01-14T12:09:13-08:00 New Revision: 5d1b3ba687690bbb37f911f66a2c2c5f19d60032 URL: https://github.com/llvm/llvm-project/commit/5d1b3ba687690bbb37f911f66a2c2c5f19d60032 DIFF: https://github.com/llvm/llvm-project/commit/5d1b3ba687690bbb37f911f66a2c2c5f19d60032.diff

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61807 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 updated this revision to Diff 238064. logan-5 marked 6 inline comments as done. logan-5 added a comment. Renamed check option from "Whitelist" to "AllowedIdentifiers". Added note about missing checks in documentation. Changed to use a %select for diagnostic text. Some nits. The check do

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:27-34 +static const char NonReservedMessage[] = +"declaration uses identifier '%0', which is not a reserved " +"identifier"; +static const char GlobalUnderscoreMe

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

serge-sans-paille added a comment. @MaskRay: is that okay with you if I start implementing -fsemantic-interposition based on `dso_preemptable`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72724/new/ https://reviews.llvm.org/D72724 ___

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

MaskRay added a comment. In D72724#1820362 , @serge-sans-paille wrote: > LGTM I don't follow Fedora news. It is just that a friend informed me of this -fno-semantic-interposition movement two days ago and I postulated that it was your motivation to pi

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d1b3ba68769: [Driver] Ignore -fno-semantic-interposition (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72724/new/ https://reviews.ll

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

MaskRay added a comment. In D72724#1820392 , @serge-sans-paille wrote: > @MaskRay: is that okay with you if I start implementing > -fsemantic-interposition based on `dso_preemptable`? I haven't done anything in this area. Go ahead:) I'd like to help or

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61856 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

MaskRay added a comment. Ah, I'll want to figure out how to emit local aliases to dso_local as a follow-up of D72197 , but that should be orthogonal to what you want to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

serge-sans-paille added a comment. Obsoleted by https://reviews.llvm.org/D72724, closing. Thanks @Romain-Geissler-1A for triggering that patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65616/new/ https://reviews.llvm.org/D65616 __

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

ychen updated this revision to Diff 238071. ychen added a comment. - rebase & clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thi

[PATCH] D70689: [analyzer] Fix SARIF column locations

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ee616a710bc: [analyzer] Fix SARIF column locations (authored by jranieri-grammatech). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70689/new/ https://revi

[clang] 651128f - [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

Author: Amy Huang Date: 2020-01-14T12:40:21-08:00 New Revision: 651128f557229e79598e22102edb7fad3bf288c0 URL: https://github.com/llvm/llvm-project/commit/651128f557229e79598e22102edb7fad3bf288c0 DIFF: https://github.com/llvm/llvm-project/commit/651128f557229e79598e22102edb7fad3bf288c0.diff LOG

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG651128f55722: [DebugInfo] Add option to clang to limit debug info that is emitted for classes. (authored by akhuang). Changed prior to commit: https://reviews.llvm.org/D72427?vs=237811&id=238077#toc Re

[clang] 986202f - [clang][test][NFC] Use more widely supported sanitizer for file dependency tests

Author: Jan Korous Date: 2020-01-14T12:55:11-08:00 New Revision: 986202fad41529af8288aca54f2ff62d4c501d71 URL: https://github.com/llvm/llvm-project/commit/986202fad41529af8288aca54f2ff62d4c501d71 DIFF: https://github.com/llvm/llvm-project/commit/986202fad41529af8288aca54f2ff62d4c501d71.diff LO

[PATCH] D68115: Zero initialize padding in unions

vitalybuka added a comment. In D68115#1819418 , @aaron.ballman wrote: > In D68115#1811091 , @lebedev.ri > wrote: > > > In D68115#1811089 , > > @hubert.reinterpretcast wrot

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61858 tests passed, 1 failed and 781 were skipped. failed: Clang.CodeGen/thinlto-debug-pm.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format

[PATCH] D72730: [clang-tools-extra] run-clang-tidy -export-fixes exports only fixes, not all warnings

AlexanderLanin added a comment. Important: I'm not a python expert. It works fine as far as I can tell. I would feel better if someone with more than a day python experience would say that it is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D72730: [clang-tools-extra] run-clang-tidy -export-fixes exports only fixes, not all warnings

AlexanderLanin created this revision. AlexanderLanin added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. AlexanderLanin added a comment. Important: I'm not a python expert. It works fine as far as I can tell. I would feel better if someone wi

[clang] 1ca51c0 - [Driver][test] Fix Driver/hexagon-toolchain-elf.c for -DCLANG_DEFAULT_LINKER=lld builds

Author: Fangrui Song Date: 2020-01-14T13:18:23-08:00 New Revision: 1ca51c06729d7f7326fcc2a826e07d1c92158dfd URL: https://github.com/llvm/llvm-project/commit/1ca51c06729d7f7326fcc2a826e07d1c92158dfd DIFF: https://github.com/llvm/llvm-project/commit/1ca51c06729d7f7326fcc2a826e07d1c92158dfd.diff

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 238082. njames93 added a comment. - fix spelling mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt cl

[PATCH] D72668: [Driver][test] Fix Driver/hexagon-toolchain-elf.c for -DCLANG_DEFAULT_LINKER=lld builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca51c06729d: [Driver][test] Fix Driver/hexagon-toolchain-elf.c for… (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D72668?vs=237816&id=238085#toc Repository: rG LLVM Github

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

lebedev.ri added a comment. Happy to see this check! Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- New alias :doc:`performance-prefer-pre-increment + ` to + :doc:`llvm-prefer-pre-increment + ` was added. Are we **really** **really** sure thi

[PATCH] D69779: -fmodules-codegen should not emit extern templates

llunak updated this revision to Diff 238086. llunak added a comment. I've updated the test as requested. However I've noticed that a PCH-based test for this relies on https://reviews.llvm.org/D69585 . The fix works (of course), but it requires a PCH/module with the instantiation. CHANGES SINC

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61861 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

nridge added a comment. In D72041#1800189 , @sammccall wrote: > - the allSelectedNodes API on SelectionTree feels non-orthogonal: it's only > meaningful here because the input happened to be a point and thus touches a > single token and therefore node. I

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added a comment. In D68115#1820462 , @vitalybuka wrote: > So if I understand this the proposal is to have something like > -fzero-union-padding which is off by default. > When it's OFF compiler will continue to do whatever it does

[PATCH] D68115: Zero initialize padding in unions

aaron.ballman added a comment. In D68115#1820462 , @vitalybuka wrote: > I would be happy to finish this patch if we agree on something. > > So if I understand this the proposal is to have something like > -fzero-union-padding which is off by default. > W

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

tejohnson added a comment. In D72624#1820281 , @lenary wrote: > In D72624#1817464 , @tejohnson wrote: > > > > > > Thank you for your feedback! It has been very helpful. > > > I'm not sure if ThinLTOCodeGenerator.cpp

[PATCH] D69779: -fmodules-codegen should not emit extern templates

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks for your patience! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69779/new/ https://reviews.llvm.org/D69779 ___

[PATCH] D69779: -fmodules-codegen should not emit extern templates

llunak updated this revision to Diff 238089. llunak added a comment. This version uses a module based on the code posted above. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69779/new/ https://reviews.llvm.org/D69779 Files: clang/lib/Serialization/ASTWriterDecl.cpp clang/test/Modul

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

rjmccall added a comment. > Well, just like for all the other FP builder methods, you can use the > setIsFPConstrained method on the builder object to switch between strict and > non-strict mode. Does this not suffice, or is there anything particular about > the comparisons that would require a

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- New alias :doc:`performance-prefer-pre-increment + ` to + :doc:`llvm-prefer-pre-increment + ` was added. lebedev.ri wrote:

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

dblaikie added a comment. (just a general comment that this code review should be only in service of the design discussion happening on llvm-dev - please don't approve/commit this without closing out the design discussion there if there are actionable conclusions from this review) Repository:

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

lebedev.ri added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- New alias :doc:`performance-prefer-pre-increment + ` to + :doc:`llvm-prefer-pre-increment + ` was added. njames93 wrote: > lebedev.ri wrote: > > Are we **really**

[clang] a3490e3 - Remove trailing `;`. NFC.

Author: Michael Liao Date: 2020-01-14T16:52:20-05:00 New Revision: a3490e3e3d38d502179329f76138d96c5b2bab88 URL: https://github.com/llvm/llvm-project/commit/a3490e3e3d38d502179329f76138d96c5b2bab88 DIFF: https://github.com/llvm/llvm-project/commit/a3490e3e3d38d502179329f76138d96c5b2bab88.diff

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

tejohnson added a comment. In D72624#1820598 , @dblaikie wrote: > (just a general comment that this code review should be only in service of > the design discussion happening on llvm-dev - please don't approve/commit > this without closing out the design

[PATCH] D68115: Zero initialize padding in unions

vitalybuka added a comment. In D68115#1820579 , @aaron.ballman wrote: > In D68115#1820462 , @vitalybuka > wrote: > > > I would be happy to finish this patch if we agree on something. > > > > So if I understand thi

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

nridge updated this revision to Diff 238094. nridge added a comment. Revise the approach to treat non-first expansions as not-selected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72041/new/ https://reviews.llvm.org/D72041 Files: clang-tools-ex

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

tycho added a subscriber: merge_guards_bot. tycho added a comment. In D72404#1820461 , @merge_guards_bot wrote: > {icon times-circle color=red} Unit tests: fail. 61858 tests passed, 1 failed > and 781 were skipped. > > failed: Clang.CodeGen/thinlto-deb

[clang] a48600c - [OPENMP]Do not emit special virtual function for NVPTX target.

Author: Alexey Bataev Date: 2020-01-14T16:59:22-05:00 New Revision: a48600c0a653d34f4af760f117755ed1776adf9d URL: https://github.com/llvm/llvm-project/commit/a48600c0a653d34f4af760f117755ed1776adf9d DIFF: https://github.com/llvm/llvm-project/commit/a48600c0a653d34f4af760f117755ed1776adf9d.diff

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61848 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D44352: [Concepts] Type Constraints

rsmith accepted this revision. rsmith added a comment. Some cleanups (mainly parameters that are no longer necessary), then this is good to go. Thanks! Comment at: clang/include/clang/Basic/LangOptions.def:146 LANGOPT(DllExportInlines , 1, 1, "dllexported classes dllexport i

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith updated this revision to Diff 238099. rsmith added a comment. Herald added subscribers: kbarton, nemanjai. Rebase and slightly expand release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 Fi

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. Herald added a subscriber: wuzish. Ping, I don't think I have any actionable feedback here and I'd like to get this landed before Clang 10 branches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.l

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

ychen added a comment. In D72404#1820628 , @tycho wrote: > In D72404#1820461 , > @merge_guards_bot wrote: > > > {icon times-circle color=red} Unit tests: fail. 61858 tests passed, 1 > > failed and 781 were skipped

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 238104. njames93 added a comment. - moved check from llvm module to performance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/l

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

Jonathan.Crowther created this revision. Jonathan.Crowther added reviewers: hubert.reinterpretcast, xingxue. Herald added subscribers: llvm-commits, cfe-commits, arphaman, hiraditya. Herald added projects: clang, LLVM. Implemented (for AIX) a function to take any function and return the path of t

[PATCH] D72675: ix -ffast-math/-ffp-contract interaction

wristow marked 3 inline comments as done. wristow added a comment. Thanks for the quick feedback @hfinkel Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2721 if (!MathErrno && AssociativeMath && ReciprocalMath && !SignedZeros && - !TrappingMath) + !TrappingMath

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61861 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

lebedev.ri added a comment. In D72553#1820692 , @njames93 wrote: > - moved check from llvm module to performance Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.or

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

mtrofin updated this revision to Diff 238107. mtrofin marked 2 inline comments as done. mtrofin added a comment. Alternative: expose speedup/size components to more closely align with legacy PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72547/new

[PATCH] D69779: -fmodules-codegen should not emit extern templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG729530f68fe1: -fmodules-codegen should not emit extern templates (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69779/new/ https://revi

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya updated this revision to Diff 238106. ilya added a comment. Address rsmith's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaChec

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

arsenm added a comment. LGTM Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:487 +def FeatureMfma1Insts : SubtargetFeature<"mfma1-insts", + "HasMfma1Insts", We already have the HasMAIInsts feature Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya marked 4 inline comments as done. ilya added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13384 case Stmt::MemberExprClass: { expr = cast(expr)->getBase(); break; rsmith wrote: > ilya wrote: > > rsmith wrote: > > > Hm

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 238114. njames93 added a comment. - remove `This check` from docs... again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files: clang-tools-extra/clang-tidy/cert/C

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

lenary added a comment. @efriedma To keep you in the loop, D72624 is the patch to add a target hook for setting the TargetMachine options based on module metadata. That patch does not add any RISC-V specific functionality, it only lays the groundwork for it.

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:112 + + Flags use of the `C` standard library functions 'memset', 'memcpy' and + 'memcmp' and similar derivatives on non-trivial types. Please use double back-ticks to h

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61849 tests passed, 1 failed and 781 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_class/try_lock.pass.cpp {icon question-circle col

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbc9d22e49b4: make -fmodules-codegen and -fmodules-debuginfo work also with PCHs (authored by llunak). Changed prior to commit: https://reviews.llvm.org/D69778?vs=227634&id=238115#toc Repository: rG

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

lenary added a comment. One thing to note about my patch, above: I have not made the TargetMachine DataLayout non-const, but I wanted to ensure that this might be possible in future, which is why calling `initializeOptionsWithModuleMetadata` must be done before the first call to `createDataLayo

[clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

Author: Alexey Bataev Date: 2020-01-14T18:12:06-05:00 New Revision: 23058f9dd4d7e18239fd63b6da52549514b45fda URL: https://github.com/llvm/llvm-project/commit/23058f9dd4d7e18239fd63b6da52549514b45fda DIFF: https://github.com/llvm/llvm-project/commit/23058f9dd4d7e18239fd63b6da52549514b45fda.diff

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

MaskRay updated this revision to Diff 238120. MaskRay marked 2 inline comments as done. MaskRay added a comment. Make driver a thin wrapper since we are going to add a master option in MC (D72738 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. Lewis, your latest patch looks good, we just had another run with no new failures. But we know it will have issues with -g. So I think we should not merge it yet. Do you have a version of the patch that creates the labels for the compiler-generated save/restore lib calls

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

hubert.reinterpretcast added inline comments. Comment at: llvm/include/llvm/Support/FileUtilities.h:44 +if (!FuncAddr) { + return ""; +} I'm not sure that this function should handle failure by returning an empty string. The error condition can be m

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61850 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

njames93 added a comment. In D72121#1817733 , @Eugene.Zelenko wrote: > Please also close PRs. Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72121/new/ https://reviews.llvm.org/D72121 ___ cfe

[PATCH] D71848: Allow the discovery of Android NDK's triple-prefixed binaries.

jyknight added a comment. Since this change is not android-only, please update change description, and update some non-android tests. E.g. maybe the tests in clang/test/Driver/linux-ld.c for ubuntu_14.04_multiarch_tree should check the path at which ld is found. While the existing Inputs/ubunt

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61862 tests passed, 1 failed and 781 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_sharedtimedmutex_requirements/thread_sharedtimedmutex_class/try_lock.pass.cpp {icon que

<    1   2   3   >