njames93 marked an inline comment as done. njames93 added inline comments.
================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- New alias :doc:`performance-prefer-pre-increment + <clang-tidy/checks/performance-prefer-pre-increment>` to + :doc:`llvm-prefer-pre-increment + <clang-tidy/checks/llvm-prefer-pre-increment>` was added. ---------------- lebedev.ri wrote: > Are we **really** **really** sure this is the correct relation direction? > This isn't an llvm-specific guideline that may be applicable to other code, > but a known generic C++ guideline that llvm coding guide follows. You're probably right, I added this to llvm first, then thought about alias. Which module should its primary be I'd say performancepersonally. Cppcoreguidelines has [[ https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#enforcement-8 | 1 little note ]] about it but I dont think that justifies putting the check in there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
