Re: [PATCH] D71414: [clangd] Introduce codeblocks

Hi, it is still broken on AArch64 bots, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/21251/steps/ninja%20check%201/logs/stdio Thanks, Yvan On Sat, 14 Dec 2019 at 16:15, Nico Weber via Phabricator via cfe-commits wrote: > > thakis added inline comme

Re: [PATCH] D71414: [clangd] Introduce codeblocks

I was actually watching for buildbots(sent out 6b8ff5e43b405d255259196b6a53a3b5671aa5c7 for fixing some breakages for example) but somehow this breakage mail didn't arrive. buildbots were in bad shape on friday it might've skipped because of that :/ Thanks for fixing this. On Sat, Dec 14, 2019 at

[PATCH] D61549: Fix use of 'is' operator for comparison

Jim added a comment. @j-carl Could you give a Python 3.8 syntax reference for this change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61549/new/ https://reviews.llvm.org/D61549 ___ cfe-commits mailing list cfe-com

[clang-tools-extra] 0f959c8 - [clangd] Get rid of raw string literals in macro calls

Author: Kadir Cetinkaya Date: 2019-12-16T09:17:36+01:00 New Revision: 0f959c87cc7867beb67bfab2d5e3cf90708b2f98 URL: https://github.com/llvm/llvm-project/commit/0f959c87cc7867beb67bfab2d5e3cf90708b2f98 DIFF: https://github.com/llvm/llvm-project/commit/0f959c87cc7867beb67bfab2d5e3cf90708b2f98.dif

Re: [PATCH] D71414: [clangd] Introduce codeblocks

sent out 0f959c87cc7867beb67bfab2d5e3cf90708b2f98 On Mon, Dec 16, 2019 at 9:08 AM Yvan Roux wrote: > Hi, it is still broken on AArch64 bots, logs are available here: > > > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/21251/steps/ninja%20check%201/logs/stdio > > Thanks, > Yv

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

teemperor updated this revision to Diff 233998. teemperor added a comment. - Further reduced test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71201/new/ https://reviews.llvm.org/D71201 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenObjC/debug-info-direct-method.

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

kadircet added a reviewer: kadircet. kadircet added a comment. I think this requires changes in other places too, for example when querying index for the children we rather want to query using the symbolid of template pattern, not the instantiation. Comment at: clang-tools-ex

[PATCH] D70157: Align branches within 32-Byte boundary

annita.zhang added a comment. In D70157#1768338 , @annita.zhang wrote: > In D70157#1768319 , @chandlerc wrote: > > > I'm seeing lots of updates to fix bugs, but no movement for many days on > > both my meta commen

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

kbobyrev updated this revision to Diff 234001. kbobyrev added a comment. Rebase on top of master, fix the build and apply formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71455/new/ https://reviews.llvm.org/D71455 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/c

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

Ka-Ka added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70527/new/ https://reviews.llvm.org/D70527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D66839: Fix stack address builtin for negative numbers

Jim added a comment. I think this checking should be implemented in lib/Sema/SemaChecking.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://reviews.llvm.org/D66839 ___ cfe-commits m

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b9715cb2193: [NFC] Fix typos in Clangd and Clang (authored by kbobyrev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71455/

Re: [PATCH] D71414: [clangd] Introduce codeblocks

Thanks Kadir, bots are back to green :) On Mon, 16 Dec 2019 at 09:18, Kadir Çetinkaya wrote: > > sent out 0f959c87cc7867beb67bfab2d5e3cf90708b2f98 > > On Mon, Dec 16, 2019 at 9:08 AM Yvan Roux wrote: >> >> Hi, it is still broken on AArch64 bots, logs are available here: >> >> http://lab.llvm.org

[clang-tools-extra] 3b9715c - [NFC] Fix typos in Clangd and Clang

Author: Kirill Bobyrev Date: 2019-12-16T10:54:40+01:00 New Revision: 3b9715cb219352fb831af144fd68e14e8fd275b4 URL: https://github.com/llvm/llvm-project/commit/3b9715cb219352fb831af144fd68e14e8fd275b4 DIFF: https://github.com/llvm/llvm-project/commit/3b9715cb219352fb831af144fd68e14e8fd275b4.diff

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas updated this revision to Diff 234005. janosimas added a comment. Herald added a subscriber: mgehre. Herald added a project: clang. I reviewed the code over the discussion with the `--` option, I also changed the `-p` optin to `-strip` to avoid confusion with the `clang-tidy` option. so

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas added a comment. I also noticed there is a `clang-format-diff` that also has the `-p` option, it would be nice to update it for consistency. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 _

[PATCH] D71535: [clang][AST] Make 'getPartialSpecializations' const-qualified in DeclTemplate

PragmaTwice created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I found that `ClassTemplateDecl::getSpecializations` is const-qualified, but `ClassTemplateDecl::getPartialSpecializations`is not, which has very similar implementation to the former method.

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

ikudrin added a comment. Personally, I would prefer to see the file name and path to be changed as little as possible because that would help to recognize the files better. We cannot use `remove_dots()` on POSIX OSes to simplify paths, because it may return an invalid path; thus we have to use

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill marked an inline comment as done. lewis-revill added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:667 +.addExternalSymbol(SpillLibCall, RISCVII::MO_CALL) +.setMIFlag(MachineInstr::FrameSetup); + shiva0217

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14323 +Result = Builder.CreateIntrinsic( +Intrinsic::ptrmask, {Args.SrcType, SrcForMask->getType(), Args.IntType}, +{SrcForMask, NegatedMask}, nullptr, "aligned_result"); ---

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68362/new/ https://reviews.llvm.org/D68362 ___ cfe-commits mailing list cf

[PATCH] D71541: [Clang]: fix spelling mistake in assert message

imkiva created this revision. imkiva added reviewers: clang, pcc. imkiva added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D71541 Files: lib/AST/VTableBuilder.cpp Index: lib/AST/VTableBuilder.cpp ==

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

theraven added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14323 +Result = Builder.CreateIntrinsic( +Intrinsic::ptrmask, {Args.SrcType, SrcForMask->getType(), Args.IntType}, +{SrcForMask, NegatedMask}, nullptr, "aligned_result");

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Nice! I think this is the correct way of implementing this, and I don't think it will have any issue with other backends. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D71542: [coroutines][PR41909] don't build dependent coroutine statements if the coroutine still has a dependent promise type

blastrock created this revision. blastrock added reviewers: GorNishanov, EricWF, lewissbaker, tks2103, modocache, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. blastrock edited the summary of this revision. This started with bug https://bugs.llvm.org/show_bug.cgi?

[PATCH] D71543: [clangd] Fix handling of inline and anon namespaces in hover

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd normally skips printing of inline and anon namespaces while printing nested name specifiers. There was a bug causing us to print inne

[PATCH] D71529: [Sema] Fixes -Wrange-loop-analysis warnings

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71529/new/ https://reviews.llvm.org/D71529 _

[PATCH] D71544: [clangd] Improve printing of lambda names

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Clangd was printing lambdas as `(anonymous class)` before, we can improve it by at least printing `(lambda)` instea

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60932 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

probinson added a comment. Do we have a similar problem if the filespec has an embedded ./ or ../ in it? I'm thinking some broader canonicalization ought to be done here. $ clang ./dir1/dir2/../dir3/file.c should resolve to dir1/dir3/file.c shouldn't it? Repository: rG LLVM Github Monorepo

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/URI.h:115 +// the SourceManager. +URI toURI(llvm::StringRef Path, const SourceManager &SM, + const std::string &FallbackDir); This function does a very specialized form of path-to-

[PATCH] D71544: [clangd] Improve printing of lambda names

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60959 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

ilya-biryukov added a comment. My biggest concern is that we seem to make output for template instantiation worse. There should be a way to stop showing anonymous namespace without introducing such regressions. Comment at: clang-tools-extra/clangd/Hover.cpp:353 /// Generate

[clang-tools-extra] 079ef78 - Revert "[clangd] Implement "textDocument/documentLink" protocol support"

Author: Dmitri Gribenko Date: 2019-12-16T15:21:51+01:00 New Revision: 079ef783dd5530b5f87beefe624b9179547ded7e URL: https://github.com/llvm/llvm-project/commit/079ef783dd5530b5f87beefe624b9179547ded7e DIFF: https://github.com/llvm/llvm-project/commit/079ef783dd5530b5f87beefe624b9179547ded7e.dif

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. kadircet added a parent revision: D71544: [clangd] Improve printing of lambda names. Follow-up to D71543

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

gribozavr2 added a comment. Sorry, I reverted this change in 079ef783dd5530b5f87beefe624b9179547ded7e . The tests depend on builtin headers, which is not intentionally supported in clangd tests; these tests are broken in some

[PATCH] D71544: [clangd] Improve printing of lambda names

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71544/new/ https://reviews.llvm.org/D71544 _

[clang] 4c4f4dd - Silence an MSVC "not all control paths" diagnostic; NFC.

Author: Aaron Ballman Date: 2019-12-16T09:35:15-05:00 New Revision: 4c4f4dd3f894a0f7a20df8b9696ffe22ab388821 URL: https://github.com/llvm/llvm-project/commit/4c4f4dd3f894a0f7a20df8b9696ffe22ab388821 DIFF: https://github.com/llvm/llvm-project/commit/4c4f4dd3f894a0f7a20df8b9696ffe22ab388821.diff

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet updated this revision to Diff 234050. kadircet marked 9 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71543/new/ https://reviews.llvm.org/D71543 Files: clang-tools-ex

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

sammccall added a comment. In D70872#1785797 , @gribozavr2 wrote: > which is intentionally not supported in clangd tests Not intentionally as far as I'm aware :-) Do you have a link or details for some failing environment? I'm OOO but I'd like to follow

[clang-tools-extra] 7dc388b - [clangd] Make Tweak::Selection movable. NFC

Author: Sam McCall Date: 2019-12-16T15:46:57+01:00 New Revision: 7dc388bd9596bbf42633f8a8e450224e39740b60 URL: https://github.com/llvm/llvm-project/commit/7dc388bd9596bbf42633f8a8e450224e39740b60 DIFF: https://github.com/llvm/llvm-project/commit/7dc388bd9596bbf42633f8a8e450224e39740b60.diff LO

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 234051. arichardson marked 6 inline comments as done. arichardson added a comment. - Add support for constant-evaluating pointer values - Add errors messages for constant evaluation - Extend tests for constant evaluation - Use ptrtoint+inttoptr instead of

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60957 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

kadircet added a comment. In D71543#1785785 , @ilya-biryukov wrote: > My biggest concern is that we seem to make output for template instantiation > worse. > There should be a way to stop showing anonymous namespace without > introducing such regressio

[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60930 tests passed, 2 failed and 726 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/lock.pass.cpp failed: libc++.std/thre

[clang-tools-extra] 2500a8d - [clangd] Reapply b60896fad926 Fall back to selecting token-before-cursor if token-after-cursor fails.

Author: Sam McCall Date: 2019-12-16T15:55:16+01:00 New Revision: 2500a8d5d8813a3e31fc9ba8dd45e211439a1e3d URL: https://github.com/llvm/llvm-project/commit/2500a8d5d8813a3e31fc9ba8dd45e211439a1e3d DIFF: https://github.com/llvm/llvm-project/commit/2500a8d5d8813a3e31fc9ba8dd45e211439a1e3d.diff LO

[clang-tools-extra] 8f876d5 - Revert "[clangd] Reapply b60896fad926 Fall back to selecting token-before-cursor if token-after-cursor fails."

Author: Sam McCall Date: 2019-12-16T15:57:43+01:00 New Revision: 8f876d5105507f874c0fb86bc779c9853eab3fe2 URL: https://github.com/llvm/llvm-project/commit/8f876d5105507f874c0fb86bc779c9853eab3fe2 DIFF: https://github.com/llvm/llvm-project/commit/8f876d5105507f874c0fb86bc779c9853eab3fe2.diff LO

[clang-tools-extra] a0ff8cd - [clangd] Reapply b60896fad926 Fall back to selecting token-before-cursor if token-after-cursor fails.

Author: Sam McCall Date: 2019-12-16T15:58:51+01:00 New Revision: a0ff8cd631add513423fc2d8afa49e9650d01fe3 URL: https://github.com/llvm/llvm-project/commit/a0ff8cd631add513423fc2d8afa49e9650d01fe3 DIFF: https://github.com/llvm/llvm-project/commit/a0ff8cd631add513423fc2d8afa49e9650d01fe3.diff LO

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60961 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. @efriedma validation passes without the checks you were pointed out, see https://github.com/serge-sans-paille/llvm-project/pull/4/checks Thanks for making the code simpler! Comment at: clang/lib/AST/Decl.cpp:3019 +if (SL.isValid()) +

[clang] 9f99aba - [clang][SystemZ] Add support for -march=native

Author: Ulrich Weigand Date: 2019-12-16T16:11:32+01:00 New Revision: 9f99aba1cfeb603f368c45ef78ba9795bab16d47 URL: https://github.com/llvm/llvm-project/commit/9f99aba1cfeb603f368c45ef78ba9795bab16d47 DIFF: https://github.com/llvm/llvm-project/commit/9f99aba1cfeb603f368c45ef78ba9795bab16d47.diff

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

probinson added a comment. I have to wonder if we're not being too eager to produce the debug info. It seems that the undeduced type problem arises because we're trying to produce debug info before we've really finished instantiating `value` here. But how Clang works pretty much always confus

[PATCH] D71422: [clangd] Introduce bulletlists

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.h:95 + /// Causes every line of the document to be indented by 2 spaces. Except the + /// first line, it is containers responsibility to adjust padding for first sammccall wr

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

erichkeane added a comment. In D71467#1784398 , @erichkeane wrote: > In D71467#1784338 , @craig.topper > wrote: > > > In D71467#1784286 , @rjmccall > > wrote: > > > > > The

[PATCH] D61549: Fix use of 'is' operator for comparison

tambre added a comment. In D61549#1785369 , @Jim wrote: > @j-carl Could you give a Python 3.8 syntax reference for this change. This is not a language change in Python 3.8. AFAICT, the behaviour of `is` has been the same as long as Python has been in us

[PATCH] D71422: [clangd] Introduce bulletlists

kadircet updated this revision to Diff 234059. kadircet marked 2 inline comments as done. kadircet added a comment. - Move indentation logic into bulletlist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71422/new/ https://reviews.llvm.org/D71422

[clang] f02d6dd - Fix floating point builtins to not promote float->double

Author: Erich Keane Date: 2019-12-16T07:20:29-08:00 New Revision: f02d6dd6c7afc08f871a623c0411f2d77ed6acf8 URL: https://github.com/llvm/llvm-project/commit/f02d6dd6c7afc08f871a623c0411f2d77ed6acf8 DIFF: https://github.com/llvm/llvm-project/commit/f02d6dd6c7afc08f871a623c0411f2d77ed6acf8.diff L

[PATCH] D71422: [clangd] Introduce bulletlists

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60933 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[clang] fd0c91b - [OPENMP50]Add if clause in target teams distribute parallel for simd directive.

Author: Alexey Bataev Date: 2019-12-16T10:33:56-05:00 New Revision: fd0c91bab184e50e548b9daca4b8cfb0719ff959 URL: https://github.com/llvm/llvm-project/commit/fd0c91bab184e50e548b9daca4b8cfb0719ff959 DIFF: https://github.com/llvm/llvm-project/commit/fd0c91bab184e50e548b9daca4b8cfb0719ff959.diff

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

martong updated this revision to Diff 234062. martong marked an inline comment as done. martong added a comment. Simplify getRecordDeclOfFriend() further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020 Fil

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

martong marked an inline comment as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:252 + QualType Ty = FD->getFriendType()->getType().getCanonicalType(); + if (isa(Ty)) +Ty = cast(Ty)->getNamedType(); a_sidorin wrot

RE: [clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

Hi Michael, this turns out to be an assert failure:   clang/tools/clang-scan-deps/ClangScanDeps.cpp:340: const clang::tooling::dependencies::ModuleDeps& FullDeps::lookupModuleDeps(clang::tooling::dependencies::ClangModuleDep): Assertion `I != Modules.end()' failed.   Does this help with debugging a

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

rnk added a comment. In D71320#1784726 , @thakis wrote: > I think this broke the reverse-iteration bot: > http://lab.llvm.org:8011/builders/reverse-iteration/builds/15619 Looks like I forgot to build polly, and @aheejin fixed it. Thanks! I usually enab

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 234064. arichardson added a comment. Fix align32array[0] -> &align32array[0] typo in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 Files: clang/include/cla

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor updated this revision to Diff 234067. epastor added a comment. - Apply formatting fixes where reasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71436/new/ https://reviews.llvm.org/D71436 Files: clang/test/CodeGen/ms-inline-asm-64.

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60963 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60854 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne added a comment. Herald added a subscriber: arichardson. Thanks Sam and Luis for the review. Could I ask that one of you commit this if you are able? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68362/new/ https://reviews.llvm.org/D68362 _

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

lenary marked 3 inline comments as done. lenary added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1525 unsigned TwoXLenInBytes = (2 * XLen) / 8; if (!IsFixed && ArgFlags.getOrigAlign() == TwoXLenInBytes && DL.getTypeAllocSize(OrigTy) == T

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

lenary added a comment. Yeah, will do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68362/new/ https://reviews.llvm.org/D68362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] 081f736 - Fixing a -Wcovered-switch diagnostic and changing tabs to spaces; NFC.

Author: Aaron Ballman Date: 2019-12-16T11:38:30-05:00 New Revision: 081f736157dea53735f098165d750abfbbcd96dd URL: https://github.com/llvm/llvm-project/commit/081f736157dea53735f098165d750abfbbcd96dd DIFF: https://github.com/llvm/llvm-project/commit/081f736157dea53735f098165d750abfbbcd96dd.diff

[libunwind] ce3d1c6 - [libunwind][RISCV] Add 64-bit RISC-V support

Author: Sam Elliott Date: 2019-12-16T16:36:56Z New Revision: ce3d1c6d61dcd96f44492516f8b613bbcadaeb8e URL: https://github.com/llvm/llvm-project/commit/ce3d1c6d61dcd96f44492516f8b613bbcadaeb8e DIFF: https://github.com/llvm/llvm-project/commit/ce3d1c6d61dcd96f44492516f8b613bbcadaeb8e.diff LOG: [

[PATCH] D70157: Align branches within 32-Byte boundary

annita.zhang added a comment. > More performance data was posted on > http://lists.llvm.org/pipermail/llvm-dev/2019-December/137609.html and > http://lists.llvm.org/pipermail/llvm-dev/2019-December/137610.html. Let's > move on based on the data. Based on the SPEC data, we observed 2.6% and 1.3

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton created this revision. s.egerton added reviewers: asb, simoncook, lewis-revill, PaoloS, lenary. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, Ma

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson created this revision. arichardson added a reviewer: rupprecht. Herald added subscribers: llvm-commits, cfe-commits, krytarowski, emaste. Herald added projects: clang, LLVM. arichardson updated this revision to Diff 234082. arichardson added a comment. Drop unrelated change I have be

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234082. arichardson added a comment. Drop unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files: llvm/test/tools/llvm-ranlib/D-flag.test llvm/t

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

This revision was automatically updated to reflect the committed changes. Closed by commit rGce3d1c6d61dc: [libunwind][RISCV] Add 64-bit RISC-V support (authored by lenary). Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Improves basic hover presentation logic to include more info. Repository: rG LLVM Github Monorepo

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 234087. kadircet added a comment. - Get rid of irrelevant change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-extra/clangd/Hover.cpp clang-to

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60962 tests passed, 1 failed and 726 were skipped. failed: LLVM.tools/llvm-ranlib/D-flag.test {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json , CMakeCache.txt

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json , CMakeCache.txt

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill marked an inline comment as done. lewis-revill added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:289 unsigned CFIIndex = MF.addFrameInst( MCCFIInstruction::createDefCfaOffset(nullptr, -StackSize)); BuildMI(MBB, MBBI, DL, TII

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60962 tests passed, 1 failed and 726 were skipped. failed: LLVM.tools/llvm-ranlib/D-flag.test {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui added a comment. In D71508#1785767 , @probinson wrote: > Do we have a similar problem if the filespec has an embedded ./ or ../ in it? problems occur only when filespec starts with ./ otherwise it's fine. Repository: rG LLVM Github Mon

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234088. arichardson added a comment. Force UTC timezone for reproducible results Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files: llvm/test/tools/llvm-ranli

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

lewis-revill added a comment. Thanks Scott, it should be relatively easy to add tests for this in 'clang/test/Preprocessor/riscv-target-features.c' if you could. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:668 +.setMIFlag(MachineInstr::FrameSetup); + +// Add registers spilled in libcall as liveins. lewis-revill wrote: > shiva0217 wrote: > > GCC will generate stack adj

[clang] 878ab6d - [TLI] Support for per-Function TLI that overrides available libfuncs

Author: Teresa Johnson Date: 2019-12-16T09:19:30-08:00 New Revision: 878ab6df033d44430939c02075ee00800995dc3b URL: https://github.com/llvm/llvm-project/commit/878ab6df033d44430939c02075ee00800995dc3b DIFF: https://github.com/llvm/llvm-project/commit/878ab6df033d44430939c02075ee00800995dc3b.diff

[PATCH] D67923: [TLI] Support for per-Function TLI that overrides available libfuncs

tejohnson updated this revision to Diff 234090. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67923/new/ https://reviews.llvm.org/D67923 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Ana

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, paulwalker-arm, efriedma, dancgr, mgudim. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the llvm.aarch64.sve.ldnf1 intr

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60963 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

probinson added a comment. In D71508#1786122 , @kamleshbhalui wrote: > In D71508#1785767 , @probinson wrote: > > > Do we have a similar problem if the filespec has an embedded ./ or ../ in > > it? > > > problems

[PATCH] D67923: [TLI] Support for per-Function TLI that overrides available libfuncs

This revision was automatically updated to reflect the committed changes. Closed by commit rG878ab6df033d: [TLI] Support for per-Function TLI that overrides available libfuncs (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D679

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

emaste added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:69 + --version - Display the version of this program + -D- Use zero for timestamps and uids/gids (default) + -U- Use actual timestamps and uids/gids ---

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:69 + --version - Display the version of this program + -D- Use zero for timestamps and uids/gids (default) + -U

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand updated this revision to Diff 234096. uweigand added a comment. Added float (f32) test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71467/new/ https://reviews.llvm.org/D71467 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGen/fpconstrained-cmp-double.c

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7424 + ParsedAttr &Attr) { + if (CurType->isFunctionType()) { +State.getSema().Diag(Attr.getLoc(), diag::warn_type_attribute_wrong

Re: [clang-tools-extra] a0ff8cd - [clangd] Reapply b60896fad926 Fall back to selecting token-before-cursor if token-after-cursor fails.

Sam McCall wrote: >LOG: [clangd] Reapply b60896fad926 Fall back to selecting token-before-cursor if token-after-cursor fails. > >This reverts commit 8f876d5105507f874c0fb86bc779c9853eab3fe2. I believe this has caused a significant number of build bot failures, with error messages along these li

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. In D71467#1785943 , @erichkeane wrote: > I did the compare operators that didn't work right, and will do a separate > patch for the fp-classification type ones: > f02d6dd6c7afc08f871a623c0411f2d77ed6acf8 >

  1   2   3   >