ikudrin added a comment.

Personally, I would prefer to see the file name and path to be changed as 
little as possible because that would help to recognize the files better. We 
cannot use `remove_dots()` on POSIX OSes to simplify paths, because it may 
return an invalid path; thus we have to use `getRealPath()`. If I understand it 
right, there is no similar problem with the file name itself.

So, which issues this patch is going to solve?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70527/new/

https://reviews.llvm.org/D70527



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to