[PATCH] D70780: [WebAssembly] Find wasm-opt with GetProgramPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f1e2151b8e9: [WebAssembly] Find wasm-opt with GetProgramPath (authored by sunfishcode). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70780/new/ https://re

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

probinson added a comment. In D70696#1765675 , @yonghong-song wrote: > It is just strange that gcc 7.3.1 (did not test, but maybe later gcc versions > as well) emits the debuginfo (encoded in dwarf) > even if the external variable is not used in the cur

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. In D70696#1765675 , @yonghong-song wrote: > @probinson for the question, > > > Does bpf require debug info for the declaration of global_var in noref.c ? > > No, bpf only cares the referenced external global variables. So my curre

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. In D70696#1765714 , @yonghong-song wrote: > @dblaikie Good points. I will guard external variable debug info generation > under `-fstandalone-debug` flag. Oh, I figured given your needs this'd be guarded behind the target bein

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. In D70696#1765675 , @yonghong-song wrote: > @probinson for the question, > > > Does bpf require debug info for the declaration of global_var in noref.c ? > > No, bpf only cares the referenced external global variables. So my curr

[PATCH] D69223: WDocumentation: Implement the \anchor.

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/test/Index/comment-xml-schema.c:38 +// RUN: xmllint --noout --relaxng %S/../../bindings/xml/comment-xml-schema.rng %S/Inputs/CommentXML/valid-inline-command-01.xml // RUN: not xml

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

probinson added a comment. In D70696#1765671 , @dblaikie wrote: > In D70696#1765637 , @probinson wrote: > > > For the case: > > > > cat ref.c > > extern int global_var; > > int main() { return global_v

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. In D70696#1765784 , @probinson wrote: > In D70696#1765671 , @dblaikie wrote: > > > In D70696#1765637 , @probinson > > wrote: > > > > > For the case

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. In D70696#1765789 , @dblaikie wrote: > In D70696#1765784 , @probinson wrote: > > > In D70696#1765671 , @dblaikie > > wrote: > > > > > In D70696#176

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, ruiu. Herald added a project: clang. Herald added a subscriber: cfe-commits. sidneym added a subscriber: llvm-commits. Avoid passing unsupported options to lld when -fuse-ld=lld is used. Repository: rG LLVM Github Monorep

[PATCH] D70779: AArch64: add support for newer Apple CPUs

ab added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:587 +"Apple A10", [ +ProcAppleA7, +FeatureCRC, I'm not sure we want to reuse the f

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 231758. mibintc added a comment. This commit was reverted in 30e7ee3c4bac because a null deref error occurred in IRBuilder.h when setting strictfp attribute, see https://bugs.llvm.org/sho

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. @dblaikie , If you try switching to C compiler. then the DW_TAG_variable is their. for C++ . It's not generated. Please check godbolt again. -- though strange Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70696/new/ htt

[PATCH] D70535: [clangd] Define out-of-line qualify return value

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:153 + // Get new begin and end positions for the qualified body. + auto OrigFuncRange = toHalfOpe

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

kparzysz added inline comments. Comment at: clang/test/Driver/hexagon-toolchain-elf.c:560 +// CHECK082-NOT: "-march=hexagon" +// CHECK082-NOT: "-mcpu=hexagon" I don't think there will ever be `"-mcpu=hexagon"` (including the quotation marks). Maybe thi

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. In D70696#1765843 , @dblaikie wrote: > In D70696#1765823 , @SouraVX wrote: > > > @dblaikie , If you try switching to C compiler. then the DW_TAG_variable > > is their. for C++ . It's not g

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. In D70696#1765823 , @SouraVX wrote: > @dblaikie , If you try switching to C compiler. then the DW_TAG_variable is > their. for C++ . It's not generated. Please check godbolt again. -- though > strange Hmm - I don't seem to s

[PATCH] D53250: [ToolChain] Use default linker if the toolchain uses a custom one

phosek added a comment. Sorry about the late response, I was mostly out last week. This recently came up again so I'd like to look into it but I'll have to rethink the change and come up with a better approach. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53250

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

NoQ added a comment. So... note tags ? Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:261 + + // TODO: do we want to emit notes for escapes? + // do we want to emit notes for for error checks? I.e. on which br

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc marked 9 inline comments as done. mibintc added a comment. I added inline comments describing what I did in this version of the patch to address the bug https://bugs.llvm.org/show_bug.cgi?id=44048 Comment at: clang/include/clang/AST/DeclBase.h:1539 +/// Indicates i

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 231765. sidneym added a comment. Update testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 Files: clang/lib/Driver/ToolChains/Hexagon.cpp clang/test/Driver/hexagon-toolchain-elf.c Index: clang/t

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante updated this revision to Diff 231766. Mordante marked 2 inline comments as done. Mordante added a comment. Addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69223/new/ https://reviews.llvm.org/D69223 Files: clang/bindings/xml/comment-xml-schema.rng c

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

kpn added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:268 I->addAttribute(AttributeList::FunctionIndex, Attribute::StrictFP); -setConstrainedFPFunctionAttr(); } mibintc wrote: > @kpn I got rid of this line because the function attr

[clang-tools-extra] 82039cb - [clangd] repair mac tests for 88bccded8fa1

Author: Sam McCall Date: 2019-12-02T21:55:54+01:00 New Revision: 82039cbc8d2a0f6fb5995f54e0e4291bcfd0 URL: https://github.com/llvm/llvm-project/commit/82039cbc8d2a0f6fb5995f54e0e4291bcfd0 DIFF: https://github.com/llvm/llvm-project/commit/82039cbc8d2a0f6fb5995f54e0e4291bcfd0.diff LO

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall added a comment. In D70863#1765668 , @arphaman wrote: > @sammccall Sam, it looks like the tests are failing on the darwin bots: > > http://lab.llvm.org:8080/green/job/clang-stage1-RA/4243/consoleFull Thanks, and sorry! Fingers crossed that 820

[PATCH] D70701: Fix more VFS tests on Windows

rnk added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1077-1078 +std::error_code RedirectingFileSystem::makeAbsolute(SmallVectorImpl &Path) const { + if (llvm::sys::path::is_absolute(Path, llvm::sys::path::Style::posix) || + llvm::sys::path::is_abso

[clang-tools-extra] 93f7761 - Revert "[clangd] repair mac tests for 88bccded8fa1"

Author: Sam McCall Date: 2019-12-02T22:13:29+01:00 New Revision: 93f77617abba512d2861e2fc50ce385883f587b6 URL: https://github.com/llvm/llvm-project/commit/93f77617abba512d2861e2fc50ce385883f587b6 DIFF: https://github.com/llvm/llvm-project/commit/93f77617abba512d2861e2fc50ce385883f587b6.diff LO

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

MaskRay added a comment. > If we could get this patch merged, we could build and link the whole LLVM > with lld on NetBSD and it would increase the productivity of the bot (better > build times). Right now we need to maintain hacks to link at most with 2/3 > cores, while 5/6 ones are idling doi

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

aprantl resigned from this revision. aprantl added a comment. @rsmith can you take a look at this to see if this is going into the right direction? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 __

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

NoQ added a comment. > I feel like the 2. is a better solution. Of course, that change might have a > performance impact as well. Yes, i'm all for '2.'. There's no need to make this callback more complicated than it already is. As for performance, it's messy and suffers from a deeper problem:

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added a comment. I was thinking about note tags, but since we iterate on the argument/parameter pairs and might change the state in each iteration we would need to add a new transition after each change. I was wondering if using note tags would worth the cost (both in performance due

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas added a comment. Hi, if this patch still LGTY, could you commit it on my behalf? I don't have commit access. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits mail

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

rnk added inline comments. Comment at: clang/test/Misc/permissions.cpp:8 // RUN: umask 002 // RUN: %clang_cc1 -emit-llvm-bc %s -o %t If you change this to `umask 022`, does that result in `rw-r-`? That would make the test meaningful on your system. Rep

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added a comment. Sorry, my previous comment might not be clear. The point is, the same call might both acquire and release handles (there are such calls in Fuchsia), so we might end up adding more than one note for a call for which we would need to add more than one transitions. If y

[PATCH] D70701: Fix more VFS tests on Windows

amccarth marked 3 inline comments as done. amccarth added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1077-1078 +std::error_code RedirectingFileSystem::makeAbsolute(SmallVectorImpl &Path) const { + if (llvm::sys::path::is_absolute(Path, llvm::sys::path::

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun marked 3 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:261 + + // TODO: do we want to emit notes for escapes? + // do we want to emit notes for for error checks? I.e. on which bra

[PATCH] D70923: Fix comment to more accurately describe C++ language requirements around tail padding.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. As of C++ core issue 43 (http://wg21.link/cwg43), which was voted into the C++ working draft in 1999, it is not permissible to memcpy a base class subobject, even if it's of POD type, so there is no pro

[clang-tools-extra] 936de1c - Remove extraneous semicolon.

Author: Bill Wendling Date: 2019-12-02T14:09:21-08:00 New Revision: 936de1c5bc2dfbec25318985cddb7345d989a7ee URL: https://github.com/llvm/llvm-project/commit/936de1c5bc2dfbec25318985cddb7345d989a7ee DIFF: https://github.com/llvm/llvm-project/commit/936de1c5bc2dfbec25318985cddb7345d989a7ee.diff

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. @dblaikie The concern for that users using -fstandalone-debug may suddenly see a bloat of external var debug info is totally valid. Let me just stick to BPF use case for now. If somebody else ever wants this information with `-fstandalone-debug`, the restriction

[PATCH] D70926: Add option for not breaking line before ObjC params

ghvg1313 created this revision. ghvg1313 added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. >From `clang-format` version 3.7.0 and up, , there is no way to keep following >format of ObjectiveC block: - (void)_aMethod { [self.test1 t:self w:

[PATCH] D70923: Fix comment to more accurately describe C++ language requirements around tail padding.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70923/new/ https://reviews.llvm.org/D70923 ___

[clang] 711c669 - Fix comment to more accurately describe C++ language requirements around tail padding.

Author: Richard Smith Date: 2019-12-02T14:41:27-08:00 New Revision: 711c669ae92658aecc6fabccc583594924bac6d7 URL: https://github.com/llvm/llvm-project/commit/711c669ae92658aecc6fabccc583594924bac6d7 DIFF: https://github.com/llvm/llvm-project/commit/711c669ae92658aecc6fabccc583594924bac6d7.diff

[PATCH] D70923: Fix comment to more accurately describe C++ language requirements around tail padding.

This revision was automatically updated to reflect the committed changes. Closed by commit rG711c669ae926: Fix comment to more accurately describe C++ language requirements around tail… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added a comment. Could you update the ClangStyleOption.rst (using the tool in docs/tools) and as you are adding a new option would you add a line or two in the docs/ReleaseNotes.rst in the clang-format section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun added a comment. @aaron.ballman Type attributes are definitely more flexible as in they can be applied in more contexts. These attributes, however, make no sense outside of a function declaration, or maybe a type alias. So I feel like we could argue on both sides. I made a minimal ve

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun updated this revision to Diff 231784. xazax.hun added a comment. - Convert to type attributes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/i

[clang] 717140a - [clang test] Do not assume default target

Author: Thomas Preud'homme Date: 2019-12-02T22:57:30Z New Revision: 717140a0dcc651ca2fec23248d1675fb2d388b9c URL: https://github.com/llvm/llvm-project/commit/717140a0dcc651ca2fec23248d1675fb2d388b9c DIFF: https://github.com/llvm/llvm-project/commit/717140a0dcc651ca2fec23248d1675fb2d388b9c.diff

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D70748: [clang test] Do not assume default target

thopre closed this revision. thopre added a comment. Committed as 717140a0dcc651ca2fec23248d1675fb2d388b9c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70748/new/ https://revie

[clang] 536ceda - FileCheck IR output for blockaddress in new test

Author: Reid Kleckner Date: 2019-12-02T15:05:50-08:00 New Revision: 536cedaecbe586ec9cf86d5102872adc27e6ea23 URL: https://github.com/llvm/llvm-project/commit/536cedaecbe586ec9cf86d5102872adc27e6ea23 DIFF: https://github.com/llvm/llvm-project/commit/536cedaecbe586ec9cf86d5102872adc27e6ea23.diff

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

rnk added a comment. In D70302#1764261 , @johannes wrote: > I see, apologies for the premature commit. No problem, LLVM's code review practices are somewhat opaque. Comment at: clang/test/CodeGen/label-array-aggregate-init.c:1 +// RUN

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song updated this revision to Diff 231786. yonghong-song edited the summary of this revision. yonghong-song added a comment. clang-format change (from @aprantl) , add a little details into summary related to recent discussion, move tests from CodeGenCXX to CodeGen as they are all C tests

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added a comment. You're right indeed Russell, my bad, this gain is not as important as I initially claimed -- however there's a gain. Several factors came into play: 1. The latest ninja 1.9.0 doesn't use all cpu sockets on some Windows systems (see this

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 231790. ghvg1313 added a comment. - Update documents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Relea

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231792. Tyker added a comment. improved based on aaron's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticPa

[clang-tools-extra] 64f74bf - [clang-tidy] Rewrite modernize-avoid-bind check.

Author: Zachary Turner Date: 2019-12-02T15:36:26-08:00 New Revision: 64f74bf72eb484aa32e1104050cb54745116decf URL: https://github.com/llvm/llvm-project/commit/64f74bf72eb484aa32e1104050cb54745116decf DIFF: https://github.com/llvm/llvm-project/commit/64f74bf72eb484aa32e1104050cb54745116decf.diff

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

nickdesaulniers added a comment. In D68101#1765665 , @rjmccall wrote: > Given all that, this patch seems far too aggressive. While mergeable > sections can be useful for optimizing arbitrary code that might not use a > section, they are also extremely u

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

This revision was automatically updated to reflect the committed changes. Closed by commit rG64f74bf72eb4: [clang-tidy] Rewrite modernize-avoid-bind check. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D70368?vs=230661&id=231793#toc Repository: rG LLVM Github Monor

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

0x8000- added a comment. Thank you for rebasing on current master. I have ran it today on our code base and found three classes of false positives: 1. Writing to a bitfield of a struct. The struct still is suggested it should be const. 2. Using a variable with an ostream extraction; like "i

[PATCH] D70931: [MS] Emit exported complete/vbase destructors

rnk created this revision. rnk added a reviewer: hans. Herald added a project: clang. Fixes PR44205 I checked, and deleting destructors are not affected. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70931 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/CodeGenCX

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman updated this revision to Diff 231799. arphaman marked 6 inline comments as done. arphaman added a comment. Fixed nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69543/new/ https://reviews.llvm.org/D69543 Files: clang-tools-extra/cla

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:80 + const LangOptions &getLangOpts() const { +return getASTContext().getLangOpts(); kadircet wrote: > can we introduce this helper in a new patch, while changing other occurr

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

rjmccall added a comment. > So I don't think we should even be trying to mark sections as mergeable > unless we walk all elements in the section and make sure it's even safe to > apply these. That's the conservative fix, yes. You can either: 1. emit global objects with the same section name i

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. This fixes a bug in IRGen where a call to `llvm.objc.storeStrong` was being emitted to initialize a __strong field of an uninitialized tem

[PATCH] D70936: [clang-scan-deps] do not skip empty #if/#elif in the minimize to avoid missing `__has_include` dependencies

arphaman created this revision. arphaman added reviewers: Bigcheese, dexonsmith, kousikk. Herald added subscribers: ributzka, tschuett, jkorous. Herald added a project: clang. This patch makes the minimizer more conservative to avoid missing dependency files that are brought in by `__has_include`

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

ahatanak added a comment. Note that passing `isInit=true` to `EmitStoreThroughLValue` to make it emit `llvm.objc.retain` would be incorrect since the callee destructs the struct argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70935/new/ h

[PATCH] D70936: [clang-scan-deps] do not skip empty #if/#elif in the minimize to avoid missing `__has_include` dependencies

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, although I have a suggested change for one of the comments (and I'm still sad about this). Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:76

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

bd1976llvm added a comment. In D68101#1766151 , @nickdesaulniers wrote: > In D68101#1765665 , @rjmccall wrote: > > > Given all that, this patch seems far too aggressive. While mergeable > > sections can be useful

[clang] 3895305 - [clang-scan-deps] do not skip empty #if/#elif in the minimizer to avoid missing `__has_include` dependencies

Author: Alex Lorenz Date: 2019-12-02T18:47:22-08:00 New Revision: 389530524be1715e97947810514f3a75dfe73975 URL: https://github.com/llvm/llvm-project/commit/389530524be1715e97947810514f3a75dfe73975 DIFF: https://github.com/llvm/llvm-project/commit/389530524be1715e97947810514f3a75dfe73975.diff L

[PATCH] D70936: [clang-scan-deps] do not skip empty #if/#elif in the minimize to avoid missing `__has_include` dependencies

This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rG389530524be1: [clang-scan-deps] do not skip empty #if/#elif in the minimizer to avoid missing… (authored by arphaman). Changed prior to commit: https://reviews

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2345 +<< "-ffp-contract=fast"; +optID = options::OPT_ffp_contract; +FPModel = Val; mibintc wrote: > michele.scandale wrote: > > Here the state of

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

rjmccall added a comment. I can't speak for the pragma authors, but I strongly doubt the pragma is intended to force all affected globals to go into a single section unit, since the division into section units is purely an object-file representation issue. Looks to me like `MCContext::getELFSec

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

NoQ added a comment. In D70725#1765981 , @xazax.hun wrote: > the same call might both acquire and release handles (there are such calls in > Fuchsia), so we might end up adding more than one note for a call for which > we would need to add more than one

[clang] f1e3988 - Recommit "[DWARF5]Addition of alignment atrribute in typedef DIE."

Author: Sourabh Singh Tomar Date: 2019-12-03T09:51:43+05:30 New Revision: f1e3988aa6016188c376b9bcca1afc7559f9fbc0 URL: https://github.com/llvm/llvm-project/commit/f1e3988aa6016188c376b9bcca1afc7559f9fbc0 DIFF: https://github.com/llvm/llvm-project/commit/f1e3988aa6016188c376b9bcca1afc7559f9fbc0

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1054 + "pointer to __strong expected"); + EmitStoreOfScalar(*AI++, LV); +} else This definitely deserves a comment. I don't think the assertion is right; the condition

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added a comment. In D70111#1765223 , @dblaikie wrote: > Looks OK to me - please recommit when you're ready. Thank you @awpandey . As requested, I've recommited this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://revi

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

NoQ added a comment. > `note()` Of course i mean something like this: std::string text = note(); if (!text.empty()) return text; (and return something like `""` on the other return path in the inner lambdas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I can tell from https://zed0.co.uk/clang-format-configurator/ that it's not possible to get it to the form you suggested, I'm not opposed to accepting this, I'm just

<    1   2