[PATCH] D53482: Add clang-format stability check with FormatTests

MyDeveloperDay added a comment. As @krasimir said we wouldn't normally commit tests which just break as they'd fail on the buildbot and someone would revert your change within 24 hours.. however, what you have here raises an interesting conversation This bug of instability is often raised, I've

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4995 + verifyFormat("c()->f();"); + verifyFormat("x()->foo<1>;"); + verifyFormat("x = p->foo<3>();"); MyDeveloperDay wrote: > curdeius wrote: > > What about: > > > > ``` > > ver

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

lebedev.ri resigned from this revision. lebedev.ri added inline comments. Comment at: clang/test/Analysis/check_analyzer_fixit.py:1 +#!/usr/bin/env python +# This does work with python3? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://

[clang] 0d14656 - [mips] Set __OCTEON__ macros

Author: Simon Atanasyan Date: 2019-11-05T12:10:58+03:00 New Revision: 0d14656b9d8ca38b8ea321c7047eaeec43c5b2ef URL: https://github.com/llvm/llvm-project/commit/0d14656b9d8ca38b8ea321c7047eaeec43c5b2ef DIFF: https://github.com/llvm/llvm-project/commit/0d14656b9d8ca38b8ea321c7047eaeec43c5b2ef.dif

[clang] e578d0f - [mips] Fix `__mips_isa_rev` macros value for Octeon CPU

Author: Simon Atanasyan Date: 2019-11-05T12:10:58+03:00 New Revision: e578d0fd295a67bce1e1fc922237f459deb49c7e URL: https://github.com/llvm/llvm-project/commit/e578d0fd295a67bce1e1fc922237f459deb49c7e DIFF: https://github.com/llvm/llvm-project/commit/e578d0fd295a67bce1e1fc922237f459deb49c7e.dif

[PATCH] D69791: [ARM,MVE] Add intrinsics for gather/scatter load/stores.

simon_tatham marked 3 inline comments as done. simon_tatham added inline comments. Comment at: clang/include/clang/Basic/arm_mve_defs.td:175 +// CopyKind expects t and u to be scalars. It returns a scalar +// whose kind (signed, unsigned or float) matches that of k, and whose -

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

hans added a comment. We hit this in V8 which is annotating some pointers as being 4GB-aligned. Does anyone know what it would take to raise Clang's limit here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 _

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

balazske added a comment. So we can have only one checker to model `fread` with `eval::Call`. Why is `fread` now modeled by StreamChecker and StdLibraryFunctionsChecker (both use `eval::Call`)? These checkers look at the function from different aspects, I do not like to have one checker with bo

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane marked 2 inline comments as done. erichkeane added a comment. In D68824#1733621 , @hans wrote: > We hit this in V8 which is annotating some pointers as being 4GB-aligned. > Does anyone know what it would take to raise Clang's limit here? The

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

merge_guards_bot added a comment. Build result: pass - 59845 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D64319: [OpenCL] Add function attributes handling for builtin functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a8d477a0e00: [OpenCL] Add builtin function attribute handling (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64319/new/ https://review

[PATCH] D63557: [OpenCL] Group builtin functions by prototype

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e56b0f94bfc: [OpenCL] Group builtin functions by prototype (authored by svenvh). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D63557?vs=222446&id=227833#toc

[clang] 9a8d477 - [OpenCL] Add builtin function attribute handling

Author: Sven van Haastregt Date: 2019-11-05T10:26:47Z New Revision: 9a8d477a0e00c15d6d33a52486fa931483b7f2ea URL: https://github.com/llvm/llvm-project/commit/9a8d477a0e00c15d6d33a52486fa931483b7f2ea DIFF: https://github.com/llvm/llvm-project/commit/9a8d477a0e00c15d6d33a52486fa931483b7f2ea.diff

[clang] 0e56b0f - [OpenCL] Group builtin functions by prototype

Author: Sven van Haastregt Date: 2019-11-05T10:26:47Z New Revision: 0e56b0f94bfc683c5a95e96784cfc9229a730bc8 URL: https://github.com/llvm/llvm-project/commit/0e56b0f94bfc683c5a95e96784cfc9229a730bc8 DIFF: https://github.com/llvm/llvm-project/commit/0e56b0f94bfc683c5a95e96784cfc9229a730bc8.diff

[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

jonpa closed this revision. jonpa added a comment. committed as 9376714 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67763/new/ https://reviews.llvm.org/D67763 ___ cfe-

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia updated this revision to Diff 227841. Anastasia marked an inline comment as done. Anastasia added a comment. - Factored OpenCL diagnostics out in a separate helper function - Removed special case for ParenType CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65744/new/ https://re

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6721 + if (getLangOpts().OpenCL) { + rjmccall wrote: > Anastasia wrote: > > rjmccall wrote: > > > Since you're moving this code anyway, can this be split into its own > > > function? I'

[clang] 9376714 - [Clang FE] Recognize -mnop-mcount CL option (SystemZ only).

Author: Jonas Paulsson Date: 2019-11-05T12:12:36+01:00 New Revision: 93767143147b7d765c6ce8123a4226d449228649 URL: https://github.com/llvm/llvm-project/commit/93767143147b7d765c6ce8123a4226d449228649 DIFF: https://github.com/llvm/llvm-project/commit/93767143147b7d765c6ce8123a4226d449228649.diff

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki created this revision. miyuki added reviewers: aprantl, rsmith, faisalv. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki edited reviewers, added: JDevlieghere; removed: jdoerfert. Herald added a reviewer: jdoerfert. This chan

[PATCH] D69841: Target Ivy bridge on macOS Mojave and later

davezarzycki created this revision. davezarzycki added a reviewer: bob.wilson. davezarzycki added a project: clang. Ivy Bridge is required by macOS 10.14 (Mojave) and later. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69841 Files: clang/lib/Driver/ToolChains/Arch/X86.cpp

[PATCH] D69841: Target Ivy bridge on macOS Mojave and later

davezarzycki added a comment. Hi @bob.wilson – Am I missing something here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69841/new/ https://reviews.llvm.org/D69841 ___ cfe-commits mailing list cfe-com

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:196 //~ -> we need to qualify Bar not x. -if (!ND->getDeclContext()->isNamespace()) +if (!ND->getLexicalDeclContext()->isNamespace())

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:281 + +auto *NSD = llvm::dyn_cast(Context); +assert(NSD && "Non-namespace decl context found."); NIT: `dyn_cast` + `assert` are equivalent to a single `llvm::cast` ===

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 227860. hokein marked 13 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 Files: clang-tools-e

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

tejohnson marked an inline comment as done. tejohnson added a comment. In D69732#1733447 , @wristow wrote: > > This probably needs to be taken over by someone who cares about full LTO > > performance > > We at PlayStation are definitely interested in full

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:370 + for (auto &E : *Edits) { +if (auto Err = reformatEdit(E.getValue(), Style)) + elog("Failed to format replacements: {0}", std::move(Err)); ilya-biryukov

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

mstorsjo added a comment. I'm not familiar with where/how the CrossWindows toolchain is used, but you say (and the code seems to agree) that it's intended to be able to use ld.bfd for linking code built for the MSVC ABI with MSVC/WinSDK libs? I'm surprised that even works at all (or does it, or

[PATCH] D69769: [Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

mstorsjo added a comment. Same thing here, no need to send a separate patch for backporting. (And in general, for cases where backporting would be relevant, you'd normally just make a patch for master, then let it be merged there, and request a backport of it from the release branch maintainer,

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @sylvestre.ledru did the testing and benchmarking on firefox (see https://bugzilla.mozilla.org/show_bug.cgi?id=1588710#c12), everything seems ok, let's move forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao marked 2 inline comments as done. hliao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7689 + // Coerce HIP pointer arguments from generic pointers to global ones. + llvm::Type *coerce(llvm::Type *Ty, unsigned DefaultAS, + unsigned

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao updated this revision to Diff 227864. hliao marked an inline comment as done. hliao added a comment. revise parameter names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69826/new/ https://reviews.llvm.org/D69826 Files: clang/lib/CodeGen/C

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7246-7248 +// Set implicit behavior except for "default" for defaultmap +if ((Bits & OMP_MAP_IMPLICIT) && +(ImplicitBehavior != OMPC_DEFAULTMAP_MODIFIER_default)) { c

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:124 + if (const SymbolicRegion *SR = DestMR->getSymbolicBase()) +if (const Expr *SizeExpr = getDynamicSizeExpr(C.getState(), SR)) + return exprToStr(SizeExpr, C); -

[PATCH] D69844: [Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki created this revision. miyuki added reviewers: aprantl, faisalv, rsmith, JDevlieghere. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes the necessity to access the SourceLocation internal representation in several places which use FoldingSet objects.

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

Charusso updated this revision to Diff 227867. Charusso marked 6 inline comments as done. Charusso added a comment. - Use existing visitors. - Make the `MallocBugVisitor` available for every checker. - Fix duplication of fix-its on the warning path piece when we emit a note as well. CHANGES SIN

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1151 + || Value > 5 + || Value < 1) +TC.getDriver().Diag(diag::err_drv_invalid_int_value) dblaikie wrote: > probinson wrote: > > Clang doesn't support DWARF v1.

[PATCH] D65511: Delay emitting dllexport explicitly defaulted members until the class is fully parsed (PR40006)

hans added a comment. Sorry, seems I forgot to submit this comment.. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11545 +for (CXXMethodDecl *M : WorkList) { + DefineImplicitSpecialMember(*this, M, M->getLocation()); + ActOnFinishInlineFunctionDef(M); ---

Re: [PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

Thanks! On Mon, Nov 4, 2019 at 4:31 PM James Y Knight via Phabricator via cfe-commits wrote: > jyknight added a comment. > > Updated release notes in d11a9018b773c0359934a7989d886b02468112e4 < > https://reviews.llvm.org/rGd11a9018b773c0359934a7989d886b02468112e4>. > > > Repository: > rG LLVM G

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

hokein updated this revision to Diff 227877. hokein marked 4 inline comments as done. hokein added a comment. address comments, and simplify the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69615/new/ https://reviews.llvm.org/D69615 Files:

[PATCH] D68969: [clang-format] Remove the dependency on frontend

thakis added a subscriber: vlad.tsyrklevich. thakis added a comment. The revert message said: Vlad Tsyrklevich via cfe-commits Tue, Oct 29, 1:51 PM (7 days ago) to via, mydeveloperday I've reverted this commit as it was causing UBSan failures on the ubsan bot. These failures looked l

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:220 + bool VisitOverloadExpr(OverloadExpr *E) { +if (!E->decls().empty()) + return true; // handle

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:769 +llvm::StringRef TokenName; +if (Tok.getKind() == tok::identifier) + TokenName = Tok.getIdentifierInfo()->getName(); ilya-biryukov wrote: > Why do we ha

[clang] 642916a - [OPENMP][DOCS]Fix coloring of the implemented features status, NFC.

Author: Alexey Bataev Date: 2019-11-05T10:13:58-05:00 New Revision: 642916adc97e54810aa597512ca7012b3c8697c5 URL: https://github.com/llvm/llvm-project/commit/642916adc97e54810aa597512ca7012b3c8697c5 DIFF: https://github.com/llvm/llvm-project/commit/642916adc97e54810aa597512ca7012b3c8697c5.diff

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

thakis added a comment. Thanks for sending this out! Instead of the dynamic lookup of that symbol, what do you think about passing in the function via a normal api? That way, the type checker and linker help us keep things working; dynamic lookup is always a bit subtle and hard to grep for. (l

[PATCH] D69791: [ARM,MVE] Add intrinsics for gather/scatter load/stores.

dmgreen added a comment. Looks good as far as I can see. Comment at: clang/include/clang/Basic/arm_mve.td:78 +def _gather_base: Intrinsic< + Vector, (args VecOf>:$addr, imm_mem7bit:$offset), + (IRInt<"vldr_gather_base", [Vector, VecOf>]> $addr, $offset)>; ---

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea added a comment. Thanks for the feedback @Meinersbur! This patch is mainly geared towards Windows users. I'm not expecting anything on Linux, you already have all the bells & whistles there :-) Although I definitely see improvements on my Linux box. Would the distro make a difference? M

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. In D68969#1733946 , @thakis wrote: > The revert message said: > > Vlad Tsyrklevich via cfe-commits > Tue, Oct 29, 1:51 PM (7 days ago) > to via, mydeveloperday > > I've reverted this commit as it was causing UBSan

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: fail - 59795 tests passed, 21 failed and 762 were skipped. failed: lld.ELF/linkerscript/filename-spec.s failed: Clang.Index/index-module-with-vfs.m failed: Clang.Modules/double-quotes.m failed: Clang.Modules/framework-public-includes-private

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

merge_guards_bot added a comment. Build result: pass - 59741 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] 7b710a4 - [OPENMP]Improve diagnostics for unsupported unified addressing.

Author: Alexey Bataev Date: 2019-11-05T10:31:59-05:00 New Revision: 7b710a4294c1baed0157d86d3e2dabac78c306ce URL: https://github.com/llvm/llvm-project/commit/7b710a4294c1baed0157d86d3e2dabac78c306ce DIFF: https://github.com/llvm/llvm-project/commit/7b710a4294c1baed0157d86d3e2dabac78c306ce.diff

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea added a comment. In D69825#1733958 , @thakis wrote: > Thanks for sending this out! > > Instead of the dynamic lookup of that symbol, what do you think about passing > in the function via a normal api? That way, the type checker and linker help > u

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso updated this revision to Diff 227888. Charusso marked 2 inline comments as done. Charusso retitled this revision from "[analyzer][WIP] CERTStrChecker: Model gets()" to "[analyzer] CERTStrChecker: Model gets()". Charusso added a comment. - Do not try to fix-it an array with offsets. CHA

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added a subscriber: jholewinski. Herald added projects: clang, LLVM. The new OpenMPConstants.h is a location for all Op

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 227891. jdoerfert marked 5 inline comments as done. jdoerfert added a comment. Split D69853 out and changed according to (most) comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso updated this revision to Diff 227892. Charusso added a comment. - Support `alloca()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69813/new/ https://reviews.llvm.org/D69813 Files: clang/include/clang/Lex/Preprocessor.h clang/include/clang/StaticAnalyzer/Checkers/Checkers

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 227895. jdoerfert marked an inline comment as done. jdoerfert added a comment. Be consistent wrt. enum classes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files:

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki updated this revision to Diff 227894. miyuki added a comment. Changed getRawEncoding -> getHashValue in Sema.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 Files: clang/include/clang/Basic/SourceLocation.h clang/include/clang/Edit/

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

aprantl added a comment. What's the motivation behind this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:408 OpenMPClauseKind CKind) { - assert(DKind <= OMPD_unknown); assert(CKind <= OMPC_unknown); Why assert is removed? Comment

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:1643 HelpText<"Emit OpenMP code only for SIMD-based constructs.">; +def fopenmp_new_codegen : Flag<["-"], "fopenmp-new-codegen">, Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>, + HelpT

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. The motivation is to be able to make source locations' underlying type configurable. Richard Smith suggested that this might be feasible: http://lists.llvm.org/pipermail/cfe-dev/2019-October/063515.html So, the first step is to get rid of getRawEncoding where possible. I

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:408 OpenMPClauseKind CKind) { - assert(DKind <= OMPD_unknown); assert(CKind <= OMPC_unknown); ABa

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. see D69854: [clang-format] [RELAND] Remove the dependency on frontend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 ___

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, vlad.tsyrklevich, klimek, mitchell-stellar. MyDeveloperDay added projects: clang-format, clang. Herald added a subscriber: mgorny. relanding D68969: [clang-format] Remove the dependency on frontend

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 227900. jdoerfert marked 6 inline comments as done. jdoerfert added a comment. Minor changes according to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Fil

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert added inline comments. Comment at: clang/include/clang/Driver/Options.td:1643 HelpText<"Emit OpenMP code only for SIMD-based constructs.">; +def fopenmp_new_codegen : Flag<["-"], "fopenmp-new-codegen">, Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>, + Hel

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 227902. jdoerfert added a comment. make it a class (NFC) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: clang/include/clang/Basic/LangOptions.def clang/in

[PATCH] D69855: Fix llvm-namespace-comment for macro expansions

twardakm created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. twardakm edited the summary of this revision. twardakm added a project: clang-tools-extra. If a namespace is a macro name, it should be allowed to close the namespace with the same name. This co

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:1-2 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device \ +// RUN: -emit-llvm -x hip

[PATCH] D69791: [ARM,MVE] Add intrinsics for gather/scatter load/stores.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Nice. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69791/new/ https://reviews.llvm.org/D69791 __

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Szelethus added a comment. Hmm, so this checker is rather a collection of CERT rule checkers, right? Shouldn't the checker name contain the actual rule name (STR31-C)? User interfacewise, I would much prefer smaller, leaner checkers than a big one with a lot of options, which are barely support

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added a comment. Also, I think it would better to split LLVM part and clang part into separate patches. Comment at: llvm/include/llvm/IR/OpenMPIRBuilder.h:29 + /// not have an effect on \p M (see initialize). + OpenMPIRBuilder(Module &M) : M(M), Builder(M.getContext(

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:107 +if (!Index) + return NoIndexProvided; + hokein wrote: > ilya-biryukov wrote: > > Why isn't this a scope enum in the first place? > this is tricky, the reas

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

merge_guards_bot added a comment. Build result: fail - 33803 tests passed, 1 failed and 462 were skipped. failed: LLVM.Object/macho-invalid.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

rnk added a comment. > I think a better distinguisher would be whether clang was invoked as > clang[++] or clang-cl (i.e. driver mode). I think Martin said most of what I wanted to say. Making this dependent on the driver mode seems reasonable and would be the easier way forward. If you still

[clang] 15140e4 - [hip] Enable pointer argument lowering through coercing type.

Author: Michael Liao Date: 2019-11-05T13:05:05-05:00 New Revision: 15140e4bacf94fbc509e5a139909aefcd1cc3363 URL: https://github.com/llvm/llvm-project/commit/15140e4bacf94fbc509e5a139909aefcd1cc3363 DIFF: https://github.com/llvm/llvm-project/commit/15140e4bacf94fbc509e5a139909aefcd1cc3363.diff

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao updated this revision to Diff 227908. hliao marked an inline comment as done. hliao added a comment. Add host-side checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69826/new/ https://reviews.llvm.org/D69826 Files: clang/lib/CodeGen/CG

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:757 + lex(Content, LangOpts, [&](const clang::Token &Tok, const SourceManager &SM) { +if (Tok.getK

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 227909. Tyker added a comment. @rsmith Changes: - Rebased on recent master. - Adapted this patch to constexpr destructors. - Fixed issues with handling of temporaries. - Improve Tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https:/

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227910. cmtice marked 9 inline comments as done. cmtice added a comment. Made requested changes: - renamed option to be dwarf-specific - fixed spelling & blank line issues - only set version if emit-dwarf is true - move test to Driver directory I *think* I go

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso added a comment. In D69813#1734193 , @Szelethus wrote: > Hmm, so this checker is rather a collection of CERT rule checkers, right? > Shouldn't the checker name contain the actual rule name (STR31-C)? User > interfacewise, I would much prefer sma

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15140e4bacf9: [hip] Enable pointer argument lowering through coercing type. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69826/new/ ht

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added a comment. In D69785#1734205 , @ABataev wrote: > Also, I think it would better to split LLVM part and clang part into separate > patches. What do you mean exactly and why? C

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert added a comment. FWIW, *I will enable the new pass in some tests before this goes in* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 ___ cfe-commits

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

rnk accepted this revision. rnk added a comment. In D69763#1733382 , @Ericson2314 wrote: > I am curious, how did this work since there is no longer an `lld-link2`? Were > these tests failing or not being run? These tests don't actually need to run the l

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rG87e0cb4f1ad2: [clangd] Implement semantic highlightings via findExplicitReferences (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

yaxunl added a comment. I am a little bit concerned that user may have such code: struct A { int *p; } __global__ kernel(A a) { int x; a.p = &x; f(a); } @arsenm what happens if a private pointer is mis-used as a global pointer? I am wondering if we should coerce byval struct k

[PATCH] D69858: [AArch64][SVE] Implement floating-point comparison & reduction intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, huntergr, dancgr, mgudim. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds intrinsics for the following: - fadda & faddv - fminv, fmaxv, fminnmv & fmaxnmv -

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz marked 2 inline comments as done. ekatz added inline comments. Comment at: llvm/lib/Support/APFloat.cpp:273 + if (p != end) +return createError("Invalid exponent in exponent"); arsenm wrote: > Error message sounds like nonsense It is actually incorr

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added a comment. In D69785#1734292 , @jdoerfert wrote: > In D69785#1734205 , @ABataev wrote: > > > Also, I think it would better to split LLVM part and clang part into > > separate patches. > > > What do yo

[clang-tools-extra] 87e0cb4 - [clangd] Implement semantic highlightings via findExplicitReferences

Author: Ilya Biryukov Date: 2019-11-05T19:15:24+01:00 New Revision: 87e0cb4f1ad299c87c3e26676a9b31b3caf58921 URL: https://github.com/llvm/llvm-project/commit/87e0cb4f1ad299c87c3e26676a9b31b3caf58921 DIFF: https://github.com/llvm/llvm-project/commit/87e0cb4f1ad299c87c3e26676a9b31b3caf58921.diff

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao added a comment. In D69826#1734296 , @yaxunl wrote: > I am a little bit concerned that user may have such code: > > struct A { int *p; } > __global__ kernel(A a) { > int x; > a.p = &x; > f(a); > } > > > @arsenm what happens if a pri

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz updated this revision to Diff 227917. ekatz added a comment. Fixed requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 Files: clang/lib/Lex/LiteralSupport.cpp llvm/include/llvm/ADT/APFloat.h llvm/lib/MC/MCParser/AsmPar

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69766/new/ https://reviews.llvm.org/D69766 ___ cfe-c

[PATCH] D63020: [HIP] Fix visibility for 'extern' device variables.

hliao added a comment. Sam, could you review this? Even though it has no functionality issue so far, from the code sequence, once there's an `addrspacecast` is inserted, we lose the chance to set target specific attributes if any. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

MaskRay added a comment. In D69755#1731420 , @krytarowski wrote: > In D69755#1731394 , @MaskRay wrote: > > > I still have the feeling that such configurations should be added to > > clangDriver/gcc specs or a shell

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

JonChesterfield added inline comments. Comment at: clang/include/clang/Driver/Options.td:1643 HelpText<"Emit OpenMP code only for SIMD-based constructs.">; +def fopenmp_new_codegen : Flag<["-"], "fopenmp-new-codegen">, Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>,

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

yaxunl added a comment. In D69826#1734324 , @hliao wrote: > In D69826#1734296 , @yaxunl wrote: > > > I am a little bit concerned that user may have such code: > > > > struct A { int *p; } > > __global__ kernel(A

[PATCH] D63020: [HIP] Fix visibility for 'extern' device variables.

yaxunl accepted this revision. yaxunl added a subscriber: scchan. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! @scchan This may fix the undefined symbol in work item struct issue at -O0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:173 + } + + // Builds of compiler-rt on bare-metal targets are specialized by specific CodaFi wrote: > phosek wrote: > > Would it be possible to support the [per-target runtimes

  1   2   >