[PATCH] D69475: [clang] Provide better fix-it on exception spec error

jdemeule created this revision. jdemeule added a reviewer: rsmith. jdemeule added a project: clang. Clang will report an error when the exception specification is not respected with a fix-it. However, this fix-it does not fully qualify the type in case of function template specialization which l

[clang] d4758d4 - Fix a spelling mistake in a couple of intrinsic description comments. NFC

Author: Greg Bedwell Date: 2019-10-27T09:42:14Z New Revision: d4758d4a8d842275f4319ae278808be0bcd2ede3 URL: https://github.com/llvm/llvm-project/commit/d4758d4a8d842275f4319ae278808be0bcd2ede3 DIFF: https://github.com/llvm/llvm-project/commit/d4758d4a8d842275f4319ae278808be0bcd2ede3.diff LOG:

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

mrexodia added a comment. I don't really have a say in this, but I was trying to run the python script to generate the rst file and it didn't work. I tried fixing it, but it's definitely very hacky. Perhaps some kind of test can be introduced that runs this python script and checks if it succee

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay added a comment. In D69433#1722463 , @mrexodia wrote: > I don't really have a say in this, but I was trying to run the python script > to generate the rst file and it didn't work. I tried fixing it, but it's > definitely very hacky. Perhap

[PATCH] D31839: make -Winteger-overflow find overflows in function arguments

xbolva00 added a comment. Are you gonna commit this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31839/new/ https://reviews.llvm.org/D31839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 226570. xbolva00 added a comment. Addressed review note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: clang/include/clang/Basic/Builtins.def clang/test/C

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 226571. xbolva00 added a comment. Added new testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: clang/include/clang/Basic/Builtins.def clang/test/CodeG

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

Mordante created this revision. Mordante added reviewers: rnk, rsmith, aaron.ballman. Mordante added a project: clang. This allows the caller of the function to add a note about how to fix the stack exhaustion. This can be useful to aid the user. For example it can be used to show a help message

[PATCH] D69479: [Sema] Warn about possible stack exhaution

Mordante created this revision. Mordante added reviewers: rnk, rsmith, aaron.ballman. Mordante added a project: clang. When a long set of expressions is chained it may overflow the stack. This warns about the issue. Note I'm not sure whether `AnalyzeImplicitConversions` is the best place to add

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

xbolva00 added a comment. Exact use case? Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69478/new/ https://reviews.llvm.org/D69478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D69479: [Sema] Warn about possible stack exhaution

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12349 // This is not the right CC for (e.g.) a variable initialization. - AnalyzeImplicitConversions(*this, E, CC); + analyzeImplicitConversionsWithSufficientStackSpace(*this, E, CC); }

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

Mordante added a comment. The use case and its test are in D69479 . Is that sufficient? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69478/new/ https://reviews.llvm.org/D69478 __

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

xbolva00 added a comment. Yes, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69478/new/ https://reviews.llvm.org/D69478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D69479: [Sema] Warn about possible stack exhaution

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12349 // This is not the right CC for (e.g.) a variable initialization. - AnalyzeImplicitConversions(*this, E, CC); + analyzeImplicitConversionsWithSufficientStackSpace(*this, E, CC); }

[PATCH] D69481: [Sema] Fixes templated friend member assertion

Mordante created this revision. Mordante added reviewers: rjmccall, rsmith, aaron.ballman. Mordante added a project: clang. Mordante added a subscriber: rtrieu. Fixes https://bugs.llvm.org/show_bug.cgi?id=41792 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69481 Files: clan

[clang] faee39b - PR43762: when implicitly changing the active union member for an

Author: Richard Smith Date: 2019-10-27T12:31:16-07:00 New Revision: faee39baa87e43f4b746dd77e479268391163658 URL: https://github.com/llvm/llvm-project/commit/faee39baa87e43f4b746dd77e479268391163658 DIFF: https://github.com/llvm/llvm-project/commit/faee39baa87e43f4b746dd77e479268391163658.diff

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits updated this revision to Diff 226583. jhibbits added a comment. Don't double-check 8548 CPU for setting LLVM CPU type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ https://reviews.llvm.org/D67787 Files: clang/lib/Basic/Targe

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits marked an inline comment as done. jhibbits added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:61 .Case("a2q", "a2q") +.Case("8548", "e500") +.Case("e500", "e500") vit9696 wrote: > That looks like a typo t

[clang] 06d3fce - PR43400: Add test that we can instantiate a friend function that is

Author: Richard Smith Date: 2019-10-27T12:41:53-07:00 New Revision: 06d3fce01d4f4dfd743e24e1f553afbb6709610f URL: https://github.com/llvm/llvm-project/commit/06d3fce01d4f4dfd743e24e1f553afbb6709610f DIFF: https://github.com/llvm/llvm-project/commit/06d3fce01d4f4dfd743e24e1f553afbb6709610f.diff

[PATCH] D69479: [Sema] Warn about possible stack exhaution

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12349 // This is not the right CC for (e.g.) a variable initialization. - AnalyzeImplicitConversions(*this, E, CC); + analyzeImplicitConversionsWithSufficie

[PATCH] D69479: [Sema] Warn about possible stack exhaution

Mordante updated this revision to Diff 226590. Mordante marked an inline comment as done. Mordante added a comment. Add an extra argument to `AnalyzeImplicitConversions` as suggested by @xbolva00 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69479/new/ https://reviews.llvm.org/D69479

[PATCH] D69479: [Sema] Warn about possible stack exhaution

rsmith added a comment. We should resist using `runWithSufficientStackSpace` where possible. Have you tried making this process data-recursive instead? It looks fairly straightforward to form a worklist of expressions to which we want to apply `AnalyseImplicitConversions`, and run through that

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis marked 3 inline comments as done. abelkocsis added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-bad-signal-to-kill-thread.rst:8 +``SIGTERM`` signal and the signal kills the entire process, not just the +individual thread. Use any signal e

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 226596. abelkocsis marked 4 inline comments as done. abelkocsis added a comment. Checker moved to bugprone module, cert alias added. Small fixes in checker file, warning message updated. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION ht

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 226598. abelkocsis marked an inline comment as done. abelkocsis added a comment. Small fixes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-tools-extr

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

JonChesterfield added a reviewer: grokos. JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69494/new/ https://reviews.llvm.org/D69494 _

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

arsenm added a comment. In D69494#1722853 , @ABataev wrote: > Tests? In D69494#1722853 , @ABataev wrote: > Tests? This is NFC and doesn't change any behavior. The test for the convergent attribute is already

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

ABataev added a comment. In D69494#1722867 , @arsenm wrote: > In D69494#1722853 , @ABataev wrote: > > > Tests? > > > > > In D69494#1722853 , @ABataev wrote: > > > Tests? > >

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

arsenm added a comment. In D69494#1722868 , @ABataev wrote: > In D69494#1722867 , @arsenm wrote: > > > In D69494#1722853 , @ABataev wrote: > > > > > Tests? > > > > > > > > >

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. Ah, yes, missed this. Then just add a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69494/new/ https://reviews.llvm.org/D69494 __

[PATCH] D69493: Add -fconvergent-functions flag

arsenm added a comment. In D69493#1722894 , @jlebar wrote: > I'm confused about "The CUDA builtin library is apparently compiled in C++ > mode". By...whom, and for what purposes? > > No objections from me, this seems reasonable regardless, but I'd also l

[clang] 40ab8ae - OpenMP: Add helper function for convergent runtime calls

Author: Matt Arsenault Date: 2019-10-27T21:26:55-07:00 New Revision: 40ab8ae9fb70f1550815bf0f867148b5101a4f66 URL: https://github.com/llvm/llvm-project/commit/40ab8ae9fb70f1550815bf0f867148b5101a4f66 DIFF: https://github.com/llvm/llvm-project/commit/40ab8ae9fb70f1550815bf0f867148b5101a4f66.diff

[clang] 56a503b - OpenMP: Add convergent to more runtime functions

Author: Matt Arsenault Date: 2019-10-27T21:26:55-07:00 New Revision: 56a503bdba9c33fce4d8fe86494cfd9c0b62c88a URL: https://github.com/llvm/llvm-project/commit/56a503bdba9c33fce4d8fe86494cfd9c0b62c88a DIFF: https://github.com/llvm/llvm-project/commit/56a503bdba9c33fce4d8fe86494cfd9c0b62c88a.diff

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

arsenm closed this revision. arsenm added a comment. r40ab8ae9fb70f1550815bf0f867148b5101a4f66 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69494/new/ https://reviews.llvm.org/D69494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69495: OpenMP: Add convergent to more runtime functions

arsenm closed this revision. arsenm added a comment. 56a503bdba9c33fce4d8fe86494cfd9c0b62c88a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69495/new/ https://reviews.llvm.org/D69495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] 39eef2c - PR43775: don't produce a bogus 'auto' -Wc++98-compat warning for CTAD

Author: Richard Smith Date: 2019-10-27T21:42:58-07:00 New Revision: 39eef2cbb6ab1fda2e0beb8789cd49a3ce276b16 URL: https://github.com/llvm/llvm-project/commit/39eef2cbb6ab1fda2e0beb8789cd49a3ce276b16 DIFF: https://github.com/llvm/llvm-project/commit/39eef2cbb6ab1fda2e0beb8789cd49a3ce276b16.diff

[clang-tools-extra] 1a9c01c - [clangd] Pass ExtraArgs to TestTU in TweakIsAvailable matcher

Author: Kadir Cetinkaya Date: 2019-10-28T07:18:26+01:00 New Revision: 1a9c01c7f6c7e88676440869bbbe9f43fa45b109 URL: https://github.com/llvm/llvm-project/commit/1a9c01c7f6c7e88676440869bbbe9f43fa45b109 DIFF: https://github.com/llvm/llvm-project/commit/1a9c01c7f6c7e88676440869bbbe9f43fa45b109.dif

[clang] a4facd3 - [c++20] Enforce rule that a union-like class or class with reference

Author: Richard Smith Date: 2019-10-27T23:26:44-07:00 New Revision: a4facd355dc36bc83d5c2402856f5a3741890c9a URL: https://github.com/llvm/llvm-project/commit/a4facd355dc36bc83d5c2402856f5a3741890c9a DIFF: https://github.com/llvm/llvm-project/commit/a4facd355dc36bc83d5c2402856f5a3741890c9a.diff

[clang-tools-extra] 5ab9a85 - [clangd] Reland DefineInline action availability checks

Author: Kadir Cetinkaya Date: 2019-10-28T07:28:21+01:00 New Revision: 5ab9a850f6bde53974798ee285a06335fb788ae5 URL: https://github.com/llvm/llvm-project/commit/5ab9a850f6bde53974798ee285a06335fb788ae5 DIFF: https://github.com/llvm/llvm-project/commit/5ab9a850f6bde53974798ee285a06335fb788ae5.dif

[clang-tools-extra] 3d65def - [clangd] Reland DefineInline action apply logic with fully qualified names

Author: Kadir Cetinkaya Date: 2019-10-28T07:45:38+01:00 New Revision: 3d65def1fd2febe5c1748de6f5ce009712e88f31 URL: https://github.com/llvm/llvm-project/commit/3d65def1fd2febe5c1748de6f5ce009712e88f31 DIFF: https://github.com/llvm/llvm-project/commit/3d65def1fd2febe5c1748de6f5ce009712e88f31.dif

[clang-tools-extra] f4d7caf - [clangd] Reland Store Index in Tweak::Selection

Author: Kadir Cetinkaya Date: 2019-10-28T07:55:58+01:00 New Revision: f4d7caf6df819d18b4d5b460d21f7f8fe1e1b705 URL: https://github.com/llvm/llvm-project/commit/f4d7caf6df819d18b4d5b460d21f7f8fe1e1b705 DIFF: https://github.com/llvm/llvm-project/commit/f4d7caf6df819d18b4d5b460d21f7f8fe1e1b705.dif