[PATCH] D29039: [clang-format] Proposal for clang-format -r option

MyDeveloperDay added a comment. Comment at: tools/clang-format/ClangFormat.cpp:345 + + Regex regex(FileNames[i]); + I could imagine the path you supplying being just a directory . or ../../include/Format as much as a wild card, once in that directory I

r374285 - [clang] prevent crash for nonnull attribut in constant context (Bug 43601)

Author: tyker Date: Thu Oct 10 00:13:20 2019 New Revision: 374285 URL: http://llvm.org/viewvc/llvm-project?rev=374285&view=rev Log: [clang] prevent crash for nonnull attribut in constant context (Bug 43601) Summary: bug : https://bugs.llvm.org/show_bug.cgi?id=43601 Reviewers: rnk Reviewed By:

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

klimek added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { tra wrote: > hliao wrote: >

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a subscriber: eli.friedman. serge-sans-paille added a comment. @efriedma the free probe algorithm requires more testing, and I'd like to take into account memset and memcpy as free probes too. To showcase this algorithm, consider the following LLVM bitcode: define i32

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

klimek added a comment. In D68554#1702090 , @MyDeveloperDay wrote: > As this behaviour is not something clang-format should do because there are > external tool that can do this for us, I thought I'd set myself a challenge > of trying to write this with

[PATCH] D68716: [clang] prevent crash for nonnull attribut in constant context (Bug 43601)

This revision was automatically updated to reflect the committed changes. Closed by commit rG59c6df9b2c52: [clang] prevent crash for nonnull attribut in constant context (Bug 43601) (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D68743: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 2.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks again, looks good. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68743/new/ https://reviews.llvm.org/D68743 _

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 224271. gchatelet added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/Att

Re: r374006 - Reland 'Add VFS support for sanitizers' blacklist'

Thanks, Jan. And one more time, sorry about the inconvenience. On Thu, Oct 10, 2019 at 12:47 AM Jan Korous wrote: > Ok, no worries. I understand the reason for the revert and will rewrite > the patch. > > > On Oct 9, 2019, at 7:19 AM, Ilya Biryukov wrote: > > Fair enough, sorry about that. > >

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:157 +if (canHighlightName(E->getName())) + addToken(E->getNameLoc(), HighlightingKind::DependentName); +return true; Could we highlighting based on the

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet added a comment. It should be ready to submit, @aaron.ballman @courbet can you take a final look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 ___

[PATCH] D68767: [clang-format] NFC - Move functionality into functions to help code structure

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, owenpan. MyDeveloperDay added a project: clang-format. Herald added a project: clang. I don't think its the main()'s responsibility to be working out how to dump the config, or the format()'s responsi

r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

Author: sjoerdmeijer Date: Thu Oct 10 01:27:14 2019 New Revision: 374288 URL: http://llvm.org/viewvc/llvm-project?rev=374288&view=rev Log: Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)" This was further discussed at the llvm dev list: http://lists.llvm.org/pipermail/llvm-d

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

dmgreen added a subscriber: rsmith. dmgreen accepted this revision. dmgreen added a comment. Yeah, OK. D67678 is the patch that will change the default, but only to "int", not to "none" for the moment. An earlier version of that patch had a different way of sett

[PATCH] D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer

EricWF accepted this revision. EricWF added inline comments. This revision is now accepted and ready to land. Comment at: libcxx/test/support/any_helpers.h:30 {}; template bool containsType(std::any const& a) { LGTM. Repository: rG LLVM Github Monorepo

[PATCH] D68028: [clang] Add no_builtin attribute

courbet added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3418 + let Spellings = [Clang<"no_builtin">]; + let Args = [VariadicStringArgument<"FunctionNames">]; + let Subjects = SubjectList<[Function]>; [nit] Should this be `BuiltinNames` ? b

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer added a comment. I have commit all my pragma patches, so now back to the last bit, this doc update. This doc change should now reflect our implementation. Are we happy for this to go in? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66199/new/ https://reviews.llvm.org/D6

[PATCH] D68710: Remove time-trace message as it is inconsistent style

russell.gallop marked 2 inline comments as done. russell.gallop added inline comments. Comment at: clang/include/clang/Driver/Options.td:1797 + HelpText<"Turn on time profiler. Generates JSON file based on output filename. " + "Results can be analyzed with chrome://tr

[PATCH] D68710: Remove time-trace message as it is inconsistent style

russell.gallop updated this revision to Diff 224278. russell.gallop added a comment. Update so --help helps user find trace file. Documentation has the further details on how to view it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68710/new/ https://reviews.llvm.org/D68710 Files: c

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

JonasToth added a comment. In D68694#1701772 , @aaron.ballman wrote: > > In my opinion this check should be disabled in case of integer literals, > > since there are a lot of existing code (even in system libraries) where > > user can do nothing, e.g.:

[PATCH] D68710: Remove time-trace message as it is inconsistent style

anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. Yes, I agree. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68710/new/ https://reviews.llvm.org/D68710 ___ cfe-c

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille marked 3 inline comments as done. serge-sans-paille added inline comments. Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:400 +!(STI.isOSWindows() && !STI.isTargetMachO()); +if (InlineStackClashProtector && !InEpilogue) { + const uint64_t

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 224285. gchatelet marked 2 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/inclu

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 224286. gchatelet added a comment. - Fix missing rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/Basic/Attr.td clang/include/cla

r374294 - Remove rest of time-trace message as it is inconsistent style

Author: russell_gallop Date: Thu Oct 10 02:33:53 2019 New Revision: 374294 URL: http://llvm.org/viewvc/llvm-project?rev=374294&view=rev Log: Remove rest of time-trace message as it is inconsistent style Other options which create output files don't produce output messages. Improve documentation t

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

simon_tatham updated this revision to Diff 224288. simon_tatham marked 3 inline comments as done. simon_tatham added a comment. Removed spuriously inserted blank line and redundant `checkAttributeNumArgs`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D68710: Remove time-trace message as it is inconsistent style

This revision was automatically updated to reflect the committed changes. russell.gallop marked an inline comment as done. Closed by commit rG9d9ac46a08d7: Remove rest of time-trace message as it is inconsistent style (authored by russell.gallop). Changed prior to commit: https://reviews.llvm.o

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:371 + if (!Replaces.empty()) { +IntrusiveRefCntPtr DiagOpts = +new DiagnosticOptions(); klimek wro

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. > I think it's easy enough to do as a kind of driver, either in python or C++, > but then again, at that point putting it into ClangFormat seems fine. One > thing that I find on the one side kinda nice, but on the o

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

tellenbach added a comment. This patch would fix PR37240 but is probably not the most optimal solution. For other ideas see http://lists.llvm.org/pipermail/llvm-dev/2019-September/135433.html . I'll leave this patch open unt

[PATCH] D68581: Include leading attributes in DeclStmt's SourceRange

sberg updated this revision to Diff 224303. sberg edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68581/new/ https://reviews.llvm.org/D68581 Files: clang/lib/Parse/ParseStmt.cpp clang/test/AST/sourceranges.cpp Index: clang/test/AST/sourceranges.cp

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

russell.gallop added a comment. This is failing the sanitizer lint check: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/23819/steps/64-bit%20check-sanitizer/logs/stdio /compiler-rt/lib/ubsan/ubsan_checks.inc:22: Lines should be <= 80 characters long [whitespace/line_length] [

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri added a comment. In D67122#1703482 , @russell.gallop wrote: > This is failing the sanitizer lint check: > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/23819/steps/64-bit%20check-sanitizer/logs/stdio > > /compiler-rt/lib/u

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri added a comment. Not unexpectedly, this broke sanitizer-x86_64-linux-bootstrap-ubsan. I'm going to attempt to address uncovered issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67122/new/ https://reviews.llvm.org/D67122 __

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

klimek added a comment. In D68554#1703358 , @MyDeveloperDay wrote: > > I think it's easy enough to do as a kind of driver, either in python or > > C++, but then again, at that point putting it into ClangFormat seems fine. > > One thing that I find on th

r374324 - Revert "Use -fdebug-compilation-dir to form absolute paths in coverage mappings"

Author: kadircet Date: Thu Oct 10 05:20:11 2019 New Revision: 374324 URL: http://llvm.org/viewvc/llvm-project?rev=374324&view=rev Log: Revert "Use -fdebug-compilation-dir to form absolute paths in coverage mappings" This reverts commit f6777964bde28c349d3e289ea37ecf5f5eeedbc4. Because the absolu

r374328 - [AST] ASTReader::ReadSLocEntry(): move computation of FirstDecl into the branch where it's used

Author: lebedevri Date: Thu Oct 10 05:22:42 2019 New Revision: 374328 URL: http://llvm.org/viewvc/llvm-project?rev=374328&view=rev Log: [AST] ASTReader::ReadSLocEntry(): move computation of FirstDecl into the branch where it's used The existing code is not defined, you are not allowed to produce

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri added a comment. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/15329/steps/annotate/logs/stdio appears to contain "only" 3 distinct issues. I've pushed those 3 fixes, but maybe that is not enough, we'll see. Repository: rG LLVM Github Monorepo CHA

[PATCH] D67608: [ARM] Preserve fpu behaviour for '-crypto'

dnsampaio updated this revision to Diff 224323. dnsampaio added a comment. Attending review request: - Fixed to only add '-crypto' when not passing -fno-integrated-as - Fixed test to use arm-none-none-eabi - Changed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D67608: [ARM] Preserve fpu behaviour for '-crypto'

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. Thanks for the update. That looks good to me. Will be good to wait for a day before committing to give US timezone a chance to object. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D63131: arm64_32: implement the desired ABI for the ILP32 triple.

t.p.northover added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63131/new/ https://reviews.llvm.org/D63131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

gribozavr added a comment. Sorry, but this commit broke OCaml tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19014 I reverted it in r374354. Please test before re-landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D616

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! In D66049#1701730 , @dkrupp wrote: > I also analyzed openssl with the baseline and this version, but did not find > any new warnings. > Se

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

cameron.mcinally added a comment. > I reverted it in r374354. Please test before re-landing. Hmm, how do I run those tests? I did not see that failure with check-all. That's a pretty straightforward failure. It's just a one-line IR change: `fsub float {{.*}}0{{.*}}, %F1` -> `fneg float %F1` R

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: Same question as before: maybe better

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added a comment. I looked over the codegen testcase fpconstrained.c and it looks pretty good, so i think this is ready for your review comments. I'll be off the grid for a couple days but looking forward to receiving your feedback. I inserted a

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

cameron.mcinally added a comment. In D61675#1703749 , @cameron.mcinally wrote: > > I reverted it in r374354. Please test before re-landing. > > Hmm, how do I run those tests? I did not see that failure with check-all. > > That's a pretty straightforward f

r374363 - [OPENMP50]Register vendor name only once in vendor context selector.

Author: abataev Date: Thu Oct 10 08:15:26 2019 New Revision: 374363 URL: http://llvm.org/viewvc/llvm-project?rev=374363&view=rev Log: [OPENMP50]Register vendor name only once in vendor context selector. No need to store multiple copies of the same vendor names in the context selector, keep only s

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 ___

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, nhaehnle, jvesely, arsenm. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4abac5330277: In openFileForRead don't cache erroneous entries if the error relates to them… (authored by kousikk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D68795: [libTooling] Introduce a single, "main" header file for Transformer.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a subscriber: jfb. Herald added a project: clang. Split the existing `Transformer.h` into two new files, with more focused purpose: `RewriteRule.h` and `TransformerTool.h`. The file `Transformer.h` is repurposed to co

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

gchatelet added a comment. @courbet there's a slight difference in the way the field is serialized in the mir / ir format (hence not [NFC]) but there's no change in semantics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68792/new/ https://review

[PATCH] D68795: [libTooling] Introduce a single, "main" header file for Transformer.

gribozavr added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:28 +// also update their code to reference `TransformerTool`. +#include "clang/Tooling/Transformer/TransformerTool.h" +// Temporary alias to assist clients in migrating to new class

[PATCH] D68807: [ClangTidy] Separate tests for infrastructure and checkers

gribozavr created this revision. Herald added subscribers: cfe-commits, lebedev.ri, jfb, arphaman, mgrang, christof, kbarton, aheejin, nemanjai, srhines. Herald added a reviewer: jfb. Herald added a reviewer: jdoerfert. Herald added a reviewer: lebedev.ri. Herald added a project: clang. gribozavr

[PATCH] D67550: [AArch64][SVE] Implement unpack intrinsics

greened added inline comments. Comment at: lib/Target/AArch64/SVEInstrFormats.td:836 class sve_int_perm_unpk sz16_64, bits<2> opc, string asm, -ZPRRegOp zprty1, ZPRRegOp zprty2> +ZPRRegOp zprty1, ZPRRegOp zprty2, SDPatternOperator

[PATCH] D67551: [AArch64][SVE] Implement sdot and udot (lane) intrinsics

greened added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67551/new/ https://reviews.llvm.org/D67551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri added a comment. In D67122#1703616 , @lebedev.ri wrote: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/15329/steps/annotate/logs/stdio > appears to contain "only" 3 distinct issues. > I've pushed those 3 fixe

[PATCH] D29039: [clang-format] Proposal for clang-format -r option

zturner added a comment. In Windows you just write a Python script to do this, and this works everywhere, not just on one platform or the other, so bash isn't even necessary and Python is easy to write so I wouldn't really say it's "even harder". If you google for `run-clang-format.py` you'll

[PATCH] D66199: [docs] loop pragmas

hsaito added inline comments. Comment at: docs/LanguageExtensions.rst:3069 +There are loop hints that control transformations (e.g. vectorization, loop +unrolling) and there loop hints that set transformation options (e.g. +``vectorize_width``, ``unroll_count``). Pragmas setting

[PATCH] D68795: [libTooling] Introduce a single, "main" header file for Transformer.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:28 +// also update their code to reference `TransformerTool`. +#include "clang/Tooling/Transformer/TransformerTool.h" +// Temporary alias to

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao created this revision. hliao added reviewers: tra, rsmith, yaxunl. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. - HIP/CUDA host side needs to use device kernel symbol name to match the device side b

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. this's a patch address the same issue previously proposed to be worked around in https://reviews.llvm.org/D63164 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 ___

r374387 - [OPENMP50]Support for declare variant directive for NVPTX target.

Author: abataev Date: Thu Oct 10 10:28:10 2019 New Revision: 374387 URL: http://llvm.org/viewvc/llvm-project?rev=374387&view=rev Log: [OPENMP50]Support for declare variant directive for NVPTX target. NVPTX does not support global aliases. Instead, we have to copy the full body of the variant func

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay updated this revision to Diff 224403. MyDeveloperDay added a comment. builds ontop of D68767: [clang-format] NFC - Move functionality into functions to help code structure move replacement warnings into a separate function and move outputXML out i

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. In D68554#1703596 , @klimek wrote: > I ran through the same line of reasoning in my head when writing my last > comment :) The argument about the readability of error messages by tools is > definitely a good one, so I'd sa

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao marked 2 inline comments as done. hliao added a comment. minor comment to help review. BTW, as the AST ser/deser is changed as well, not sure we have compatibility issue and, if there is, how to handle that. please advice me on that concern. Thanks. Comment at: clang/i

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 reclaimed this revision. xbolva00 added a comment. (still interested in this patch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

r374399 - [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

Author: paulhoad Date: Thu Oct 10 10:54:47 2019 New Revision: 374399 URL: http://llvm.org/viewvc/llvm-project?rev=374399&view=rev Log: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl Summary: An incorrect assertion is thrown when clang-formatting MSVC's STL

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, many thanks! A few last NITs too Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:31 +/// std::vector foo(std::map); +// C

[PATCH] D68795: [libTooling] Introduce a single, "main" header file for Transformer.

ymandel updated this revision to Diff 224414. ymandel added a comment. Herald added a subscriber: mgorny. Removed umbrella-header, as per discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68795/new/ https://reviews.llvm.org/D68795 Files:

[PATCH] D68795: [libTooling] Introduce a single, "main" header file for Transformer.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:28 +// also update their code to reference `TransformerTool`. +#include "clang/Tooling/Transformer/TransformerTool.h" +// Temporary alias to

r374403 - Re-land "Use -fdebug-compilation-dir to form absolute paths in coverage mappings"

Author: rnk Date: Thu Oct 10 11:01:20 2019 New Revision: 374403 URL: http://llvm.org/viewvc/llvm-project?rev=374403&view=rev Log: Re-land "Use -fdebug-compilation-dir to form absolute paths in coverage mappings" This reverts r374324 (git commit 62808631acceaa8b78f8ab9b407eb6b943ff5f77) I change

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

dkrupp added a comment. @aaron.ballman could you please commit? I don't have commit access. Thx. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55125/new/ https://reviews.llvm.org/D55125 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b4c8f680712: [clang-format] throws an incorrect assertion in consumeToken() formatting the… (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D68707?vs=224075&id=224415#to

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer updated this revision to Diff 224421. SjoerdMeijer added a comment. Thanks! Typo fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66199/new/ https://reviews.llvm.org/D66199 Files: clang/docs/LanguageExtensions.rst Index: clang/docs/LanguageExtensions.rst ==

[PATCH] D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer

This revision was automatically updated to reflect the committed changes. Closed by commit rGffc83995de6d: [libc++][test] Change IsSmallObject's calculation for std::any's small object… (authored by CaseyCarter). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D66199: [docs] loop pragmas

hsaito accepted this revision. hsaito added a comment. This revision is now accepted and ready to land. LGTM. Please wait for a few days in case others have more comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66199/new/ https://reviews.llvm.org/D66199 ___

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer added a comment. Sure, will do, thanks again for taking a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66199/new/ https://reviews.llvm.org/D66199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

r374416 - Update clang tests for new LLVM IR backslash printing in r374415

Author: rnk Date: Thu Oct 10 11:36:41 2019 New Revision: 374416 URL: http://llvm.org/viewvc/llvm-project?rev=374416&view=rev Log: Update clang tests for new LLVM IR backslash printing in r374415 Modified: cfe/trunk/test/CodeGen/debug-prefix-map.c cfe/trunk/test/CodeGen/string-literal.c

r374418 - Fix one more clang test which didn't have \5C in it

Author: rnk Date: Thu Oct 10 11:42:06 2019 New Revision: 374418 URL: http://llvm.org/viewvc/llvm-project?rev=374418&view=rev Log: Fix one more clang test which didn't have \5C in it Modified: cfe/trunk/test/CoverageMapping/abspath.cpp Modified: cfe/trunk/test/CoverageMapping/abspath.cpp URL:

r374419 - [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 2.

Author: efriedma Date: Thu Oct 10 11:45:34 2019 New Revision: 374419 URL: http://llvm.org/viewvc/llvm-project?rev=374419&view=rev Log: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 2. Just running -fsyntax-only over arm_neon.h doesn't cover some intrinsics which are defined using

[PATCH] D68743: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 2.

This revision was automatically updated to reflect the committed changes. Closed by commit rG30a96d3fcb76: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 2. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D68743?vs=224229&id=224432#toc Repository: rG

[PATCH] D68753: [CUDA][HIP} Add a test for constexpr default ctor

tra added inline comments. Comment at: test/SemaCUDA/constexpr-ctor.cu:14-27 +template struct B { + T a; + constexpr B() = default; +}; + +template struct C { + T a; Do we really need three identical templates? If they are needed to let compiler emit multip

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 224431. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Added test case, statistics and refactor interactions with existing stack probing mechanism. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

cameron.mcinally added a subscriber: RKSimon. cameron.mcinally added a comment. @gribozavr I see that you also reverted @RKSimon's commit for the OCaml/core.ml failure: Author: gribozavr Date: Thu Oct 10 07:16:58 2019 New Revision: 374357 URL: http://llvm.org/viewvc/llvm-project?rev=3

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. Some early stats: on the sqlite amalgamation [0], the free probe reuse allows to skip 123 out of the 474 probes needed during frame lowering. [0] https://www.sqlite.org/download.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D68823: Fix help message for -ffp-contract

yaxunl created this revision. yaxunl added a reviewer: tra. https://reviews.llvm.org/D68823 Files: include/clang/Driver/Options.td Index: include/clang/Driver/Options.td === --- include/clang/Driver/Options.td +++ include/clang/D

[PATCH] D68720: Support -fstack-clash-protection for x86

xbolva00 added inline comments. Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:479 +} +if (std::any_of(MI.operands_begin(), MI.operands_end(), +[](MachineOperand &MO) { return MO.isFI(); })) { nit: llvm::any_of Repository: rG

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao updated this revision to Diff 224443. hliao added a comment. add more assertions on offload compilation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68660/new/ https://reviews.llvm.org/D68660 Files: clang/lib/Tooling/Tooling.cpp clang/

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { -

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

lebedev.ri added a comment. Thanks, i like it. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2058-2073 +/* void CodeGenFunction::EmitAlignmentAssumption(llvm::Value *PtrValue, QualType Ty, SourceLocation Loc,

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane created this revision. erichkeane added reviewers: lebedev.ri, hfinkel, joey, jdoerfert. lebedev.ri added a comment. Thanks, i like it. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2058-2073 +/* void CodeGenFunction::EmitAlignmentAssumption(llvm::Value *PtrValu

[PATCH] D68753: [CUDA][HIP} Add a test for constexpr default ctor

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: test/SemaCUDA/constexpr-ctor.cu:14-27 +template struct B { + T a; + constexpr B() = default; +}; + +template struct C { + T a; tra wrote: > Do we really need three identical t

[PATCH] D68825: [libTooling] Change Stencil equality to use `toString()`

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. ymandel edited the summary of this revision. Removes the `isEqual` method from StencilPartInterface and modifies equality to use the string representation returned by the `toString` method for compar

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane updated this revision to Diff 224449. erichkeane added a comment. Remove unused code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/CodeGen/CGBuiltin.cpp clang/l

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2854 +def warn_assume_align_too_big : Warning<"alignments greater than 1 << 29 are " + "unsupported by LLVM">, InGroup; Should this be in the IgnoredAttributes group? T

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 224453. nridge added a comment. Updated to use heuristics based on OverloadExpr::decl() Also folded VisitUnresolvedLookupExpr and VisitUnresolvedMemberExpr together into a single VisitOverloadExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked 3 inline comments as done. nridge added a comment. I like how we went from using heuristics, to not using heuristics, to using heuristics again :) But admittedly, the new heuristics are more accurate because they're based on phase 1 lookup results rather than just syntax, so I'm h

  1   2   >