gribozavr added inline comments.

================
Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:28
+// also update their code to reference `TransformerTool`.
+#include "clang/Tooling/Transformer/TransformerTool.h"
+// Temporary alias to assist clients in migrating to new class name.
----------------
I'm not a fan of umbrella headers... especially if they don't cover everything.

I think "include what you use" is a better rule.

The rest of the patch makes sense to me, just not this file. (OK to keep it 
temporarily if we need it to help clients migrate, of course.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68795/new/

https://reviews.llvm.org/D68795



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to