[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:256 + SourceLocation getBeginningOfIdentifier(const Position &Pos, const SourceManager &SM, hokein wrote: > the function name doesn'

[clang-tools-extra] r373304 - [clang-tidy] Fix module registry name and description for Darwin clang-tidy module.

Author: gribozavr Date: Tue Oct 1 00:17:26 2019 New Revision: 373304 URL: http://llvm.org/viewvc/llvm-project?rev=373304&view=rev Log: [clang-tidy] Fix module registry name and description for Darwin clang-tidy module. Summary: When creating the module, must have copy-pasted from the misc modul

[PATCH] D68251: [clang-tidy] Fix module registry name and description for Darwin clang-tidy module.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373304: [clang-tidy] Fix module registry name and description for Darwin clang-tidy… (authored by gribozavr, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[clang-tools-extra] r373305 - [clangd] Handle OverloadExpr in targetDecl

Author: ibiryukov Date: Tue Oct 1 00:27:55 2019 New Revision: 373305 URL: http://llvm.org/viewvc/llvm-project?rev=373305&view=rev Log: [clangd] Handle OverloadExpr in targetDecl Reviewers: sammccall Reviewed By: sammccall Subscribers: nridge, MaskRay, jkorous, arphaman, kadircet, usaxena95, c

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Hi, On 2019-09-27 10:13, Hans Wennborg wrote: > Committed a fix in r373049, and I'll ask to have it merged for 9.0.1 > as well. Sorry again for the breakage. No worries. Thanks for the fix! /Mikael > > On Thu, Sep 26, 2019 at 7:09 PM Mikael Holmén > wrote: >> >> Hi, >> >> As Karl-Johan said I

[PATCH] D68119: [clangd] Handle OverloadExpr in targetDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL373305: [clangd] Handle OverloadExpr in targetDecl (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D68260: Decrease the verbosity of the -ftime-trace optionAnd move the relevant information in the doc.

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: anton-afanasyev. Herald added a project: clang. Currently, building a large software like Firefox shows 'Use chrome://tracing or Speedscope App (https://www.speedscope.app) for flamegraph visualization' for each file. Repo

[PATCH] D68260: Decrease the verbosity of the -ftime-trace optionAnd move the relevant information in the doc.

anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. I believe it's better solution, LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68260/new/ https://reviews.llvm.org/D68260 ___

r373308 - Decrease the verbosity of the -ftime-trace option

Author: sylvestre Date: Tue Oct 1 00:52:42 2019 New Revision: 373308 URL: http://llvm.org/viewvc/llvm-project?rev=373308&view=rev Log: Decrease the verbosity of the -ftime-trace option And move the relevant information in the doc. Summary: Currently, building a large software like Firefox shows

[PATCH] D68137: [clangd] Handle template arguments in findExplicitReferences

ilya-biryukov marked 6 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:556 + // We re-define Traverse*, since there's no corresponding Visit*. + bool TraverseTemplateArgumentLoc(TemplateArgumentLoc A) { ---

[PATCH] D68260: Decrease the verbosity of the -ftime-trace optionAnd move the relevant information in the doc.

sylvestre.ledru added a comment. thanks :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68260/new/ https://reviews.llvm.org/D68260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D68137: [clangd] Handle template arguments in findExplicitReferences

ilya-biryukov updated this revision to Diff 222554. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Restore dlog() - Check reference to function pointer non-type template parameters in tests - Extend comment of TraverseTemplateArgumentLoc Repository: rG LLVM Gi

[PATCH] D68260: Decrease the verbosity of the -ftime-trace optionAnd move the relevant information in the doc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373308: Decrease the verbosity of the -ftime-trace option (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov added a comment. In D66647#1686021 , @kadircet wrote: > So currently AST doesn't store any information regarding template parameter > locations except the deepest one. > Therefore I've changed the availability to discard any methods inside

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Looking at this I'm wondering if this Isn't at least partially handled by the `BreakConstructorInitializersStyle` in combination with `ConstructorInitializerAllOnOne

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

kadircet created this revision. kadircet added reviewers: ilya-biryukov, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68261 Files: clang-tools-extra/clangd/re

r373312 - [clang][lldb][NFC] Encapsulate ExternalASTMerger::ImporterSource

Author: teemperor Date: Tue Oct 1 02:02:05 2019 New Revision: 373312 URL: http://llvm.org/viewvc/llvm-project?rev=373312&view=rev Log: [clang][lldb][NFC] Encapsulate ExternalASTMerger::ImporterSource NFC preparation work for upcoming ExternalASTMerger patches. Modified: cfe/trunk/include/cl

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

krasimir added inline comments. Comment at: clang/lib/Format/Format.cpp:1828 +// Replace "\r\n" with "\n" +std::string replaceCRLF(std::string Code) { nit: missing trailing fullstop. Comment at: clang/lib/Format/Format.cpp:1832 + while ((Pos

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet updated this revision to Diff 222562. kadircet added a comment. - Fix getSemiColon to handle semicolons at the end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D66647 Files: clang-tools-extra

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske updated this revision to Diff 222566. balazske added a comment. - Various code cleanups. Eval functions use CallEvent, CallExpr is removed from state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67706/new/ https://reviews.llvm.org/D6770

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet updated this revision to Diff 222567. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68143/new/ https://reviews.llvm.org/D68143 Files: clang/lib/AST/

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +return SourceRange(getBeginLoc()); --

[PATCH] D68137: [clangd] Handle template arguments in findExplicitReferences

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68137/new/ https://reviews.llvm.org/D68137 __

[PATCH] D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:231 + if (const Stmt *S = Child->ASTNode.get()) +if (EnclosingFunc->hasBody() &

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for this patch, (and by your patience ;-) ) This LGTM, Were there any objections from anyone else? otherwise I'd say this was ok. Repository: rC Clang CHANGES S

[clang-tools-extra] r373318 - [clangd] Handle template arguments in findExplicitReferences

Author: ibiryukov Date: Tue Oct 1 03:02:23 2019 New Revision: 373318 URL: http://llvm.org/viewvc/llvm-project?rev=373318&view=rev Log: [clangd] Handle template arguments in findExplicitReferences Reviewers: kadircet Reviewed By: kadircet Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-

[PATCH] D68137: [clangd] Handle template arguments in findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rL373318: [clangd] Handle template arguments in findExplicitReferences (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:110 // begins in selection range, ends in selection range and any scope that begins // outside the selection range, ends outside as well. const Node *getParentOfRootStmts(c

[PATCH] D68211: [clangd] Use the index-based API to do the header-source switch.

hokein updated this revision to Diff 222574. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68211/new/ https://reviews.llvm.org/D68211 Files: clang-tools-extra/cla

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

ilya-biryukov added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +return SourceRange(getBeginLoc()); -

[clang-tools-extra] r373320 - [clangd] Use the index-based API to do the header-source switch.

Author: hokein Date: Tue Oct 1 03:21:15 2019 New Revision: 373320 URL: http://llvm.org/viewvc/llvm-project?rev=373320&view=rev Log: [clangd] Use the index-based API to do the header-source switch. Summary: If the file heuristic fails, we try to use the index&AST to do the header/source inference

[PATCH] D68211: [clangd] Use the index-based API to do the header-source switch.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373320: [clangd] Use the index-based API to do the header-source switch. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

ilya-biryukov added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +return SourceRange(getBeginLoc()); -

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet updated this revision to Diff 222581. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68143/new/ https://reviews.llvm.org/D68143 Files: clang/lib/AST/DeclTemplate.cpp clang/lib/Parse/ParseTem

[PATCH] D68024: [clangd] Implement GetEligiblePoints

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:610 + /*FullyQualifiedName=*/const char *, + /*Curr

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein updated this revision to Diff 222583. hokein marked 2 inline comments as done. hokein added a comment. add one more testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67695/new/ https://reviews.llvm.org/D67695 Files: clang-tools-extr

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:330 + "/^/ comments", // non-interesting token + "void f(int abc) { abc ^ ++; }",// whitespace + "void f(int abc) { ^abc^++; }", // range of iden

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

SureYeaah updated this revision to Diff 222585. SureYeaah marked 2 inline comments as done. SureYeaah added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68182/new/ https://reviews.llvm.org/D68182 Files: clang-

[clang-tools-extra] r373323 - [clangd] Implement getBeginning for overloaded operators.

Author: hokein Date: Tue Oct 1 04:03:56 2019 New Revision: 373323 URL: http://llvm.org/viewvc/llvm-project?rev=373323&view=rev Log: [clangd] Implement getBeginning for overloaded operators. Summary: This will fix some bugs where navigation doesn't work on cases like `std::cout <^< "hello"`. Rev

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373323: [clangd] Implement getBeginning for overloaded operators. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Szelethus added a comment. A few nits inline, otherwise the patch is awesome, thank you!! Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:60-61 private: - void Fopen(CheckerContext &C, const CallExpr *CE) const; - void Tmpfile(CheckerContext &C, const CallExp

[PATCH] D68024: [clangd] Implement GetEligiblePoints

kadircet updated this revision to Diff 222590. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68024/new/ https://reviews.llvm.org/D68024 Files: clang-tools-ex

r373327 - [clang] Ignore builtin namespaces in test/Import/cxx-anon-namespace

Author: teemperor Date: Tue Oct 1 04:53:20 2019 New Revision: 373327 URL: http://llvm.org/viewvc/llvm-project?rev=373327&view=rev Log: [clang] Ignore builtin namespaces in test/Import/cxx-anon-namespace Some platforms (e.g. AArch64) put __va_list in the 'std' namespace which might end up being t

[PATCH] D53137: Scalable vector core instruction support + size queries

huntergr added inline comments. Comment at: llvm/include/llvm/IR/DataLayout.h:454 +auto BaseSize = getTypeSizeInBits(Ty); +return { (BaseSize.getKnownMinSize() + 7) / 8, BaseSize.isScalable() }; } rovka wrote: > We already overload operator /, why not

[PATCH] D53137: Scalable vector core instruction support + size queries

huntergr updated this revision to Diff 222593. huntergr added a comment. Herald added a subscriber: dexonsmith. - Renamed `ScalableSize` to `TypeSize`, including header name. - added `alignTo` function that takes and returns a `TypeSize`. I wasn't sure if this should be added to MathExtras.h wher

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet marked 7 inline comments as done. gchatelet added a comment. thx @aaron.ballman , I'm waiting for your reply before uploading the new patch (some of my comments won't have the accompanying code update sorry) Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1072 +NoBuiltin

[PATCH] D68268: [Alignment][NFC] Remove StoreInst::setAlignment(unsigned)

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, cfe-commits, asbirlea, hiraditya. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Many thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68143/new/ https://reviews.llvm.org/D68143

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

ABataev added inline comments. Comment at: lib/Sema/SemaDecl.cpp:17618 + + if (LangOpts.CUDA) { +// When compiling for device, host functions are never emitted. Similarly, Are you going to handle `#pragma omp declare target device_type(nohost)` in Cuda mod

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:109-110 bool StreamChecker::evalCall(const CallEvent &Call, CheckerContext &C) const { + if (!Call.isGlobalCFunction()) +return false;

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:127-131 + for (auto P : Call.parameters()) { +QualType T = P->getType(); +if (!T->isIntegralOrEnumerationType() && !T->isPointerType()) + return nullptr; + } --

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

Szelethus added a comment. The logic of the patch is fine in my eyes, but I dislike the formatting. Could you please make the code obey the LLVM coding style, and after that use clang-format-diff.py? https://llvm.org/docs/CodingStandards.html https://clang.llvm.org/docs/ClangFormat.html#script-f

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:109-110 bool StreamChecker::evalCall(const CallEvent &Call, CheckerContext &C) const { + if (!Call.isGlobalCFunction()) +return false; + balazske wrote: > Szele

r373340 - [clang] Make handling of unnamed template params similar to function params

Author: kadircet Date: Tue Oct 1 07:08:51 2019 New Revision: 373340 URL: http://llvm.org/viewvc/llvm-project?rev=373340&view=rev Log: [clang] Make handling of unnamed template params similar to function params Summary: Clang uses the location identifier should be inserted for declarator decls wh

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

This revision was automatically updated to reflect the committed changes. Closed by commit rL373340: [clang] Make handling of unnamed template params similar to function params (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family information to auxiliary functions with template parameters

Szelethus added a comment. In D68162#1686810 , @NoQ wrote: > Thank you, fantastic finding! > > > in fact we know it //compile time// > > Yeah, but is it accidental or is there a good reason behind always having > this information at compile time? 'Cause i

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Can we move this behind a Wenum-compare subgroup, say Wenum-compare-type? Our codebase is (well, was) Wenum-compare clean, and this new warnings fires pretty often and from a first quick glance the warning looks pretty low-signal anyways (*). Maybe the subgroup shouldn't even be on by default -- do

[PATCH] D68273: [clangd] Fix raciness in code completion tests

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68273 Files: clang-tools-extra/clangd

[PATCH] D68273: [clangd] Fix raciness in code completion tests

ilya-biryukov added a comment. This is still racy if there were > 1 request. I wonder if there a better way to address this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68273/new/ https://reviews.llvm.org/D68273 __

[PATCH] D68274: [Alignment][Clang][NFC] Add CharUnits::getAsAlign

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: cfe-commits, jholewinski. Herald added a project: clang. This is a prerequisite to removing `llvm::GlobalObject::setAlignment(unsigned)`. This is patch is part of a series to introduce an Alignment type

[PATCH] D68273: [clangd] Fix raciness in code completion tests

kadircet updated this revision to Diff 222618. kadircet added a comment. - As discussed offline, making `consumeRequests` take an argument for how many requests to receive before returning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68273/new/

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:109-110 bool StreamChecker::evalCall(const CallEvent &Call, CheckerContext &C) const { + if (!Call.isGlobalCFunction()) +return false;

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

hokein added a comment. In D67901#1687308 , @nridge wrote: > I do feel strongly that types and non-types should be highlighted > differently, so the updated patch adds two new dependent highlightings, one > for types and one for variables/functions. I

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

puya added a comment. > Looking at this I'm wondering if this Isn't at least partially handled by the > BreakConstructorInitializersStyle in combination with > ConstructorInitializerAllOnOneLineOrOnePerLine style? I’m fairly certain that’s only true when line is long enough to be broken. In wh

r373345 - [Diagnostics] Move warning into the subgroup (-Wenum-compare-conditional)

Author: xbolva00 Date: Tue Oct 1 08:44:38 2019 New Revision: 373345 URL: http://llvm.org/viewvc/llvm-project?rev=373345&view=rev Log: [Diagnostics] Move warning into the subgroup (-Wenum-compare-conditional) Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td cfe/trunk/include/c

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Yeah, I moved this warning into own subgroup in rL373345. Thanks. ut 1. 10. 2019 o 16:24 Nico Weber napísal(a): > > Can we move this behind a Wenum-compare subgroup, say Wenum-compare-type? Our > codebase is (well, was) Wenum-compare clean, and this new warnings fires > pretty often and from a

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Thanks! Any thoughts on the true positive rate for this warning? On Tue, Oct 1, 2019 at 11:43 AM Dávid Bolvanský wrote: > Yeah, I moved this warning into own subgroup in rL373345. Thanks. > > ut 1. 10. 2019 o 16:24 Nico Weber napísal(a): > > > > Can we move this behind a Wenum-compare subgroup

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 222612. lewis-revill added a comment. Rewrote logic to calculate stack sizes, frame indexes and frame pointer offsets. This was necessary to take into account the fact that the save/restore lib calls are essentially an opaque section of the stack that i

r373348 - [OPENMP]Fix PR43516: Compiler crash with collapse(2) on non-rectangular

Author: abataev Date: Tue Oct 1 09:19:10 2019 New Revision: 373348 URL: http://llvm.org/viewvc/llvm-project?rev=373348&view=rev Log: [OPENMP]Fix PR43516: Compiler crash with collapse(2) on non-rectangular loop. Missed check if the condition is also dependent when building final expressions for t

[PATCH] D68029: [ThinLTO] Enable index-only WPD from clang

tejohnson added a comment. Herald added a subscriber: hiraditya. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68029/new/ https://reviews.llvm.org/D68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D68029: [ThinLTO] Enable index-only WPD from clang

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68029/new/ https://reviews.llvm.org/D68029 ___ cfe-commits mailing

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Sorry, answered on phone, missed it. I looked at your buildbots for chromium and yeah, so many warnings. I will make it off by default. ut 1. 10. 2019 o 19:58 Dávid Bolvanský napísal(a): > > (Not sure if you intentionally didn't reply-all.) > > Sorry, answered on phone, missed it. I looked at you

r373370 - [ThinLTO] Enable index-only WPD from clang

Author: tejohnson Date: Tue Oct 1 11:08:29 2019 New Revision: 373370 URL: http://llvm.org/viewvc/llvm-project?rev=373370&view=rev Log: [ThinLTO] Enable index-only WPD from clang Summary: To trigger the index-only Whole Program Devirt support added to LLVM, we need to be able to specify -fno-spli

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane added a comment. In D64671#1688626 , @aaron.ballman wrote: > Do you need someone to commit this on your behalf (sorry for not asking that > question sooner)? Yes, please. I have no rights of any kind, this is in fact my first ever pull reques

[PATCH] D68029: [ThinLTO] Enable index-only WPD from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL373370: [ThinLTO] Enable index-only WPD from clang (authored by tejohnson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Done. rL373371. ut 1. 10. 2019 o 19:58 Dávid Bolvanský napísal(a): > > Sorry, answered on phone, missed it. I looked at your buildbots for > chromium and yeah, so many warnings. I will make it off by default. > > ut 1. 10. 2019 o 19:58 Dávid Bolvanský napísal(a): > > > > (Not sure if you intenti

r373371 - [Diagnostics] Make -Wenum-compare-conditional off by default

Author: xbolva00 Date: Tue Oct 1 11:12:13 2019 New Revision: 373371 URL: http://llvm.org/viewvc/llvm-project?rev=373371&view=rev Log: [Diagnostics] Make -Wenum-compare-conditional off by default Too many false positives, eg. in Chromium. Modified: cfe/trunk/include/clang/Basic/DiagnosticGro

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Chromium shouldn't be a factor for determining is a warning is on or off by default. We can easily turn warnings off, and I had done so in http://crrev.com/http://crrev.com/701604 (as long as warnings have a dedicated flag -- but that's needed for every large codebase adopting a new clang). So that

r373374 - [OPENMP]Fix PR43330: OpenMP target: Mapping of partial arrays fails.

Author: abataev Date: Tue Oct 1 11:18:03 2019 New Revision: 373374 URL: http://llvm.org/viewvc/llvm-project?rev=373374&view=rev Log: [OPENMP]Fix PR43330: OpenMP target: Mapping of partial arrays fails. Fixed calculation the size of the array sections. Modified: cfe/trunk/lib/CodeGen/CGOpenM

r373375 - [NFC] Updated tests after rL373371

Author: xbolva00 Date: Tue Oct 1 11:18:45 2019 New Revision: 373375 URL: http://llvm.org/viewvc/llvm-project?rev=373375&view=rev Log: [NFC] Updated tests after rL373371 Forgot to run check-clang-semacxx. Modified: cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp Modified: cfe/trunk/test/Sem

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

yaxunl created this revision. yaxunl added a reviewer: tra. Sometimes it is useful to compile HIP device code to LLVM BC. It is not convenient to use clang -cc1 since there are lots of options needed. This patch allows clang driver to compile HIP device code to LLVM BC with -emit-llvm -c. htt

Re: r373371 - [Diagnostics] Make -Wenum-compare-conditional off by default

This breaks emaCXX/warn-sign-conversion.cpp -- but see other thread, maybe just revert this for now until we know what we want to do here :) On Tue, Oct 1, 2019 at 2:10 PM David Bolvansky via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xbolva00 > Date: Tue Oct 1 11:12:13 2019 > Ne

Re: r373371 - [Diagnostics] Make -Wenum-compare-conditional off by default

I fixed it, forgot to run clang semacxx check too. I am not sure.. I checked github and found case: https://github.com/ros-industrial-consortium/godel/issues/115 Seems like this is very rare, not worth to make it on.. ut 1. 10. 2019 o 20:19 Nico Weber napísal(a): > > This breaks emaCXX/warn-sig

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/include/llvm/ADT/Statistic.h:47 -class Statistic { +class StatisticBase { public: Do we actually need the common base class? I'm

[PATCH] D67940: [BPF] Preserve and make bitfield access relocatable

yonghong-song abandoned this revision. yonghong-song added a comment. We will take a different approach. So abandon this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67940/new/ https://reviews.llvm.org/D67940 _

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

MyDeveloperDay updated this revision to Diff 222665. MyDeveloperDay set the repository for this revision to rC Clang. MyDeveloperDay added a project: clang-tools-extra. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68227/new/ https://reviews.llvm.org/D68227 Files:

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk updated this revision to Diff 222667. kousikk marked an inline comment as done. kousikk added a comment. Address code-reorg comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 Files: clang/inc

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk added a comment. In D68193#1688838 , @dexonsmith wrote: > Sorry for bouncing you around, but I just had a look at the other user of > `createFileEntry` and I think the right thing to do is to somehow share the > code between `DependencyScanningWo

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68227/new/ https://reviews.llvm.org/D68227 ___ cfe-

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk updated this revision to Diff 222669. kousikk added a comment. Add missed const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScan

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:60-61 private: - void Fopen(CheckerContext &C, const CallExpr *CE) const; - void Tmpfile(CheckerContext &C, const CallExpr *CE) const; - void Fclose(CheckerContext &C, const CallExpr *C

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. Thanks for the patch update. I will launch some new correctness runs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 ___ cfe-commits ma

r373387 - [OPENMP50]Initial codegen for declare variant implementation vendor.

Author: abataev Date: Tue Oct 1 13:18:32 2019 New Revision: 373387 URL: http://llvm.org/viewvc/llvm-project?rev=373387&view=rev Log: [OPENMP50]Initial codegen for declare variant implementation vendor. Initial implementation of global aliases emission for the declare variant pragma with implemen

r373388 - [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

Author: paulhoad Date: Tue Oct 1 13:20:22 2019 New Revision: 373388 URL: http://llvm.org/viewvc/llvm-project?rev=373388&view=rev Log: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed Summary: This is a patch to fix PR43372 (https://bugs.llvm.

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

This revision was automatically updated to reflect the committed changes. Closed by commit rL373388: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso updated this revision to Diff 222685. Charusso marked an inline comment as done. Charusso added a comment. - Use the TU's Decls instead of the gathered casts' Decls. - The math is still missing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67079/new/ https://reviews.llvm.org/D

[PATCH] D68296: clang-format: Add ability to wrap braces after multi-line control statements

mitchell-stellar created this revision. mitchell-stellar added reviewers: sammccall, owenpan, reuk. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the BraceWrappingFlags' AfterControlStatement from a bool to an enum wi

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

scott.linder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53768/new/ https://reviews.llvm.org/D53768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 222701. SouraVX added a comment. Added test cases for debug info Clang frontend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-al

  1   2   >