dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/ADT/Statistic.h:47
 
-class Statistic {
+class StatisticBase {
 public:
----------------
Do we actually need the common base class? I'm thinking that since 
NoopStatistic never registers (and can't because the interfaces to do so 
changed to TrackingStatistic*), then there's a good chance that nothing reads 
DebugType, Name, Desc, Value, Initialized and we might be able to save a little 
memory by eliminating them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68252/new/

https://reviews.llvm.org/D68252



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to