[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth added inline comments. Comment at: llvm/trunk/include/llvm/IR/DiagnosticInfo.h:79 + DK_FirstPluginKind, + DK_MisExpect }; jrtc27 wrote: > Is this not going to clash with the first caller to > `getNextAvailablePluginDiagnosticKind`? `DK_FirstPluginKi

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: llvm/trunk/include/llvm/IR/DiagnosticInfo.h:79 + DK_FirstPluginKind, + DK_MisExpect }; paulkirth wrote: > jrtc27 wrote: > > Is this not going to clash with the first calle

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. It'd be nice to see this land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX marked 3 inline comments as done. SouraVX added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; aprantl wrote: > I understan

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX updated this revision to Diff 220435. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 Files: include/clang/AST/DeclCXX.h lib/AST/DeclPrinter.cpp lib/AST/JSONNodeDumper.cpp lib/AST/TextNodeDumper.cpp lib/CodeGen/CGDebugInfo.cpp

[clang-tools-extra] r372074 - [clangd] Remove stale comment. NFC

Author: ibiryukov Date: Mon Sep 16 23:49:50 2019 New Revision: 372074 URL: http://llvm.org/viewvc/llvm-project?rev=372074&view=rev Log: [clangd] Remove stale comment. NFC Modified: clang-tools-extra/trunk/clangd/ClangdServer.h Modified: clang-tools-extra/trunk/clangd/ClangdServer.h URL: htt

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske marked 3 inline comments as done. balazske added a comment. C++17 makes things more difficult because the align is probably handled by `operator new`, probably not, depending on the defined allocation functions. This can be observed only with a non clang-tidy checker (we could compute t

<    1   2