paulkirth added inline comments.
================ Comment at: llvm/trunk/include/llvm/IR/DiagnosticInfo.h:79 + DK_FirstPluginKind, + DK_MisExpect }; ---------------- jrtc27 wrote: > Is this not going to clash with the first caller to > `getNextAvailablePluginDiagnosticKind`? `DK_FirstPluginKind` is special and > shouldn't have anything after it. hmm, I wasn't aware of that. Is this documented somewhere? Also no tests seem to break from this, so that might be another area to address. I'll upload a patch for this that moves the flag, and adds a note about the ordering. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
