r368941 - [www] Update DR status page to match latest version of CWG issues list.

Author: rsmith Date: Wed Aug 14 15:57:51 2019 New Revision: 368941 URL: http://llvm.org/viewvc/llvm-project?rev=368941&view=rev Log: [www] Update DR status page to match latest version of CWG issues list. Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html U

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:200 CXXRecordDecl *Canonical = Record->getCanonicalDecl(); if (Canonical->hasAttr() || Canonical->hasAttr()) return; mgehre wrote: > gribozavr wrote: > > Should this code no

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ added a comment. In D65182#1629192 , @Szelethus wrote: > Hmm, why the need for checker options? Why not have them by default? If > fixits are an experimental feature, maybe we should have a global > `enable-fixits` config. But I don't insist :) I d

[PATCH] D65182: [analyzer] Add fix-it hint support.

Szelethus accepted this revision. Szelethus added a comment. In D65182#1630540 , @NoQ wrote: > In D65182#1629192 , @Szelethus wrote: > > > Hmm, why the need for checker options? Why not have them by default? If > >

[PATCH] D52524: Add -Wno-poison-system-directories flag

manojgupta added a comment. In D52524#1621468 , @thakis wrote: > Couldn't cross build users just pass -nostdsysteminc to tell clang to not > look in system header locations? My understanding is "-nostdsysteminc " does not block users from passing inclu

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeWriter.h:33 // BitCodeConstants, though they can be added without breaking it. static const unsigned VersionNumber = 2; I definitely haven't been particularly good about bumpin

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

Bigcheese added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:130 + + const DirectoryEntry *getDir() const { return Entry.getDir(); } + Isn't this incorrect in the case of symlinks? Comment at: clang/include/clang/Basic/

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus updated this revision to Diff 215281. Szelethus changed the repository for this revision from rC Clang to rG LLVM Github Monorepo. Szelethus added a comment. Revised the documentation according to @NoQ's comments. By literally copy pasting it. Like any good programmer should do :^) R

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added inline comments. Comment at: clang/docs/analyzer/checkers.rst:263 + + void _deref_after_equals() { + std::string s = "llvm"; I suggest `deref_after_assignment`. Comment at: clang/docs/analyzer/checkers.rst:271 + const char *return_t

[PATCH] D66261: [analyzer] Warn about -analyzer-configs being meant for development purposes only

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, rnkovacs, dcoughlin, dkrupp. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. This is more of a

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus updated this revision to Diff 215288. Szelethus marked 2 inline comments as done. Szelethus added a comment. Fixed! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60281/new/ https://reviews.llvm.org/D60281 Files: clang/docs/analyzer/checkers.rst Index: clang/docs/analyzer/

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! One more quick question: Who is Husi??? Comment at: clang/docs/analyzer/checkers.rst:261 + + void consume(const char *); + This declaration doesn't add mu

[PATCH] D66261: [analyzer] Warn about -analyzer-configs being meant for development purposes only

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, i appreciate! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66261/new/ https://reviews.llvm.org/D66261

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus added a comment. In D60281#1630646 , @NoQ wrote: > Thanks! > > One more quick question: Who is Husi??? Well thats me. Long story short, the reason why my name is Szelethus is that my first ever character to hit max level in World of Warcraft w

[PATCH] D66265: [NFCI] Always initialize BugReport const fields

xiaobai created this revision. xiaobai added reviewers: compnerd, Szelethus, NoQ. Herald added a project: clang. Some compilers require that const fields of an object must be explicitly initialized by the constructor. I ran into this issue building with clang 3.8 on Ubuntu 16.04. Repository: r

[PATCH] D66265: [NFCI] Always initialize BugReport const fields

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66265/new/ https://reviews.llvm.org/D66265

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D65889: [analyzer] CastValueCh

[PATCH] D66266: [WIP][RISCV] Set MaxAtomicPromoteWidth and MaxAtomicInlineWidth

pzheng created this revision. Herald added subscribers: cfe-commits, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, jfb, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar,

[PATCH] D66265: [NFCI] Always initialize BugReport const fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL368950: [NFCI] Always initialize BugReport const fields (authored by xiaobai, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D66265?vs=215292&id=215299#t

r368950 - [NFCI] Always initialize BugReport const fields

Author: xiaobai Date: Wed Aug 14 17:58:51 2019 New Revision: 368950 URL: http://llvm.org/viewvc/llvm-project?rev=368950&view=rev Log: [NFCI] Always initialize BugReport const fields Summary: Some compilers require that const fields of an object must be explicitly initialized by the constructor. I

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny updated this revision to Diff 215298. jdenny added a comment. Rebase. Add more tests, as requested at D66247#1630441 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65835/new/ https://reviews.llvm.org/D65835 Files: clang/include/clang

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added a comment. Why there are the changes from the another patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65835/new/ https://reviews.llvm.org/D65835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus added a comment. Shouldn't we just delete this entire visitor altogether and merge it into ConditionBRVisitor (like, eventually, not right now)? It seems to be a relic of the past. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66267/new/ https://revie

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny added a comment. I think you're referring to stuff like `OpenMPCaptureLevel` in `ScopeInfo.h`. I wrote those changes for this patch first, as can be seen in phabricator history. I needed them for the other patch too, and I thought we were going to end up applying that patch first, so I

[PATCH] D66268: [clang-doc] Fix use of source-root flag

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, ilya-biryukov. The value, if any, of --source-root flag was not being used. This has been fixed and

[PATCH] D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. This migrates objc-forbidden-subclassing to `isDerivedFrom` as it now supports matching Objective-C interface declarations. Test Notes: Ran clang tools tests. Repository: rG L

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran updated this revision to Diff 215304. DiegoAstiazaran marked 11 inline comments as done. DiegoAstiazaran added a comment. Increase version number of clang-doc bitcode. Rename `documentInfo` function to `shouldSerializeInfo`. In new `parseBases` a BaseRecordInfo object is created an

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:436 + if (const CXXRecordDecl *Base = + cast_or_null(Ty->getDecl()->getDefinition())) { +bool IsVirtual = false; juliehockett wrote: > Will `get

[PATCH] D52524: Add -Wno-poison-system-directories flag

thakis added a comment. Wouldn't those projects just move to also disabling the warning by passing -Wno-poison-system-directories? If there are projects that are actively adding -I/usr/include, that means they're consciously fighting the build system and you've kind of already lost, no? Can't y

[PATCH] D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛

stephanemoore created this revision. stephanemoore added reviewers: aaron.ballman, gribozavr. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. This migrates objc-super-self to `isDerivedFrom` as it now supports matching Objective-C interface declarations. Test Note

[PATCH] D52524: Add -Wno-poison-system-directories flag

manojgupta added a comment. In D52524#1630767 , @thakis wrote: > Wouldn't those projects just move to also disabling the warning by passing > -Wno-poison-system-directories? If there are projects that are actively > adding -I/usr/include, that means they

[PATCH] D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛

stephanemoore updated this revision to Diff 215311. stephanemoore added a comment. Fix example matches in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66270/new/ https://reviews.llvm.org/D66270 Files: clang-tools-extra/clang-tidy/objc/

[PATCH] D52524: Add -Wno-poison-system-directories flag

manojgupta added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1071 +// cross-compiling. +def PoisonSystemDirectories : DiagGroup<"poison-system-directories">; + Please verify that the warning is not enabled by default. CHANGES SINC

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added a comment. Cute!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60281/new/ https://reviews.llvm.org/D60281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r368954 - [NFC] Update doc comment to fix warning.

Author: jdevlieghere Date: Wed Aug 14 20:59:30 2019 New Revision: 368954 URL: http://llvm.org/viewvc/llvm-project?rev=368954&view=rev Log: [NFC] Update doc comment to fix warning. This fixes the warning: parameter 'EnableNullFPSuppression' not found in the function declaration [-Wdocumentation]

[PATCH] D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681.

dlj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The change in r368681 contains a (probably unintentional) behavioral change for rewrite rules with a single matcher. Previously, the single matcher would not need to be bound (`joinCaseMatchers` retur

r368958 - [Tooling] Add a hack to work around issues with matcher binding in r368681.

Author: dlj Date: Wed Aug 14 21:10:11 2019 New Revision: 368958 URL: http://llvm.org/viewvc/llvm-project?rev=368958&view=rev Log: [Tooling] Add a hack to work around issues with matcher binding in r368681. The change in r368681 contains a (probably unintentional) behavioral change for rewrite rul

[PATCH] D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368958: [Tooling] Add a hack to work around issues with matcher binding in r368681. (authored by dlj, committed by ). Hera

Re: r368874 - Document clang-cpp in the release notes for clang

On Wed, Aug 14, 2019 at 6:48 PM Chris Bieneman via cfe-commits wrote: > > Author: cbieneman > Date: Wed Aug 14 09:49:52 2019 > New Revision: 368874 > -- ... > +- In 9.0.0 and later Clang added a new target, clang-cpp, which generates a > + shared library comprised of all the clang component libr

r368969 - [X86] Add test cases for _mm_movepi64_pi64 and _mm_movpi64_epi64.

Author: ctopper Date: Wed Aug 14 23:20:33 2019 New Revision: 368969 URL: http://llvm.org/viewvc/llvm-project?rev=368969&view=rev Log: [X86] Add test cases for _mm_movepi64_pi64 and _mm_movpi64_epi64. Modified: cfe/trunk/test/CodeGen/sse2-builtins.c Modified: cfe/trunk/test/CodeGen/sse2-built

r368970 - [Clang] Pragma vectorize_predicate implies vectorize

Author: sjoerdmeijer Date: Wed Aug 14 23:24:40 2019 New Revision: 368970 URL: http://llvm.org/viewvc/llvm-project?rev=368970&view=rev Log: [Clang] Pragma vectorize_predicate implies vectorize New pragma "vectorize_predicate(enable)" now implies "vectorize(enable)", and it is ignored when vectoriz

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

This revision was automatically updated to reflect the committed changes. Closed by commit rL368970: [Clang] Pragma vectorize_predicate implies vectorize (authored by SjoerdMeijer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer added a comment. Thanks, and will fix your suggestions before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

<    1   2   3