r368128 - [RISCV] Remove duplicated logic when determining the target ABI

Author: rogfer01 Date: Wed Aug 7 00:08:00 2019 New Revision: 368128 URL: http://llvm.org/viewvc/llvm-project?rev=368128&view=rev Log: [RISCV] Remove duplicated logic when determining the target ABI We were calculating twice ilp32/lp64. Do this in one place instead. Differential Revision: https:

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Thanks @lenary ! I will commit this shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL368128: [RISCV] Remove duplicated logic when determining the target ABI (authored by rogfer01, committed by ). Herald added subscribers: llvm-commits, jrtc27. Herald added a project: LLVM. Changed prior t

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer added a comment. > I do not know whether/how "setting a transformation option implicitly enables > the transformation" should be implemented, maybe we should discuss this. Yep, agreed. I've sent a mail to the dev list: http://lists.llvm.org/pipermail/cfe-dev/2019-August/063054.html

[PATCH] D65833: [Tooling] Expose ExecutorConcurrency option.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Only hesitation is that AllTUsExecution is one executor of (potentially) many, so this is a weird place for a common flag. However it's already "global" in the sense that --help will sho

r368131 - Re-submit r367649: Improve raw_ostream so that you can "write" colors using operator<

Author: ruiu Date: Wed Aug 7 01:08:17 2019 New Revision: 368131 URL: http://llvm.org/viewvc/llvm-project?rev=368131&view=rev Log: Re-submit r367649: Improve raw_ostream so that you can "write" colors using operator<< The original patch broke buildbots, perhaps because it changed the default set

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:144 + EXPECT_THAT(AST.getLocalTopLevelDecls(), + ElementsAre(DeclNamed("f"), DeclNamed("f"), DeclNamed("f"), + DeclNamed("V"), DeclNamed("V")

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom updated this revision to Diff 213808. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Added more ways to specialize/instantiate templates to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65510/new/ https://rev

r368132 - Remove inclusion of a private gmock header from a test

Author: gribozavr Date: Wed Aug 7 01:16:29 2019 New Revision: 368132 URL: http://llvm.org/viewvc/llvm-project?rev=368132&view=rev Log: Remove inclusion of a private gmock header from a test Modified: cfe/trunk/unittests/AST/RecursiveASTVisitorTest.cpp Modified: cfe/trunk/unittests/AST/Recur

[PATCH] D65738: [clangd] Added a TextMate theme parser that updates when the current theme changes.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. mostly good, please update the patch description. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:6 + +interface TokenColorRule { +

[PATCH] D65849: [unittests] Mark private gmock headers with IWYU pragmas. NFC

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added subscribers: llvm-commits, kadircet. Herald added a project: LLVM. To prevent clangd from adding #include of those headers. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65849 Files:

Re: [clang-tools-extra] r368019 - [clangd] Compute scopes eagerly in IncludeFixer

Yes, merged in r368133. On Tue, Aug 6, 2019 at 4:33 PM Ilya Biryukov wrote: > > +Hans Wennborg, could we merge this into the release? > > On Tue, Aug 6, 2019 at 1:36 PM Ilya Biryukov via cfe-commits > wrote: >> >> Author: ibiryukov >> Date: Tue Aug 6 04:37:50 2019 >> New Revision: 368019 >> >>

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:144 + EXPECT_THAT(AST.getLocalTopLevelDecls(), + ElementsAre(DeclNamed("f"), DeclNamed("f"), DeclNamed("f"), + DeclNamed("V"), DeclNamed(

Re: [clang-tools-extra] r368019 - [clangd] Compute scopes eagerly in IncludeFixer

Many thanks! On Wed, Aug 7, 2019 at 10:31 AM Hans Wennborg wrote: > Yes, merged in r368133. > > On Tue, Aug 6, 2019 at 4:33 PM Ilya Biryukov wrote: > > > > +Hans Wennborg, could we merge this into the release? > > > > On Tue, Aug 6, 2019 at 1:36 PM Ilya Biryukov via cfe-commits < > cfe-commits@

[PATCH] D65849: [unittests] Mark private gmock headers with IWYU pragmas. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL368135: [unittests] Mark private gmock headers with IWYU pragmas. NFC (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D65849?vs=213810&id=213816#toc Repository

[clang-tools-extra] r368136 - [clangd] Added a TextMate theme parser to the vscode extension.

Author: jvikstrom Date: Wed Aug 7 01:48:52 2019 New Revision: 368136 URL: http://llvm.org/viewvc/llvm-project?rev=368136&view=rev Log: [clangd] Added a TextMate theme parser to the vscode extension. Summary: Adds a TextMate parser module to the vscode extension. It parses a theme into an array

[PATCH] D65738: [clangd] Added a TextMate theme parser to the vscode extension.

This revision was automatically updated to reflect the committed changes. jvikstrom marked 5 inline comments as done. Closed by commit rL368136: [clangd] Added a TextMate theme parser to the vscode extension. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subs

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

gribozavr created this revision. gribozavr added reviewers: plotfi, jkorous, compnerd. Herald added subscribers: cfe-commits, dexonsmith, mgorny. Herald added a project: clang. ASSERT_THAT_ERROR looks like the intended helper for use in tests. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D65854: [diagtool] Use `operator<<(Colors)` to print out colored output.

ruiu created this revision. ruiu added a reviewer: JDevlieghere. Herald added a project: clang. Herald added a subscriber: cfe-commits. r368131 introduced this new API to print out messages in colors. If the colored output is disabled, `operator<<(Colors)` becomes nop. No functionality change inte

[PATCH] D65854: [diagtool] Use `operator<<(Colors)` to print out colored output.

MaskRay added inline comments. Comment at: clang/tools/diagtool/TreeView.cpp:167 + if (!hasColors(out)) +out.enable_colors(false); + `out.enable_colors(out.has_colors());` It looks the function `hasColors` is overengineered. `out` in these files can only b

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Maps an array of TM scopes to the most specific scope that is added. Needed to have fast access to a rule

r368147 - gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

Author: mgehre Date: Wed Aug 7 03:45:36 2019 New Revision: 368147 URL: http://llvm.org/viewvc/llvm-project?rev=368147&view=rev Log: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types Summary: Hard code gsl::Owner/gsl::Pointer for std types. The paper mentions some types explici

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

This revision was automatically updated to reflect the committed changes. Closed by commit rL368147: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types (authored by mgehre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

r368149 - Replace llvm::MutexGuard/UniqueLock with their standard equivalents

Author: d0k Date: Wed Aug 7 03:57:25 2019 New Revision: 368149 URL: http://llvm.org/viewvc/llvm-project?rev=368149&view=rev Log: Replace llvm::MutexGuard/UniqueLock with their standard equivalents All supported platforms have now, so we don't need our own copies any longer. No functionality cha

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368152: [clang] Fix mismatched args constructing AddressSpaceAttr. (authored by AntonBikineev, committed by ). Herald adde

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Szelethus added a comment. Do you have plans to extend this checker with the modeling of `isa<>`? I might take that off your shoulder if not :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 ___ cf

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368104: Delay diagnosing asm constraints that require immediates until after inlining (authored by void, committed by ). H

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 added a comment. Thanks @asb @lenary for the review! I understand that, after this change, we will also want to make `-march=rv{32,64}gc` the default in Linux as well. Otherwise there will be an ABI mismatch with the default `-march=rv{32.64}i` in a default invocation. Does this make

r368152 - [clang] Fix mismatched args constructing AddressSpaceAttr.

Author: antonbikineev Date: Wed Aug 7 04:12:43 2019 New Revision: 368152 URL: http://llvm.org/viewvc/llvm-project?rev=368152&view=rev Log: [clang] Fix mismatched args constructing AddressSpaceAttr. Differential Revision: https://reviews.llvm.org/D65589 Modified: cfe/trunk/lib/Sema/SemaType.

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 updated this revision to Diff 213812. rogfer01 retitled this revision from "[RISCV] Default to lp64d in 64-bit RISC-V Linux" to "[RISCV] Default to ilp32d/lp64d in RISC-V Linux". rogfer01 edited the summary of this revision. rogfer01 added a comment. ChangeLog: - Make `ilp32d` also the

r368157 - Replace non-recursive sys::Mutex users with std::mutex

Author: d0k Date: Wed Aug 7 04:59:44 2019 New Revision: 368157 URL: http://llvm.org/viewvc/llvm-project?rev=368157&view=rev Log: Replace non-recursive sys::Mutex users with std::mutex Also remove a use of sys::MutexImpl, that's just evil. No functionality change intended. Modified: cfe/trun

[PATCH] D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints

dcandler created this revision. dcandler added reviewers: rsmith, t.p.northover, compnerd, void, joerg, efriedma, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. A number of inline assembly constraints are

r368163 - [ASTImporter] Do not import FunctionTemplateDecl in record twice.

Author: balazske Date: Wed Aug 7 05:40:17 2019 New Revision: 368163 URL: http://llvm.org/viewvc/llvm-project?rev=368163&view=rev Log: [ASTImporter] Do not import FunctionTemplateDecl in record twice. Summary: For functions there is a check to not duplicate the declaration if it is in a record (c

[PATCH] D65203: [ASTImporter] Do not import FunctionTemplateDecl in record twice.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368163: [ASTImporter] Do not import FunctionTemplateDecl in record twice. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D65866: Code completion should not ignore default parameters in functions.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Inorder to display the default arguments we must process the CK_Optional chunks of CodeCompletionString while creating the Sign

r368170 - [OPENMP]Add standard macro value _OPENMP for OpenMP 5.0.

Author: abataev Date: Wed Aug 7 07:02:11 2019 New Revision: 368170 URL: http://llvm.org/viewvc/llvm-project?rev=368170&view=rev Log: [OPENMP]Add standard macro value _OPENMP for OpenMP 5.0. According to the OpenMP standard, compiler must define _OPENMP macro, which has value in format mm, wh

[PATCH] D65866: Code completion should not ignore default parameters in functions.

usaxena95 updated this revision to Diff 213871. usaxena95 added a comment. Removed unused include of logger. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65866/new/ https://reviews.llvm.org/D65866 Files: clang-tools-extra/clangd/CodeCompletionS

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. `is_device_ptr` can be considered as a kind of mapping clause (see 2.19.7 Data-Mapping Attribute Rules, Clauses, and Directives), so, I assume, clang correct here in terms of OpenMP 4.5. Thus, I would not call this a "fix", this is just a new feature from OpenMP 5.0. P

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. Thanks for taking a look Reid! I rebased the patch and had a conflict with one of Richard's patches and so ran the lit tests again and noticed there are several new failures. I am taking a look at those now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027

r368172 - [OPENMP]Set default version to OpenMP 4.5.

Author: abataev Date: Wed Aug 7 07:39:17 2019 New Revision: 368172 URL: http://llvm.org/viewvc/llvm-project?rev=368172&view=rev Log: [OPENMP]Set default version to OpenMP 4.5. Since clang fully supports OpenMP 4.5, set the default version to 4.5 instead of 3.1. Modified: cfe/trunk/lib/Front

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom updated this revision to Diff 213878. jvikstrom added a comment. Changed tests to also look at template parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65510/new/ https://reviews.llvm.org/D65510 Files: clang-tools-extra/clang

r368173 - Remove LLVM mutexes from clang in favor of std::mutex

Author: d0k Date: Wed Aug 7 07:44:40 2019 New Revision: 368173 URL: http://llvm.org/viewvc/llvm-project?rev=368173&view=rev Log: Remove LLVM mutexes from clang in favor of std::mutex None of those need to be recursive mutexes. No functionality change intended. Modified: cfe/trunk/lib/Direct

[PATCH] D65866: Code completion should not ignore default parameters in functions.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:35 +void appendCodeCompletionString(const CodeCompletionString &CCS, std::string *Out) { + for (c

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:85 +if (const auto *Args = FD->getTemplateSpecializationArgs()) { + std::string SpecializationArgs; + // Without the PrintingPolicy "bool" will be printed as "_Bo

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:144 + EXPECT_THAT(AST.getLocalTopLevelDecls(), + ElementsAre(DeclNamed("f"), DeclNamed("f"), DeclNamed("f"), +

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:188 +AllOf(DeclNamed("d"), WithTemplateArgs("")), +AllOf(DeclNamed("foo"), WithTemplateA

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This patch removes an (artificial) limitation of `applyFirst`, which requires that all of the rules' matchers can be grouped together in a single `anyOf()`. This change generalizes the code to group

[PATCH] D65461: [OPENMP]Add support for analysis of linear variables and step.

ABataev updated this revision to Diff 213888. ABataev added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65461/new/ https://reviews.llvm.org/D65461 Files: include/clang/AST/OpenMPClause.h lib/AST/OpenMPClause.cpp lib/Sema/SemaOpenMP.cpp

[PATCH] D65878: [Refactor] Moving SourceExtraction header from lib to include

SureYeaah created this revision. SureYeaah added a reviewer: arphaman. Herald added subscribers: cfe-commits, kadircet, dexonsmith, ilya-biryukov. Herald added a project: clang. - Moved the SourceExtraction header from lib to include so that it can be used in clangd. Repository: rG LLVM Githu

[PATCH] D65879: [clang-tidy] Update `TransformerClangTidyCheck` to use new `buildMatchers` functionality.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. `buildMatchers` is the new, more general way to extract the matcher from a rule. This change migrates the code to use it instead of `buildMatcher`. Repository:

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

alexfh added a comment. In D65065#1617031 , @gribozavr wrote: > > This suggestion would result another strange behavior: if the user disables > > cert-err09-cpp because he or she doesn't want to see its reports, the other > > one (cert-err61-cpp) will st

[PATCH] D65880: [Driver] Move LIBRARY_PATH before user inputs

MaskRay created this revision. MaskRay added reviewers: lichray, phosek, void. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes PR16786 Currently, library paths specified by LIBRARY_PATH are placed after inputs: `inputs LIBRARY_PATH stdlib` In gcc, the order is: `inpu

[PATCH] D65881: [Driver] Move LIBRARY_PATH before user inputs

MaskRay created this revision. MaskRay added reviewers: lichray, phosek, void. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes PR16786 Currently, library paths specified by LIBRARY_PATH are placed after inputs: `inputs LIBRARY_PATH stdlib` In gcc, the order is: `inpu

[PATCH] D65881: [Driver] Move LIBRARY_PATH before user inputs

MaskRay abandoned this revision. MaskRay added a comment. Sorry. Accidentally created a duplicate one by my arc diff.. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65881/new/ https://reviews.llvm.org/D65881 ___ cfe-

[PATCH] D65883: [Extract] Fixed SemicolonExtractionPolicy for Do and Switch Stmt

SureYeaah created this revision. SureYeaah added reviewers: arphaman, sammccall. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65883 Files: clang/lib/Tooling/Refactoring/Extract/SourceExtraction

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh marked 23 inline comments as done. svenvh added a subscriber: Pierre. svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:51 -// Helper class to store type access qualifiers (volatile, const, ...). -class Qualifier { - string QualName = _QualName; -

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh updated this revision to Diff 213904. svenvh marked 9 inline comments as done. svenvh added a comment. Addressing review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65456/new/ https://reviews.llvm.org/D65456 Files: clang/lib/Sema/OpenCLBuiltins.td clang/lib/Sema/

[PATCH] D65880: [Driver] Move LIBRARY_PATH before user inputs

MaskRay updated this revision to Diff 213908. MaskRay added a comment. Fix a comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65880/new/ https://reviews.llvm.org/D65880 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/linker-opts.c Index: test/

[PATCH] D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase

SureYeaah updated this revision to Diff 213909. SureYeaah added a comment. Removed Do Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65883/new/ https://reviews.llvm.org/D65883 Files: clang/lib/Tooling/Refactoring/Extract/SourceExtraction.cpp In

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider marked an inline comment as done. glider added a comment. In D65234#1615649 , @efriedma wrote: > For the "=x" thing I was talking about, try the following testcase: > > void a() { struct S { unsigned x[4]; } z; asm volatile("%0":"=x"(z)); } > vo

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider updated this revision to Diff 213920. glider added a comment. Added test cases for =x, replaced grep with not Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65234/new/ https://reviews.llvm.org/D65234 Files: clang/lib/CodeGen/CGStmt.cpp c

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Thanks to Kristóf Umann for the great idea! Repository: rC

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso marked 4 inline comments as done. Charusso added a comment. This is a little-bit WIP as the symbol conjuring is very naive. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:111 +QualType Ty = CE->getCallReturnType(C.getASTContext()); +V = C.ge

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso added a comment. In D64374#1594617 , @Szelethus wrote: > I guess `getAs` and `castAs` methods could join the party too. I'm evaluating > plenty of results on LLVM, and those seem to be in the same problem category. In D64374#1618694

[PATCH] D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase

SureYeaah updated this revision to Diff 213925. SureYeaah added a comment. Added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65883/new/ https://reviews.llvm.org/D65883 Files: clang/lib/Tooling/Refactoring/Extract/SourceExtraction.cpp c

[PATCH] D65866: Code completion should not ignore default parameters in functions.

usaxena95 updated this revision to Diff 213926. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Added tests in CodeCompletionStringsTests.cpp Resolved comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65866/new/ https:/

[PATCH] D65866: Code completion should not ignore default parameters in functions.

usaxena95 updated this revision to Diff 213927. usaxena95 added a comment. Formatted new test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65866/new/ https://reviews.llvm.org/D65866 Files: clang-tools-extra/clangd/CodeCompletionStrings.cpp c

[PATCH] D65880: [Driver] Move LIBRARY_PATH before user inputs

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM. Local flags should certainly override LIBRARY_PATH. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65880/new/ https://reviews.llvm.org/D65880 __

[clang-tools-extra] r368186 - Code completion should not ignore default parameters in functions.

Author: sammccall Date: Wed Aug 7 09:52:21 2019 New Revision: 368186 URL: http://llvm.org/viewvc/llvm-project?rev=368186&view=rev Log: Code completion should not ignore default parameters in functions. Summary: Inorder to display the default arguments we must process the CK_Optional chunks of Co

[PATCH] D65866: Code completion should not ignore default parameters in functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368186: Code completion should not ignore default parameters in functions. (authored by sammccall, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov. Herald added a project: LLVM. Chan

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

ymandel updated this revision to Diff 213932. ymandel added a comment. fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65877/new/ https://reviews.llvm.org/D65877 Files: clang/include/clang/Tooling/Refactoring/Transformer.h clang/lib

[PATCH] D65846: Improve error message from FrontendAction

akyrtzi added a comment. Sorry, it's not clear to me what is the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65846/new/ https://reviews.llvm.org/D65846 ___ cfe-commits mailing list cfe-commits

r368188 - [clang][NFC] Fix typo in matcher comment

Author: ymandel Date: Wed Aug 7 10:01:31 2019 New Revision: 368188 URL: http://llvm.org/viewvc/llvm-project?rev=368188&view=rev Log: [clang][NFC] Fix typo in matcher comment Also updates corresponding html doc. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clan

[PATCH] D65043: [Format] Add C++20 standard to style options

modocache added a comment. Friendly ping! @sammccall is this what you had in mind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65043/new/ https://reviews.llvm.org/D65043 ___ cfe-commits mailing list

[PATCH] D65043: [Format] Add C++20 standard to style options

Quuxplusone added a comment. FWIW, looks unobjectionable to me, except for some nitpicks on the test cases (which are easy to fix so I'm hoping you just will :)). Comment at: clang/unittests/Format/FormatTest.cpp:13780 + // In C++2a, it is interpreted as a prefix increment on

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:111 +QualType Ty = CE->getCallReturnType(C.getASTContext()); +V = C.getSValBuilder().makeTruthVal(true, Ty); + } Charusso wrote: > That is a very lame way to co

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:111 +QualType Ty = CE->getCallReturnType(C.getASTContext()); +V = C.getSValBuilder().makeTruthVal(true, Ty); + } NoQ wrote: > Charusso wrote: > > That is a

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:111 +QualType Ty = CE->getCallReturnType(C.getASTContext()); +V = C.getSValBuilder().makeTruthVal(true, Ty); + } Charusso wrote: > NoQ wrote: > > Charusso wrote

[PATCH] D65854: [diagtool] Use `operator<<(Colors)` to print out colored output.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with Fangrui's comment addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65854/new/ https://reviews.llvm.org/D65854 _

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, but please print the function template arguments uniformly before landing this (to avoid different forms of outputs inside the same test). Repository: rG LLVM Github Mon

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso updated this revision to Diff 213952. Charusso marked 5 inline comments as done. Charusso added a comment. - Remove symbol-conjuring. - Add a forgotten test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65889/new/ https://reviews.llvm.org/D65889 Files: clang/lib/Static

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:111 +QualType Ty = CE->getCallReturnType(C.getASTContext()); +V = C.getSValBuilder().makeTruthVal(true, Ty); + } NoQ wrote: > Charusso wrote: > > NoQ wrote

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:7077 +// someContainer.add(std::move(localOWner)); +// return p; +if (!IsTempGslOwner && pathOnlyInitializesGslPointer(Path) && gr

r368196 - [Tooling] Expose ExecutorConcurrency option.

Author: diegoastiazaran Date: Wed Aug 7 11:35:28 2019 New Revision: 368196 URL: http://llvm.org/viewvc/llvm-project?rev=368196&view=rev Log: [Tooling] Expose ExecutorConcurrency option. D65628 requires a flag to specify the number of threads for a clang-doc step. It would be good to use Executo

[PATCH] D65833: [Tooling] Expose ExecutorConcurrency option.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368196: [Tooling] Expose ExecutorConcurrency option. (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev marked 3 inline comments as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:226 +// Add this function to global destructors. +appendToGlobalDtors(M, Func, 0); + } vzakhari wrote: > FY

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp targe

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:226 +// Add this function to global destructors. +appendToGlobalDtors(M, Func, 0); + } sdmitriev wrote: > vzakhari wrote: > > FYI, llvm.global_dtors does

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:226 +// Add this function to global destructors. +appendToGlobalDtors(M, Func, 0); + } ABataev wrote: > sdmitriev wrote: > > vzakhari wrote: > > > FYI,

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny marked an inline comment as done. jdenny added a comment. In D65835#1618865 , @ABataev wrote: > `is_device_ptr` can be considered as a kind of mapping clause (see 2.19.7 > Data-Mapping Attribute Rules, Clauses, and Directives), so, I assume, clan

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Szelethus added a comment. Cheers! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65889/new/ https://reviews.llvm.org/D65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

efriedma added a comment. This seems better. I'm not sure I follow why this needs special handling in SelectionDAGBuilder::visitIntrinsicCall, as opposed to just using ISD::INTRINSIC_VOID like other similar target-specific intrinsics. (You can custom-lower INTRINSIC_VOID in ARMTargetLowering:

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp targe

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. > Maybe, but I haven't found any statement in either version that states that > map restrictions apply to is_device_ptr. `is_device_ptr` is a kind of mapping clause. I assume we can extend the restrictions for `map` clause to this clause too. > Another question is whet

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. > I should have reported that the current implementation isn't complete for > OpenMP 4.5. For example, on target teams, reduction(+:x) map(x) is an error > but not map(x) reduction(+:x). So there are bugs to fix, and maybe this will > evolve into multiple patches, but I

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1619526 , @ABataev wrote: > > Maybe, but I haven't found any statement in either version that states that > > map restrictions apply to is_device_ptr. > > `is_device_ptr` is a kind of mapping clause. I assume we can exten

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1619549 , @jdenny wrote: > In D65835#1619526 , @ABataev wrote: > > > > Maybe, but I haven't found any statement in either version that states > > > that map restrictions apply to

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

JamesNagurne added a comment. In case you haven't seen, this commit breaks non-x86 build bots due to the combination of '-triple x86_64*' and '-S'. Some tests that use this target are only looking for AST dumps, and do not actually require such a target. This is not one of those tests, as it's

[PATCH] D65545: Handle some fs::remove failures

vsapsai added a comment. I have no other comments but for the fatal error in `FileRemover` I'd like to loop in Jonas as he was touching module cache in LLDB fairly recently. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1444-1445 // Remove the file. - llvm::s

  1   2   >