efriedma added a comment.

This seems better.

I'm not sure I follow why this needs special handling in 
SelectionDAGBuilder::visitIntrinsicCall, as opposed to just using 
ISD::INTRINSIC_VOID like other similar target-specific intrinsics.  (You can 
custom-lower INTRINSIC_VOID in ARMTargetLowering::LowerOperation, if that makes 
it easier.)

I'd just skip changing fast-isel; with an intrinsic, if fast-isel misses, we 
just fall back to the SelectionDAG code that does the right thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65019/new/

https://reviews.llvm.org/D65019



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to