r367984 - [DirectoryWatcher] Fix asserts Mac builds

Author: smeenai Date: Tue Aug 6 00:13:53 2019 New Revision: 367984 URL: http://llvm.org/viewvc/llvm-project?rev=367984&view=rev Log: [DirectoryWatcher] Fix asserts Mac builds Add a missing semicolon after an assert. Remove the period from the assert message while I'm here, because we don't usual

Re: r367979 - [clang][DirectoryWatcher] Adding llvm::Expected error handling to create.

You missed a semicolon after an assert, which broke asserts Mac builds. I fixed it in r367984. From: cfe-commits on behalf of Puyan Lotfi via cfe-commits Reply-To: Puyan Lotfi Date: Monday, August 5, 2019 at 10:11 PM To: "cfe-commits@lists.llvm.org" Subject: r367979 - [clang][DirectoryWatche

Re: r367979 - [clang][DirectoryWatcher] Adding llvm::Expected error handling to create.

Thank you! I had forgot that cmake decides which cpp file to build with for DirectoryWatcher depending on the os you’re building on :-( PL Sent from ProtonMail Mobile On Tue, Aug 6, 2019 at 12:14 AM, Shoaib Meenai wrote: > You missed a semicolon after an assert, which broke asserts Mac builds

[PATCH] D65738: [clangd] Added a TextMate theme parser that updates when the current theme changes.

jvikstrom updated this revision to Diff 213528. jvikstrom marked 2 inline comments as done. jvikstrom added a comment. Narrowed CL down to loading/parsing a text mate theme. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65738/new/ https://reviews.l

[PATCH] D65738: [clangd] Added a TextMate theme parser that updates when the current theme changes.

jvikstrom added a comment. In D65738#1614897 , @hokein wrote: > Haven't looked at the patch in details. > > Looks like the patch is doing different things, and the test just covers a > small set of the code. > > 1. find and parse the theme definition file

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

davezarzycki added a comment. From the Swift language source (http://github.com/apple/swift): include/swift/AST/Attr.h:/// A limited variant of \c @objc that's used for classes with generic ancestry. include/swift/AST/Decl.h: /// \c @usableFromInline attribute are treated as public. This is no

Re: r367675 - [OpenCL] Allow OpenCL C style vector initialization in C++

Merged both this and the follow-up to release_90 in r367987. On Mon, Aug 5, 2019 at 1:16 PM Anastasia Stulova via cfe-commits wrote: > > Hi Yvan, > > > Sorry for this, it should now be fixed in r367823. > > > Thanks, > > Anastasia > > > > > From: Yvan Roux > Sen

Re: r367906 - [DirectoryWatcher][linux] Fix build for older kernels

Merged to release_90 in r367995. On Mon, Aug 5, 2019 at 8:43 PM Jan Korous via cfe-commits wrote: > > Author: jkorous > Date: Mon Aug 5 11:44:07 2019 > New Revision: 367906 > > URL: http://llvm.org/viewvc/llvm-project?rev=367906&view=rev > Log: > [DirectoryWatcher][linux] Fix build for older ker

[PATCH] D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/AST/RecursiveASTVisitorTest.cpp:107 +} \ No newline at end of file Please add a newline. Repository: rG LLVM Githu

[PATCH] D65738: [clangd] Added a TextMate theme parser that updates when the current theme changes.

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/TextMate.ts:6 + +export namespace SemanticHighlighting { +interface ScopeColorRule { I think we should not use the namespace in typescript. The `namespace` in TS refers

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio reopened this revision. dnsampaio added a comment. This revision is now accepted and ready to land. Hi, first thanks for those that looked into this and sorry for the delay. We have investigated the errors and seems that the test was, first in the wrong folder, inside CodeGen where it s

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 213540. dnsampaio added a comment. Fix test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/ARM.cpp test/CodeGenCXX/ARM/exception-alignment.cpp test/S

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio added a comment. I have tested this in our MacOS and linux environments. @thakis @thegameg @phosek, would it be possible for you to check if this works for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

balazske updated this revision to Diff 213551. balazske added a comment. A new kind of solution, the previous does not work always. Still no test for this new problem case (circular dependency between a ParmVarDecl and function of it and a CXXDefaultArgExpr that references to the function probab

[PATCH] D65796: [clangd] Compute scopes eagerly in IncludeFixer

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Computing lazily leads to crashes. In particular, computing scopes may produce diagnostics (from inside template instantiat

r368009 - Add User docs for ASTImporter

Author: martong Date: Tue Aug 6 02:52:21 2019 New Revision: 368009 URL: http://llvm.org/viewvc/llvm-project?rev=368009&view=rev Log: Add User docs for ASTImporter Summary: This document includes the description of the ASTImporter from the user/client perspective. A subsequent patch will describe

[PATCH] D65573: Add User docs for ASTImporter

This revision was automatically updated to reflect the committed changes. Closed by commit rL368009: Add User docs for ASTImporter (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6557

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D65796: [clangd] Compute scopes eagerly in IncludeFixer

ilya-biryukov updated this revision to Diff 213557. ilya-biryukov added a comment. - Make sure the test actually runs IncludeFixer.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65796/new/ https://reviews.llvm.org/D65796 Files: clang-tools-ex

[PATCH] D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

ilya-biryukov updated this revision to Diff 213558. ilya-biryukov added a comment. - Add the missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64907/new/ https://reviews.llvm.org/D64907 Files: clang/include/clang/AST/RecursiveASTVisi

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

balazske updated this revision to Diff 213563. balazske added a comment. Small but important fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65577/new/ https://reviews.llvm.org/D65577 Files: clang/include/clang/AST/ASTImporter.h clang/lib/A

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/AST.h:86 +bool isImplicitTemplateInstantiation(const NamedDecl *D); +bool isExplicitTemplateSpecialization(const NamedDecl *D); Could you add a small comment with an example? ``` /// Indi

[PATCH] D65738: [clangd] Added a TextMate theme parser that updates when the current theme changes.

jvikstrom updated this revision to Diff 213567. jvikstrom marked 6 inline comments as done. jvikstrom added a comment. Renamed file to semantic-highlighting.ts. Added test for parsing theme files. Inlined the parsing into the loading function. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D65738: [clangd] Added a TextMate theme parser that updates when the current theme changes.

jvikstrom updated this revision to Diff 213568. jvikstrom added a comment. Clarified comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65738/new/ https://reviews.llvm.org/D65738 Files: clang-tools-extra/clangd/clients/clangd-vscode/package

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

martong accepted this revision. martong added a comment. Still looks good to me, other than some style nits. Comment at: clang/lib/AST/ASTImporter.cpp:3829 +Error ASTNodeImporter::ImportDefaultArgOfParmVarDecl(const ParmVarDecl *FromParam, ParmVarDecl *ToParam) { + ToParam-

[PATCH] D65445: [CrossTU] Handle case when no USR could be generated during Decl search.

balazske updated this revision to Diff 213571. balazske added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65445/new/ https://reviews.llvm.org/D65445 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h clang/lib/Cross

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || mgehre wrote: > xazax.hun wrote: > > I

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Sema/Sema.h:6122 + /// std::container::iterator. \param UnderlyingRecord The record named by ND. + void addDefaultGslPointerAttrib

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:7031 + LLVM_FALLTHROUGH; +case IndirectLocalPathEntry::DefaultInit: return Path[I].E->getSourceRange(); This change would be best committed

[clang-tools-extra] r368019 - [clangd] Compute scopes eagerly in IncludeFixer

Author: ibiryukov Date: Tue Aug 6 04:37:50 2019 New Revision: 368019 URL: http://llvm.org/viewvc/llvm-project?rev=368019&view=rev Log: [clangd] Compute scopes eagerly in IncludeFixer Summary: Computing lazily leads to crashes. In particular, computing scopes may produce diagnostics (from inside

[PATCH] D65796: [clangd] Compute scopes eagerly in IncludeFixer

This revision was automatically updated to reflect the committed changes. Closed by commit rL368019: [clangd] Compute scopes eagerly in IncludeFixer (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6572 +return false; + return llvm::StringSwitch(Callee->getName()) + .Cases("begin", "rbegin", "cbegin", "crbegin", true) xazax.hun wrote: > gribozavr wrote: > > Should we also che

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

SureYeaah updated this revision to Diff 213583. SureYeaah added a comment. Implemented function to get expansion range such that ends are both in the same file id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65754/new/ https://reviews.llvm.org/D

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you should hold off a bit to commit -- @rsmith, do you have any concerns with this approach? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

r368020 - [CrossTU] Handle case when no USR could be generated during Decl search.

Author: balazske Date: Tue Aug 6 05:10:16 2019 New Revision: 368020 URL: http://llvm.org/viewvc/llvm-project?rev=368020&view=rev Log: [CrossTU] Handle case when no USR could be generated during Decl search. Summary: When searching for a declaration to be loaded the "lookup name" for every other

[PATCH] D65445: [CrossTU] Handle case when no USR could be generated during Decl search.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368020: [CrossTU] Handle case when no USR could be generated during Decl search. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

gribozavr added inline comments. Comment at: docs/clang-tidy/checks/bugprone-infinite-loop.rst:12 +the loop condition is not changed. This check detects such loops. A loop is +considered as infinite if it does not have any loop exit statement (``break``, +``continue``, ``goto``,

r368029 - Improve MSVC visualizations so the parser shows where we are in the code

Author: mps Date: Tue Aug 6 06:29:35 2019 New Revision: 368029 URL: http://llvm.org/viewvc/llvm-project?rev=368029&view=rev Log: Improve MSVC visualizations so the parser shows where we are in the code Also provide a visualizer for lambda introducers Modified: cfe/trunk/utils/ClangVisualize

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:307 +// the same file id. +static SourceRange getExpansionRangeInSameFiles(SourceLocation Loc, +const SourceManager &SM, nit: `get

[PATCH] D65738: [clangd] Added a TextMate theme parser that updates when the current theme changes.

hokein added a comment. thanks, looks simpler now, just a few more nits. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:7 +interface TokenColorRule { + scope: string, textColor: string, +} nit: we need documentation fo

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || ---

[PATCH] D65804: Fixed toHalfOpenFileRange assertion fail

SureYeaah created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. - Added new function that gets Expansion range with both ends in the same file. - Fixes the crash at https://github.com/clangd/clangd/issues/113 R

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

SureYeaah updated this revision to Diff 213599. SureYeaah marked 8 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65754/new/ https://reviews.llvm.org/D65754 Files: clan

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom updated this revision to Diff 213608. jvikstrom marked an inline comment as done. jvikstrom added a comment. Added tests for making sure explicit specializations, explicit instantiations, partial instantiations, explicit declarations and template variables are in topLevelDecls. Also ad

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom marked 2 inline comments as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:110 +template +void f(T) {} +void s() { ilya-biryukov wrote: > Could you also check that: > > 1. explicit

Re: r367889 - [docs] document -Weveything more betterer

Thanks! On Mon, Aug 5, 2019 at 3:58 PM JF Bastien wrote: > Ugh this is silly… fixed again. > > On Aug 5, 2019, at 12:55 PM, Nico Weber wrote: > > Still sad, now with a different message: > http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45220 > > /home/buildbot/llvm-build-dir/clang-s

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

tycho added a comment. Two things: - I'm curious why we would want to force `-O2`/`-O3` instead of just allowing `-Os`/`-Oz` to be used with LTO. Is optimizing for size combined with LTO really that unusual? I've built several projects using GCC with `-Os -flto` and the size reduction over pla

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. One important comment about somehow distinguishing multiple decls with the same name. Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:110 +template +void f(T) {} +void

Re: [clang-tools-extra] r368019 - [clangd] Compute scopes eagerly in IncludeFixer

+Hans Wennborg , could we merge this into the release? On Tue, Aug 6, 2019 at 1:36 PM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryukov > Date: Tue Aug 6 04:37:50 2019 > New Revision: 368019 > > URL: http://llvm.org/viewvc/llvm-project?rev=368019&view=rev > L

[PATCH] D65693: [driver][riscv] Support riscv64-linux-gnu multiarch paths

asb requested changes to this revision. asb added a comment. This revision now requires changes to proceed. Many thanks for the patch. Could you please add some tests for this behaviour? I imagine you'll want to add a new directory in test/Driver/Inputs with a Debian tree skeleton. See D63497

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

gribozavr added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't start watching. In such - /// case it

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

gribozavr added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:283 /*waitForInitialSync=*/true); + if (!DW) return; plotfi wrote: > jkorous wrote: > > jkorous wrote: > > > IIUC this is silently dropping errors. We

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || xazax.hun wrote: > gribozavr wrote: >

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

gribozavr added a comment. So the problem you're trying to solve is that the output is non-deterministic, is that correct? > However, it is random which checker name is included in the warning. If that is indeed the problem, then I think the solution should be making the output deterministic -

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:316 + // Expand begin of Expansion range till the top and map with file id hash. + llvm::DenseMap BeginExpansions; + SourceRange BeginExpansion = ExpansionRange.getBegin(); sa

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

SureYeaah updated this revision to Diff 213614. SureYeaah added a comment. use fileID instead of hash in map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65754/new/ https://reviews.llvm.org/D65754 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:283 /*waitForInitialSync=*/true); + if (!DW) return; gribozavr wrote: > plotfi wrote: > > jkorous wrote: > > > j

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

bruntib added a comment. Not exactly. The problem is that it is non-deterministic which checker reports the issue. For example before this patch, in the test file above there was only one report. However, sometimes the report message is: throw expression should throw anonymous temporary values

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

gribozavr added a comment. Producing the message two times is worse user experience than producing one. Most users don't care which checker produced the message. However, the output should be deterministic. Therefore, a better fix would be making deduplication deterministic, instead of printing

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

rjmccall added a comment. I doubt "CTAD" is going to survive as a term that people recognize and remember, and I don't think `-Wclass-template-argument-deduction` is outrageously wordy compared to some of our other diagnostic groups. With that change, this would be fine with me. Repository:

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

rjmccall added a comment. Oh, I see this review might be dead in the water; I'm not sure why I was just added as a reviewer to it (by a non-author, no less). I personally have no problem with pulling out specific features as sub-groups of the compatibility warning. I agree with Richard, though

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 6 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't

LLVM Types

Hello, Can I dump LLVM Type hierarchies somehow ?? Types which are declared in this file ("clang/AST/Type.h " ) Regards, Mona ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

AST for For loop

Hello, While dumping the AST for For loop, Why do I get <<>> ?? Source code: void func() { for (int i = 0; i < 5; i++) break; } AST FunctionDecl 0x4a4ac10 line:2:6 func 'void ()' `-CompoundStmt 0x4a4ae1c `-ForStmt 0x4a4adf8 |-DeclStmt 0x4a4ad38 | `-VarDecl 0x4a4acd0 col:11 used i

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

bruntib added a comment. This suggestion would result another strange behavior: if the user disables cert-err09-cpp because he or she doesn't want to see its reports, the other one (cert-err61-cpp) will still report the issue. So he or she has to disable both (or as many aliases it has). As fa

Re: AST for For loop

On Tue, Aug 6, 2019 at 11:15 AM Monalisa Rout via cfe-commits wrote: > > Hello, > While dumping the AST for For loop, Why do I get <<>> ?? > > Source code: > void func() > { > for (int i = 0; i < 5; i++) > break; > } > > AST > > FunctionDecl 0x4a4ac10 > line:2:6 > func 'void ()' > `-CompoundSt

[PATCH] D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

Charusso updated this revision to Diff 213610. Charusso marked 4 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65663/new/ https://reviews.llvm.org/D65663 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang/lib

[PATCH] D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

Charusso added a comment. Here is an example of the new `MemberExpr::getBase()` based report: F9736772: report-Driver.cpp-operator()-6-1.html Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2420 + if (!IsAssuming) { +P

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

gribozavr added a comment. > This suggestion would result another strange behavior: if the user disables > cert-err09-cpp because he or she doesn't want to see its reports, the other > one (cert-err61-cpp) will still report the issue. So he or she has to disable > both (or as many aliases it ha

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || ---

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

lebedev.ri added a comment. In D65065#1617031 , @gribozavr wrote: > > This suggestion would result another strange behavior: if the user disables > > cert-err09-cpp because he or she doesn't want to see its reports, the other > > one (cert-err61-cpp) wil

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea added a comment. Thanks for the update Alex! Just a few more comments and we should be good to go: Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:117 +std::mutex CacheLock; +llvm::StringMap> Cache; + }; --

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

gribozavr added a comment. `-Weverything` is not recommended for anything except compiler testing, and similarly with clang-tidy, enabling all checkers is not a good idea. I don't think improving this particular point will make enabling all checks more usable. Repository: rCTE Clang Tools Ex

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:7077 +// someContainer.add(std::move(localOWner)); +// return p; +if (!IsTempGslOwner && pathOnlyInitializesGslPointer(Path) && gr

r368052 - [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

Author: ibiryukov Date: Tue Aug 6 08:46:12 2019 New Revision: 368052 URL: http://llvm.org/viewvc/llvm-project?rev=368052&view=rev Log: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro Summary: Instead of traversing inside the TraverseDecl() function. Previously the attributes were traver

[PATCH] D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

This revision was automatically updated to reflect the committed changes. Closed by commit rL368052: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

lebedev.ri added a comment. In D65065#1617079 , @gribozavr wrote: > `-Weverything` is not recommended for anything except compiler testing, and > similarly with clang-tidy, enabling all checkers is not a good idea. I don't > think improving this particul

Re: AST for For loop

Awesome, thanks! On Tue, Aug 6, 2019 at 5:18 PM Aaron Ballman wrote: > On Tue, Aug 6, 2019 at 11:15 AM Monalisa Rout via cfe-commits > wrote: > > > > Hello, > > While dumping the AST for For loop, Why do I get <<>> ?? > > > > Source code: > > void func() > > { > > for (int i = 0; i < 5; i++) >

[PATCH] D65690: [clang-doc] Add index in each info html file

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65690/new/ https://reviews.llvm.org/D65690 ___ cfe-commits mailing list c

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

fhahn added a comment. In D65776#1615834 , @Meinersbur wrote: > Mmmh, I would have expected this to work the same way as `vectorize_width`. > According to the docs: > > > The following example implicitly enables vectorization and interleaving by > > spec

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry, should have accepted this in the last round. Great stuff, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65754/new/ https

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev marked 4 inline comments as done. sdmitriev added inline comments. Comment at: clang/include/clang/Driver/Action.h:74 OffloadUnbundlingJobClass, +OffloadWrapperJobClass, ABataev wrote: > Do we really need this new kind of job here, can we use

[clang-tools-extra] r368058 - Fixed toHalfOpenFileRange assertion fail

Author: sureyeaah Date: Tue Aug 6 10:01:12 2019 New Revision: 368058 URL: http://llvm.org/viewvc/llvm-project?rev=368058&view=rev Log: Fixed toHalfOpenFileRange assertion fail Summary: - Added new function that gets Expansion range with both ends in the same file. - Fixes the crash at https://gi

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

This revision was automatically updated to reflect the committed changes. Closed by commit rL368058: Fixed toHalfOpenFileRange assertion fail (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

r368062 - [Syntax] Do not add a node for 'eof' into the tree

Author: ibiryukov Date: Tue Aug 6 10:07:58 2019 New Revision: 368062 URL: http://llvm.org/viewvc/llvm-project?rev=368062&view=rev Log: [Syntax] Do not add a node for 'eof' into the tree Summary: While useful as a sentinel value when iterating over tokens, having 'eof' in the tree, seems to do mo

[PATCH] D64576: [Syntax] Do not add a node for 'eof' into the tree

This revision was automatically updated to reflect the committed changes. Closed by commit rL368062: [Syntax] Do not add a node for 'eof' into the tree (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. Unfortunately I'm not able to quickly find the Doxygen output of Swift online. When I process: `A limited variant of \c @objc that's used for classes with generic ancestry.` with Doxygen I get: `A limited variant of that's used for classes with generic ancestry.` Since t

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

mehdi_amini added a comment. > I assume I might be missing something here, though, since someone mentioned > this above (I don't understand the response to it though). There are two invocations in LTO: the first phase where we compile from source to bitcode, and the second phase which is invoke

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

tycho added a comment. OK, that makes sense. So this change would not enforce `-O2`/`-O3` for the bitcode emission, but would enforce one of the two for the LTO phase. This may be a stupid question, but aren't there some optimization passes that can emit functions during the LTO phase that were

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman updated this revision to Diff 213664. arphaman marked 6 inline comments as done. arphaman added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63907/new/ https://reviews.llvm.org/D63907 Files: clang/include/clang/Bas

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:117 +std::mutex CacheLock; +llvm::StringMap> Cache; + }; aganea wrote: > Why not use a bump allocator here? (it would be per-thread

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added a comment. Just for reference, this patch still doesn't reuse the FileManager across invocations in a thread. We expect to get even better performance once we reuse it, but I'm going have to improve its API first. Repository: rC Clang CHANGES SINCE LAST ACTION https://revie

[clang-tools-extra] r368070 - [clang-doc] Add index in each info html file

Author: diegoastiazaran Date: Tue Aug 6 11:31:46 2019 New Revision: 368070 URL: http://llvm.org/viewvc/llvm-project?rev=368070&view=rev Log: [clang-doc] Add index in each info html file An index structure is created while generating the output file for each info. This structure is parsed to JSON

[PATCH] D65690: [clang-doc] Add index in each info html file

This revision was automatically updated to reflect the committed changes. Closed by commit rL368070: [clang-doc] Add index in each info html file (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev created this revision. ABataev added reviewers: yaxunl, tra, jlebar, hfinkel. Herald added a reviewer: jdoerfert. Herald added a project: clang. Previously, object files were bundled using partial linking. It resulted in the following structure of the bundled objects: clang-offload-bund

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:69 + + using MemoryBuffersVector = SmallVectorImpl>; + Why not `ArrayRef`? Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.c

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM, thank you! In D63907#1617417 , @arphaman wrote: > Just for reference, this patch still doesn't reuse the FileManager across > invocations in a t

[PATCH] D65648: [clang-format] Add support to SpacesBeforeTrailingComments to add spaces before Block comments.

Manikishan marked an inline comment as done. Manikishan added inline comments. Comment at: unittests/Format/FormatTest.cpp:3663 + FormatStyle Style = getGoogleStyle(); + Style.SpacesBeforeTrailingComments = 0; EXPECT_EQ("#define MACRO() \\\n"

r368072 - Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

Author: xazax Date: Tue Aug 6 12:13:29 2019 New Revision: 368072 URL: http://llvm.org/viewvc/llvm-project?rev=368072&view=rev Log: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes This patch extends some existing warnings to utilize the knowledge about the gsl::Pointer and

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL368072: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

  1   2   >