[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Driver/Types.cpp:303 + // Types.def is correct. Everything above this comment will be removed + // in a subsequent NFC

[PATCH] D64914: Implement P1771

erichkeane updated this revision to Diff 210753. erichkeane marked an inline comment as done. erichkeane added a comment. Removes pure/const, limits change to just CXX11 spelling, and changes docs/FeatureTestMacro. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64914/new/ https://review

[clang-tools-extra] r366541 - [clangd] cleanup: unify the implemenation of checking a location is inside main file.

Author: hokein Date: Fri Jul 19 01:33:39 2019 New Revision: 366541 URL: http://llvm.org/viewvc/llvm-project?rev=366541&view=rev Log: [clangd] cleanup: unify the implemenation of checking a location is inside main file. Summary: We have variant implementations in the codebase, this patch unifies

[PATCH] D64915: [clangd] cleanup: unify the implemenation of checking a location is inside main file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366541: [clangd] cleanup: unify the implemenation of checking a location is inside main… (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill updated this revision to Diff 210768. chill added a comment. This revision is now accepted and ready to land. Changed `tcancel` implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 Files: clang/include/clang/Basic/BuiltinsAArc

[PATCH] D64222: [sanitizers] Use covering ObjectFormatType switches

This revision was automatically updated to reflect the committed changes. Closed by commit rL366544: [sanitizers] Use covering ObjectFormatType switches (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D64222?vs=208085&id=210772#toc Reposit

r366544 - [sanitizers] Use covering ObjectFormatType switches

Author: hubert.reinterpretcast Date: Fri Jul 19 01:46:18 2019 New Revision: 366544 URL: http://llvm.org/viewvc/llvm-project?rev=366544&view=rev Log: [sanitizers] Use covering ObjectFormatType switches Summary: This patch removes the `default` case from some switches on `llvm::Triple::ObjectFormat

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

sammccall added a comment. Just doc nits I think. This eliminates a semi-fast path (that uses approximate token matching to avoid running the lexer in claimRange sometimes) but I think we can live without it. Comment at: clang-tools-extra/clangd/Selection.cpp:242 // This i

[PATCH] D64980: [clangd][BackgroundIndexLoader] Directly store DependentTU while loading shard

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We were deferring the population of DependentTU field in LoadedShard until BackgroundIndexLoader was consumed. Thi

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

SjoerdMeijer updated this revision to Diff 210774. SjoerdMeijer retitled this revision from " #pragma clang loop predicate(enable|disable)" to " #pragma clang loop vectorize_predicate(enable|disable)". SjoerdMeijer edited the summary of this revision. SjoerdMeijer added a comment. Hi Michael, th

[clang-tools-extra] r366545 - [clangd] Handle windows line endings in QueryDriver

Author: kadircet Date: Fri Jul 19 02:08:22 2019 New Revision: 366545 URL: http://llvm.org/viewvc/llvm-project?rev=366545&view=rev Log: [clangd] Handle windows line endings in QueryDriver Summary: The previous patch did not fix the end mark. D64789 fixes second case of https://github.com/clangd/cl

r366546 - [OpenCL] Define CLK_NULL_EVENT without cast

Author: svenvh Date: Fri Jul 19 02:11:48 2019 New Revision: 366546 URL: http://llvm.org/viewvc/llvm-project?rev=366546&view=rev Log: [OpenCL] Define CLK_NULL_EVENT without cast Defining CLK_NULL_EVENT with a `(void*)` cast has the (unintended?) side-effect that the address space will be fixed (as

[PATCH] D64970: [clangd] Handle windows line endings in QueryDriver

This revision was automatically updated to reflect the committed changes. Closed by commit rL366545: [clangd] Handle windows line endings in QueryDriver (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D63876: [OpenCL] Define CLK_NULL_EVENT without cast

This revision was automatically updated to reflect the committed changes. Closed by commit rL366546: [OpenCL] Define CLK_NULL_EVENT without cast (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[libunwind] r366549 - Drop svn version suffix.

Author: hans Date: Fri Jul 19 02:22:57 2019 New Revision: 366549 URL: http://llvm.org/viewvc/llvm-project?rev=366549&view=rev Log: Drop svn version suffix. Modified: libunwind/branches/release_90/CMakeLists.txt Modified: libunwind/branches/release_90/CMakeLists.txt URL: http://llvm.org/view

[clang-tools-extra] r366551 - Revert r366458, r366467 and r366468

Author: azhar Date: Fri Jul 19 02:26:33 2019 New Revision: 366551 URL: http://llvm.org/viewvc/llvm-project?rev=366551&view=rev Log: Revert r366458, r366467 and r366468 r366458 is causing test failures. r366467 and r366468 had to be reverted as they were casuing conflict while reverting r366458.

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:458 +// edit there are stale previous highlightings. +std::lock_guard Lock(HighlightingsMutex); +FileToHighlightings.erase(File); ilya-biryukov wrote: > jvikstrom w

Re: [clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

Reverted in r366551. Revert r366458, r366467 and r366468 r366458 is causing test failures. r366467 and r366468 had to be reverted as they were casuing conflict while reverting r366458. r366468 [clangd] Remove dead code from BackgroundIndex r366467 [clangd] BackgroundIndex s

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 210783. SureYeaah marked 2 inline comments as done. SureYeaah added a comment. Updated comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-e

[PATCH] D41412: [libcxx] implement concat() and split()

grosser added a comment. In D41412#1592152 , @timshen wrote: > Tobias, > > I spoke to @EricWF who is willing to take a look at all these patches. > However, I don't know when exactly will the review starts. Amazing. I am super interested in seeing this

[PATCH] D62960: Add SVE opaque built-in types

rovka added a comment. FWIW, I think the tests look great. Would be nice if someone more experienced with clang could also have a look though. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62960/new/ https://reviews.llvm.org/D62960 ___

Re: r366480 - [RISCV] Hard float ABI support

Merged to the 9.0 branch in r366554. On Thu, Jul 18, 2019 at 8:29 PM Alex Bradbury via cfe-commits wrote: > > Author: asb > Date: Thu Jul 18 11:29:59 2019 > New Revision: 366480 > > URL: http://llvm.org/viewvc/llvm-project?rev=366480&view=rev > Log: > [RISCV] Hard float ABI support > > The RISC-V

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 210786. kadircet added a comment. - Add tests. - Change the layer we ignore the diags: - Mark diags from headers as insidemainfile when we decide to surface them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:473 + SourceManager &SM = Info.getSourceManager(); + if (!InsideMainFile && SM.isWrittenInBuiltinFile(Info.getLocation())) { +IgnoreDiagnostics::l

Re: r366511 - Update the SimpleJIT class in the clang-interpreter example to use ORCv2.

Merged to 9.0 in r366556. On Fri, Jul 19, 2019 at 12:46 AM Lang Hames via cfe-commits wrote: > > Author: lhames > Date: Thu Jul 18 15:47:18 2019 > New Revision: 366511 > > URL: http://llvm.org/viewvc/llvm-project?rev=366511&view=rev > Log: > Update the SimpleJIT class in the clang-interpreter exa

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, javed.absar. Herald added a project: clang. By exposing a callback that can guard code publishing results of 'onMainAST' callback in the same manner we gu

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 ___ cfe-commits mailing list cfe-com

[clang-tools-extra] r366559 - Revert "Revert r366458, r366467 and r366468"

Author: kadircet Date: Fri Jul 19 03:18:52 2019 New Revision: 366559 URL: http://llvm.org/viewvc/llvm-project?rev=366559&view=rev Log: Revert "Revert r366458, r366467 and r366468" This reverts commit 9c377105da0be7c2c9a3c70035ce674c71b846af. [clangd][BackgroundIndexLoader] Directly store Depende

[PATCH] D64980: [clangd][BackgroundIndexLoader] Directly store DependentTU while loading shard

This revision was automatically updated to reflect the committed changes. Closed by commit rL366559: Revert "Revert r366458, r366467 and r366468" (authored by kadircet, committed by ). Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Changed prior to commit: https:/

Re: [clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

Hi Azhar, D64980 should fix the problem. I am reverting your revert while adding the fix in r366559. On Fri, Jul 19, 2019 at 11:29 AM Azhar Mohammed wrote: > Reverted in r366551. > > > Revert r366458, r366467 and r366468 > > r366458 is causing test failures. r366467 and r366468 had to be

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske added a reviewer: ilya-biryukov. balazske added a subscriber: ilya-biryukov. balazske added a comment. @ilya-biryukov Please check if it is acceptable to use `ASTUnit` in PlistDiagnostic.cpp. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/ http

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:399 + // FIXME: SelectionTree needs to be fixed for macros + /*{R"cpp(#define LOOP(x

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:208 const SelectionTree::Node *N = Inputs.ASTSelection.commonAncestor(); - if (!N) -return false; - Target = llvm::make_unique(N, SM, Ctx); - return Target->isExtrac

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

sammccall added a comment. I think this is the right design. As mentioned offline, I think we can now move the onDiagnostics call out from TUScheduler into ClangdServer (and remove onDiagnostics from the callbacks interface). This is a better layer because the diagnostics callback model is reall

[clang-tools-extra] r366566 - [Clangd] Fixed SelectionTree bug for macros

Author: sureyeaah Date: Fri Jul 19 04:41:02 2019 New Revision: 366566 URL: http://llvm.org/viewvc/llvm-project?rev=366566&view=rev Log: [Clangd] Fixed SelectionTree bug for macros Summary: Fixed SelectionTree bug for macros - Fixed SelectionTree claimRange for macros and template instantiations -

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL366566: [Clangd] Fixed SelectionTree bug for macros (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210800. SureYeaah marked 5 inline comments as done. SureYeaah added a comment. Minor changes and disabled extraction from label statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://revie

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM from my side. Do you have any concerns @sammccall ? Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:427 R"cpp(void f(int a) {

[PATCH] D64775: [Format/ObjC] Avoid breaking between unary operators and ObjC method invocations

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yeah, worst case we'll need to roll this back and go with the targeted fix, but I don't see a problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

t.p.northover added inline comments. Comment at: clang/test/Sema/aarch64-tme-errors.c:1 +// RUN: %clang_cc1 -triple aarch64-eabi -verify %s + I don't think the Sema checks need to be split over so many files. One for the whole of transactional seems enough. Simi

[PATCH] D64914: Implement P1771

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2346 +// spellings. +bool IsCXX11NoDiscard() const { + return this->getSemanticSpelling() == CXX11_nodiscard; I don't think this is strictly required, but perhaps it's

[clang-tools-extra] r366568 - [Clangd] Fixed ExtractVariable test

Author: sureyeaah Date: Fri Jul 19 05:11:04 2019 New Revision: 366568 URL: http://llvm.org/viewvc/llvm-project?rev=366568&view=rev Log: [Clangd] Fixed ExtractVariable test Modified: clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp Modified: clang-tools-extra/trunk/clangd/unittests/Twe

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210803. SureYeaah marked an inline comment as done. SureYeaah added a comment. Added test for label Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files: clang-too

[PATCH] D64914: Implement P1771

erichkeane marked 2 inline comments as done. erichkeane added a comment. I'll need to rebase this on another patch soon anyway, so I'll hold off until next week to update this particularly since we have some open questions. The additional TableGen work is tempting to do, though I'm not complete

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:427 R"cpp(void f(int a) { auto dummy = 1; label: [ [gsl::suppress("type")] ] for (;;) a = dummy; })cpp"}, kadircet w

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov updated this revision to Diff 210805. ilya-biryukov added a comment. - Use the same mechanism for diagnostics - Change typedef to function)> - Update a comment - s/PublishResults/PublishFn - Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D64914: Implement P1771

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:2833-2835 if (D->getFunctionType() && - D->getFunctionType()->getReturnType()->isVoidType()) { + D->getFunctionType()->getReturnType()->isVoidType() && + !isa(D)) {

[PATCH] D60456: [RISCV] Hard float ABI support

This revision was automatically updated to reflect the committed changes. Closed by commit rL366450: [RISCV] Hard float ABI support (authored by asb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D60456?v

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov updated this revision to Diff 210807. ilya-biryukov added a comment. - Update usage of DiagsMu in a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64985/new/ https://reviews.llvm.org/D64985 Files: clang-tools-extra/clangd/Cl

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov updated this revision to Diff 210808. ilya-biryukov added a comment. - Remove a leftover comment from the previous version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64985/new/ https://reviews.llvm.org/D64985 Files: clang-tools-

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov added a comment. Thanks for all the suggestions. This is ready for the next round now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64985/new/ https://reviews.llvm.org/D64985 ___ cfe-com

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome, I think this is in better shape than before highlighting was added. Comment at: clang-tools-extra/clangd/TUScheduler.h:102 const

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

ilya-biryukov added a comment. `StaticAnalyzer/Core` does not depend on `clangFrontend` now, you can see this by looking at `lib/StaticAnalyzer/Core/CMakeLists.txt`: add_clang_library(clangStaticAnalyzerCore ... LINK_LIBS clangAST clangASTMatchers clangAnalysis clangBasic

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong updated this revision to Diff 210813. martong added a comment. - Rebase to master - Some refactor is done mostly because since D63603 ([ASTImporter] Propagate error from ImportDeclContext) we may not imported successfully all decls of a DC. - Made the c

[PATCH] D64990: [clangd] Disable background-index on lit-tests by default

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Since background-index can perform disk writes, we don't want to turn it on tests that won't clear it. Repositor

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, rnkovacs, a_sidorin, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity, mgorny.

[PATCH] D64990: [clangd] Disable background-index on lit-tests by default

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:361 + EnableBackgroundIndex = false; // Ensure background index makes progress. BackgroundQu

[clang-tools-extra] r366575 - [clangd] Disable background-index on lit-tests by default

Author: kadircet Date: Fri Jul 19 06:40:30 2019 New Revision: 366575 URL: http://llvm.org/viewvc/llvm-project?rev=366575&view=rev Log: [clangd] Disable background-index on lit-tests by default Summary: Since background-index can perform disk writes, we don't want to turn it on tests that won't cl

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:307 +llvm::StringRef NewCode; +std::vector DiffedLines; + } TestCases[]{ @hokein rightfully pointed out that mentioning all changed lines ma

[PATCH] D64990: [clangd] Disable background-index on lit-tests by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL366575: [clangd] Disable background-index on lit-tests by default (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov updated this revision to Diff 210823. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Group PublishFn with onMainAST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64985/new/ https://reviews.llvm.org/D6

[PATCH] D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list

kmclaughlin updated this revision to Diff 210821. kmclaughlin retitled this revision from "[SVE][Inline-Asm] Add support to clang for SVE inline assembly" to "[SVE][Inline-Asm] Add support to specify SVE registers in the clobber list". kmclaughlin added a comment. - Removed typo fixes from this

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

RKSimon added inline comments. Comment at: llvm/test/CodeGen/AArch64/tme-tcancel.ll:1 +; RUN: llc %s -o - | FileCheck %s + Would it make sense to add -verify-machineinstrs to all these Codegen/AArch64/tme-*.ll tests? CHANGES SINCE LAST ACTION https://reviews

[clang-tools-extra] r366577 - [clangd] Provide a way to publish highlightings in non-racy manner

Author: ibiryukov Date: Fri Jul 19 06:51:01 2019 New Revision: 366577 URL: http://llvm.org/viewvc/llvm-project?rev=366577&view=rev Log: [clangd] Provide a way to publish highlightings in non-racy manner Summary: By exposing a callback that can guard code publishing results of 'onMainAST' callback

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

This revision was automatically updated to reflect the committed changes. Closed by commit rL366577: [clangd] Provide a way to publish highlightings in non-racy manner (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

ilya-biryukov added a comment. The fix for a race condition on remove has landed in rL366577 , this revision would need a small update after it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://r

[PATCH] D64863: [clangd] Ignore diags from builtin files

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:601 - if (mentionsMainFile(*LastDiag) || - (LastDiag->Severity >= DiagnosticsEngine::Level::Error && - IncludeLinesWithErrors.insert(LastDiag->Range.start.line).second)) { --

[PATCH] D64592: [OpenMP] Fix declare target link implementation

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2592-2593 llvm::raw_svector_ostream OS(PtrName); - OS << CGM.getMangledName(GlobalDecl(VD)) << "_decl_tgt_ref_ptr"; + unsigned DeviceID, Line; + unsigned FileID = 0; + OS << CGM.

[libclc] r366581 - Creating release candidate final from release_801 branch

Author: tstellar Date: Fri Jul 19 07:14:12 2019 New Revision: 366581 URL: http://llvm.org/viewvc/llvm-project?rev=366581&view=rev Log: Creating release candidate final from release_801 branch Added: libclc/tags/RELEASE_801/final/ - copied from r366580, libclc/branches/release_80/ _

[libunwind] r366581 - Creating release candidate final from release_801 branch

Author: tstellar Date: Fri Jul 19 07:14:12 2019 New Revision: 366581 URL: http://llvm.org/viewvc/llvm-project?rev=366581&view=rev Log: Creating release candidate final from release_801 branch Added: libunwind/tags/RELEASE_801/final/ - copied from r366580, libunwind/branches/release_80/

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman added a comment. In D64838#1592520 , @Nathan-Huckleberry wrote: > void foo() { > __attribute__((address_space(0))) *x; > *y; > } > > > If the attributes are parsed then function body looks like this to the parser: > > { > *

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 210834. kadircet added a comment. - Move deduplication logic back into the `flushLastDiag` as discussed offline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64863/new/ https://reviews.llvm.org/D64863 Files:

[PATCH] D64863: [clangd] Ignore diags from builtin files

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:128 +return false; + Position StartPos = sourceLocToPosition(SM, IncludeInMainFile); NIT: inline `StartPos`, it has online a single usage now. Comm

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 210838. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64863/new/ https://reviews.llvm.org/D64863 Files: clang-tools-ex

[PATCH] D64998: Improve clang-format-diff help output

thakis created this revision. thakis added a reviewer: krasimir. The description in clang-format-diff.py is more useful than the one in `clang-format-diff -h`, so use the same description in both places. https://reviews.llvm.org/D64998 Files: clang/tools/clang-format/clang-format-diff.py In

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

gribozavr added a comment. Is it true that all inline commands require an argument? For example, "\&" does not. Comment at: clang/test/Sema/warn-documentation.cpp:1030 +// The inline comments expect a string after the command. +// expected-warning@+1 {{'\a' command does not

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

thakis added a comment. In D63648#1591469 , @aganea wrote: > It totally makes sense, thanks for the explanation Nico! Let's forget about > `cl` compatibility, that wasn't my initial intent. > > We always pass //relative// paths on the cmd-line, for all th

[PATCH] D64780: Disallow most calling convention attributes on PS4.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. You should give other reviewers a chance to sign off in case they have additional comments. Comment at: lib/Basic/Targets/OSTargets.h:56

[libunwind] r366587 - [libunwind][ARM] Fix loading FP registers on big-endian targets

Author: miyuki Date: Fri Jul 19 08:20:32 2019 New Revision: 366587 URL: http://llvm.org/viewvc/llvm-project?rev=366587&view=rev Log: [libunwind][ARM] Fix loading FP registers on big-endian targets Summary: The function Unwind-EHABI.cpp:_Unwind_VRS_Pop loads the saved values of 64-bit FP registers

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sunfish added a comment. > This allows for us to fall back from arch-specific to generic headers as > needed. The same can be true of libraries. Not all libraries contains > compiled code. `.so` files can also be linker scripts that reference other > libraries in which case they can be arch-

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio created this revision. dnsampaio added reviewers: ostannard, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. The maximum alignment used by ARM arch is 64bits, not 128. This could cause overaligned memory access for 128 bit neon

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini updated this revision to Diff 210850. mantognini added a comment. - Add minimal regression test for PR42665 - Add CXXMemberCallExpr::getObjectType() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64569/new/ https://reviews.llvm.org/D64569

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini added a comment. In D64569#1592059 , @rjmccall wrote: > Yes, that's the right fix, although you might also consider adding a > `getObjectType()` to `CXXMemberCallExpr`. Thanks, John, it should be better now, but let me know if I can improve

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 FillDiagBase(*LastDiag); -adjustDiagFromHeader(*LastDiag, Info, *LangOpts); +if (!InsideMainFile) + LastDiagWasAdjusted = adjustDiagFromHeader(*LastDiag, Info, *LangOpts); -

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: test/OpenMP/declare_target_link_codegen.cpp:22-23 +// HOST-DAG: @c_decl_tgt_ref_ptr = weak global i32* @c +// HOST-DAG: @_{{.*}}d = internal global i32 2 +// HOST-DAG: @_{{.*}}d_{{.*}}_decl_tgt

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210854. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target_codegen.cp

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64569/new/ https://reviews.llvm.org/D64569 ___

[PATCH] D64592: [OpenMP] Fix declare target link implementation

ABataev added a comment. LG with a nit. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2595 +unsigned DeviceID, Line; +unsigned FileID = 0; +getTargetEntryUniqueInfo(CGM.getContext(), No need to initialize FileID. Repository: rC Clang

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210856. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target_codegen.cp

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: lib/Basic/Targets/OSTargets.h:564 } + TargetInfo::CallingConvCheckResult checkCallingConvention(CallingConv CC) const override { +return (CC == CC_C) ? TargetInfo::CCCR

r366592 - [Format/ObjC] Avoid breaking between unary operators and operands

Author: benhamilton Date: Fri Jul 19 09:50:24 2019 New Revision: 366592 URL: http://llvm.org/viewvc/llvm-project?rev=366592&view=rev Log: [Format/ObjC] Avoid breaking between unary operators and operands Summary: Test Plan: New tests added. Ran tests with: % ninja FormatTests && ./tools/clang

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

SjoerdMeijer updated this revision to Diff 210857. SjoerdMeijer added a comment. Removed the separate function that created the loop.llvm.vectorize.predicate metadata. This is now just part of function `createLoopVectorizeMetadata`, that creates all other vectorize metadata. CHANGES SINCE LAST

[PATCH] D64775: [Format/ObjC] Avoid breaking between unary operators and operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL366592: [Format/ObjC] Avoid breaking between unary operators and operands (authored by benhamilton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

gribozavr added inline comments. Comment at: clang-tidy/bugprone/InfiniteLoopCheck.cpp:25 + +static bool isAccessForVar(const Stmt *St, const VarDecl *Var) { + if (const auto *DRE = dyn_cast(St)) St => S "S" is a common abbreviation in the Clang codebase, "St"

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2332 S->isSemanticForm() ? S->getSyntacticForm() : S, Queue)); TRY_TO(TraverseSynOrSemInitListEx

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong updated this revision to Diff 210861. martong added a comment. - Further simplify by removing the last for loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44100/new/ https://reviews.llvm.org/D44100 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 210862. dgoldman added a comment. - Minor fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursive.cpp test/Sem

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgrang, mgorny. An index structure is created while reducing the infos. This is then pas

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane marked 4 inline comments as done. jpakkane added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/InitLocalVariablesCheck.cpp:21 + Finder->addMatcher( + varDecl(unless(hasInitializer(anything(.bind("vardecl"), this); +} alexfh wro

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 210868. jpakkane added a comment. Now properly deals with template instantiations and macros. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clan

  1   2   >