t.p.northover added inline comments.
================
Comment at: clang/test/Sema/aarch64-tme-errors.c:1
+// RUN: %clang_cc1 -triple aarch64-eabi -verify %s
+
----------------
I don't think the Sema checks need to be split over so many files. One for the
whole of transactional seems enough. Similarly for CodeGen really.
================
Comment at: llvm/test/CodeGen/AArch64/tme-tcancel.ll:6
+define void @test_tcancel() #0 {
+ tail call void @llvm.aarch64.tcancel(i64 0) #1
+ ret void
----------------
Testing more values than 0 would be a good idea.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64416/new/
https://reviews.llvm.org/D64416
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
