[PATCH] D63031: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization

dblaikie added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63031/new/ https://reviews.llvm.org/D63031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D64576: [Syntax] Do not add a node for 'eof' into the tree

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. While useful as a sentinel value when iterating over tokens, having 'eof' in the tree, seems to do more harm than good. Repository:

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

rjmccall added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = Anastasia wrote: > rjmccall wrote: > > Anastasia wrote: > > > rjmccall

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum marked 20 inline comments as done. quantum added a comment. I'll clean up the table gen stuff. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") +

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209271. quantum marked 6 inline comments as done. quantum added a comment. Update comments regarding multable globals. Use `CHECK-DAG`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.l

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman marked 3 inline comments as done. emmettneyman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequiresDesignator : InheritableAttr { + let Spellings = [Clang<"requires_designator">]; + let Subjects = SubjectList<[Record]>; --

[clang-tools-extra] r365804 - [clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test

Author: jkorous Date: Thu Jul 11 11:21:21 2019 New Revision: 365804 URL: http://llvm.org/viewvc/llvm-project?rev=365804&view=rev Log: [clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test ...to minimize the chance of stack overflow before reaching the limit. Modified:

[PATCH] D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

eugenis added inline comments. Comment at: clang/docs/UndefinedBehaviorSanitizer.rst:207 +equivalence by pointer, not also by name (even on platforms that would +otherwise fall back to checking equivalence by name). I don't think this is true. As far as I can s

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209274. quantum added a comment. Clean up table gen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clang/

[PATCH] D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC

echristo added a comment. Not a huge fan of boolean parameters like this, perhaps factor out the context as well into the caller and then we don't need it at all? Something else? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64540/new/ https://reviews.llvm.org/D64540 ___

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, I forgot we hadn't hooked this part up! Comment at: clang-tools-extra/clangd/XRefs.cpp:1222 + if (Direction == TypeHierarchyDirection::Parents || ResolveLevels

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Any static library with a PRIVATE dependency ends up with a $ generator expression in its INTERFACE_LINK_LIBRARIES, which won't be evaluate

[PATCH] D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros

tstellar created this revision. tstellar added reviewers: beanz, smeenai. Herald added subscribers: dexonsmith, steven_wu, mgorny, mehdi_amini. Herald added projects: clang, LLVM. This will simplify the macros by allowing us to remove the hard-coded list of libraries that should be installed when

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. @beanz, what do you think of this? I think it's kinda awful, but I can't think of a better alternative short of upgrading to CMake 3.12 (as detailed in my comment). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64579/new/

r365808 - [Driver] -noprofilelib flag

Author: phosek Date: Thu Jul 11 12:06:38 2019 New Revision: 365808 URL: http://llvm.org/viewvc/llvm-project?rev=365808&view=rev Log: [Driver] -noprofilelib flag This flag is analoguous to other flags like -nostdlib or -nolibc and could be used to disable linking of profile runtime library. This i

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun marked an inline comment as done. xazax.hun added a comment. Thanks for the review! I will update the patch soon. As there is a dependency that is not accepted yet Richard (who authored the code I extended) might have some chance to take a look at this patch. Commen

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. While upgrading to newer CMake would be nice, I think it's unlikely that we could move all the way to 3.12 since that version was only released a year ago and still isn't available in most dis

r365809 - [CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC

Author: vedantk Date: Thu Jul 11 12:11:46 2019 New Revision: 365809 URL: http://llvm.org/viewvc/llvm-project?rev=365809&view=rev Log: [CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC Replace a `llvm::Function *` parameter with a bool, which seems harder to set to the wrong value by acciden

[PATCH] D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL365809: [CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D63954: Add lifetime categories attributes

xazax.hun added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2770 +def Owner : InheritableAttr { + let Spellings = [CXX11<"gsl", "Owner">]; + let Subjects = SubjectList<[CXXRecord]>; aaron.ballman wrote: > xazax.hun wrote: > > aaron.ballman wr

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. In D64579#1581172 , @phosek wrote: > While upgrading to newer CMake would be nice, I think it's unlikely that we > could move all the way to 3.12 since that version was only released a year > ago and still isn't available in most

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. In D64579#1581194 , @smeenai wrote: > In D64579#1581172 , @phosek wrote: > > > While upgrading to newer CMake would be nice, I think it's unlikely that we > > could move all the way to 3.12

[PATCH] D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

tstellar created this revision. tstellar added reviewers: beanz, smeenai. Herald added a subscriber: mgorny. Herald added a project: clang. tstellar added a parent revision: D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros. If CLANG_LINK_CLANG_DYLIB is also enabled, then t

r365814 - Revert "[CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC"

Author: vedantk Date: Thu Jul 11 12:28:07 2019 New Revision: 365814 URL: http://llvm.org/viewvc/llvm-project?rev=365814&view=rev Log: Revert "[CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC" This reverts commit 1af41074445229fea66b99710a850e5f42ecfa95. Modified: cfe/trunk/lib/CodeGen

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer updated this revision to Diff 209299. SjoerdMeijer marked an inline comment as not done. SjoerdMeijer added a comment. thanks for taking a look and the suggestions! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 Files: lib/Parse/

[PATCH] D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC

vsk reopened this revision. vsk added a comment. This revision is now accepted and ready to land. Sorry about that, reopening per Eric's comment. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64540/new/ https://reviews.llvm.org/D64540 __

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer added a comment. oh no, the diff got messed up here. I.e. Phab shows 2 modified files, because the first patch set was created in a monorepo, and the 2nd patch set in a another and separate clang repo. Just for clarity, file `lib/Parse/ParsePragma.cpp` is the latest with the feedb

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 209302. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Move the generation of css stylesheet to a function inside the HTMLGenerator. A virtual function createResources was declared for Generator class. This is no-op

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum marked 5 inline comments as done. quantum added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") + quantum wrote: > aheejin wrote:

[PATCH] D62960: Add SVE opaque built-in types

rsandifo-arm added a comment. Ping, and thanks for the reviews so far. I think I've addressed all the comments to date and I've tried to make the patch ready to commit in its current state (rather than the RFC that it originally was). It would be really useful if we could apply the patch soon,

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209304. quantum added a comment. Treat global.get of an immutable global as a memory access for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/incl

[PATCH] D64062: Remove both -dumpversion and __VERSION__

rnk added a comment. I still have this open concern: In D64062#1574868 , @rnk wrote: > One concern that I have is that we don't have a replacement for > `-dumpversion`. I thought I saw someone propose adding such a flag, but I > can't find it. Basically

Re: r365724 - clang-cl: Remove -O0 option

This seems to have caused a libfuzzer test to fail here: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/48261 It's not easy to fix because -O0 is passed to clang-cl on Windows and clang elsewhere, so /Od won't do the trick without a substitution. This was kind of why I added -O0 in the

[PATCH] D64586: [WebAssembly] Make -pthread imply -bulk-memory

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100. Herald added a project: clang. This paves the way for using passive segments in pthread builds, which will make separate memory files unnecessary

[PATCH] D64585: [OpenMP] With nested parallelism, threadprivate variables become shared on outer parallel when appearing in inner parallel copyin clause

Prince781 created this revision. Prince781 added reviewers: ABataev, faisalv, malcolm.parsons, efriedma, eli.friedman, maskray0, MaskRay, tareqsiraj, rsmith. Prince781 added projects: clang, OpenMP. Herald added subscribers: jdoerfert, jfb, guansong. There is a bug since at least clang 8.0.0 wher

[PATCH] D64585: [OpenMP] With nested parallelism, threadprivate variables become shared on outer parallel when appearing in inner parallel copyin clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15329 +if (getLangOpts().OpenMP && getLangOpts().OpenMPUseTLS) { + // Avoid capturing TLS-backed threadprivate variables in outer scopes. this is not the right place to fix this bug

[PATCH] D64585: [OpenMP] With nested parallelism, threadprivate variables become shared on outer parallel when appearing in inner parallel copyin clause

Prince781 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15329 +if (getLangOpts().OpenMP && getLangOpts().OpenMPUseTLS) { + // Avoid capturing TLS-backed threadprivate variables in outer scopes. ABataev wrote: > this is not the right pl

r365821 - [OPENMP]Improve handling of analysis of unsupported VLAs in reductions.

Author: abataev Date: Thu Jul 11 13:35:31 2019 New Revision: 365821 URL: http://llvm.org/viewvc/llvm-project?rev=365821&view=rev Log: [OPENMP]Improve handling of analysis of unsupported VLAs in reductions. Fixed the processing of the unsupported VLAs in the reduction clauses. Used targetDiag if t

[PATCH] D64585: [OpenMP] With nested parallelism, threadprivate variables become shared on outer parallel when appearing in inner parallel copyin clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15329 +if (getLangOpts().OpenMP && getLangOpts().OpenMPUseTLS) { + // Avoid capturing TLS-backed threadprivate variables in outer scopes. Prince781 wrote: > ABataev wrote: > > this

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

gribozavr added inline comments. Comment at: clang/test/Sema/warn-lifetime-analysis-nocfg.cpp:25 + +struct [[gsl::Owner(int)]] OwnerWithConv { + OwnerWithConv(); xazax.hun wrote: > gribozavr wrote: > > Would be nice if the second pair of types had clearly relate

[PATCH] D62888: [NewPM] Port Sancov

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/ https://reviews.llvm.org/D62888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py:67 + with open(os.path.join(__location__, checker["FullPackageName"]+".rst"),"w") as f: +f.write(".. title:: clang-tidy - %s\n" % checker["FullPackageName"

[PATCH] D64592: [OpenMP] Fix unified memory implementation for multiple compilation units

gtbercea created this revision. gtbercea added reviewers: ABataev, jdoerfert, caomhin. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. This patch fixes the case where variables in different compilation units have the same name. Repository: rC Clang https://rev

[PATCH] D63954: Add lifetime categories attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2770 +def Owner : InheritableAttr { + let Spellings = [CXX11<"gsl", "Owner">]; + let Subjects = SubjectList<[CXXRecord]>; xazax.hun wrote: > aaron.ballman wrote: > > xazax.hun wr

r365822 - CodeGen, NFC: Test for auto-init for 32bit pointers

Author: vitalybuka Date: Thu Jul 11 13:51:59 2019 New Revision: 365822 URL: http://llvm.org/viewvc/llvm-project?rev=365822&view=rev Log: CodeGen, NFC: Test for auto-init for 32bit pointers Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init

[PATCH] D64592: [OpenMP] Fix unified memory implementation for multiple compilation units

lebedev.ri added a comment. Description lacking. Why is that bad? How does this play wrt reproducibility of the output? Normally value names in IR are completely discarded in Release build mode, why do they matter here? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D63967: Handle IntToPtr in isBytewiseValue

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63967/new/ https://reviews.llvm.org/D63967 _

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequiresDesignator : InheritableAttr { + let Spellings = [Clang<"requires_designator">]; + let Subjects = SubjectList<[Record]>; emmettneyman wrote: > compnerd wrote: >

[PATCH] D63967: Handle IntToPtr in isBytewiseValue

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: llvm/lib/Analysis/ValueTracking.cpp:3222 + if (auto *CE = dyn_cast(C)) { +if (CE->getOpcode() == Instruction::IntToPtr) { @pcc BTW, your original patch just gave up

[PATCH] D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64580/new/ https://reviews.llvm.org/D64580 ___

[PATCH] D64592: [OpenMP] Fix unified memory implementation for multiple compilation units

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2567 + std::hash HashFn; + size_t hash = 0; + if (!CGM.getCodeGenOpts().MainFileName.empty()) 1. Capitalize the first letter in tbe variable name. 2. Why do you need to use

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xAAAAAAAA

vitalybuka created this revision. vitalybuka added reviewers: pcc, eugenis, glider, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Patch extends effect of D63967 to 32bit platforms and improves pattern initialization there.

[PATCH] D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64582/new/ https://reviews.llvm.org/D64582 _

[PATCH] D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros

smeenai added a comment. Nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64580/new/ https://reviews.llvm.org/D64580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D64598: fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

yonghong-song created this revision. yonghong-song added reviewers: eli.friedman, jdoerfert, ast. Herald added subscribers: kristina, arphaman, aprantl. Herald added a project: clang. This is a followup patch for https://reviews.llvm.org/D61809. Handle unnamed bitfield properly and add more test c

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

beanz accepted this revision. beanz added a comment. Yea, this makes sense even if it is a bit sad. We do use the `--whole-archive` approach for `libLLVM`, and it works. I was hoping to avoid it here in part to free up the ability to link `libclang_shared` before or in parallel to archiving the

r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

Author: smeenai Date: Thu Jul 11 14:20:38 2019 New Revision: 365825 URL: http://llvm.org/viewvc/llvm-project?rev=365825&view=rev Log: [clang-shlib] Fix clang-shlib for PRIVATE dependencies Any static library with a PRIVATE dependency ends up with a $ generator expression in its INTERFACE_LINK_LIB

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rL365825: [clang-shlib] Fix clang-shlib for PRIVATE dependencies (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. In D64579#1581557 , @beanz wrote: > Yea, this makes sense even if it is a bit sad. We do use the > `--whole-archive` approach for `libLLVM`, and it works. I was hoping to avoid > it here in part to free up the ability to link `li

r365827 - [analyzer] exploded-graph-rewriter: Fix filenames in program point.

Author: dergachev Date: Thu Jul 11 14:27:42 2019 New Revision: 365827 URL: http://llvm.org/viewvc/llvm-project?rev=365827&view=rev Log: [analyzer] exploded-graph-rewriter: Fix filenames in program point. Fix a typo in JSON field name. Modified: cfe/trunk/test/Analysis/exploded-graph-rewriter

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xAAAAAAAA

pcc added a comment. The problem with `0x` on 32-bit is that it is likely to be a valid address. When I discussed this with JF I proposed a pointer initialization of `0x` which he agreed to. This value is very likely to trap when accessed (due to accesses likely wrapping to zer

[PATCH] D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

beanz accepted this revision. beanz added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64582/new/ https://reviews.llvm.org/D64582 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D64278: Rename libclang_shared to libclang-cpp

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This is fine with me. I have no real attachment to the name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278

[PATCH] D62888: [NewPM] Port Sancov

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, thanks so much for sticking through this, I know it was ... nontrivial! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/ htt

r365831 - Rename libclang_shared to libclang-cpp

Author: sylvestre Date: Thu Jul 11 14:42:55 2019 New Revision: 365831 URL: http://llvm.org/viewvc/llvm-project?rev=365831&view=rev Log: Rename libclang_shared to libclang-cpp Summary: Fix bug 42475 Reviewers: beanz, tstellar Reviewed By: beanz Subscribers: kimgr, mgorny, cfe-commits Tags: #cl

[PATCH] D64278: Rename libclang_shared to libclang-cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL365831: Rename libclang_shared to libclang-cpp (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xAAAAAAAA

jfb added a comment. In D64597#1581605 , @pcc wrote: > The problem with `0x` on 32-bit is that it is likely to be a valid > address. > > When I discussed this with JF I proposed a pointer initialization of > `0x` which he agreed to. This

r365832 - Fix a Python3 compatibility error

Author: azhar Date: Thu Jul 11 14:45:48 2019 New Revision: 365832 URL: http://llvm.org/viewvc/llvm-project?rev=365832&view=rev Log: Fix a Python3 compatibility error File "clang/test/lit.cfg.py", line 186, in config.available_features.add('macos-sdk-' + macOSSDKVersion) TypeError: must be

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6587 +return; + } + rjmccall wrote: > Comment indentation. > > Should we do this when starting to parse a function prototype instead

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. In D64062#1581290 , @rnk wrote: > Perhaps we should just remove `__VERSION__` and keep `-dumpversion`. As you wish. clang --version seems an alternative and dumpversion never //worked// for clang. so, I don't expect soft

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante updated this revision to Diff 209348. Mordante added a comment. tab -> space adds an extra unit test for lambdas fixes an off by one error found while testing the lambdas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 Files: clang/in

r365835 - CodeGen: Suppress c++ warnings in test

Author: vitalybuka Date: Thu Jul 11 14:59:09 2019 New Revision: 365835 URL: http://llvm.org/viewvc/llvm-project?rev=365835&view=rev Log: CodeGen: Suppress c++ warnings in test Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp URL: ht

[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman, steven_wu. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. This attribute can be applied to typedefs of BOOL in Objective-C. It causes loads, stores, and casts to BOOL to

[PATCH] D64146: [ConstExprPreter][WIP] Initial patch for the constexpr interpreter

jfb added inline comments. Comment at: clang/lib/AST/ExprVM/Compiler.cpp:85 +/* isArray */ false, +/* isGlobal */ false); + ParamDescriptors.insert({ParamOffset, std::move(Desc)})

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

mgehre marked 5 inline comments as done. mgehre added a comment. In D64448#159 , @gribozavr wrote: > For example, libc++ wraps everything in std in an inline namespace. I believed that I had written a test for inline namespaces, but seems that I sho

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") + quantum wrote: > quantum wrote: > > aheejin wrote: > > > Why is it `c`(co

[PATCH] D64458: add -fthinlto-index= option to clang-cl

tejohnson added a comment. LGTM, but please wait for @pcc to make sure he is satisfied. I think it would be good to port the file type deduction to clang (possibly as a follow on), to make these consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

r365838 - [NewPM] Port Sancov

Author: leonardchan Date: Thu Jul 11 15:35:40 2019 New Revision: 365838 URL: http://llvm.org/viewvc/llvm-project?rev=365838&view=rev Log: [NewPM] Port Sancov This patch contains a port of SanitizerCoverage to the new pass manager. This one's a bit hefty. Changes: - Split SanitizerCoverageModul

[PATCH] D62888: [NewPM] Port Sancov

This revision was automatically updated to reflect the committed changes. Closed by commit rL365838: [NewPM] Port Sancov (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D62888?vs=207698&id=209358#toc Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

gribozavr added a comment. In D64448#1581719 , @mgehre wrote: > In D64448#159 , @gribozavr wrote: > > > I don't know how various versions of libstdc++ differ. > > > The current implementation passed the (partial

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

gribozavr added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:486 +TYPE_TRAIT_1(__is_gsl_owner, IsGslOwner, KEYCXX) +TYPE_TRAIT_1(__is_gsl_pointer, IsGslPointer, KEYCXX) KEYWORD(__underlying_type , KEYCXX) mgehre wrote: > griboz

[PATCH] D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static

mgehre updated this revision to Diff 209360. mgehre added a comment. Implement comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt cla

[PATCH] D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static

mgehre added a comment. This should address all remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 209362. emmettneyman marked 2 inline comments as done. emmettneyman added a comment. Added documentation about using the attributes with unions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ htt

[PATCH] D64603: [Target] Use IEEE quad format for long double on Fuchsia x86_64

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. This change unifies the long double format between x86_64 and aarch64 targets making it easier to write code that's indepe

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah updated this revision to Diff 209363. SureYeaah marked 12 inline comments as done. SureYeaah added a comment. Added comments and minor changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64562/new/ https://reviews.llvm.org/D64562 Files

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:410 +// Test for functions toHalfOpenFileRange and getHalfOpenFileRange +// FIXME: Need better testing support to be able to check more than just Decls. +TEST(SourceCodeTests, Half

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

tlively updated this revision to Diff 209367. tlively added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driv

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

tlively updated this revision to Diff 209365. tlively added a comment. - Add mutable-globals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

mgehre updated this revision to Diff 209370. mgehre marked 9 inline comments as done. mgehre added a comment. - Implement comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64448/new/ https://reviews.llvm.org/D64448 Files: clang/include/clan

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

tlively updated this revision to Diff 209369. tlively added a comment. - and other comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/D

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

mgehre added a comment. In D64448#1581771 , @gribozavr wrote: > In D64448#1581719 , @mgehre wrote: > > > In D64448#159 , @gribozavr > > wrote: > > > > > I don't know how

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1448 +def RequireDesignatedInitDocs : Documentation { + let Category = DocCatType; aaron.ballman wrote: > The behavior should be documented as to what happens when you apply

[PATCH] D64062: Remove both -dumpversion and __VERSION__

rnk added a comment. In D64062#1581662 , @sylvestre.ledru wrote: > In D64062#1581290 , @rnk wrote: > > > Perhaps we should just remove `__VERSION__` and keep `-dumpversion`. > > > As you wish. clang --version seems

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with suggestion Comment at: lib/Driver/ToolChains/Clang.cpp:4009 TC.getArch() == llvm::Triple::ppc || TC.getTriple().isPPC64()) { - CmdArgs.push_back("-mlong-dou

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. We want to preserve debug info in our runtimes to aid symbolization and debugging; for shared libraries this will be stripped away during install-

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. Lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64605/new/ https://reviews.llvm.org/D64605 ___ cfe-commit

[clang-tools-extra] r365844 - [clangd] Fix MSVC build failure.

Author: probinson Date: Thu Jul 11 16:48:06 2019 New Revision: 365844 URL: http://llvm.org/viewvc/llvm-project?rev=365844&view=rev Log: [clangd] Fix MSVC build failure. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26898 Modified: clang-tools-extra

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL365845: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

r365845 - [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

Author: phosek Date: Thu Jul 11 16:49:39 2019 New Revision: 365845 URL: http://llvm.org/viewvc/llvm-project?rev=365845&view=rev Log: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes We want to preserve debug info in our runtimes to aid symbolization and debugging; for shared libraries this w

  1   2   3   >