[PATCH] D64310: [clangd] Added semantic highlighting for constructors and destructors.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Add semantic highlighting to constructor and destructor declarations. Repository: rG LLVM Github Monore

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:68 + +TagDecl *D = TL.getTypePtr()->getAsTagDecl(); +if (!D) We are only interested in `TagDecl`, maybe use the `VisitTagLoc` callback, so that you can get rid of

r365298 - [AArch64] Fix vsqadd scalar intrinsics operands

Author: dnsampaio Date: Mon Jul 8 01:35:05 2019 New Revision: 365298 URL: http://llvm.org/viewvc/llvm-project?rev=365298&view=rev Log: [AArch64] Fix vsqadd scalar intrinsics operands Summary: Change the vsqadd scalar instrinsics to have the second argument as signed values, not unsigned, accord

[PATCH] D64239: [AArch64] Fix vsqadd scalar intrinsics operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL365298: [AArch64] Fix vsqadd scalar intrinsics operands (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

r365300 - [AArch64] Fix scalar vuqadd intrinsics operands

Author: dnsampaio Date: Mon Jul 8 01:47:47 2019 New Revision: 365300 URL: http://llvm.org/viewvc/llvm-project?rev=365300&view=rev Log: [AArch64] Fix scalar vuqadd intrinsics operands Summary: Change the vuqadd scalar instrinsics to have the second argument as unsigned values, not signed, accord

[PATCH] D64242: [AArch64] Fix scalar vuqadd intrinsics operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL365300: [AArch64] Fix scalar vuqadd intrinsics operands (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D63793: Treat the range of representable values of floating-point types as [-inf, +inf] not as [-max, +max].

ostannard added a comment. There are a number of buildbot failures which look related to this, e.g. - http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/6730/steps/ninja%20check%201/logs/FAIL%3A%20UBSan-AddressSanitizer-armhf%3A%3Adiv-zero.cpp - http://lab.llvm.org:8011/builders/cl

r365305 - [RISCV] Specify registers used for exception handling

Author: asb Date: Mon Jul 8 02:38:06 2019 New Revision: 365305 URL: http://llvm.org/viewvc/llvm-project?rev=365305&view=rev Log: [RISCV] Specify registers used for exception handling Implements the handling of __builtin_eh_return_regno(). Differential Revision: https://reviews.llvm.org/D63417 P

[PATCH] D63793: Treat the range of representable values of floating-point types as [-inf, +inf] not as [-max, +max].

MaskRay added a comment. In D63793#1572977 , @ostannard wrote: > There are a number of buildbot failures which look related to this, e.g. > > - > http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/6730/steps/ninja%20check%201/logs/FAIL%3A%20U

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

jvikstrom updated this revision to Diff 208354. jvikstrom marked an inline comment as done. jvikstrom added a comment. Type -> Class Also added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/ https://reviews.llvm.org/D64257 Fi

[PATCH] D64319: [OpenCL] Add function attributes handling for builtin functions

Pierre created this revision. Pierre added reviewers: Anastasia, svenvh. Pierre added projects: clang, LLVM. Herald added subscribers: cfe-commits, kristina. Add handling to for the "overload, "pure", "constant" and "convergent" function attributes for OpenCL builtin functions. Repository: rC

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

jvikstrom marked 4 inline comments as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:68 + +TagDecl *D = TL.getTypePtr()->getAsTagDecl(); +if (!D) hokein wrote: > We are only interested in `TagDecl`, ma

[PATCH] D64320: [OpenCL] Print builtin function prototypes if ambiguous

Pierre created this revision. Pierre added reviewers: Anastasia, svenvh. Pierre added projects: clang, LLVM. Herald added subscribers: cfe-commits, kristina. When hitting an ambigous call to a builtin function with the -fdeclare-opencl-builtins option, diagnostics don't print the prototypes that c

[PATCH] D64321: [OpenCL] Change diagnostic for function declaration

Pierre created this revision. Pierre added reviewers: Anastasia, svenvh. Pierre added projects: clang, LLVM. Herald added a subscriber: cfe-commits. When declaring functions only differing by their return type, diagnostic was indicating "conflicting types for" the function. Similarly to c++, it is

[PATCH] D60456: [RISCV] Hard float ABI support

asb added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9232 +if (IsFloat && Size > FLen) + return false; +// Can't be eligible if an integer type was already found (only fp+int or rjmccall wrote: > Is this the only consideration for

[PATCH] D63417: [RISCV] Specify registers used for exception handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL365305: [RISCV] Specify registers used for exception handling (authored by asb, committed by ). Herald added subscribers: llvm-commits, lenary, MaskRay. Herald added a project: LLVM. Changed prior to comm

[PATCH] D60456: [RISCV] Hard float ABI support

rogfer01 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9352 +return false; + // As a quirk of the ABI, zero-width bitfields aren't ignored for fp+fp + // or int+fp structs, but are ignored for a struct with an fp field and

[PATCH] D60456: [RISCV] Hard float ABI support

asb updated this revision to Diff 208308. asb marked 7 inline comments as done. asb retitled this revision from "[RISCV][WIP/RFC] Hard float ABI support" to "[RISCV] Hard float ABI support". asb edited the summary of this revision. asb added a comment. Herald added subscribers: lenary, Jim, MaskRa

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6510 LifetimeBoundCall, +LifetimePointerInit, +LifetimeTempOwner What is this name supposed to mean? Initialization of a "lifetime pointer"? What's a "lifetime pointer"? If yo

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:68 + +TagDecl *D = TL.getTypePtr()->getAsTagDecl(); +if (!D) jvikstrom wrote: > hokein wrote: > > We are only interested in `TagDecl`, maybe use the `VisitTagLo

[clang-tools-extra] r365311 - [clangd] Use xxhash instead of SHA1 for background index file digests.

Author: sammccall Date: Mon Jul 8 04:33:17 2019 New Revision: 365311 URL: http://llvm.org/viewvc/llvm-project?rev=365311&view=rev Log: [clangd] Use xxhash instead of SHA1 for background index file digests. Summary: Currently SHA1 is about 10% of our CPU, this patch reduces it to ~1%. xxhash is

r365314 - [analyzer] Add analyzer option to limit the number of imported TUs

Author: gamesh411 Date: Mon Jul 8 05:37:10 2019 New Revision: 365314 URL: http://llvm.org/viewvc/llvm-project?rev=365314&view=rev Log: [analyzer] Add analyzer option to limit the number of imported TUs Summary: During CTU analysis of complex projects, the loaded AST-contents of imported TUs can

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

This revision was automatically updated to reflect the committed changes. Closed by commit rL365314: [analyzer] Add analyzer option to limit the number of imported TUs (authored by gamesh411, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r365315 - [ASTImporter] Fix import of lambda in function param

Author: martong Date: Mon Jul 8 05:49:13 2019 New Revision: 365315 URL: http://llvm.org/viewvc/llvm-project?rev=365315&view=rev Log: [ASTImporter] Fix import of lambda in function param Summary: The current import implementation fails to import the definition of a lambda class if the lambda clas

[PATCH] D64073: [ASTImporter] Fix import of lambda in function param

This revision was automatically updated to reflect the committed changes. Closed by commit rL365315: [ASTImporter] Fix import of lambda in function param (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208378. MaskRay retitled this revision from "[ubsan] Delete the FloatDivideByZero ErrorType" to "[Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272". MaskRay edited the summary of this revision. MaskRay added a comment. Heral

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208382. MaskRay added a comment. Remove a stray : Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 Files: lib/Driver/ToolChain.cpp test/Driver/fsanitize.c Index: test/Driver/fsan

[PATCH] D64310: [clangd] Added semantic highlighting for constructors and destructors.

jvikstrom abandoned this revision. jvikstrom added a comment. Abandoning after discussion with sammccall and hokein. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64310/new/ https://reviews.llvm.org/D64310 ___

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixed SelectionTree bug for macros - Fixed SelectionTree claimRange for macros and template instantiat

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 208387. SureYeaah added a comment. Removed debugging code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-extra/clangd/Selection.cpp clang-tool

[PATCH] D64276: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think the function names are awkward, but otherwise I think this should be acceptable. I'll accept, but give 24 hrs for the other reviewers to get through their mondays.

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 208389. SureYeaah added a comment. Removed extra includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-extra/clangd/Selection.cpp clang-tool

[PATCH] D60456: [RISCV] Hard float ABI support

asb marked an inline comment as done. asb added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9352 +return false; + // As a quirk of the ABI, zero-width bitfields aren't ignored for fp+fp + // or int+fp structs, but are ignored for a struct with

[PATCH] D60456: [RISCV] Hard float ABI support

asb updated this revision to Diff 208392. asb marked an inline comment as done. asb added a comment. Updated to address comment typo picked up by @rogfer01 (thanks!). As noted in another comment, it's not entirely clear what zero-width bitfield behaviour to match (see here

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208395. MaskRay edited the summary of this revision. MaskRay added a comment. make various sanitizer features work Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 Files: lib/Driver/

[PATCH] D64276: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code

MaskRay updated this revision to Diff 208399. MaskRay edited the summary of this revision. MaskRay added a comment. getMangledTypeOfLongDouble -> getLongDoubleMangling as erichkeane suggested. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64276/new/ https://revie

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

MaskRay updated this revision to Diff 208402. MaskRay added a comment. Rebase after getMangledCodeOfLongDouble -> getLongDoubleMangling rename Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64277/new/ https://reviews.llvm.org/D64277 Files: include/clang/Driver/

[PATCH] D64169: ARM MTE stack sanitizer.

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM with one minor nit. Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:632 ATTR_KIND_WILLRETURN = 61, + ATTR_KIND_SANITIZE_MEMTAG = 62 }; P

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208410. MaskRay added a comment. Fix sanitizer-ld.c test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 Files: lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChain.cpp test/Driver

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

jvikstrom updated this revision to Diff 208412. jvikstrom marked 5 inline comments as done. jvikstrom added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/ https://reviews.llvm.org/D64257 Files: clang-tool

[PATCH] D60456: [RISCV] Hard float ABI support

rogfer01 added a comment. > As noted in another comment, it's not entirely clear what zero-width bitfield > behaviour to match (see here > ) > as GCC seems buggy and the ABI is under-specified. Ideally I'd like to la

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:94 + + // It doesn't make sense to perform a traversal if user said their compilation + // database is in a different place. Return that directory for all files. ---

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:73 +if (auto RD = dyn_cast(D)) { + if (auto DC = RD->getDestructor()) { +auto Range = DC->getSourceRange(); hokein wrote: > Here is the case: > > ```

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

jvikstrom updated this revision to Diff 208416. jvikstrom added a comment. Clang formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/ https://reviews.llvm.org/D64257 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang

r365329 - [RISCV][NFC] Make use of Triple::isRISCV

Author: asb Date: Mon Jul 8 08:07:12 2019 New Revision: 365329 URL: http://llvm.org/viewvc/llvm-project?rev=365329&view=rev Log: [RISCV][NFC] Make use of Triple::isRISCV Use new helper introduced in rL365327. Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp cfe/trunk/lib/Driver/ToolCha

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:73 +if (auto RD = dyn_cast(D)) { + if (auto DC = RD->getDestructor()) { +auto Range = DC->getSourceRange(); jvikstrom wrote: > hokein wrote: > > Here is t

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun marked 5 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6510 LifetimeBoundCall, +LifetimePointerInit, +LifetimeTempOwner gribozavr wrote: > What is this name supposed to mean? Initializatio

[PATCH] D61681: [clangd] A code tweak to expand a macro

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExpandMacro.cpp:57 + if (It == Spelled.begin()) +return Spelled.end(); + // Check the token we found actually touches the cursor position. sammccall wrote: > it's pret

[PATCH] D61681: [clangd] A code tweak to expand a macro

ilya-biryukov updated this revision to Diff 208425. ilya-biryukov marked 5 inline comments as done. ilya-biryukov added a comment. - Replace bsearch with partition_point. - Include macro name in the title. - Added a FIXME for empty selection case. - Return null when no token is found. Repository

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63756/new/ https://reviews.llvm.org/D63756 ___ cfe-c

[clang-tools-extra] r365331 - [clangd] A code tweak to expand a macro

Author: ibiryukov Date: Mon Jul 8 08:25:16 2019 New Revision: 365331 URL: http://llvm.org/viewvc/llvm-project?rev=365331&view=rev Log: [clangd] A code tweak to expand a macro Reviewers: sammccall Reviewed By: sammccall Subscribers: mgorny, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tag

r365331 - [clangd] A code tweak to expand a macro

Author: ibiryukov Date: Mon Jul 8 08:25:16 2019 New Revision: 365331 URL: http://llvm.org/viewvc/llvm-project?rev=365331&view=rev Log: [clangd] A code tweak to expand a macro Reviewers: sammccall Reviewed By: sammccall Subscribers: mgorny, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tag

[PATCH] D61681: [clangd] A code tweak to expand a macro

This revision was automatically updated to reflect the committed changes. Closed by commit rL365331: [clangd] A code tweak to expand a macro (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis created this revision. thakis added a reviewer: rnk. https://reviews.llvm.org/D64349 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaAttr.cpp clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

hfinkel added a comment. In D64128#1572504 , @rjmccall wrote: > I would be opposed to any addition of a `-f` flag for this absent any > evidence that it's valuable for some actual C code; this patch appears to be > purely speculative. I certainly don't

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun added inline comments. Comment at: clang/test/Sema/warn-lifetime-analysis-nocfg.cpp:22 + int *release2(); + int *c_str() const; +}; gribozavr wrote: > This method is confusing -- is it a name that the warning is supposed to know > about? Not yet, see

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 208439. xazax.hun marked 12 inline comments as done. xazax.hun added a comment. - Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL365339: Teach the IRBuilder about fadd and friends. (authored by kpn, committed by ). Herald added a project: LLVM. Chang

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 208441. xazax.hun added a comment. - Fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaInit.cpp clang/test/Sema/wa

r365341 - Add nofree attribute to CodeGenOpenCL/convergent.cl test

Author: homerdin Date: Mon Jul 8 09:24:10 2019 New Revision: 365341 URL: http://llvm.org/viewvc/llvm-project?rev=365341&view=rev Log: Add nofree attribute to CodeGenOpenCL/convergent.cl test The revision at https://reviews.llvm.org/rL365336 added inference of the nofree attribute. This revision

[PATCH] D63161: Devirtualize destructor of final class.

yamauchi added a comment. This was reverted due to some internal test failure. But it turned out a false alarm. I'll work on recommitting it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63161/new/ https://reviews.llvm.org/D63161 _

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

ychen added a comment. In D56353 , I remember @chandlerc thought `-f(no-)omit-frame-pointer` should win over `-m(no-)omit-leaf-frame-pointer`. I'm not sure what his thoughts on this now. @chandlerc ? Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome! Do you have commit access? Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:90 +bool isAFunctionRef(const clang::Expr *Expr) { + const

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:247 return SelectionTree::Unselected; -// getTopMacroCallerLoc() allows selection of constructs in macro args. e.g: +// getFileRange() allows selecting macro arg expansions //

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 208454. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - s/TranslationUnitDeclaration/TranslationUnit - Remove accessor from 'eof', add a FIXME to remove it from the tree altogether Repository: rG LLVM Github Monorepo

r365355 - [Syntax] Introduce syntax trees

Author: ibiryukov Date: Mon Jul 8 10:25:02 2019 New Revision: 365355 URL: http://llvm.org/viewvc/llvm-project?rev=365355&view=rev Log: [Syntax] Introduce syntax trees Summary: A tooling-focused alternative to the AST. This commit focuses on the memory-management strategy and the structure of the

[clang-tools-extra] r365356 - [clangd] Use -completion-style=bundled by default if signature help is available

Author: sammccall Date: Mon Jul 8 10:27:15 2019 New Revision: 365356 URL: http://llvm.org/viewvc/llvm-project?rev=365356&view=rev Log: [clangd] Use -completion-style=bundled by default if signature help is available Summary: I didn't manage to find something nicer than optional, but at least I f

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:35 +/// A root node for a translation unit. Parent is always null. +class TranslationUnitDeclaration final : public Tree { +public: sammccall wrote: > I don't think TU is

[PATCH] D61637: [Syntax] Introduce syntax trees

This revision was automatically updated to reflect the committed changes. Closed by commit rGb736969eddce: [Syntax] Introduce syntax trees (authored by ilya-biryukov). Changed prior to commit: https://reviews.llvm.org/D61637?vs=208454&id=208455#toc Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D64058: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

logan-5 added a comment. *ping* Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64058/new/ https://reviews.llvm.org/D64058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

r365357 - Replace temporary variable matches in test since r363952 causes an

Author: akhuang Date: Mon Jul 8 10:35:28 2019 New Revision: 365357 URL: http://llvm.org/viewvc/llvm-project?rev=365357&view=rev Log: Replace temporary variable matches in test since r363952 causes an extra temporary variable to be created. Modified: cfe/trunk/test/CodeGenCXX/cxx2a-compare.cp

[PATCH] D64169: ARM MTE stack sanitizer.

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:28 + if (!CGM.getLangOpts().Sanitize.hasOneOf( + SanitizerKind::Address | SanitizerKind::KernelAddress | + SanitizerKind::HWAddress | Saniti

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang marked an inline comment as done. czhang added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:39 +return; + Finder->addMatcher(varDecl(hasGlobalStorage()).bind("var"), this); +} aaron.ballman wro

[PATCH] D63835: [Syntax] Add nodes for most common statements

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:25 /// A kind of a syntax node, used for implementing casts. enum class NodeKind : uint16_t { Leaf, there are going to be many of these. I'd suggest either sorting them a

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

erichkeane added a comment. The change itself doesn't really bother me at all, however the test will fail if we build without preserving names. In order to validate this you'll have to do fno-discard-value-names on a test. Comment at: clang/test/CodeGenOpenCL/address-spaces-

[clang-tools-extra] r365364 - [clangd] Don't insert absolute paths, give up instead.

Author: sammccall Date: Mon Jul 8 11:07:46 2019 New Revision: 365364 URL: http://llvm.org/viewvc/llvm-project?rev=365364&view=rev Log: [clangd] Don't insert absolute paths, give up instead. Summary: Also implement resolution of paths relative to mainfile without HeaderSearchInfo. Reviewers: ka

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

vitalybuka added a comment. is the patch description still correct? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 208463. DiegoAstiazaran added a comment. Rebase after D52847 was pushed. Path added to parent Info in serialization, this is required after D63911 was pushed. CHANGES SINCE LAST ACT

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev created this revision. ABataev added reviewers: NoQ, Szelethus, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: jdoerfert, jfb, guansong, rnkovacs. Herald added a project: clang. Some OpenMP clauses rely on the values of the variables. If the variable

Re: [libunwind] r364217 - Merging r360861:

On 24 Jun 2019, at 20:40, Tom Stellard via cfe-commits wrote: > > Author: tstellar > Date: Mon Jun 24 11:40:58 2019 > New Revision: 364217 > > URL: http://llvm.org/viewvc/llvm-project?rev=364217&view=rev > Log: > Merging r360861: > >

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ added a comment. Hmm, wait, i don't really break backwards compatibility. Fridays... Previously we have impure-checking when we enable the optin checker and pureonly-checking when we disable the option. I can easily bring back the option, only for the purposes of backwards compatibility, s

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

rjmccall added a comment. Please don't check IR names in test output. That actually includes anonymous names like `%2`; these should always be tested with FileCheck variables. I suggest using `%.*` as the pattern; if you're matching the LHS of an LLVM assignment, that shouldn't have problems

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

asbirlea added inline comments. Comment at: llvm/include/llvm/Analysis/MemorySSA.h:1109 // else. -if (MemoryPhi *MP = dyn_cast(Access)) +if (const MemoryPhi *MP = dyn_cast(Access)) return MP->getIncomingValue(ArgNo); Could changes in this file

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay added a comment. In D64317#1574007 , @vitalybuka wrote: > is the patch description still correct? Yes. > Also, add SanitizerMask::FloatDivideByZero to a few other masks to make > -fsanitize-trap, -fsanitize-recover, -fsanitize-minimal-runtime a

Re: r281071 - Myriad: nominally "support" ASAN.

On Fri, 9 Sep 2016 at 11:29, Douglas Katzman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dougk > Date: Fri Sep 9 13:20:49 2016 > New Revision: 281071 > > URL: http://llvm.org/viewvc/llvm-project?rev=281071&view=rev > Log: > Myriad: nominally "support" ASAN. > > Doesn't work, bu

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ added a comment. Mmm, no, not really; it seems that if i introduce a checker dependency, i also have to put the option onto the base checker, otherwise the checker name wouldn't match when i do `getCheckerBooleanOption(getChecker(), "PureOnly")`. Which means that the option name will inevi

r365374 - [OPENMP]Improve error message for device unsupported types.

Author: abataev Date: Mon Jul 8 12:21:54 2019 New Revision: 365374 URL: http://llvm.org/viewvc/llvm-project?rev=365374&view=rev Log: [OPENMP]Improve error message for device unsupported types. Provide more data to the user in the error message about unsupported type for device compilation. Modi

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ updated this revision to Diff 208473. NoQ added a comment. Fix the crash on enabling both checkers, add a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64274/new/ https://reviews.llvm.org/D64274 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/Stat

Re: r365030 - Make a buildbot using a buggy gcc happy

Kristof, It looks like your fix didn’t address all the bots: /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/tools/clang/lib/Analysis/Dominators.cpp:14:48: error: explicit specialization of 'anchor' after instantiation void CFGDominatorTreeImpl::anchor() {}

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

rsmith added inline comments. Comment at: lib/Driver/SanitizerArgs.cpp:27-30 static const SanitizerMask NeedsUbsanRt = SanitizerKind::Undefined | SanitizerKind::Integer | SanitizerKind::ImplicitConversion | SanitizerKind::Nullability | +SanitizerKind::CFI | Sanitiz

[PATCH] D60456: [RISCV] Hard float ABI support

rjmccall added a comment. I'm fine with proceeding with your best guess about what the ABI should be. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9232 +if (IsFloat && Size > FLen) + return false; +// Can't be eligible if an integer type was already found (only fp+

[PATCH] D60456: [RISCV] Hard float ABI support

asb added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9236 +if (IsInt && Field1Ty && Field1Ty->isIntegerTy()) + return false; +if (!Field1Ty) { rjmccall wrote: > asb wrote: > > rjmccall wrote: > > > The comment here is wrong because

[PATCH] D60456: [RISCV] Hard float ABI support

asb updated this revision to Diff 208477. asb marked 4 inline comments as done. asb added a comment. Tweaked a code comment. Just to confirm, @rjmccall are you happy for me to commit this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60456/new/ https://reviews.llvm.org/D60456 Files:

Re: r365030 - Make a buildbot using a buggy gcc happy

Hi! Unfortunately, I'm out of town for the week -- I'll see whether I can ask someone in the office to help out with this. On Mon, 8 Jul 2019, 21:29 JF Bastien, wrote: > Kristof, > > It looks like your fix didn’t address all the bots: > > /Users/buildslave/jenkins/workspace/clang-stage2-coverag

Re: r365030 - Make a buildbot using a buggy gcc happy

This is in any case the wrong fix. The code *is* wrong, for the reason this compiler is reporting. The correct fix is to declare the explicit specializations in the header file: template <> void CFGDominatorTreeImpl::anchor(); template <> void CFGDominatorTreeImpl::anchor(); Clang will tell you

[PATCH] D64058: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me. (possible the check (for no default capture and no captures) could be unified with the same check/language used for the implicit function pointer conversion operator ("if

Re: r365030 - Make a buildbot using a buggy gcc happy

Noted, thanks! Gabor, could you please fix this? On Mon, 8 Jul 2019, 21:37 Richard Smith, wrote: > This is in any case the wrong fix. The code *is* wrong, for the reason > this compiler is reporting. > > The correct fix is to declare the explicit specializations in the header > file: > > templat

Re: r365030 - Make a buildbot using a buggy gcc happy

I'll commit the change below once my testing finishes :) On Mon, 8 Jul 2019 at 12:40, Kristóf Umann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Noted, thanks! Gabor, could you please fix this? > > On Mon, 8 Jul 2019, 21:37 Richard Smith, wrote: > >> This is in any case the wrong fix.

  1   2   3   >