[PATCH] D62619: [analyzer][IDF] Add a control dependency calculator + a new debug checker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Sure! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62619/new/ https://reviews.llvm.org/D62619 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

rnk added a comment. Sounds good to me. I had a minor suggestion, though. Comment at: lib/Basic/Targets/PPC.cpp:468 Opts.AltiVec = 1; - TargetInfo::adjust(Opts); + if (Opts.LongDoubleSize == 64) { +LongDoubleWidth = LongDoubleAlign = 64; I think it w

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

rjmccall added inline comments. Comment at: include/clang/AST/Type.h:1133 + /// Check if this is or contains a non-trivial C struct/union type. + bool hasNonTrivialPrimitiveCStruct() const; You only want these checks to trigger on unions with non-trivial memb

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. In D64089#1567028 , @danalbert wrote: > > For example, when we're building against the Android NDK, we might want to > > use the NDK's C++ headers (which have a custom inline namespace) even if we > > have C++ headers installed n

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

jcai19 added a comment. In D63623#1565377 , @gribozavr wrote: > Thanks! Do you have commit access? Do you want me to commit this patch for > you? Totally missed your message yesterday. Sorry about that. I do not have the access so it will be great if y

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. plotfi added a reviewer: compnerd. Simplifying the phases generation process, first by copying the phases info into the Table. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64

[PATCH] D64062: Remove both -dumpversion and __VERSION__

rnk added a comment. But, based on the github search, I don't think we could reasonably change dumpversion to print 8.0.0, so I'm not sure it really matters. Firefox builds with clang these days, so I'm not sure what they could possibly be using -dumpversion for that would matter. Repository:

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. This isn't firefox per say but thirdparty apps. If you feel confident, sure, we can land that and see what happens :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 updated this revision to Diff 207623. xbolva00 added a comment. Implemented suggested "mul in bool context" diagnostic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Bas

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. In D63082#1564114 , @aaron.ballman wrote: > In D63082#1560667 , @xbolva00 wrote: > > > I wanted to follow GCC’s behaviour -Wall but then dicussion moved to > > “tautological compare group

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

compnerd added a comment. The explicit list I think is way better for readability, this is a nice starting point for cleaning this up. Comment at: clang/include/clang/Driver/Types.def:18 // TYPE(NAME, ID, PP_TYPE, TEMP_SUFFIX, FLAGS) Please update the com

[PATCH] D64100: [analyzer] exploded-graph-rewriter: Implement checker messages.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. They are displayed as raw lines and diffed via difflib on a per-checke

[PATCH] D64100: [analyzer] exploded-graph-rewriter: Implement checker messages.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Nice! Could you add some `#===---===#` separators, please? As it is in the finishing state, I think now it is appropriate. Repository: rC Clang CHANGES SINCE LAST ACTION https://revi

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

compnerd added inline comments. Comment at: clang/lib/Driver/Types.cpp:29 + { NAME, FLAGS, TEMP_SUFFIX, TY_##PP_TYPE, PHASES, }, +#define PHASES llvm::SmallVector #include "clang/Driver/Types.def" I think that we can abuse the preprocessor a bit and get somethi

[PATCH] D64104: [analyzer] exploded-graph-rewriter: Collapse large statement pretty-prints.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. When printing various statements that include braces (compound stateme

[PATCH] D64104: [analyzer] exploded-graph-rewriter: Collapse large statement pretty-prints.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I like it! What about `BlockEdge` with the long terminators? (c.f. `Edge.getSrc()->printTerminatorJson()`) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64

[PATCH] D64104: [analyzer] exploded-graph-rewriter: Collapse large statement pretty-prints.

NoQ added a comment. In D64104#1567317 , @Charusso wrote: > I like it! What about `BlockEdge` with the long terminators? (c.f. > `Edge.getSrc()->printTerminatorJson()`) We don't process these yet >.< But it should be trivial to cover them in a similar

[PATCH] D64104: [analyzer] exploded-graph-rewriter: Collapse large statement pretty-prints.

Charusso added a comment. In D64104#1567326 , @NoQ wrote: > In D64104#1567317 , @Charusso wrote: > > > I like it! What about `BlockEdge` with the long terminators? (c.f. > > `Edge.getSrc()->printTerminatorJson()`)

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

a_sidorin added inline comments. Comment at: cfe/trunk/lib/AST/ASTStructuralEquivalence.cpp:173 +DE2->getQualifier()); + } else if (auto CastE1 = dyn_cast(E1)) { +auto *CastE2 = dyn_cast(E2); Hi Gabor, Is there any test fo

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song updated this revision to Diff 207644. yonghong-song edited the summary of this revision. yonghong-song added a comment. change `void *__builtin_preserve_access_index(void *)` to `const void * _builtin_preserve_access_index(const void *)`. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

a_sidorin added a comment. Hello Gabor, This looks mostly good but I have a question inline. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1182 + if (D1CXX->isLambda()) { +if (!D2CXX->isLambda()) Should we return false if `D1CXX->isLambd

[PATCH] D64073: [ASTImporter] Fix import of lambda in function param

a_sidorin added a comment. Hello Gabor, There is an inline question about tests; other code looks fine. Comment at: clang/lib/AST/ASTImporter.cpp:1713 +// In case of lambdas, the class already has a definition ptr set, but +// the contained decls are not import

[PATCH] D64110: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Add a label to nodes that have a bug report attached or on which the a

[PATCH] D64110: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

NoQ added a comment. F9450610: Screen Shot 2019-07-02 at 4.07.00 PM.png Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64110/new/ https://reviews.llvm.org/D64110 ___ cfe-commits ma

[PATCH] D64110: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I have removed that `is_sink` business because we have an actual graph, not just a huge painting, so you could mark whether it is sink by it has zero successors. I like the idea about refa

[PATCH] D64110: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

NoQ added a comment. Sink node is not the same thing as "zero successors". A sink node is a node in which termination was explictly requested as part of modeling, which is usually nice to know. A non-sink node may have no successors because it ran out of statements to execute (i.e., the analysi

[PATCH] D64110: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

Charusso added a comment. In D64110#1567505 , @NoQ wrote: > A non-sink node may have no successors because it ran out of statements to > execute (i.e., the analysis finishes successfully). Ah, of course, sorry. > P.S. I don't have many more plans on im

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi updated this revision to Diff 207659. plotfi marked 4 inline comments as done. plotfi added a comment. Update diff based on @compnerd's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 Files:

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso updated this revision to Diff 207668. Charusso marked 7 inline comments as done. Charusso added a comment. - Create `FunctionExitPoint` diagnostics. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63915/new/ https://reviews.llvm.org/D63915 Files: clang/include/clang/Sta

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ReturnValueChecker.cpp:120 +<< (Value ? "true" : "false") +<< " according to the LLVM coding standard, but it returns " +<< (Value ? "false" : "true"); --

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Szelethus added a comment. I'd love to chip in later, if you don't mind, but here is just a couple things that caught my mind that I'd like to share before falling asleep ;) Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:98-100 +// The APIModeling package

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:228-229 /// a bug, you can add notes as you add your transitions. - const NoteTag *getNoteTag(NoteTag::Callback &&Cb) { -return Eng.getNoteTags().makeNoteTag(std

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ReturnValueChecker.cpp:107 + + // If the invariant is broken we do not return the concrete value. +if (IsInvariantBreak) Something's wrong with formatting. C

r364990 - [analyzer] exploded-graph-rewriter: Collapse very long statement pretty-prints.

Author: dergachev Date: Tue Jul 2 18:26:35 2019 New Revision: 364990 URL: http://llvm.org/viewvc/llvm-project?rev=364990&view=rev Log: [analyzer] exploded-graph-rewriter: Collapse very long statement pretty-prints. When printing various statements that include braces (compound statements, lambda

r364989 - [analyzer] exploded-graph-rewriter: Implement checker messages.

Author: dergachev Date: Tue Jul 2 18:26:32 2019 New Revision: 364989 URL: http://llvm.org/viewvc/llvm-project?rev=364989&view=rev Log: [analyzer] exploded-graph-rewriter: Implement checker messages. They are displayed as raw lines and diffed via difflib on a per-checker basis. Differential Revi

r364992 - [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

Author: dergachev Date: Tue Jul 2 18:26:41 2019 New Revision: 364992 URL: http://llvm.org/viewvc/llvm-project?rev=364992&view=rev Log: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes. Add a label to nodes that have a bug report attached or on which the analysis was general

r364991 - [analyzer] exploded-graph-rewriter: NFC: Add more comments.

Author: dergachev Date: Tue Jul 2 18:26:38 2019 New Revision: 364991 URL: http://llvm.org/viewvc/llvm-project?rev=364991&view=rev Log: [analyzer] exploded-graph-rewriter: NFC: Add more comments. Modified: cfe/trunk/utils/analyzer/exploded-graph-rewriter.py Modified: cfe/trunk/utils/analyzer

[PATCH] D64110: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:3009-3010 for (const BugReport &Report : EQ) { -if (Report.getErrorNode()->getState() == N->getState()) +if (Report.getErrorNode()->get

[PATCH] D64100: [analyzer] exploded-graph-rewriter: Implement checker messages.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364989: [analyzer] exploded-graph-rewriter: Implement checker messages. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D64110: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

NoQ updated this revision to Diff 207687. NoQ added a comment. Fix the `dump_egraph.c` test (whoops). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64110/new/ https://reviews.llvm.org/D64110 Files: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/test/Analysis/dump_egraph.c cla

[PATCH] D64110: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364992: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64104: [analyzer] exploded-graph-rewriter: Collapse large statement pretty-prints.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364990: [analyzer] exploded-graph-rewriter: Collapse very long statement pretty-prints. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D64100: [analyzer] exploded-graph-rewriter: Implement checker messages.

NoQ added a comment. In D64100#1567230 , @Charusso wrote: > Nice! Could you add some `#===---===#` separators, please? As it is in the > finishing state, I think now it is appropriate. rC364991 . Repository: rL LLV

[PATCH] D64100: [analyzer] exploded-graph-rewriter: Implement checker messages.

Charusso added a comment. In D64100#1567706 , @NoQ wrote: > In D64100#1567230 , @Charusso wrote: > > > Nice! Could you add some `#===---===#` separators, please? As it is in the > > finishing state, I think now it

[PATCH] D64100: [analyzer] exploded-graph-rewriter: Implement checker messages.

NoQ added a comment. In D64100#1567715 , @Charusso wrote: > Sometimes I was lost in the amount of your work. Nah, i literally just pushed it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64100/new/ https://reviews.llvm.

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

MaskRay updated this revision to Diff 207695. MaskRay edited the summary of this revision. MaskRay added a comment. Implement this in TargetInfo::adjust as rnk suggested Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64067/new/ https://reviews.llvm.org/D64067 Fil

[PATCH] D62888: [NewPM] Port Sancov

leonardchan updated this revision to Diff 207698. leonardchan marked 5 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/ https://reviews.llvm.org/D62888 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/

[PATCH] D62888: [NewPM] Port Sancov

leonardchan added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:750 Constant::getNullValue(ArrayTy), "__sancov_gen_"); + appendToCompilerUsed(*CurModule, {Array}); chandlerc wrote: > There is a `GlobalsToAppendTo

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso updated this revision to Diff 207703. Charusso marked 10 inline comments as done. Charusso added a comment. - Fix. - Refactor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63915/new/ https://reviews.llvm.org/D63915 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers

[PATCH] D64015: [WIP][CUDA] Use shared MangleContext for CUDA and CXX CG

aheejin resigned from this revision. aheejin added a comment. Sorry, I don't think I know enough about this code to review this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64015/new/ https://reviews.llvm.org/D64015 __

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:98-100 +// The APIModeling package is for checkers that model APIs. These checkers are +// always turned on; this package is intended for API modeling that is not +// controlled by

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:210 ///the default tag for the checker will be used. + /// @param IsPrunable Whether the note is prunable. ExplodedNode * It makes p

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song updated this revision to Diff 207704. yonghong-song added a comment. handle unnamed bitfield properly. these struct/union members are not encoded in debuginfo, so skip them during preserve_*_access_index IR intrinsics generation. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song added a comment. @rsmith Just ping, could you take a look at the clang change? If possible, could you share your opinion? Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809 __

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

hfinkel added a comment. Can you please add a test ensuring that -malign-double and -mlong-double-64 interact properly? I think that, in the current patch, they do (as -malign-double is processed first), but I'd prefer that we cover that case explicitly. Repository: rC Clang CHANGES SINCE

[PATCH] D64119: [PowerPC] Support constraint code "ww"

MaskRay created this revision. MaskRay added reviewers: awilfox, echristo, hfinkel, jsji, kbarton, nemanjai. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. "ww" and "ws" are both constraint codes for VSX vector registers that holds scalar double

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

MaskRay updated this revision to Diff 207708. MaskRay added a comment. Check -malign-double Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64067/new/ https://reviews.llvm.org/D64067 Files: include/clang/Basic/LangOptions.def include/clang/Driver/Options.td

[PATCH] D64018: [clangd] Store hash of command line in index shards.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:531 +for (llvm::StringRef C : Cmd.CommandLine) + Result.Cmd->CommandLine.emplace_back(C.str()); + } nit: push_back, or emplac

[PATCH] D64120: Rebase onto current master

gamesh411 created this revision. Herald added subscribers: cfe-commits, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D64120 Files: include/clang/CrossTU/CrossTranslationUnit.h include/clang/StaticAnalyzer/

[PATCH] D64120: Rebase onto current master

gamesh411 abandoned this revision. gamesh411 added a comment. Missed arcanist diff. Disregard this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64120/new/ https://reviews.llvm.org/D64120 ___ cfe-commits ma

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 updated this revision to Diff 207711. gamesh411 added a comment. Rebase onto current master Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59798/new/ https://reviews.llvm.org/D59798 Files: include/clang/CrossTU/CrossTranslationUnit.h include/clang/S

<    1   2