rnk added a comment.
Sounds good to me. I had a minor suggestion, though.
================
Comment at: lib/Basic/Targets/PPC.cpp:468
Opts.AltiVec = 1;
- TargetInfo::adjust(Opts);
+ if (Opts.LongDoubleSize == 64) {
+ LongDoubleWidth = LongDoubleAlign = 64;
----------------
I think it would be preferable to implement this in the base
`TargetInfo::adjust` implementation, just to reduce code duplication. The
driver already checks that the option makes sense for some particular target. I
think it's actually kind of nice that the user can bypass the driver with
`-Xclang` and try using it for some unsupported target to see what happens. It
will probably work anyway.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64067/new/
https://reviews.llvm.org/D64067
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
