[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

wxiao3 marked an inline comment as done. wxiao3 added a comment. Yes, there is a test to ensure that Darwin defaults to the old behaviour in "test/CodeGen/x86_32-m64.c". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63473/new/ https://reviews.llvm.org/D63473

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan added a comment. In D62115#1547698 , @kimgr wrote: > This looks good to me, thanks! Could you help accept this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115

[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

wxiao3 updated this revision to Diff 205261. wxiao3 added a reviewer: compnerd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63473/new/ https://reviews.llvm.org/D63473 Files: docs/ReleaseNotes.rst include/clang/Basic/LangOptions.h lib/CodeGen/TargetInfo.cpp lib/Frontend/Compiler

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

kimgr added a comment. In D62115#1547705 , @skan wrote: > In D62115#1547698 , @kimgr wrote: > > > This looks good to me, thanks! > > > Could you help accept this patch? I'm not active in the project, so I don't fe

[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

RKSimon added inline comments. Comment at: test/CodeGen/x86_32-m64.c:6 // RUN: %clang_cc1 -w -O2 -fblocks -triple i386-pc-win32 -emit-llvm -o - %s | FileCheck %s --check-prefixes=CHECK,WIN32 +// RUN: %clang_cc1 -w -O2 -fblocks -triple i386-pc-linux-gnu -target-cpu pentium4 -em

[PATCH] D63426: [clangd] Narrow rename to local symbols.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:79 + + if (Index) { +// Consult the index to determine whether the symbol is used outside of pull out a function for this? Comment at: clang-tools-ex

[PATCH] D62538: [clangd] Add hidden tweaks to dump AST/selection.

sammccall added a comment. i mean ping Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62538/new/ https://reviews.llvm.org/D62538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D62538: [clangd] Add hidden tweaks to dump AST/selection.

sammccall added a comment. pind Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62538/new/ https://reviews.llvm.org/D62538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping

sammccall added a comment. Can you explain why this is important? (in the code) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62953/new/ https://reviews.llvm.org/D62953 ___ cfe-commits mailing list cfe

[PATCH] D59744: Fix i386 ABI "__m64" type bug

hans added a comment. In D59744#1547445 , @wxiao3 wrote: > @hans > > Please make sure all Chromium for 32-bit Linux libraries are following System > V ABI (i.e., m64 is passed on mmx register). I suspect that there are some > hand written assembly code i

[PATCH] D62954: [Syntax] Add a helper to find expansion by its first spelled token

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:204 + /// An expansion produced by the preprocessor, includes macro expansions and + /// macro directives. Preprocessor always maps a non-empty range of spelled + /// tokens to a (possibly

[PATCH] D62954: [Syntax] Add a helper to find expansion by its first spelled token

sammccall added a comment. LG but needs tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62954/new/ https://reviews.llvm.org/D62954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Can we add a test using TestTU that does a very basic verification of expanded/spelled tokens (first after preamble, last token in file)? Comment at: clang-tools-extra

[PATCH] D62538: [clangd] Add hidden tweaks to dump AST/selection.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a few NITs Comment at: clangd/refactor/Tweak.h:104 + /// Is this a 'hidden' tweak, which are off by default. + virtual bool hidden() const { return

[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

hans added a comment. > The System V i386 bug fix (https://reviews.llvm.org/D59744) makes it > impossible Please refer to the svn revision instead of the code review. > for 32-bit Linux Chromium to write an assembly function that works with both > trunk clang and clang 8.0.0, which makes it di

[PATCH] D63479: Added SemanticSymbolASTCollector for collecting semantic symbolsCurrently collects variable and function declarations

jvikstrom created this revision. jvikstrom added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ilya-biryukov, mgorny. Herald added a project: clang. [clangd] Added SemanticSymbolASTCollector that collects variable and function declarations Repository:

[PATCH] D63479: Added SemanticSymbolASTCollector for collecting semantic symbolsCurrently collects variable and function declarations

jvikstrom updated this revision to Diff 205275. jvikstrom added a comment. Added dots at the end of comments Updating D63479: Added SemanticSymbolASTCollector for collecting semantic symbols = Currently collects var

[PATCH] D63481: [clangd] Parse files without extensions if we don't have a compile command.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This would enable clangd for C++ standard library files. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

yvvan created this revision. yvvan added reviewers: gribozavr, nik. Herald added a subscriber: xazax.hun. Currently this check generates the replacement with the newline in the end. The proper way to export it to YAML is to have two \n\n instead of one. Without this fix clients should reinterpre

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 added a comment. There is a bug in Clang AST. @rsmith Check testcase test/Sema/switch-1.c. In C++ mode we have AST: CompoundStmt 0x55f5b7d68460 | | | -ReturnStmt 0x55f5b7d68060| | |

[PATCH] D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h

asavonic accepted this revision. asavonic added a comment. This revision is now accepted and ready to land. Thanks. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63256/new/ https://reviews.llvm.org/D63256 ___ cfe-commits mailing list

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 updated this revision to Diff 205295. xbolva00 added a comment. Addressed some notes. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63139/new/ https://reviews.llvm.org/D63139 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaStmt.cpp test/Sema/implic

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nik added a comment. In D63331#1543441 , @hokein wrote: > Yeah, we definitely have interest in this feature, and our intern @jvikstrom > will work on this feature this summer. "this summer" depends on the location, so can you concretize this? :) > You

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 205297. anton-afanasyev marked 2 inline comments as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 Files: clan

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:232 { +llvm::TimeTraceScope TimeScope("Frontend", StringRef("")); PrettyStackTraceString CrashInfo("Per-file LLVM IR generation"); lebedev.ri wrote: > T

[PATCH] Add support for openSUSE RISC-V triple

--- clang/lib/Driver/ToolChains/Gnu.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp index c8520968e45..64f4f9e1e26 100644 --- a/clang/lib/Driver/ToolChains/Gnu.cpp +++ b/clang/lib/Driver/ToolChains

Re: [PATCH] Add support for openSUSE RISC-V triple

Missing a test, and if this is a patch and not a commit you want to submit it via https://llvm.org/docs/Phabricator.html On Tue, Jun 18, 2019 at 2:20 PM Andreas Schwab via cfe-commits wrote: > > --- > clang/lib/Driver/ToolChains/Gnu.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

aaron.ballman added inline comments. Comment at: lib/Parse/ParseStmt.cpp:102 ParsedAttributesWithRange Attrs(AttrFactory); + MaybeParseGNUAttributes(Attrs); MaybeParseCXX11Attributes(Attrs, nullptr, /*MightBeObjCMessageSend*/ true); xbolva00 wrote: > xbolv

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 205298. serge-sans-paille added a comment. Mostly documentation update + helper function renaming. @meinersbur, I've tested the setup with static and dynamic builds on Linux, please let me know your thoughts on this. CHANGES SINCE LAST ACTION h

[PATCH] D63483: [clangd] Detect C++ language based on well-known file path in vscode extension

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Matching the "C++" pattern on the first line of the file doesn't cover all cases, MSVC C++ headers doesn't have such patte

[PATCH] D63479: Added SemanticSymbolASTCollector for collecting semantic symbolsCurrently collects variable and function declarations

jvikstrom updated this revision to Diff 205301. jvikstrom added a comment. Moved SemanticSymbolASTVisitor to an anonymous namespace and added a function for getting highlights that returns highlights line by line Updating D63479: Added SemanticSymbolASTCollector for collecting semantic symbols

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added a comment. As noted in D63299 , seems like this would require more surgery - I cannot continue D63299 since I have no enough knowledge to rework it fully. I will update this patch, in case somebody picks D63299

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 added a comment. In D63139#1547968 , @xbolva00 wrote: > There is a bug in Clang AST. @rsmith > > Check test/Sema/switch-1.c. In C++ mode we have really bad AST: > > CompoundStmt 0x55f5b7d68460 > | | |-ReturnStmt 0x55f5b7d68060 > | |

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang-tools-extra] r363662 - [clangd] Detect C++ language based on well-known file path in vscode extension

Author: hokein Date: Tue Jun 18 04:53:14 2019 New Revision: 363662 URL: http://llvm.org/viewvc/llvm-project?rev=363662&view=rev Log: [clangd] Detect C++ language based on well-known file path in vscode extension Summary: Matching the "C++" pattern on the first line of the file doesn't cover all c

[clang-tools-extra] r363663 - [clangd] Parse files without extensions if we don't have a compile command.

Author: hokein Date: Tue Jun 18 04:54:17 2019 New Revision: 363663 URL: http://llvm.org/viewvc/llvm-project?rev=363663&view=rev Log: [clangd] Parse files without extensions if we don't have a compile command. Summary: This would enable clangd for C++ standard library files. Reviewers: sammccall

[PATCH] D63483: [clangd] Detect C++ language based on well-known file path in vscode extension

This revision was automatically updated to reflect the committed changes. Closed by commit rL363662: [clangd] Detect C++ language based on well-known file path in vscode extension (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D63481: [clangd] Parse files without extensions if we don't have a compile command.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363663: [clangd] Parse files without extensions if we don't have a compile command. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[clang-tools-extra] r363664 - [clangd] Add a capability to enable completions with fixes.

Author: sammccall Date: Tue Jun 18 04:57:26 2019 New Revision: 363664 URL: http://llvm.org/viewvc/llvm-project?rev=363664&view=rev Log: [clangd] Add a capability to enable completions with fixes. Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clan

[PATCH] D63091: [clangd] Add a capability to enable completions with fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363664: [clangd] Add a capability to enable completions with fixes. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CH

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

hokein added a comment. In D63331#1548020 , @nik wrote: > In D63331#1543441 , @hokein wrote: > > > Yeah, we definitely have interest in this feature, and our intern > > @jvikstrom will work on this feature this sum

[PATCH] D63381: Allow copy/move assignment operator to be coroutine as per N4775

vivekvpandya added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63381/new/ https://reviews.llvm.org/D63381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62538: [clangd] Add hidden tweaks to dump AST/selection.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clangd/refactor/Tweak.h:104 + /// Is this a 'hidden' tweak, which are off by default. + virtual bool hidden() const { return false; } }; ilya-biryukov wrote: > I wonder wh

Re: [PATCH] Add support for openSUSE RISC-V triple

On Jun 18 2019, Roman Lebedev wrote: > Missing a test, and if this is a patch and not a commit you want to > submit it via https://llvm.org/docs/Phabricator.html http://llvm.org/docs/DeveloperPolicy.html says I should send it here. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key

[PATCH] D62722: [Driver] Simplify Assemble and Backend action collapsing

kpet added a comment. Friendly ping :). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62722/new/ https://reviews.llvm.org/D62722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

Re: [PATCH] Add support for openSUSE RISC-V triple

On Tue, Jun 18, 2019 at 3:06 PM Andreas Schwab wrote: > > On Jun 18 2019, Roman Lebedev wrote: > > > Missing a test, and if this is a patch and not a commit you want to > > submit it via https://llvm.org/docs/Phabricator.html > > http://llvm.org/docs/DeveloperPolicy.html says I should send it her

r363676 - Require commas to separate multiple GNU-style attributes in the same attribute list.

Author: aaronballman Date: Tue Jun 18 05:57:05 2019 New Revision: 363676 URL: http://llvm.org/viewvc/llvm-project?rev=363676&view=rev Log: Require commas to separate multiple GNU-style attributes in the same attribute list. Fixes PR38352. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp cfe/

[PATCH] D62635: Add enums as global variables in the IR metadata.

rnk added a comment. We did things this way to track which **enumerators** were used, not which enums were used. Size data showed it was worth doing (6%). The existing format doesn't support tracking usage of individual enumerators, so we pretended they were const integers to avoid changing the

[PATCH] D63490: Script for generating AST JSON dump test cases

aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. Trying to write or maintain test code for AST dumping of JSON information can be onerous due to small changes in the test requiring a large amount of line numbers or other information to be updated in the expected test

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62952/new/ https://reviews.llvm.org/D62952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang-tools-extra] r363680 - [clangd] Add hidden tweaks to dump AST/selection.

Author: sammccall Date: Tue Jun 18 06:37:54 2019 New Revision: 363680 URL: http://llvm.org/viewvc/llvm-project?rev=363680&view=rev Log: [clangd] Add hidden tweaks to dump AST/selection. Summary: This introduces a few new concepts: - tweaks have an Intent (they don't all advertise as refactorings

[PATCH] D63479: Added SemanticSymbolASTCollector for collecting semantic symbolsCurrently collects variable and function declarations

jvikstrom abandoned this revision. jvikstrom added a comment. Resubmitting later with "complete" prototype in CL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63479/new/ https://reviews.llvm.org/D63479 ___

[PATCH] D62538: [clangd] Add hidden tweaks to dump AST/selection.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363680: [clangd] Add hidden tweaks to dump AST/selection. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D63330: [clangd] Add Value field to HoverInfo

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:722 + // Fill in value with initializer. Puts evaluated version if possible. + if (const auto *Var = dyn_cast(D)) { do we want the initializer both here and in Definition? I susp

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44865/new/ https://reviews.llvm.org/D44865 ___

[clang-tools-extra] r363681 - [clangd] Remove the extra ";", NFC

Author: hokein Date: Tue Jun 18 06:52:00 2019 New Revision: 363681 URL: http://llvm.org/viewvc/llvm-project?rev=363681&view=rev Log: [clangd] Remove the extra ";", NFC Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/DumpAST.cpp Modified: clang-tools-extra/trunk/clangd/refactor/tweak

r363682 - AMDGPU: Disable errno by default

Author: arsenm Date: Tue Jun 18 06:59:32 2019 New Revision: 363682 URL: http://llvm.org/viewvc/llvm-project?rev=363682&view=rev Log: AMDGPU: Disable errno by default Modified: cfe/trunk/lib/Driver/ToolChains/AMDGPU.h cfe/trunk/test/Driver/fast-math.c Modified: cfe/trunk/lib/Driver/ToolCh

[PATCH] D62697: AMDGPU: Disable errno by default

arsenm closed this revision. arsenm added a comment. r363682 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62697/new/ https://reviews.llvm.org/D62697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 reclaimed this revision. xbolva00 added a comment. Ok, If we peek a few tokens ahead and check attribute if it is stmt attribute and then we call MaybeParseGNUAttr - this probably would work but are you fine with it as a workaround ? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

aaron.ballman added a comment. Most of the comments are about minor nits like grammar and coding conventions, but I did have some questions regarding what kinds of functions the sycl_kernel attribute gets applied to. Also, I'd like to see some additional tests that demonstrate the sycl device a

r363684 - AMDGPU: Add GWS instruction builtins

Author: arsenm Date: Tue Jun 18 07:10:01 2019 New Revision: 363684 URL: http://llvm.org/viewvc/llvm-project?rev=363684&view=rev Log: AMDGPU: Add GWS instruction builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.cl Modified: c

[PATCH] D63366: AMDGPU: Add GWS instruction builtins

arsenm closed this revision. arsenm added a comment. r363684 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63366/new/ https://reviews.llvm.org/D63366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 205331. Blackhart added a comment. - Reorder release note changes - Update documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt c

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart added a comment. Hello, I've updated the documentation with more informations about the transformations the check do. I'm not very confident in writing documentation in english. Please review it and submit me your change requests. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

aaron.ballman added a comment. In D62952#1535088 , @hubert.reinterpretcast wrote: > @aaron.ballman, for similar cases in the plist output, it has been proposed > > - that the reference expected file be committed into the tree pre-normalized, > and > - th

[PATCH] D63437: [CodeGen][ARM] Fix FP16 vector coercion

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. Ah, right. In that case, this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63437/new/ https://reviews.llvm.org/D63437 __

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:192 + + This check replaces all occurrences of the C ``memcpy`` function by ``std::copy``. + Please remove //This check//. Same in first statement in documentation. CH

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

lebedev.ri added a comment. Still missing tests Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceMemcpyByStdCopy.cpp:34-35 + callExpr(hasDeclaration(functionDecl(hasName("memcpy"), + isExpansionInSystemHeader())), +

[PATCH] D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: lib/Sema/SemaDecl.cpp:13345-13346 +<< (FD->getStorageClass() == SC_None +? FixItHint::CreateInsertion(FD->getTypeSpecStartLoc(), +

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 205341. Blackhart marked 3 inline comments as done. Blackhart added a comment. Remove "//this check//" from documentation and release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-too

r363687 - [CodeGen][ARM] Fix FP16 vector coercion

Author: miyuki Date: Tue Jun 18 07:34:27 2019 New Revision: 363687 URL: http://llvm.org/viewvc/llvm-project?rev=363687&view=rev Log: [CodeGen][ARM] Fix FP16 vector coercion Summary: When a function argument or return type is a homogeneous aggregate which contains an FP16 vector but the target doe

[PATCH] D63437: [CodeGen][ARM] Fix FP16 vector coercion

This revision was automatically updated to reflect the committed changes. Closed by commit rL363687: [CodeGen][ARM] Fix FP16 vector coercion (authored by miyuki, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

aaron.ballman added a comment. In D63299#1548306 , @xbolva00 wrote: > Ok, If we peek a few tokens ahead and check attribute if it is stmt attribute > and then we call MaybeParseGNUAttr - this probably would work but are you > fine with it as a workaround

[PATCH] D63088: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Funny enough, I've got a paper out for WG14 to try to relax this for C2x: http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2381.pdf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 updated this revision to Diff 205349. xbolva00 added a comment. Addressed notes. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 Files: include/clang/Basic/Attr.td lib/Sema/AnalysisBasedWarnings.cpp test/Sema/fallthrough-a

[PATCH] D62954: [Syntax] Add a helper to find expansion by its first spelled token

ilya-biryukov updated this revision to Diff 205352. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. - Address comments. - s/findExpansion/expansionStartingAt. - Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D62954: [Syntax] Add a helper to find expansion by its first spelled token

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:209 + ///#define FOO 1 2 3 // Expansion from "#define FOO 1" to an empty range. + ///FOO // Expansion from "FOO" to "1 2 3". + struct Expansion {

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 205354. Blackhart marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-tidy/modernize/Mod

[PATCH] D63426: [clangd] Narrow rename to local symbols.

hokein updated this revision to Diff 205355. hokein marked 5 inline comments as done. hokein added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63426/new/ https://reviews.llvm.org/D63426 Files: clang-tools-ext

[PATCH] D63426: [clangd] Narrow rename to local symbols.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:83 +// FIXME: we may skip querying the index if D is function-local. +const NamedDecl *D = +clang::tooling::getNamedDeclAt(ASTCtx, SourceLocationBeg); sammccall

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added inline comments. Comment at: clang/test/SemaSYCL/device-attributes.cpp:3 + +[[clang::sycl_kernel]] int gv2 = 0; // expected-warning {{'sycl_kernel' attribute only applies to functions}} +__attribute((sycl_kernel)) int gv3 = 0; // expected-warning {{'sycl_kernel'

[clang-tools-extra] r363691 - [clangd] Return vector from applyTweak. NFC

Author: ibiryukov Date: Tue Jun 18 08:15:41 2019 New Revision: 363691 URL: http://llvm.org/viewvc/llvm-project?rev=363691&view=rev Log: [clangd] Return vector from applyTweak. NFC For the same reasons as r363150, which got overwritten by changes in r363680. Sending without review to unbreak our

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Can you also add some SemaCXX tests that ensure the attribute is properly diagnosed when written on a bit-field, a static data member, a function, is given an argument, etc? Comment at: include/clan

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

This revision was automatically updated to reflect the committed changes. lichray marked an inline comment as done. Closed by commit rL363692: [libc++] Implement P0608R3 - A sane variant converting constructor (authored by lichray, committed by ). Herald added a project: LLVM. Herald added a subsc

[PATCH] D59744: Fix i386 ABI "__m64" type bug

mtklein added a comment. Hey folks, I'm the Skia point of contact on this, and "luckily" the person who wrote all the code that got us into this mess. Let me cross post a couple questions I've had from the Chromium bug over here where folks might know the answer... Now that Clang's decided to

[PATCH] D54295: [RISCV] Add inline asm constraint A for RISC-V

asb accepted this revision. asb added a comment. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54295/new/ https://reviews.llvm.org/D54295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 updated this revision to Diff 205364. xbolva00 added a comment. Addressed review notes. Thanks @aaron.ballman ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/Diagn

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 updated this revision to Diff 205365. xbolva00 added a comment. Updated forgotten test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 abandoned this revision. xbolva00 added a comment. Right :( Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63299/new/ https://reviews.llvm.org/D63299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. In D62952#1548377 , @aaron.ballman wrote: > In general, that seems reasonable, but I would prefer to take care of more of > the work in lit.local.cfg than have to deal with that atrocious RUN line in > every test

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

aaron.ballman added a comment. In D62952#1548580 , @hubert.reinterpretcast wrote: > In D62952#1548377 , @aaron.ballman > wrote: > > > In general, that seems reasonable, but I would prefer to take care of more > >

[PATCH] D63497: Add support for openSUSE RISC-V triple

schwab created this revision. Herald added subscribers: llvm-commits, cfe-commits, rkruppe, dexonsmith, rogfer01, shiva0217, kito-cheng. Herald added projects: clang, LLVM. Repository: rC Clang https://reviews.llvm.org/D63497 Files: clang/lib/Driver/ToolChains/Gnu.cpp llvm/unittests/ADT/T

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn updated this revision to Diff 205371. kpn added a comment. Add static methods to convert between a StringRef and the enums for RoundingMode or ExceptionBehavior. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 Files: include/llvm/IR/IRBui

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. In D62952#1548593 , @aaron.ballman wrote: > But is there a reason to not keep `%diff_sarif` and define it in terms of > `%normalize_sarif | diff -U1 -b` within lit.local.cfg? I guess I don't see > the benefit to e

[PATCH] D62954: [Syntax] Add a helper to find expansion by its first spelled token

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:207 + auto FileIt = Files.find(SourceMgr->getFileID(Spelled->location())); + assert(FileIt != Files.end()); +

[PATCH] D63497: Add support for openSUSE RISC-V triple

lebedev.ri added a reviewer: asb. lebedev.ri added a comment. Nice :) It is also a good idea to upload patches with full context (`-U9`) Comment at: llvm/unittests/ADT/TripleTest.cpp:333 + T = Triple("riscv64-suse-linux"); + EXPECT_EQ(Triple::riscv64, T.getArch());

[PATCH] D62954: [Syntax] Add a helper to find expansion by its first spelled token

ilya-biryukov updated this revision to Diff 205374. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Added a message to the assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62954/new/ https://reviews.llvm.org/

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

aaron.ballman added a comment. In D62952#1548620 , @hubert.reinterpretcast wrote: > In D62952#1548593 , @aaron.ballman > wrote: > > > But is there a reason to not keep `%diff_sarif` and define it in terms of > >

r363698 - [Syntax] Add a helper to find expansion by its first spelled token

Author: ibiryukov Date: Tue Jun 18 09:27:27 2019 New Revision: 363698 URL: http://llvm.org/viewvc/llvm-project?rev=363698&view=rev Log: [Syntax] Add a helper to find expansion by its first spelled token Summary: Used in clangd for a code tweak that expands a macro. Reviewers: sammccall Reviewed

[PATCH] D63426: [clangd] Narrow rename to local symbols.

sammccall added a comment. Thanks for exposing the ND, cleaner. Found another problem :-( not in your code but about this whole approach to using the index. Let's talk tomorrow Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:81 + Req.Limit = 100; + if (auto ID = get

  1   2   3   >