lebedev.ri added a reviewer: asb.
lebedev.ri added a comment.

Nice :)
It is also a good idea to upload patches with full context (`-U99999`)



================
Comment at: llvm/unittests/ADT/TripleTest.cpp:333
 
+  T = Triple("riscv64-suse-linux");
+  EXPECT_EQ(Triple::riscv64, T.getArch());
----------------
Without context i can't tell, in general is the grouping here based on the 
triple, or the vendor?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63497/new/

https://reviews.llvm.org/D63497



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to