[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

Hahnfeld added a comment. Am I correct that the second to last revision ("- Fix tests.") removed all checks for the actual `device_id` argument from the tests? From my point of view that's not fixing but weakening the tests! Can you explain why they needed "fixing"? If I had to guess this is b

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. The tests must check the device ID for target-based calls of the task alloc function. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ http

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added a comment. In D63009#1544758 , @Hahnfeld wrote: > Am I correct that the second to last revision ("- Fix tests.") removed all > checks for the actual `device_id` argument from the tests? From my point of > view that's not fixing but weakenin

[PATCH] D62009: [clang] perform semantic checking in constant context

This revision was automatically updated to reflect the committed changes. Closed by commit rL363488: [clang] perform semantic checking in constant context (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

r363362 - [C++20] add Basic consteval specifier

Author: tyker Date: Fri Jun 14 01:56:20 2019 New Revision: 363362 URL: http://llvm.org/viewvc/llvm-project?rev=363362&view=rev Log: [C++20] add Basic consteval specifier Summary: this revision adds Lexing, Parsing and Basic Semantic for the consteval specifier as specified by http://www.open-st

r363361 - [clang] Fixing incorrect implicit deduction guides (PR41549)

Author: tyker Date: Fri Jun 14 01:40:04 2019 New Revision: 363361 URL: http://llvm.org/viewvc/llvm-project?rev=363361&view=rev Log: [clang] Fixing incorrect implicit deduction guides (PR41549) Summary: [[ https://bugs.llvm.org/show_bug.cgi?id=41549 | bug report ]] Before this patch, implicit ded

r363488 - [clang] perform semantic checking in constant context

Author: tyker Date: Sat Jun 15 01:32:56 2019 New Revision: 363488 URL: http://llvm.org/viewvc/llvm-project?rev=363488&view=rev Log: [clang] perform semantic checking in constant context Summary: Since the addition of __builtin_is_constant_evaluated the result of an expression can change based on

r363475 - Fixed the --print-supported-cpus test

Author: ziangwan725 Date: Fri Jun 14 16:34:40 2019 New Revision: 363475 URL: http://llvm.org/viewvc/llvm-project?rev=363475&view=rev Log: Fixed the --print-supported-cpus test Add constraints for the test that require specific backend targets to be registered. Remove trailing whitespace in the d

r363464 - Add --print-supported-cpus flag for clang.

Author: ziangwan725 Date: Fri Jun 14 14:42:21 2019 New Revision: 363464 URL: http://llvm.org/viewvc/llvm-project?rev=363464&view=rev Log: Add --print-supported-cpus flag for clang. This patch allows clang users to print out a list of supported CPU models using clang [--target=] --print-supported-

[clang-tools-extra] r363365 - Test commit

Author: sureyeaah Date: Fri Jun 14 02:40:42 2019 New Revision: 363365 URL: http://llvm.org/viewvc/llvm-project?rev=363365&view=rev Log: Test commit Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/RawStringLiteral.cpp Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/RawString

r363491 - [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Author: charusso Date: Sat Jun 15 03:05:49 2019 New Revision: 363491 URL: http://llvm.org/viewvc/llvm-project?rev=363491&view=rev Log: [analyzer] ReturnVisitor: Bypass everything to see inlined calls Summary: When we traversed backwards on ExplodedNodes to see where processed the given statement

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL363491: [analyzer] ReturnVisitor: Bypass everything to see inlined calls (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

r363493 - [clang] Add storage for APValue in ConstantExpr

Author: tyker Date: Sat Jun 15 03:24:47 2019 New Revision: 363493 URL: http://llvm.org/viewvc/llvm-project?rev=363493&view=rev Log: [clang] Add storage for APValue in ConstantExpr Summary: When using ConstantExpr we often need the result of the expression to be kept in the AST. Currently this is

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL363493: [clang] Add storage for APValue in ConstantExpr (authored by Tyker, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D62399?vs=203723&id=204

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch has multiple small improvements related to the APValue in ConstantExpr. changes: - APValue in ConstantExpr are now cleaned up using ASTContext::addDestr

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker updated this revision to Diff 204916. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63376/new/ https://reviews.llvm.org/D63376 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Expr.h clang/include/clang/AST/Stmt.h clang/include/clang/Sema/Sema.h clang/l

r363494 - [Clang] Rename -split-dwarf-file to -split-dwarf-output

Author: aaronpuchert Date: Sat Jun 15 07:07:43 2019 New Revision: 363494 URL: http://llvm.org/viewvc/llvm-project?rev=363494&view=rev Log: [Clang] Rename -split-dwarf-file to -split-dwarf-output Summary: This is the first in a series of changes trying to align clang -cc1 flags for Split DWARF wit

[PATCH] D63130: [Clang] Rename -split-dwarf-file to -split-dwarf-output

This revision was automatically updated to reflect the committed changes. Closed by commit rL363494: [Clang] Rename -split-dwarf-file to -split-dwarf-output (authored by aaronpuchert, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart added a comment. In D63324#1543706 , @lebedev.ri wrote: > In D63324#1543626 , @Blackhart wrote: > > > In D63324#1543609 , @lebedev.ri > > wrote: > > > > > In D6332

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart added a comment. In D63324#1543782 , @xbolva00 wrote: > This might not be currently ideal recommendation since std::copy produces > memmove with -O3. What do you recommend ? There is a way to disable this modernization if the user compile with

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204920. Blackhart added a comment. Revert "Modernize memcpy only if C++20 is enabled" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204922. Blackhart added a comment. Add override keyword to the destructor and set it as "= default" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeList

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204924. Blackhart marked an inline comment as done. Blackhart added a comment. Remove "auto" keyword when type is created from same statement CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204925. Blackhart marked an inline comment as done. Blackhart added a comment. Use "std::array" instead of the raw array CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tid

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea added a comment. In D63009#1544784 , @ABataev wrote: > The tests must check the device ID for target-based calls of the task alloc > function. Since device ID is now an expression I can only do this: i64 {{.*}}) Is this what you wanted? @AB

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea added a comment. In D63009#1544758 , @Hahnfeld wrote: > Am I correct that the second to last revision ("- Fix tests.") removed all > checks for the actual `device_id` argument from the tests? From my point of > view that's not fixing but weakeni

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceMemcpyByStdCopy.cpp:11 +#include "../utils/OptionsUtils.h" + +#include Please remove unnecessary empty line. Comment at: clang-tools-extra/clang-ti

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204926. Blackhart marked an inline comment as done. Blackhart added a comment. - Remove unnessecary empty line - Use "array.size()" instead of numerical constant CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63

r363496 - [Clang] Harmonize Split DWARF options with llc

Author: aaronpuchert Date: Sat Jun 15 08:38:51 2019 New Revision: 363496 URL: http://llvm.org/viewvc/llvm-project?rev=363496&view=rev Log: [Clang] Harmonize Split DWARF options with llc Summary: With Split DWARF the resulting object file (then called skeleton CU) contains the file name of another

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

This revision was automatically updated to reflect the committed changes. aaronpuchert marked 3 inline comments as done. Closed by commit rL363496: [Clang] Harmonize Split DWARF options with llc (authored by aaronpuchert, committed by ). Changed prior to commit: https://reviews.llvm.org/D59673?

[PATCH] D63167: [Clang] Remove obsolete -enable-split-dwarf={single,split}

aaronpuchert updated this revision to Diff 204928. aaronpuchert added a comment. Remove `-enable-split-dwarf` completely, adapting the test case accordingly. Also remove `-split-dwarf` which wasn't used at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D63167: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf

aaronpuchert added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:864 default: -if (!CodeGenOpts.SplitDwarfOutput.empty() && -(CodeGenOpts.getSplitDwarfMode() == CodeGenOptions::SplitFileFission)) { +if (!CodeGenOpts.SplitDwarfOutput.empty()) {

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204930. Blackhart marked 2 inline comments as done. Blackhart added a comment. - Update releasenotes - Add documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tid

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204932. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp clang-tools-extra/cla

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceMemcpyByStdCopy.h:41 + std::unique_ptr Inserter; + const utils::IncludeSorter::IncludeStyle IncludeStyle; +}; I think this could be determined from .clang-format.

[PATCH] D62611: [analyzer][Dominators] Add unittests

sanaanajjar231288 added a comment. In D62611#1521692 , @Szelethus wrote: > Fixes according to reviewer comments, thanks! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 __

r363502 - Recommit r363298 "[lit] Disable test on darwin when building shared libs."

Author: dhinton Date: Sat Jun 15 13:09:54 2019 New Revision: 363502 URL: http://llvm.org/viewvc/llvm-project?rev=363502&view=rev Log: Recommit r363298 "[lit] Disable test on darwin when building shared libs." Was reverted in r363379 due to build breakage. Thanks to Nico Weber for reverting the o

[PATCH] D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda

modocache added inline comments. Comment at: cfe/trunk/lib/Sema/TreeTransform.h:7173 +auto *MD = dyn_cast_or_null(FD); +if (!MD || !MD->getParent()->isGenericLambda()) { + assert(!Promise->getType()->isDependentType() && rsmith wrote: > This assert d

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added a comment. In D63009#1544900 , @gtbercea wrote: > In D63009#1544758 , @Hahnfeld wrote: > > > Am I correct that the second to last revision ("- Fix tests.") removed all > > checks for the actual `devic

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

dim abandoned this revision. dim added a comment. No longer needed after rC362328 and follow-ups. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62873/new/ https://reviews.llvm.org/D62873

[PATCH] D62839: [clangd] Index API and implementations for relations

hintonda added a comment. This seems to have broken gcc 5.4 builds -- for example see http://lab.llvm.org:8011/builders/clang-cmake-armv7-lnt/builds/29/steps/build%20stage%201/logs/stdio. I believe the following patch should fix the problem: diff --git a/clang-tools-extra/clangd/index/FileInd

[clang-tools-extra] r363504 - Fix gcc-05.4 bot failures caused by in r363481 "[clangd] Index API and implementations for relations"

Author: dhinton Date: Sat Jun 15 18:09:41 2019 New Revision: 363504 URL: http://llvm.org/viewvc/llvm-project?rev=363504&view=rev Log: Fix gcc-05.4 bot failures caused by in r363481 "[clangd] Index API and implementations for relations" Use std::make_tuple instead of initializer list to make gcc-

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added a comment. Thanks for fixing that! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nridge added a comment. In D63331#1543441 , @hokein wrote: > To avoid multiple people working on the same feature, I think the plan is > that @jvikstrom will pick up the current stuff, and continue > working/improving it. Sounds good! I'm excited to se

[clang-tools-extra] r363506 - [clangd] Type hierarchy subtypes

Author: nridge Date: Sat Jun 15 19:31:37 2019 New Revision: 363506 URL: http://llvm.org/viewvc/llvm-project?rev=363506&view=rev Log: [clangd] Type hierarchy subtypes Summary: This builds on the relations support added in D59407, D62459, D62471, and D62839 to implement type hierarchy subtypes. Re

[PATCH] D58880: [clangd] Type hierarchy subtypes

This revision was automatically updated to reflect the committed changes. Closed by commit rL363506: [clangd] Type hierarchy subtypes (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D58

[PATCH] D58880: [clangd] Type hierarchy subtypes

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1052 + PathRef TUPath) { + // TODO: Pass in ClangdServer::WorkspaceRoot as a HintPath. + StringRef HintPath; kadircet wrote: > this part looks a little messed

[PATCH] D58880: [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 204937. nridge marked 5 inline comments as done. nridge added a comment. Address remaining review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang

Hello everyone, LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be restarted in the few minutes. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

nridge updated this revision to Diff 204939. nridge added a comment. Revise fix and add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63316/new/ https://reviews.llvm.org/D63316 Files: clang-tools-extra/clangd/Protocol.h clang-tools-extra/

[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

nridge marked an inline comment as done. nridge added a comment. The fix actually broke another lit test, because in that test the client was not sending the diagnostic's code back in the `codeAction` request, resulting in a mismatch with the new comparison function. I think a real client could