aaronpuchert added inline comments.
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:864
default:
- if (!CodeGenOpts.SplitDwarfOutput.empty() &&
- (CodeGenOpts.getSplitDwarfMode() == CodeGenOptions::SplitFileFission))
{
+ if (!CodeGenOpts.SplitDwarfOutput.empty()) {
DwoOS = openOutputFile(CodeGenOpts.SplitDwarfOutput);
----------------
Perhaps I should also check whether `SplitDwarfFile` is empty.
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1276
createTargetTransformInfoWrapperPass(getTargetIRAnalysis()));
- if (!CodeGenOpts.SplitDwarfOutput.empty() &&
- CodeGenOpts.getSplitDwarfMode() == CodeGenOptions::SplitFileFission) {
+ if (!CodeGenOpts.SplitDwarfOutput.empty()) {
DwoOS = openOutputFile(CodeGenOpts.SplitDwarfOutput);
----------------
Dito here.
================
Comment at: clang/test/CodeGen/split-debug-filename.c:14-16
-// Testing to ensure that the dwo name is not output into the compile unit if
-// it's for vanilla split-dwarf rather than split-dwarf for implicit modules.
-// VANILLA-NOT: splitDebugFilename
----------------
We lose that when we remove `-enable-split-dwarf`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63167/new/
https://reviews.llvm.org/D63167
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
