[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke created this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This patch adds vendor id detection for Hygon Dhyana CPUs. More details can be found on: http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f92104

[PATCH] D62312: [ASTImporter] Added visibility context check for CXXRecordDecl.

balazske marked an inline comment as done. balazske added a comment. Thanks for reviewing. Similar additions are planned to follow with function and variable template, enum, scoped enum, typedef, type alias. Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:34 }; +stru

[PATCH] D62367: [X86] VP2INTERSECT clang

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.cpp:518 case AVX512F: Features["avx512f"] = Features["avx512cd"] = Features["avx512er"] = Features["avx512pf"] = Features["avx512dq"] = Features["avx512bw"] = This patch needs

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:38 " else ", statemen

[PATCH] D62312: [ASTImporter] Added visibility context check for CXXRecordDecl.

balazske updated this revision to Diff 201133. balazske added a comment. - Changed type of string constants to const. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62312/new/ https://reviews.llvm.org/D62312 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImp

[PATCH] D62367: [X86] VP2INTERSECT clang

xiangzhangllvm updated this revision to Diff 201137. xiangzhangllvm added a comment. rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62367/new/ https://reviews.llvm.org/D62367 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def

[PATCH] D62372: [clangd] Limit the size of synthesized fix message

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay. Herald added a project: clang. A temporary workaround until we figure out a better way to present fixes. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D62298: [CodeComplete] Filter override completions by function name

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Have one question though, does it improve behavior in vscode? Since label seems to be the same, it will most definitely improve clangd's ranking but vscode ignores it anyway.

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added a comment. In D62298#1515399 , @kadircet wrote: > LGTM > > Have one question though, does it improve behavior in vscode? Since label > seems to be the same, it will most definitely improve clangd's ranking but > vscode ignores it anyw

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3172 +// Add a space after return type. +if (Chunk.Kind == CodeCompletionString::CK_ResultType) { + assert(!SeenTypedChunk); kadircet wrote: > do we expect anything

[PATCH] D62298: [CodeComplete] Filter override completions by function name

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3172 +// Add a space after return type. +if (Chunk.Kind == CodeCompletionString::CK_ResultType) { + assert(!SeenTypedChunk); ilya-biryukov wrote: > kadircet wrote: > > do

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201157. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files:

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added inline comments. Comment at: clang/test/CodeCompletion/overrides.cpp:14 void vfunc(bool param) override; - void + vfo }; kadircet wrote: > nit: I suppose it should be `vfu`?(same thing for the comments below starting > with `Runs comple

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201161. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Add whitespace outside printOverrideString Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3172 +// Add a space after return type. +if (Chunk.Kind == CodeCompletionString::CK_ResultType) { + assert(!SeenTypedChunk); kadircet wrote: > ilya-biryukov wrote: >

[clang-tools-extra] r361616 - Fix sphinx "Malformed option description" warning

Author: rksimon Date: Fri May 24 02:31:32 2019 New Revision: 361616 URL: http://llvm.org/viewvc/llvm-project?rev=361616&view=rev Log: Fix sphinx "Malformed option description" warning Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-pro-type-member-init.rst Modifie

[PATCH] D62373: [ASTImporter] Store import errors for Decls

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. We add a new member which is a mapping from the alr

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201164. ilya-biryukov added a comment. - Do not add an extra 'override' on optional chunks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files: clang-tools-ex

[PATCH] D62335: [OpenCL][PR41963] Add overloads of old atomics with generic pointer type in C++ mode

Anastasia updated this revision to Diff 201165. Anastasia added a comment. Fixed `atomic_max` and `atomic_min`. Thanks to David for pointing this out on the bug! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62335/new/ https://reviews.llvm.org/D62335 Files: lib/Headers/opencl-c.h

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201168. ilya-biryukov added a comment. - Update a comment in the test - Reformat the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files: clang-tools-ext

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201167. ilya-biryukov added a comment. - Remove redundant test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files: clang-tools-extra/clangd/unittests/CodeCom

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. During import of a specific Decl D, it may happen t

[PATCH] D62372: [clangd] Limit the size of synthesized fix message

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/Diagnostics.cpp:449 + + size_t FirstNewline = R.find('\n'); + if (FirstNewline != llvm::StringRef::npos)

[clang-tools-extra] r361623 - [CodeComplete] Filter override completions by function name

Author: ibiryukov Date: Fri May 24 03:18:39 2019 New Revision: 361623 URL: http://llvm.org/viewvc/llvm-project?rev=361623&view=rev Log: [CodeComplete] Filter override completions by function name Summary: We put only part of the signature starting with a function name into "typed text" chunks no

r361623 - [CodeComplete] Filter override completions by function name

Author: ibiryukov Date: Fri May 24 03:18:39 2019 New Revision: 361623 URL: http://llvm.org/viewvc/llvm-project?rev=361623&view=rev Log: [CodeComplete] Filter override completions by function name Summary: We put only part of the signature starting with a function name into "typed text" chunks no

[PATCH] D62298: [CodeComplete] Filter override completions by function name

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361623: [CodeComplete] Filter override completions by function name (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62298?vs=201168&id=201178#toc Repository

[PATCH] D62372: [clangd] Limit the size of synthesized fix message

ilya-biryukov updated this revision to Diff 201179. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Address comments, simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62372/new/ https://reviews.llvm.org/D62372

[clang-tools-extra] r361625 - [clangd] Limit the size of synthesized fix message

Author: ibiryukov Date: Fri May 24 03:26:23 2019 New Revision: 361625 URL: http://llvm.org/viewvc/llvm-project?rev=361625&view=rev Log: [clangd] Limit the size of synthesized fix message Summary: A temporary workaround until we figure out a better way to present fixes. Reviewers: kadircet Revi

[PATCH] D62372: [clangd] Limit the size of synthesized fix message

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361625: [clangd] Limit the size of synthesized fix message (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62372?vs=201179&id=201181#toc Repository: rCTE

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. This is the third step of the full error handling.

[PATCH] D62377: [OpenCL] Add support for the cl_arm_integer_dot_product extensions

kpet created this revision. kpet added a reviewer: Anastasia. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar, yaxunl. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D62377 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Heade

[clang-tools-extra] r361628 - Made cppcoreguidelines-pro-type-member-init-use-assignment run in all language modes

Author: gribozavr Date: Fri May 24 03:39:00 2019 New Revision: 361628 URL: http://llvm.org/viewvc/llvm-project?rev=361628&view=rev Log: Made cppcoreguidelines-pro-type-member-init-use-assignment run in all language modes Modified: clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-pr

[clang-tools-extra] r361629 - Make cppcoreguidelines-pro-type-member-init-use-assignment.cpp pass on platforms where char is unsigned

Author: gribozavr Date: Fri May 24 03:50:15 2019 New Revision: 361629 URL: http://llvm.org/viewvc/llvm-project?rev=361629&view=rev Log: Make cppcoreguidelines-pro-type-member-init-use-assignment.cpp pass on platforms where char is unsigned The other options are to completely specify the triple (

[PATCH] D62377: [OpenCL] Add support for the cl_arm_integer_dot_product extensions

Anastasia added a comment. This deserves at least a link to the published spec in the description! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62377/new/ https://reviews.llvm.org/D62377 ___ cfe-commits mailing list

[PATCH] D62377: [OpenCL] Add support for the cl_arm_integer_dot_product extensions

kpet added a comment. Yes, indeed :). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62377/new/ https://reviews.llvm.org/D62377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaron.ballman accepted this revision. aaron.ballman added a comment. My only real concern about this is that sometimes the fix-it will be wrong because the issue is a typo in the definition. However, it seems like that could be handled by preferring typo correction when the edit distance is belo

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert added a comment. In D59402#1515703 , @aaron.ballman wrote: > My only real concern about this is that sometimes the fix-it will be wrong > because the issue is a typo in the definition. You're right about that, there are multiple reasons wh

[PATCH] D60776: [clang-tidy] Add test support for the fix description.

hokein updated this revision to Diff 201221. hokein added a comment. Use CHECK-NOTES. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60776/new/ https://reviews.llvm.org/D60776 Files: clang-tools-extra/test/clang-tidy/misc-unused-using-decls.cpp

[PATCH] D60776: [clang-tidy] Add test support for the fix description.

hokein added a comment. Based on our last offline discussion, it is possible to use `CHECK-NOTES` to verify fix descriptions. However, `CHECK-NOTES` enforce sto verify all `note` diagnostic messages, some existing tests will be failed because they don't cover all notes (the number is not large,

[PATCH] D62389: [clangd] Place cursor better after completing patterns

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. By producing the $0 marker in the snippets at the last placeholder. This produces nicer results in most cases, e.g. for nam

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

Anastasia updated this revision to Diff 201228. Anastasia marked an inline comment as done. Anastasia added a comment. - Added candidates as not viable - Added dedicated diagnostic note - Added assert CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62156/new/ https://reviews.llvm.org/D621

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8229 + if (FTI.hasMethodTypeCVRUQualifiers()) { +FTI.MethodQualifiers->forEachCVRUQualifier( [&](DeclSpec::TQ TypeQual, StringRef QualName, SourceLocation SL) { rjmccall wrote: >

[PATCH] D62377: [OpenCL] Add support for the cl_arm_integer_dot_product extensions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62377/new/ https://reviews.llvm.org/D62377 ___

[PATCH] D62390: [LibTooling] Add Explanation parameter to `makeRule`.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. Conceptually, a single-case RewriteRule has a matcher, edit(s) and an (optional) explanation. `makeRule` previously only took the matcher and edit(s). This change adds (optional) support for the

[PATCH] D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field.

ymandel added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:38 " else ", statement(T; + Rule.Cases[0].Explanation = tooling::text("no explanation"); + return Rule; --

[PATCH] D62390: [LibTooling] Add Explanation parameter to `makeRule`.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Much nicer now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62390/new/ https://reviews.llvm.org/D62390

[PATCH] D62391: [CodeComplete] Complete 'return true/false' in boolean functions

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62391 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeCompletion/patterns.cpp Index: clang/test/CodeComple

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

spatel added a comment. I haven't looked closely at the series of transforms that gets us here, so let me ask: would it be more efficient to produce the add/inc/dec machine instructions directly rather than LEA? Or do we do this because the 3-address opportunity helps register allocation, so th

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

javed.absar created this revision. javed.absar added reviewers: snidertm, dmgreen. Herald added subscribers: kristof.beyls, mgorny. This is patch C2 as mentioned in RFC http://lists.llvm.org/pipermail/cfe-dev/2019-March/061834.html This adds cmse builtin functions, and introduces arm_cmse.h head

r361641 - [OpenCL] Add support for the cl_arm_integer_dot_product extensions

Author: kpet Date: Fri May 24 07:53:52 2019 New Revision: 361641 URL: http://llvm.org/viewvc/llvm-project?rev=361641&view=rev Log: [OpenCL] Add support for the cl_arm_integer_dot_product extensions The specification is available in the Khronos OpenCL registry: https://www.khronos.org/registry/Op

r361643 - [LibTooling] Add Explanation parameter to `makeRule`.

Author: ymandel Date: Fri May 24 08:11:45 2019 New Revision: 361643 URL: http://llvm.org/viewvc/llvm-project?rev=361643&view=rev Log: [LibTooling] Add Explanation parameter to `makeRule`. Summary: Conceptually, a single-case RewriteRule has a matcher, edit(s) and an (optional) explanation. `makeR

[PATCH] D62390: [LibTooling] Add Explanation parameter to `makeRule`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361643: [LibTooling] Add Explanation parameter to `makeRule`. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field.

ymandel updated this revision to Diff 201256. ymandel added a comment. updated to use new version of `makeRule`; changed explanation text in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62340/new/ https://reviews.llvm.org/D62340 Files: cla

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added projects: clang, LLVM. When using ConstantExpr we often need the result of the ex

[PATCH] D62377: [OpenCL] Add support for the cl_arm_integer_dot_product extensions

kpet closed this revision. kpet added a comment. Committed as r361641. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62377/new/ https://reviews.llvm.org/D62377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r361645 - [CodeComplete] Add whitespace around braces in lambda completions

Author: ibiryukov Date: Fri May 24 09:16:15 2019 New Revision: 361645 URL: http://llvm.org/viewvc/llvm-project?rev=361645&view=rev Log: [CodeComplete] Add whitespace around braces in lambda completions This produces nicer output. Trivial follow-up to r361461, so sending without review. Modified:

[PATCH] D37813: clang-format: better handle namespace macros

Typz marked 2 inline comments as done. Typz added inline comments. Comment at: unittests/Format/NamespaceEndCommentsFixerTest.cpp:526 EXPECT_EQ("namespace A {\n" " int i;\n" "} // namespace A", Should I also fix these tests? They al

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

thakis added a comment. Please see https://clang.llvm.org/docs/InternalsManual.html#fix-it-hints , especially the "need to obey these rules" bit. I'm not sure that's fulfilled here. Maybe the fixit should be on a note instead? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews

[clang-tools-extra] r361647 - [clang-tidy] In TransformerClangTidyCheck, require Explanation field.

Author: ymandel Date: Fri May 24 09:32:03 2019 New Revision: 361647 URL: http://llvm.org/viewvc/llvm-project?rev=361647&view=rev Log: [clang-tidy] In TransformerClangTidyCheck, require Explanation field. Summary: In general, the `Explanation` field is optional in `RewriteRule` cases. But, because

[PATCH] D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361647: [clang-tidy] In TransformerClangTidyCheck, require Explanation field. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62405: [CodeComplete] Consistently break after '{' in multi-line patterns

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added a project: clang. Completion can return multi-line patterns in some cases, e.g. for (<#init#>; <#cond#>; <#inc#>) { <#body#> } However, most patterns break the line only before closing brace, resul

[PATCH] D62406: [WebAssembly] Use "linker" as linker shortname.

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google, dschuff. Herald added a project: clang. sbc100 added a reviewer: dschuff. This is in line with other platforms. Also, move the single statement methods into the header (also in line with othe

Re: [PATCH] D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field.

This seems to produce warnings about unused variables: …/llvm/clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:20:20: warning: unused variable 'Case' [-Wunused-variable] for (const auto &Case : Rule.Cases) { Could you take a look? On Fri, May 24, 2019 at 6:29 PM Yitzhak Mandelb

r361650 - [ASTImporter] Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

Author: shafik Date: Fri May 24 09:53:44 2019 New Revision: 361650 URL: http://llvm.org/viewvc/llvm-project?rev=361650&view=rev Log: [ASTImporter] Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName Summary: https://reviews.llvm.org/D51633 added error han

[PATCH] D62407: [OpenMP] Add test for requires and unified shared memory clause with declare target link

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch adds a test for requires with unified share memory clause when a declare target link is present. This test needs to go

[PATCH] D62407: [OpenMP] Add test for requires and unified shared memory clause with declare target link

ABataev added a comment. Just one question - why it is not the part of the whole patch for the unified memory support in clang? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62407/new/ https://reviews.llvm.org/D62407 __

[PATCH] D62368: Add support for Hygon Dhyana processor

cryptoad added a comment. Regarding the Scudo side of the patch: the code has to be able to compile with gcc as well, and not necessarily the latest version. This won't compile on systems without a `signature_HYGON_*`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3653 +def note_ovl_candidate_illegal_constructor_adrspace_mismatch : Note< +"candidate constructor ignored: address space mismatch between object and constructor">; def note_ovl_candidate

[PATCH] D62343: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC]

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62343/new/ https://reviews.llvm.org/D62343 ___

Re: [PATCH] D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field.

looking now... On Fri, May 24, 2019 at 12:49 PM Ilya Biryukov wrote: > This seems to produce warnings about unused variables: > …/llvm/clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:20:20: > warning: unused variable 'Case' [-Wunused-variable] > > for (const auto &Case : Rule.

[PATCH] D62406: [WebAssembly] Use "linker" as linker shortname.

sunfish accepted this revision. sunfish added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62406/new/ https://reviews.llvm.org/D62406 _

r361651 - [WebAssembly] Use "linker" as linker shortname.

Author: sbc Date: Fri May 24 10:36:07 2019 New Revision: 361651 URL: http://llvm.org/viewvc/llvm-project?rev=361651&view=rev Log: [WebAssembly] Use "linker" as linker shortname. This is in line with other platforms. Also, move the single statement methods into the header (also in line with other

[PATCH] D62406: [WebAssembly] Use "linker" as linker shortname.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361651: [WebAssembly] Use "linker" as linker shortname. (authored by sbc, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

Re: [PATCH] D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field.

So, it only shows up in Release build, I assume because the assert is left out: for (const auto &Case : Rule.Cases) { assert(Case.Explanation != nullptr && "clang-tidy checks must have an explanation by default;" " explicitly provide an empty explanation if none is desir

r361652 - Add support for dumping Objective C AST declaration nodes to JSON.

Author: aaronballman Date: Fri May 24 10:39:55 2019 New Revision: 361652 URL: http://llvm.org/viewvc/llvm-project?rev=361652&view=rev Log: Add support for dumping Objective C AST declaration nodes to JSON. Added: cfe/trunk/test/AST/ast-dump-decl-json.m Modified: cfe/trunk/include/clang/AS

r361653 - [NewPassManager] Add tuning option: LoopUnrolling [clang-change]

Author: asbirlea Date: Fri May 24 10:40:52 2019 New Revision: 361653 URL: http://llvm.org/viewvc/llvm-project?rev=361653&view=rev Log: [NewPassManager] Add tuning option: LoopUnrolling [clang-change] Summary: Use CodeGenOpts's setting for loop unrolling. [to be coupled with D61618] Reviewers: ch

[PATCH] D61620: [NewPassManager] Add tuning option: LoopUnrolling [clang-change]

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL361653: [NewPassManager] Add tuning option: LoopUnrolling [clang-change] (authored by asbirlea, committed by ). Herald add

[PATCH] D62279: Use LTO capable linker

winksaville updated this revision to Diff 201288. winksaville added a comment. Added libcxxabi and rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62279/new/ https://reviews.llvm.org/D62279 Files: clang/cmake/caches/DistributionExample-sta

[PATCH] D62407: [OpenMP] Add test for requires and unified shared memory clause with declare target link

gtbercea added a comment. In D62407#1516298 , @ABataev wrote: > Just one question - why it is not the part of the whole patch for the unified > memory support in clang? This test will need to change in the unified memory case. That's why its being intr

[PATCH] D62407: [OpenMP] Add test for requires and unified shared memory clause with declare target link

ABataev added a comment. Just add it to the original patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62407/new/ https://reviews.llvm.org/D62407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D62412: [LibTooling] Fix unused-variable warning after r361647.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. A range-for was added in r361647 where the range variable was only used in an assertion. As a result, it warned for Release builds. This revision restructures the assertion to avoid the problem.

Re: [PATCH] D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field.

version 1 here: https://reviews.llvm.org/D62412 On Fri, May 24, 2019 at 1:36 PM Yitzhak Mandelbaum wrote: > So, it only shows up in Release build, I assume because the assert is left > out: > for (const auto &Case : Rule.Cases) { > assert(Case.Explanation != nullptr && >"c

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert planned changes to this revision. aaronpuchert added a comment. I guess you're referring to "[fix-it hints] should only be used when it’s very likely they match the user’s intent". When turning on the warning on an existing code base, I think that `static` is almost always right. B

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added subscribers: ebevhan, yaxunl. Preserve address spaces of global objects while generating 'atexit' stub. https://reviews.llvm.org/D62413 Files: lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CodeGenModule.cpp lib/Co

[PATCH] D62407: [OpenMP] Add test for requires and unified shared memory clause with declare target link

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. After some offline discussion, the patch is accepted. It is required to demonstrate the changes in https://reviews.llvm.org/D60883 Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaron.ballman added a comment. In D59402#1516421 , @aaronpuchert wrote: > I guess you're referring to "[fix-it hints] should only be used when it’s > very likely they match the user’s intent". Also, we're not attempting to recover from the error, which

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

aaron.ballman added a comment. In D62404#1516243 , @markstegeman wrote: > I haven't yet been able to figure out how to properly add a test for this > bug, since the expected result is a failure to compile while the current > test/clang-tidy/readability-

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert added a comment. In D59402#1516432 , @aaron.ballman wrote: > Also, we're not attempting to recover from the error, which is a good point > that @thakis raised. aka, if you apply the fix-it, you should also treat the > declaration as though

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11810 + << var + << ((var->getStorageClass() != SC_Extern) + ? FixItHint::CreateInsertion(var->getBeginLoc(), "static ") It would be more appropriate to suppress th

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

rsmith added a comment. In D59402#1516479 , @aaronpuchert wrote: > In D59402#1516432 , @aaron.ballman > wrote: > > > Also, we're not attempting to recover from the error, which is a good point > > that @thakis ra

r361658 - [OpenMP] Add test for requires and unified shared memory clause with declare target link

Author: gbercea Date: Fri May 24 11:48:42 2019 New Revision: 361658 URL: http://llvm.org/viewvc/llvm-project?rev=361658&view=rev Log: [OpenMP] Add test for requires and unified shared memory clause with declare target link Summary: This patch adds a test for requires with unified share memory cl

[PATCH] D62407: [OpenMP] Add test for requires and unified shared memory clause with declare target link

This revision was automatically updated to reflect the committed changes. Closed by commit rC361658: [OpenMP] Add test for requires and unified shared memory clause with declare… (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D62407?vs=201275&id=201298#t

r361660 - Add JSON dumping tests for ObjC statements; add support for dumping @catch catch-all statements.

Author: aaronballman Date: Fri May 24 11:58:29 2019 New Revision: 361660 URL: http://llvm.org/viewvc/llvm-project?rev=361660&view=rev Log: Add JSON dumping tests for ObjC statements; add support for dumping @catch catch-all statements. Added: cfe/trunk/test/AST/ast-dump-stmt-json.m Modified:

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Ok, from the Linux kernel's perspective, I believe we have worked out all underlying issues in LLVM wrt callbr that would prevent us from using asm goto successfully. This patch now has my blessing; thanks for all the hard

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

erichkeane added inline comments. Comment at: include/llvm/IR/IRBuilder.h:110 : Context(context), DefaultFPMathTag(FPMathTag), -DefaultOperandBundles(OpBundles) { +IsFPConstrained(false), DefaultConstrainedExcept(nullptr), +DefaultConstrainedRoundin

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

gtbercea updated this revision to Diff 201307. gtbercea added a comment. - Add test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60883/new/ https://reviews.llvm.org/D60883 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/Sema/Sema

r361662 - Adding an explicit triple to this test to appease build bots.

Author: aaronballman Date: Fri May 24 12:19:00 2019 New Revision: 361662 URL: http://llvm.org/viewvc/llvm-project?rev=361662&view=rev Log: Adding an explicit triple to this test to appease build bots. Modified: cfe/trunk/test/AST/ast-dump-stmt-json.m Modified: cfe/trunk/test/AST/ast-dump-stm

r361663 - [cmake] Remove old unused version of FindZ3.cmake from clang [NFC]

Author: dhinton Date: Fri May 24 12:21:21 2019 New Revision: 361663 URL: http://llvm.org/viewvc/llvm-project?rev=361663&view=rev Log: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC] Summary: This file was moved to llvm in D54978, r356929, but the old file was never removed. Re

[PATCH] D62343: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rC361663: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC] (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D62343?vs=201058&id=201308#toc Reposit

  1   2   >