[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov updated this revision to Diff 200876. ilya-biryukov added a comment. - Remove a leftover from name check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62238/new/ https://reviews.llvm.org/D62238 Files: clang/lib/Sema/SemaCodeComple

[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. Clangd is already resolving symlinks on the server side, therefore there is no more need to handle it in client side. This was

[PATCH] D62270: [Driver] Move the "-o OUT -x TYPE SRC.c" flags to the end of -cc1

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62270/new/ https://reviews.llvm.org/D62270

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thanks! This looks good to me. I'm still a bit nervous about "mklink" in the test, but let's land this and see if the bots can handle it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59

[PATCH] D62276: lld-link, clang: Treat non-existent input files as possible spellos for option flags

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Beautiful! Want to add a line to docs/ReleaseNotes.rst too? :-) Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:177 def warn_drv_unknown_argument_clang_cl_with_s

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan updated this revision to Diff 200878. skan added a comment. make test case consider Windows path separators CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115 Files: lib/Frontend/HeaderIncludeGen.cpp test/Frontend/clang_H_opt.c Index: t

[PATCH] D50147: clang-format: support external styles

Typz added a comment. Herald added a project: clang. In D50147#1310146 , @sammccall wrote: > In D50147#1309880 , @Typz wrote: > > > ping? > > > Sorry for losing track of this. > > I think `-style=` is a logical exte

r361461 - [CodeComplete] Complete a lambda when preferred type is a function

Author: ibiryukov Date: Thu May 23 00:45:35 2019 New Revision: 361461 URL: http://llvm.org/viewvc/llvm-project?rev=361461&view=rev Log: [CodeComplete] Complete a lambda when preferred type is a function Summary: Uses a heuristic to detect std::function and friends. Reviewers: kadircet Reviewed

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

This revision was automatically updated to reflect the committed changes. Closed by commit rL361461: [CodeComplete] Complete a lambda when preferred type is a function (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[clang-tools-extra] r361464 - [clangd-vscode] Bump versions dependencies. NFC

Author: ibiryukov Date: Thu May 23 01:06:24 2019 New Revision: 361464 URL: http://llvm.org/viewvc/llvm-project?rev=361464&view=rev Log: [clangd-vscode] Bump versions dependencies. NFC Result of running 'npm audit fix', which tracks security vulnerabilities. Modified: clang-tools-extra/trunk/

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1017 + let LangOpts = [SYCL]; + let Documentation = [Undocumented]; +} bader wrote: > Anastasia wrote: > > Ok, I thought the earlier request was not to add undocumented attributes >

[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, this improves the paths produced for generated files inside `bazel-genfiles`, we now point to the `/my/project/bazel-genfiles/path/to/some.proto.h` instead of `/path/to/ba

[PATCH] D36226: Added a RealFileSystem implementation that does not rely on global CWD.

ilya-biryukov abandoned this revision. ilya-biryukov added a subscriber: sammccall. ilya-biryukov added a comment. abandoning in favor of the change landed by @sammccall that resolves uses absolute paths instead of `at`-family functions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D362

[PATCH] D37813: clang-format: better handle namespace macros

klimek added a comment. In D37813#1512317 , @Typz wrote: > The patch goal is indeed to indent the content of namespace-macro blocks like > the content of any 'regular' namespace. So it should look like the content of > a namespace, possibly depending on

[PATCH] D62293: [modules] Add PP callbacks for entering and leaving a submodule.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, bruno. Herald added subscribers: jsji, dexonsmith, kbarton, nemanjai. Herald added a project: clang. Our usecase is that we would like to support making some modules visible (without corresponding #includes) while building

r361467 - Enable queue_t and clk_event_t comparisons in C++ mode

Author: svenvh Date: Thu May 23 02:20:08 2019 New Revision: 361467 URL: http://llvm.org/viewvc/llvm-project?rev=361467&view=rev Log: Enable queue_t and clk_event_t comparisons in C++ mode Support queue_t and clk_event_t comparisons in C++ for OpenCL mode, to preserve backwards compatibility with

[PATCH] D62208: [OpenCL] Enable queue_t and clk_event_t comparisons in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL361467: Enable queue_t and clk_event_t comparisons in C++ mode (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

r361468 - Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl

Author: gribozavr Date: Thu May 23 02:22:43 2019 New Revision: 361468 URL: http://llvm.org/viewvc/llvm-project?rev=361468&view=rev Log: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl Reviewers: ilya-biryukov, r

[PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl

This revision was automatically updated to reflect the committed changes. gribozavr marked an inline comment as done. Closed by commit rC361468: Delete default constructors, copy constructors, move constructors, copy… (authored by gribozavr, committed by ). Changed prior to commit: https://revi

[PATCH] D53941: [clangd][wip] Add 'related information' to diagnostics. Does not work for built-in notes

ilya-biryukov abandoned this revision. ilya-biryukov added a subscriber: sammccall. ilya-biryukov added a comment. Herald added a project: clang. Abandoning, same functionality landed in separate revision by @sammccall Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://rev

[PATCH] D60465: [ASTImporter] Error handling fix in ImportDefinition_New.

balazske updated this revision to Diff 200901. balazske added a comment. Rebase to current master. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60465/new/ https://reviews.llvm.org/D60465 Files: lib/AST/ASTImporter.cpp Index: lib/AST/ASTImporter.cpp

[PATCH] D60465: [ASTImporter] Error handling fix in ImportDefinition_New.

balazske added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60465/new/ https://reviews.llvm.org/D60465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D60465: [ASTImporter] Error handling fix in ImportDefinition_New.

balazske added a comment. Maybe this patch can be abandoned, the correction is already made (when every _New was removed). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60465/new/ https://reviews.llvm.org/D60465 ___

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. > Ah, wow, I see what confused me now: > In the fixNamespaceEndComment tests you use an indent that clang-format > would not produce. Can you please fix that, otherwise I find this super > confusing :) Can you point a specific exemple (in code) ? There are many tests rel

[clang-tools-extra] r361475 - [clangd-vscode] Do not customize uri converters in vscode

Author: kadircet Date: Thu May 23 02:58:29 2019 New Revision: 361475 URL: http://llvm.org/viewvc/llvm-project?rev=361475&view=rev Log: [clangd-vscode] Do not customize uri converters in vscode Summary: Clangd is already resolving symlinks on the server side, therefore there is no more need to han

[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

kadircet updated this revision to Diff 200909. kadircet marked an inline comment as done. kadircet added a comment. - Delete unusued import Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62288/new/ https://reviews.llvm.org/D62288 Files: clang-too

[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361475: [clangd-vscode] Do not customize uri converters in vscode (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D62288?vs=200909&id=200913#toc Repository:

[PATCH] D62282: [X86] Add ENQCMD intrinsics.

RKSimon added inline comments. Comment at: lib/Headers/enqcmdintrin.h:21 + +static __inline__ int _DEFAULT_FN_ATTRS +_enqcmd (void *__dst, const void *__src) Please add doxygen comments describing the intrinsics Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62298: [CodeComplete] Override completion items are filtered by funciton names

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a project: clang. We put only the function name into "typed text" chunks now, previously the whole signature was "typed text". This leads to meaningful fuzzy match scores, giving better signals to compare

[PATCH] D62298: [CodeComplete] Override completion items are filtered by funciton names

ilya-biryukov added a comment. Will need to update the test before landing, but wanted to share the implementation right away Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 _

[PATCH] D62299: [PR41567][Sema] Fixed cast kind in addr space conversions

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: ebevhan. This change sets missing cast kind correctly in the address space conversion case. https://reviews.llvm.org/D62299 Files: lib/Sema/SemaCast.cpp test/CodeGenOpenCLCXX/addrspace-convers

[PATCH] D62093: [analyzer] List checkers in 3 categories: released, alpha, developer

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:527-530 +// developer checkers even in the alpha output. For example, +// alpha.cplusplus.IteratorModeling is a modeling checker, hence

[PATCH] D62298: [CodeComplete] Override completion items are filtered by funciton names

ilya-biryukov updated this revision to Diff 200924. ilya-biryukov added a comment. - Use the old name for the helper function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files: clang/lib/Sema/SemaCode

[PATCH] D62298: [CodeComplete] Override completion items are filtered by funciton names

ilya-biryukov updated this revision to Diff 200926. ilya-biryukov added a comment. - Update the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/tes

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added a comment. Sorry for so many changes, this is ready for review now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 ___ cfe-commits mailing

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 200927. ilya-biryukov added a comment. - Simplify negative tests a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files: clang/lib/Sema/SemaCodeComplete.cp

[PATCH] D37813: clang-format: better handle namespace macros

klimek added inline comments. Comment at: unittests/Format/NamespaceEndCommentsFixerTest.cpp:582 + EXPECT_EQ("TESTSUITE() {\n" +" int i;\n" +"} // TESTSUITE()", All of the fixNamespaceEndComments tests are indented, but standard llvm sty

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Anastasia added a comment. //**Design question**//: since you are not aware what functions are to be run on a device while parsing them, at what point do you plan to diagnose the invalid behavior from the standard C++ i.e. using function pointers in kernel code is likely to cause issues? Also

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please address the minor nitpicks suggested here in your final commit. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:16 +// -Builtins.def, co

[PATCH] D62197: [OpenCL] Fix file-scope const sampler variable for 2.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Makes sense. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62197/new/ https://reviews.llvm.org/D62197 ___ cfe-commit

[clang-tools-extra] r361486 - [clangd] Bump vscode extension version

Author: kadircet Date: Thu May 23 04:58:03 2019 New Revision: 361486 URL: http://llvm.org/viewvc/llvm-project?rev=361486&view=rev Log: [clangd] Bump vscode extension version Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json Modified: clang-tools-extra/trunk/clangd/c

[clang-tools-extra] r361487 - [clang-tidy] New check calling out uses of +new in Objective-C code

Author: gribozavr Date: Thu May 23 05:01:26 2019 New Revision: 361487 URL: http://llvm.org/viewvc/llvm-project?rev=361487&view=rev Log: [clang-tidy] New check calling out uses of +new in Objective-C code Summary: Google's Objective-C style guide forbids calling or overriding +new to instantiate

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361487: [clang-tidy] New check calling out uses of +new in Objective-C code (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D61350?vs=200824&id=200931#toc Re

[clang-tools-extra] r361488 - [clangd] Also update package-lock.json

Author: kadircet Date: Thu May 23 05:02:14 2019 New Revision: 361488 URL: http://llvm.org/viewvc/llvm-project?rev=361488&view=rev Log: [clangd] Also update package-lock.json Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package-lock.json Modified: clang-tools-extra/trunk/cla

clang extra refactor tweaks link patch

A pretty trivial patch to successfully build clang. --- clang-r361395/tools/extra/clangd/refactor/tweaks/CMakeLists.txt.old 2019-05-23 06:35:07.247867697 +0200 +++ clang-r361395/tools/extra/clangd/refactor/tweaks/CMakeLists.txt 2019-05-23 06:35:59.810341911 +0200 @@ -19,4 +19,5 @@ clangAST cl

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ymandel wrote: > ilya-biryukov wrote: > > ymandel wrote: > > > ilya-biryukov

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ilya-biryukov wrote: > ymandel wrote: >

Re: clang extra refactor tweaks link patch

It might be best to submit the patch to phabricator so it does not get lost. https://llvm.org/docs/Phabricator.html On Thu, May 23, 2019 at 3:13 PM Rudolf Kastl via cfe-commits wrote: > > A pretty trivial patch to successfully build clang. > ___ > cfe-c

[PATCH] D62303: [Index] Fix reported references in presence of template type aliases

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous. Herald added a project: clang. See the added test for an example. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62303 Files: clang-tools-extra/clangd/

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

Maybe go with a runtime parameter (of type llvm::function_ref) instead of the template parameter? In any non-trivial example, the runtime costs of another function pointer should be negligible given that we need to parse the ASTs, run the matchers, etc. On Wed, May 22, 2019 at 10:48 PM Penzin, Pet

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 200943. djtodoro added a comment. -Add a negative test for -O0 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/CC1Options.td lib/Code

[PATCH] D48961: [Index] Add indexing support for MACROs.

marcobubke added a comment. Herald added a subscriber: dexonsmith. Herald added a project: clang. This changset is not handling #ifdef MACRO, defined(MACRO) etc. in he PPCallbacks. Is there any intention to omit them or do you simply forgot them? Repository: rC Clang CHANGES SINCE LAST ACTIO

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 200950. djtodoro added a comment. -Add `SPDefCache` to speed up the process -Add additional assertions that will improve quality of the code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/Code

Re: clang extra refactor tweaks link patch

did: https://reviews.llvm.org/D62309 Am Do., 23. Mai 2019 um 14:44 Uhr schrieb Roman Lebedev : > > It might be best to submit the patch to phabricator so it does not get lost. > https://llvm.org/docs/Phabricator.html > > On Thu, May 23, 2019 at 3:13 PM Rudolf Kastl via cfe-commits > wrote: > > >

[PATCH] D62298: [CodeComplete] Filter override completions by function name

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3154 +/// The result contains only 'typed text' and 'text' chunks. +static void PrintOverrideString(const CodeCompletionString &CCS, +CodeCompletionBuilder &Result) { -

[PATCH] D62309: Fix linking of the refactor tweaks directory

che666 created this revision. che666 added a reviewer: clang-tools-extra. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ilya-biryukov, mgorny. Herald added a project: clang. Currently it seems that the linked libs in CMakelists for the refactor tweaks directory is incomplet

[PATCH] D62309: Fix linking of the refactor tweaks directory

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62309/new/ https://reviews.llvm.org/D62309

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

ABataev added a comment. Tests? Comment at: lib/CodeGen/CGOpenMPRuntime.h:1628 + /// Return whether the unified_shared_memory has been specified. + virtual bool hasRequiresUnifiedSharedMemory(); }; Do we need to make it virtual? Repository: rC Clang CHA

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3166 +// Add a space after return type. +if (Chunk.Kind == CodeCompletionString::CK_ResultType) + Result.AddChunk(CodeCompletionString::CK_HorizontalSpace); kadircet

[PATCH] D62309: Fix linking of the refactor tweaks directory

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Thanks for the fix! A few nit-picky comments about the process, in case you'll be interested in sending more patches to LLVM. Could you please upload the patch with ful

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre updated this revision to Diff 200961. Pierre marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60763/new/ https://reviews.llvm.org/D60763 Files: clang/include/clang/Basic/CMakeLists.txt clang/include/clang/Basic/LangOptions.def clang/include/cla

[PATCH] D62312: [ASTImporter] Added visibility context check for CXXRecordDecl.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. ASTImporter makes now difference between classes with same name

[PATCH] D62303: [Index] Fix reported references in presence of template type aliases

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:140 + bool IsTypeAlias) { +if (ResolvedClass) { + //

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

xingxue updated this revision to Diff 200967. xingxue added a comment. Herald added subscribers: jsji, jfb. Added test case `stdint_h.sh.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 Files: clang/

[PATCH] D62201: [LibTooling] Address post-commit feedback for r361152

sbc100 added a comment. I think this build broke the `-DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON` build. e.g https://ci.chromium.org/p/wasm/builders/ci/linux/6457 FAILED: tools/clang/unittests/Tooling/ToolingTests : && /b/swarming/w/ir/cache/builder/src/src/work/v8/v8/third_part

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added a comment. Summarizing the offline discussion, the final results we want in the long run is a completion item of the form: - Displayed to the user: `override foo(int a, int b)` - Inserted into the editor: `return_type foo(int a, int b) override` - Filtered by `override foo` (

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/include/clang/Basic/Attr.td:297 def CUDA : LangOpt<"CUDA">; -def COnly : LangOpt<"CPlusPlus", 1>; +def COnly : LangOpt<"COnly", "!LangOpts.CPlusPlus">; def CPlusPlus : LangOpt<"CPlusP

[PATCH] D62320: Fix LLVM_LINK_LLVM_DYLIB build after rC361285

sbc100 created this revision. Herald added subscribers: cfe-commits, aheejin, mgorny. Herald added a project: clang. All the other unittests I can find specify LLVMTestingSupport in target_link_libraries not as part of LLVM_LINK_COMPONENTS. I'm how/why this fixes the build issue, but its consiste

[PATCH] D62320: Fix LLVM_LINK_LLVM_DYLIB build after rC361285

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks for fixing this. Might want to wait for Nico's response, though, since the original change was at his suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

r361502 - Work around a Visual C++ bug.

Author: probinson Date: Thu May 23 08:07:46 2019 New Revision: 361502 URL: http://llvm.org/viewvc/llvm-project?rev=361502&view=rev Log: Work around a Visual C++ bug. Using a static function as a template parameter gets a bogus compile-time error with Visual Studio 2017, prior to version 15.8. Our

Re: [PATCH] D62201: [LibTooling] Address post-commit feedback for r361152

Fixed in https://reviews.llvm.org/D62320 On Thu, May 23, 2019 at 10:44 AM Sam Clegg via Phabricator < revi...@reviews.llvm.org> wrote: > sbc100 added a comment. > > I think this build broke the `-DLLVM_BUILD_LLVM_DYLIB=ON > -DLLVM_LINK_LLVM_DYLIB=ON` build. e.g > https://ci.chromium.org/p/wasm/bu

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

Sounds good. I'll send a fix shortly. Found another bug too (captured a StringRef in a lambda) -- shall i bundle the fixes? On Thu, May 23, 2019 at 9:01 AM Ilya Biryukov wrote: > Maybe go with a runtime parameter (of type llvm::function_ref) instead of > the template parameter? > In any non-triv

[PATCH] D62202: Work around a Visual C++ bug

This revision was automatically updated to reflect the committed changes. Closed by commit rL361502: Work around a Visual C++ bug. (authored by probinson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D62

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

Given that we'll need to store the function reference, is llvm::function_ref still the way to go? The comments seem to warn away from storing function_refs. On Thu, May 23, 2019 at 11:06 AM Yitzhak Mandelbaum wrote: > Sounds good. I'll send a fix shortly. Found another bug too (captured a > Stri

r361504 - [Driver] Try normalized triple when looking for C++ libraries

Author: phosek Date: Thu May 23 08:23:16 2019 New Revision: 361504 URL: http://llvm.org/viewvc/llvm-project?rev=361504&view=rev Log: [Driver] Try normalized triple when looking for C++ libraries This addresses the issue introduced in r361432 where we would only try effective triple but not the no

[PATCH] D62286: [Driver] Try normalized triple when looking for C++ libraries

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC361504: [Driver] Try normalized triple when looking for C++ libraries (authored by phosek, committed by ). Changed prior

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

Actually, someone already committed a fix: https://reviews.llvm.org/D62202 I can still make this change if it seems worthwhile, but its not strictly necessary at this point. On Thu, May 23, 2019 at 11:14 AM Yitzhak Mandelbaum wrote: > Given that we'll need to store the function reference, is >

[PATCH] D62279: Use LTO capable linker

winksaville added a comment. Adding libcxxabi worked and `ninja stage2-distribution` succeeded but I then ran `ninja check-all` and from within stage2-bins/ but that failed: [1072/1526] cd /home/wink/prgs/llvm/llvm-project/build-dist-use-lto-capable-linker-and-add-libcxxabi/tools/clang/stage2

r361505 - [analyzer][NFC] Prettify some RUN: lines in test files.

Author: szelethus Date: Thu May 23 08:49:04 2019 New Revision: 361505 URL: http://llvm.org/viewvc/llvm-project?rev=361505&view=rev Log: [analyzer][NFC] Prettify some RUN: lines in test files. This is a test commit in disguise. Modified: cfe/trunk/test/Analysis/bsd-string.c cfe/trunk/test

r361507 - Ensure builtins use the target default Calling Convention

Author: erichkeane Date: Thu May 23 09:05:21 2019 New Revision: 361507 URL: http://llvm.org/viewvc/llvm-project?rev=361507&view=rev Log: Ensure builtins use the target default Calling Convention r355317 changed builtins/allocation functions to use the default calling convention in order to suppor

[PATCH] D62328: [LibTooling] Fix dangling references in RangeSelector.

ymandel created this revision. ymandel added reviewers: ilya-biryukov, gribozavr. Herald added a project: clang. RangeSelector had a number of cases of capturing a StringRef in a lambda, which lead to dangling references. This change converts all uses in the API of `StringRef` to `std::string` to

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Structural equivalence did not handle dependent template args properly when the arg

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet updated this revision to Diff 200998. gchatelet added a comment. - Use no-builtin instead of no-runtime-for. - Use one attribute per runtime function to make merging easier. The patch is still WIP and needs more work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201000. ilya-biryukov added a comment. Herald added subscribers: arphaman, jkorous. - Make first letter of the helper function lowercase - New model: everything before name is a text chunk, everything after it is typed chunk - Test the filter text produ

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. I think that's a good step forward, although not yet ideal. The typed chunk now contains everything starting function name and ending with `override`, so one gets both nice prefix match scores when typing a function a

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added a comment. After landing this, will try to add new presentation options for completion items here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298

r361510 - [CodeComplete] Only show lambda completions if patterns are requested

Author: ibiryukov Date: Thu May 23 09:39:26 2019 New Revision: 361510 URL: http://llvm.org/viewvc/llvm-project?rev=361510&view=rev Log: [CodeComplete] Only show lambda completions if patterns are requested This is a trivial follow-up to r361461, so sending without review. Modified: cfe/trunk

[PATCH] D62312: [ASTImporter] Added visibility context check for CXXRecordDecl.

shafik added a comment. Minor comments, I am going to run `check-lldb` now. Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:34 }; +struct GetClassPattern { + using DeclTy = CXXRecordDecl; `GetCXXRecordPattern` feels more consistent.

[PATCH] D62328: [LibTooling] Fix dangling references in RangeSelector.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62328/new/ https://reviews.llvm.org/D62328 _

[PATCH] D62303: [Index] Fix reported references in presence of template type aliases

ilya-biryukov updated this revision to Diff 201002. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Address a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62303/new/ https://reviews.llvm.org/D62303 Files:

[PATCH] D62303: [Index] Fix reported references in presence of template type aliases

ilya-biryukov added inline comments. Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:140 + bool IsTypeAlias) { +if (ResolvedClass) { + // In presence of type aliases, the resolved class was never written in k

[clang-tools-extra] r361511 - [Index] Fix reported references in presence of template type aliases

Author: ibiryukov Date: Thu May 23 09:48:47 2019 New Revision: 361511 URL: http://llvm.org/viewvc/llvm-project?rev=361511&view=rev Log: [Index] Fix reported references in presence of template type aliases Summary: See the added test for an example. Reviewers: kadircet Reviewed By: kadircet Sub

r361511 - [Index] Fix reported references in presence of template type aliases

Author: ibiryukov Date: Thu May 23 09:48:47 2019 New Revision: 361511 URL: http://llvm.org/viewvc/llvm-project?rev=361511&view=rev Log: [Index] Fix reported references in presence of template type aliases Summary: See the added test for an example. Reviewers: kadircet Reviewed By: kadircet Sub

[PATCH] D62303: [Index] Fix reported references in presence of template type aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL361511: [Index] Fix reported references in presence of template type aliases (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

Either way looks good. If we go with function_ref, we should definitely store a comment why storing function_ref is fine there. Or use a function pointer to make it even clearer that nothing cheesy is going on there. On Thu, May 23, 2019 at 5:28 PM Yitzhak Mandelbaum wrote: > Actually, someone a

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

mclow.lists added inline comments. Comment at: libcxx/include/stdint.h:16 +#endif // _STD_TYPES_T /* I don't think that this will do what you want it to. Is this a supported use case? ``` #include #define _STD_TYPES_T #include ``` Repository: rG LLVM

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

beanz added a comment. In D62215#1512849 , @winksaville wrote: > IIRC, on linux if LTO is ON I had to use `ld.gold` for both stage 1 and 2, > although that maybe > just the way it ended up and it wasn't necessary. But I'll test whatever you > come up wi

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang updated this revision to Diff 201004. akhuang added a comment. Add llvm IR test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62167/new/ https://reviews.llvm.org/D62167 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/de

r361514 - [LibTooling] Fix dangling references in RangeSelector.

Author: ymandel Date: Thu May 23 10:11:33 2019 New Revision: 361514 URL: http://llvm.org/viewvc/llvm-project?rev=361514&view=rev Log: [LibTooling] Fix dangling references in RangeSelector. Summary: RangeSelector had a number of cases of capturing a StringRef in a lambda, which lead to dangling re

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385 +// Use the global scope for static members. +DContext = getContextDescriptor( + cast(CGM.getContext().getTranslationUnitDecl()), TheCU);

  1   2   >